Re: [PATCH v3 13/16] pinctrl: Add AXP192 pin control driver

From: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
To: Michael Walle <michael@walle.cc>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, wens@csie.org,
	jic23@kernel.org, lee.jones@linaro.org, sre@kernel.org,
	broonie@kernel.org, gregkh@linuxfoundation.org,
	lgirdwood@gmail.com, lars@metafoo.de, rafael@kernel.org,
	quic_gurus@quicinc.com, sebastian.reichel@collabora.com,
	andy.shevchenko@gmail.com, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-iio@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 13/16] pinctrl: Add AXP192 pin control driver
Date: Mon, 27 Jun 2022 14:12:58 +0100	[thread overview]
Message-ID: <me4ummrWKIPseIG4ay7yCfrumN8sIdvc@localhost> (raw)
In-Reply-To: <cafd8a40ad35dcf8a35350261af6031c@walle.cc>

Michael Walle <michael@walle.cc> writes:

> Hi,
>
> As Linus suggested you could have a look at devm_gpio_regmap_register()
> with a custom xlate() callback and some improvements. But I've never
> worked with pinctrl so I might be wrong. See below.
>
>> +static int axp192_gpio_get(struct gpio_chip *chip, unsigned int offset)
>> +{
>> +	struct axp192_pctl *pctl = gpiochip_get_data(chip);
>> +	const struct axp192_pctl_reg_info *reginfo = &pctl->desc->in_regs[offset];
>> +	unsigned int val;
>> +	int ret;
>> +
>> +	ret = regmap_read(pctl->regmap, reginfo->reg, &val);
>> +	if (ret)
>> +		return ret;
>> +
>> +	return !!(val & reginfo->mask);
>> +}
>
> This should work.
>
>> +
>> +static int axp192_gpio_get_direction(struct gpio_chip *chip, unsigned
>> int offset)
>> +{
>> +	struct axp192_pctl *pctl = gpiochip_get_data(chip);
>> +	const struct axp192_pctl_reg_info *reginfo =
>> &pctl->desc->ctrl_regs[offset];
>> +	const u8 *input_muxvals = pctl->desc->functions[AXP192_FUNC_INPUT].muxvals;
>> +	unsigned int val;
>> +	int ret;
>> +
>> +	ret = regmap_read(pctl->regmap, reginfo->reg, &val);
>> +	if (ret)
>> +		return ret;
>> +
>> +	if ((val & reginfo->mask) == (input_muxvals[offset] <<
>> (ffs(reginfo->mask) - 1)))
>> +		return GPIO_LINE_DIRECTION_IN;
>
> This isn't supported (yet) in gpio-regmap...
>
>> +
>> +	return GPIO_LINE_DIRECTION_OUT;
>> +}
>> +
>> +static void axp192_gpio_set(struct gpio_chip *chip, unsigned int
>> offset, int value)
>> +{
>> +	struct axp192_pctl *pctl = gpiochip_get_data(chip);
>> +	const struct axp192_pctl_reg_info *reginfo = &pctl->desc->out_regs[offset];
>> +
>> +	regmap_update_bits(pctl->regmap, reginfo->reg, reginfo->mask, value
>> ? reginfo->mask : 0);
>> +}
>> +
>> +static int axp192_gpio_direction_input(struct gpio_chip *chip,
>> unsigned int offset)
>> +{
>> +	return pinctrl_gpio_direction_input(chip->base + offset);
>> +}
>
> ..as well as this.
>
>> +
>> +static int axp192_gpio_direction_output(struct gpio_chip *chip,
>> unsigned int offset, int value)
>> +{
>> +	chip->set(chip, offset, value);
>
> Why don't you call pinctrl_gpio_direction_output() here?

Probably because I copied this from pinctrl-axp209. I'll fix it in
the next version.

>
>
> I *think* what is needed for gpio-regmap to support this is:
>  - support values and masks for the direction, for now, we
>    only support single bits.
>  - support the pinctrl_gpio_direction_{input,output} calls
>
> -michael

That sounds about right, thanks for taking a look.