From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: ulf.hansson@linaro.org, avifishman70@gmail.com,
tali.perry1@gmail.com, joel@jms.id.au, venture@google.com,
yuenn@google.com, benjaminfair@google.com,
adrian.hunter@intel.com, skhan@linuxfoundation.org,
davidgow@google.com, pbrobinson@gmail.com, gsomlo@gmail.com,
briannorris@chromium.org, arnd@arndb.de, krakoczy@antmicro.com,
openbmc@lists.ozlabs.org, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] mmc: sdhci-npcm: Add NPCM SDHCI driver
Date: Tue, 3 Oct 2023 13:49:40 +0300 [thread overview]
Message-ID: <CAHp75VdjB6wqeezL_UotQj-65HKb83wYh4hfA=PPiooRN0QX8Q@mail.gmail.com> (raw)
In-Reply-To: <20231002200610.129799-3-tmaimon77@gmail.com>
On Mon, Oct 2, 2023 at 11:06 PM Tomer Maimon <tmaimon77@gmail.com> wrote:
>
> Add Nuvoton NPCM BMC sdhci-pltfm controller driver.
FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
...
> +static const struct of_device_id npcm_sdhci_of_match[] = {
> + { .compatible = "nuvoton,npcm750-sdhci", .data = &npcm7xx_sdhci_pdata, },
> + { .compatible = "nuvoton,npcm845-sdhci", .data = &npcm8xx_sdhci_pdata, },
Only in case when you need a new version, you may remove the inner
trailing commas,
no need to do this right now.
> + { }
> +};
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: devicetree@vger.kernel.org, ulf.hansson@linaro.org,
benjaminfair@google.com, arnd@arndb.de, krakoczy@antmicro.com,
avifishman70@gmail.com, venture@google.com,
openbmc@lists.ozlabs.org, briannorris@chromium.org,
linux-mmc@vger.kernel.org, adrian.hunter@intel.com,
tali.perry1@gmail.com, gsomlo@gmail.com, joel@jms.id.au,
davidgow@google.com, skhan@linuxfoundation.org,
linux-kernel@vger.kernel.org, pbrobinson@gmail.com
Subject: Re: [PATCH v5 2/2] mmc: sdhci-npcm: Add NPCM SDHCI driver
Date: Tue, 3 Oct 2023 13:49:40 +0300 [thread overview]
Message-ID: <CAHp75VdjB6wqeezL_UotQj-65HKb83wYh4hfA=PPiooRN0QX8Q@mail.gmail.com> (raw)
In-Reply-To: <20231002200610.129799-3-tmaimon77@gmail.com>
On Mon, Oct 2, 2023 at 11:06 PM Tomer Maimon <tmaimon77@gmail.com> wrote:
>
> Add Nuvoton NPCM BMC sdhci-pltfm controller driver.
FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
...
> +static const struct of_device_id npcm_sdhci_of_match[] = {
> + { .compatible = "nuvoton,npcm750-sdhci", .data = &npcm7xx_sdhci_pdata, },
> + { .compatible = "nuvoton,npcm845-sdhci", .data = &npcm8xx_sdhci_pdata, },
Only in case when you need a new version, you may remove the inner
trailing commas,
no need to do this right now.
> + { }
> +};
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-10-03 10:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 20:06 [PATCH v5 0/2] add NPCM SDHCI driver support Tomer Maimon
2023-10-02 20:06 ` Tomer Maimon
2023-10-02 20:06 ` [PATCH v5 1/2] dt-bindings: mmc: npcm,sdhci: Document NPCM SDHCI controller Tomer Maimon
2023-10-02 20:06 ` Tomer Maimon
2023-10-02 20:06 ` [PATCH v5 2/2] mmc: sdhci-npcm: Add NPCM SDHCI driver Tomer Maimon
2023-10-02 20:06 ` Tomer Maimon
2023-10-03 10:49 ` Andy Shevchenko [this message]
2023-10-03 10:49 ` Andy Shevchenko
2023-10-10 14:27 ` [PATCH v5 0/2] add NPCM SDHCI driver support Ulf Hansson
2023-10-10 14:27 ` Ulf Hansson
2023-10-10 19:35 ` Tomer Maimon
2023-10-10 19:35 ` Tomer Maimon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VdjB6wqeezL_UotQj-65HKb83wYh4hfA=PPiooRN0QX8Q@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=briannorris@chromium.org \
--cc=davidgow@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gsomlo@gmail.com \
--cc=joel@jms.id.au \
--cc=krakoczy@antmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pbrobinson@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.