From: Ulf Hansson <ulf.hansson@linaro.org>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au,
venture@google.com, yuenn@google.com, benjaminfair@google.com,
adrian.hunter@intel.com, skhan@linuxfoundation.org,
davidgow@google.com, pbrobinson@gmail.com, gsomlo@gmail.com,
briannorris@chromium.org, arnd@arndb.de, krakoczy@antmicro.com,
andy.shevchenko@gmail.com, openbmc@lists.ozlabs.org,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/2] add NPCM SDHCI driver support
Date: Tue, 10 Oct 2023 16:27:41 +0200 [thread overview]
Message-ID: <CAPDyKForPWPHoAuRuyXBHRpNVA9MvYa-eTXDrHx8Z94nSWpXBg@mail.gmail.com> (raw)
In-Reply-To: <20231002200610.129799-1-tmaimon77@gmail.com>
On Mon, 2 Oct 2023 at 22:06, Tomer Maimon <tmaimon77@gmail.com> wrote:
>
> This patch set adds SDHCI support for the Nuvoton NPCM Baseboard
> Management Controller (BMC).
>
> Deeply sorry it took that long until sending version three, promise to try
> to do better on the next versions (if needed) :-),
>
> The NPCM SDHCI driver tested on NPCM750 and NPCM845 EVB.
>
> Addressed comments from:
> - Andy Shevchenko : https://www.spinics.net/lists/devicetree/msg638000.html
>
> Changes since version 4:
> - Remove unnecessary clk_disable_unprepare function.
>
> Changes since version 3:
> - Use devm_clk_get_optional_enabled function.
> - Add mod_devicetable.h.
> - Modify copyright year.
>
> Changes since version 2:
> - Add data to handle architecture-specific SDHCI parameters.
> - Change config place in make and kconfig files.
> - Calling sdhci_pltfm_free to to avoid a memory leak on error.
>
> Changes since version 1:
> - Use correct spaces in the dt-bindings.
> - Drop unused labels from dt-bindings.
> - Order by module name in the make a configuration.
> - Remove unnecessary blank lines.
> - Using devm_clk_get_optional instead of devm_clk_get.
>
> Tomer Maimon (2):
> dt-bindings: mmc: npcm,sdhci: Document NPCM SDHCI controller
> mmc: sdhci-npcm: Add NPCM SDHCI driver
>
> .../devicetree/bindings/mmc/npcm,sdhci.yaml | 45 +++++++++
> drivers/mmc/host/Kconfig | 8 ++
> drivers/mmc/host/Makefile | 1 +
> drivers/mmc/host/sdhci-npcm.c | 94 +++++++++++++++++++
> 4 files changed, 148 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mmc/npcm,sdhci.yaml
> create mode 100644 drivers/mmc/host/sdhci-npcm.c
>
Applied for next (and by amending patch2 to remove some commas), thanks!
Kind regards
Uffe
WARNING: multiple messages have this Message-ID (diff)
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: andy.shevchenko@gmail.com, linux-kernel@vger.kernel.org,
benjaminfair@google.com, arnd@arndb.de, krakoczy@antmicro.com,
avifishman70@gmail.com, venture@google.com,
openbmc@lists.ozlabs.org, briannorris@chromium.org,
linux-mmc@vger.kernel.org, adrian.hunter@intel.com,
tali.perry1@gmail.com, gsomlo@gmail.com, joel@jms.id.au,
davidgow@google.com, skhan@linuxfoundation.org,
devicetree@vger.kernel.org, pbrobinson@gmail.com
Subject: Re: [PATCH v5 0/2] add NPCM SDHCI driver support
Date: Tue, 10 Oct 2023 16:27:41 +0200 [thread overview]
Message-ID: <CAPDyKForPWPHoAuRuyXBHRpNVA9MvYa-eTXDrHx8Z94nSWpXBg@mail.gmail.com> (raw)
In-Reply-To: <20231002200610.129799-1-tmaimon77@gmail.com>
On Mon, 2 Oct 2023 at 22:06, Tomer Maimon <tmaimon77@gmail.com> wrote:
>
> This patch set adds SDHCI support for the Nuvoton NPCM Baseboard
> Management Controller (BMC).
>
> Deeply sorry it took that long until sending version three, promise to try
> to do better on the next versions (if needed) :-),
>
> The NPCM SDHCI driver tested on NPCM750 and NPCM845 EVB.
>
> Addressed comments from:
> - Andy Shevchenko : https://www.spinics.net/lists/devicetree/msg638000.html
>
> Changes since version 4:
> - Remove unnecessary clk_disable_unprepare function.
>
> Changes since version 3:
> - Use devm_clk_get_optional_enabled function.
> - Add mod_devicetable.h.
> - Modify copyright year.
>
> Changes since version 2:
> - Add data to handle architecture-specific SDHCI parameters.
> - Change config place in make and kconfig files.
> - Calling sdhci_pltfm_free to to avoid a memory leak on error.
>
> Changes since version 1:
> - Use correct spaces in the dt-bindings.
> - Drop unused labels from dt-bindings.
> - Order by module name in the make a configuration.
> - Remove unnecessary blank lines.
> - Using devm_clk_get_optional instead of devm_clk_get.
>
> Tomer Maimon (2):
> dt-bindings: mmc: npcm,sdhci: Document NPCM SDHCI controller
> mmc: sdhci-npcm: Add NPCM SDHCI driver
>
> .../devicetree/bindings/mmc/npcm,sdhci.yaml | 45 +++++++++
> drivers/mmc/host/Kconfig | 8 ++
> drivers/mmc/host/Makefile | 1 +
> drivers/mmc/host/sdhci-npcm.c | 94 +++++++++++++++++++
> 4 files changed, 148 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mmc/npcm,sdhci.yaml
> create mode 100644 drivers/mmc/host/sdhci-npcm.c
>
Applied for next (and by amending patch2 to remove some commas), thanks!
Kind regards
Uffe
next prev parent reply other threads:[~2023-10-10 14:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 20:06 [PATCH v5 0/2] add NPCM SDHCI driver support Tomer Maimon
2023-10-02 20:06 ` Tomer Maimon
2023-10-02 20:06 ` [PATCH v5 1/2] dt-bindings: mmc: npcm,sdhci: Document NPCM SDHCI controller Tomer Maimon
2023-10-02 20:06 ` Tomer Maimon
2023-10-02 20:06 ` [PATCH v5 2/2] mmc: sdhci-npcm: Add NPCM SDHCI driver Tomer Maimon
2023-10-02 20:06 ` Tomer Maimon
2023-10-03 10:49 ` Andy Shevchenko
2023-10-03 10:49 ` Andy Shevchenko
2023-10-10 14:27 ` Ulf Hansson [this message]
2023-10-10 14:27 ` [PATCH v5 0/2] add NPCM SDHCI driver support Ulf Hansson
2023-10-10 19:35 ` Tomer Maimon
2023-10-10 19:35 ` Tomer Maimon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKForPWPHoAuRuyXBHRpNVA9MvYa-eTXDrHx8Z94nSWpXBg@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=briannorris@chromium.org \
--cc=davidgow@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gsomlo@gmail.com \
--cc=joel@jms.id.au \
--cc=krakoczy@antmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pbrobinson@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.