From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: ChiaEn Wu <peterwu.pub@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
"Krogerus, Heikki" <heikki.krogerus@linux.intel.com>,
Helge Deller <deller@gmx.de>, ChiaEn Wu <chiaen_wu@richtek.com>,
Alice Chen <alice_chen@richtek.com>,
cy_huang <cy_huang@richtek.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
USB <linux-usb@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
"open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
szuni chen <szunichen@gmail.com>
Subject: Re: [PATCH v4 09/13] iio: adc: mt6370: Add Mediatek MT6370 support
Date: Mon, 4 Jul 2022 22:35:47 +0200 [thread overview]
Message-ID: <CAHp75Ve+-ht6J5PZXS1jO1qfxn6Nfd2wDfuW-NsigR_k7iRJGg@mail.gmail.com> (raw)
In-Reply-To: <20220704053901.728-10-peterwu.pub@gmail.com>
On Mon, Jul 4, 2022 at 7:42 AM ChiaEn Wu <peterwu.pub@gmail.com> wrote:
>
> From: ChiaEn Wu <chiaen_wu@richtek.com>
>
> Add Mediatek MT6370 ADC support.
...
> + This driver can also be built as a module. If so the module
If so,
> + will be called "mt6370-adc.ko".
No ".ko" part.
...
> +#define ADC_CONV_TIME_US 35000
Since it's actually MS, drop this and use MS * 1000 whenever it's needed.
> +#define ADC_CONV_TIME_MS (ADC_CONV_TIME_US / 1000)
...
> +static int mt6370_adc_read_label(struct iio_dev *iio_dev,
> + struct iio_chan_spec const *chan, char *label)
> +{
> + return snprintf(label, PAGE_SIZE, "%s\n",
> + mt6370_channel_labels[chan->channel]);
sysfs_emit()
> +}
...
> +static int mt6370_adc_probe(struct platform_device *pdev)
> +{
> + int ret;
> + struct mt6370_adc_data *priv;
> + struct regmap *regmap;
> + struct iio_dev *indio_dev;
Per all your patches, use reversed xmas tree ordering ("longest line
first" rule).
Also it may be good to have a temporary variable for struct device pointer.
> +}
...
> +MODULE_DESCRIPTION("MT6370 ADC Drvier");
Driver. Spell check your patches.
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: ChiaEn Wu <peterwu.pub@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
"Krogerus, Heikki" <heikki.krogerus@linux.intel.com>,
Helge Deller <deller@gmx.de>, ChiaEn Wu <chiaen_wu@richtek.com>,
Alice Chen <alice_chen@richtek.com>,
cy_huang <cy_huang@richtek.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
USB <linux-usb@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
"open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
szuni chen <szunichen@gmail.com>
Subject: Re: [PATCH v4 09/13] iio: adc: mt6370: Add Mediatek MT6370 support
Date: Mon, 4 Jul 2022 22:35:47 +0200 [thread overview]
Message-ID: <CAHp75Ve+-ht6J5PZXS1jO1qfxn6Nfd2wDfuW-NsigR_k7iRJGg@mail.gmail.com> (raw)
In-Reply-To: <20220704053901.728-10-peterwu.pub@gmail.com>
On Mon, Jul 4, 2022 at 7:42 AM ChiaEn Wu <peterwu.pub@gmail.com> wrote:
>
> From: ChiaEn Wu <chiaen_wu@richtek.com>
>
> Add Mediatek MT6370 ADC support.
...
> + This driver can also be built as a module. If so the module
If so,
> + will be called "mt6370-adc.ko".
No ".ko" part.
...
> +#define ADC_CONV_TIME_US 35000
Since it's actually MS, drop this and use MS * 1000 whenever it's needed.
> +#define ADC_CONV_TIME_MS (ADC_CONV_TIME_US / 1000)
...
> +static int mt6370_adc_read_label(struct iio_dev *iio_dev,
> + struct iio_chan_spec const *chan, char *label)
> +{
> + return snprintf(label, PAGE_SIZE, "%s\n",
> + mt6370_channel_labels[chan->channel]);
sysfs_emit()
> +}
...
> +static int mt6370_adc_probe(struct platform_device *pdev)
> +{
> + int ret;
> + struct mt6370_adc_data *priv;
> + struct regmap *regmap;
> + struct iio_dev *indio_dev;
Per all your patches, use reversed xmas tree ordering ("longest line
first" rule).
Also it may be good to have a temporary variable for struct device pointer.
> +}
...
> +MODULE_DESCRIPTION("MT6370 ADC Drvier");
Driver. Spell check your patches.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: ChiaEn Wu <peterwu.pub@gmail.com>
Cc: "open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
"Krogerus, Heikki" <heikki.krogerus@linux.intel.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alice Chen <alice_chen@richtek.com>,
linux-iio <linux-iio@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Liam Girdwood <lgirdwood@gmail.com>,
cy_huang <cy_huang@richtek.com>, Pavel Machek <pavel@ucw.cz>,
Lee Jones <lee.jones@linaro.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Helge Deller <deller@gmx.de>, Rob Herring <robh+dt@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Guenter Roeck <linux@roeck-us.net>,
devicetree <devicetree@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
szuni chen <szunichen@gmail.com>, Mark Brown <broonie@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Jingoo Han <jingoohan1@gmail.com>,
USB <linux-usb@vger.kernel.org>,
Sebastian Reichel <sre@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ChiaEn Wu <chiaen_wu@richtek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v4 09/13] iio: adc: mt6370: Add Mediatek MT6370 support
Date: Mon, 4 Jul 2022 22:35:47 +0200 [thread overview]
Message-ID: <CAHp75Ve+-ht6J5PZXS1jO1qfxn6Nfd2wDfuW-NsigR_k7iRJGg@mail.gmail.com> (raw)
In-Reply-To: <20220704053901.728-10-peterwu.pub@gmail.com>
On Mon, Jul 4, 2022 at 7:42 AM ChiaEn Wu <peterwu.pub@gmail.com> wrote:
>
> From: ChiaEn Wu <chiaen_wu@richtek.com>
>
> Add Mediatek MT6370 ADC support.
...
> + This driver can also be built as a module. If so the module
If so,
> + will be called "mt6370-adc.ko".
No ".ko" part.
...
> +#define ADC_CONV_TIME_US 35000
Since it's actually MS, drop this and use MS * 1000 whenever it's needed.
> +#define ADC_CONV_TIME_MS (ADC_CONV_TIME_US / 1000)
...
> +static int mt6370_adc_read_label(struct iio_dev *iio_dev,
> + struct iio_chan_spec const *chan, char *label)
> +{
> + return snprintf(label, PAGE_SIZE, "%s\n",
> + mt6370_channel_labels[chan->channel]);
sysfs_emit()
> +}
...
> +static int mt6370_adc_probe(struct platform_device *pdev)
> +{
> + int ret;
> + struct mt6370_adc_data *priv;
> + struct regmap *regmap;
> + struct iio_dev *indio_dev;
Per all your patches, use reversed xmas tree ordering ("longest line
first" rule).
Also it may be good to have a temporary variable for struct device pointer.
> +}
...
> +MODULE_DESCRIPTION("MT6370 ADC Drvier");
Driver. Spell check your patches.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-07-04 20:36 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 5:38 [PATCH v4 00/13] Add Mediatek MT6370 PMIC support ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` [PATCH v4 01/13] dt-bindings: usb: Add Mediatek MT6370 TCPC ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` [PATCH v4 02/13] dt-bindings: power: supply: Add Mediatek MT6370 Charger ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 9:04 ` Krzysztof Kozlowski
2022-07-04 9:04 ` Krzysztof Kozlowski
2022-07-04 9:04 ` Krzysztof Kozlowski
2022-07-04 5:38 ` [PATCH v4 03/13] dt-bindings: leds: mt6370: Add Mediatek mt6370 current sink type LED indicator ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` [PATCH v4 04/13] dt-bindings: leds: Add Mediatek MT6370 flashlight ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` [PATCH v4 05/13] dt-bindings: backlight: Add Mediatek MT6370 backlight ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` [PATCH v4 06/13] dt-bindings: mfd: Add Mediatek MT6370 ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 9:07 ` Krzysztof Kozlowski
2022-07-04 9:07 ` Krzysztof Kozlowski
2022-07-04 9:07 ` Krzysztof Kozlowski
2022-07-04 5:38 ` [PATCH v4 07/13] mfd: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 20:29 ` Andy Shevchenko
2022-07-04 20:29 ` Andy Shevchenko
2022-07-04 20:29 ` Andy Shevchenko
2022-07-04 5:38 ` [PATCH v4 08/13] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 7:32 ` Greg KH
2022-07-04 7:32 ` Greg KH
2022-07-04 7:32 ` Greg KH
2022-07-04 9:31 ` szuni chen
2022-07-04 9:31 ` szuni chen
2022-07-04 9:31 ` szuni chen
2022-07-04 11:07 ` Greg KH
2022-07-04 11:07 ` Greg KH
2022-07-04 11:07 ` Greg KH
2022-07-04 20:19 ` Andy Shevchenko
2022-07-04 20:19 ` Andy Shevchenko
2022-07-04 20:19 ` Andy Shevchenko
2022-07-04 5:38 ` [PATCH v4 09/13] iio: adc: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 20:35 ` Andy Shevchenko [this message]
2022-07-04 20:35 ` Andy Shevchenko
2022-07-04 20:35 ` Andy Shevchenko
2022-07-04 5:38 ` [PATCH v4 10/13] power: supply: mt6370: Add Mediatek MT6370 charger driver ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 20:53 ` Andy Shevchenko
2022-07-04 20:53 ` Andy Shevchenko
2022-07-04 20:53 ` Andy Shevchenko
2022-07-04 5:38 ` [PATCH v4 11/13] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:39 ` [PATCH v4 12/13] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support ChiaEn Wu
2022-07-04 5:39 ` ChiaEn Wu
2022-07-04 5:39 ` ChiaEn Wu
2022-07-04 21:05 ` Andy Shevchenko
2022-07-04 21:05 ` Andy Shevchenko
2022-07-04 21:05 ` Andy Shevchenko
2022-07-07 10:49 ` szuni chen
2022-07-07 10:49 ` szuni chen
2022-07-07 10:49 ` szuni chen
2022-07-04 5:39 ` [PATCH v4 13/13] video: backlight: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-07-04 5:39 ` ChiaEn Wu
2022-07-04 5:39 ` ChiaEn Wu
2022-07-04 21:14 ` Andy Shevchenko
2022-07-04 21:14 ` Andy Shevchenko
2022-07-04 21:14 ` Andy Shevchenko
2022-07-13 10:53 ` ChiaEn Wu
2022-07-13 10:53 ` ChiaEn Wu
2022-07-13 10:53 ` ChiaEn Wu
2022-07-13 12:07 ` Andy Shevchenko
2022-07-13 12:07 ` Andy Shevchenko
2022-07-13 12:07 ` Andy Shevchenko
2022-07-13 13:07 ` Lee Jones
2022-07-13 13:07 ` Lee Jones
2022-07-13 13:07 ` Lee Jones
2022-07-14 7:13 ` ChiaEn Wu
2022-07-14 7:13 ` ChiaEn Wu
2022-07-14 7:13 ` ChiaEn Wu
2022-07-14 9:27 ` Andy Shevchenko
2022-07-14 9:27 ` Andy Shevchenko
2022-07-14 9:27 ` Andy Shevchenko
2022-07-14 9:43 ` Andy Shevchenko
2022-07-14 9:43 ` Andy Shevchenko
2022-07-14 9:43 ` Andy Shevchenko
2022-07-14 10:15 ` Andy Shevchenko
2022-07-14 10:15 ` Andy Shevchenko
2022-07-14 10:15 ` Andy Shevchenko
2022-07-14 9:47 ` Daniel Thompson
2022-07-14 9:47 ` Daniel Thompson
2022-07-14 9:47 ` Daniel Thompson
2022-07-14 9:49 ` Andy Shevchenko
2022-07-14 9:49 ` Andy Shevchenko
2022-07-14 9:49 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Ve+-ht6J5PZXS1jO1qfxn6Nfd2wDfuW-NsigR_k7iRJGg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=alice_chen@richtek.com \
--cc=broonie@kernel.org \
--cc=chiaen_wu@richtek.com \
--cc=chunfeng.yun@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jic23@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=peterwu.pub@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=szunichen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.