From: Greg KH <gregkh@linuxfoundation.org>
To: szuni chen <szunichen@gmail.com>
Cc: ChiaEn Wu <peterwu.pub@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
"Krogerus, Heikki" <heikki.krogerus@linux.intel.com>,
Helge Deller <deller@gmx.de>,
chiaen_wu@richtek.com, alice_chen@richtek.com,
ChiYuan Huang <cy_huang@richtek.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
USB <linux-usb@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
"open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH v4 08/13] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver
Date: Mon, 4 Jul 2022 13:07:27 +0200 [thread overview]
Message-ID: <YsLJ7+HiqaBTwCLg@kroah.com> (raw)
In-Reply-To: <CA+hk2fYA3phYAoh+BFr0ddy9MR8Ro1WCoqBpa1UK2StwMtLyfQ@mail.gmail.com>
On Mon, Jul 04, 2022 at 05:31:29PM +0800, szuni chen wrote:
> Greg KH <gregkh@linuxfoundation.org> 於 2022年7月4日 週一 下午3:32寫道：
> >
> > On Mon, Jul 04, 2022 at 01:38:56PM +0800, ChiaEn Wu wrote:
> > > From: ChiYuan Huang <cy_huang@richtek.com>
> > >
> > > Add chip level mt6370 tcpci driver.
> >
> > What does this mean? Please provide more information about the hardware
> > being supported here so we know how to review this.
>
> Dear Greg,
>
> MediaTek MT6370 is a highly-integrated smart power management IC,
> which includes a single cell Li-Ion/Li-Polymer switching battery charger,
> a USB Type-C & Power Delivery (PD) controller, dual flash LED current sources,
> a RGB LED driver, a backlight WLED driver, a display bias driver and a
> general LDO for portable devices.
>
> This driver is used for the Type-C & Power Delivery controller in
> MediaTek MT6370 IC.
>
> If we change the commit message to
>
> "Add MediaTek MT6370 tcpci driver.
> MediaTek MT6370 is a multi-functional IC that includes USB Type-C.
> It works with Type-C Port Controller Manager to provide USB PD and USB
> Type-C functionalities."
>
> does this meet your requirements?
What would you want to see if you were reading a changelog text for an
unfamiliar hardware device? More text is always better!
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: szuni chen <szunichen@gmail.com>
Cc: ChiaEn Wu <peterwu.pub@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
"Krogerus, Heikki" <heikki.krogerus@linux.intel.com>,
Helge Deller <deller@gmx.de>,
chiaen_wu@richtek.com, alice_chen@richtek.com,
ChiYuan Huang <cy_huang@richtek.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
USB <linux-usb@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
"open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH v4 08/13] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver
Date: Mon, 4 Jul 2022 13:07:27 +0200 [thread overview]
Message-ID: <YsLJ7+HiqaBTwCLg@kroah.com> (raw)
In-Reply-To: <CA+hk2fYA3phYAoh+BFr0ddy9MR8Ro1WCoqBpa1UK2StwMtLyfQ@mail.gmail.com>
On Mon, Jul 04, 2022 at 05:31:29PM +0800, szuni chen wrote:
> Greg KH <gregkh@linuxfoundation.org> 於 2022年7月4日 週一 下午3:32寫道：
> >
> > On Mon, Jul 04, 2022 at 01:38:56PM +0800, ChiaEn Wu wrote:
> > > From: ChiYuan Huang <cy_huang@richtek.com>
> > >
> > > Add chip level mt6370 tcpci driver.
> >
> > What does this mean? Please provide more information about the hardware
> > being supported here so we know how to review this.
>
> Dear Greg,
>
> MediaTek MT6370 is a highly-integrated smart power management IC,
> which includes a single cell Li-Ion/Li-Polymer switching battery charger,
> a USB Type-C & Power Delivery (PD) controller, dual flash LED current sources,
> a RGB LED driver, a backlight WLED driver, a display bias driver and a
> general LDO for portable devices.
>
> This driver is used for the Type-C & Power Delivery controller in
> MediaTek MT6370 IC.
>
> If we change the commit message to
>
> "Add MediaTek MT6370 tcpci driver.
> MediaTek MT6370 is a multi-functional IC that includes USB Type-C.
> It works with Type-C Port Controller Manager to provide USB PD and USB
> Type-C functionalities."
>
> does this meet your requirements?
What would you want to see if you were reading a changelog text for an
unfamiliar hardware device? More text is always better!
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: szuni chen <szunichen@gmail.com>
Cc: "open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
"Krogerus, Heikki" <heikki.krogerus@linux.intel.com>,
Pavel Machek <pavel@ucw.cz>,
alice_chen@richtek.com, linux-iio <linux-iio@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Liam Girdwood <lgirdwood@gmail.com>,
ChiYuan Huang <cy_huang@richtek.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Helge Deller <deller@gmx.de>, Rob Herring <robh+dt@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Guenter Roeck <linux@roeck-us.net>,
devicetree <devicetree@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
ChiaEn Wu <peterwu.pub@gmail.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Jingoo Han <jingoohan1@gmail.com>,
USB <linux-usb@vger.kernel.org>,
Sebastian Reichel <sre@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
chiaen_wu@richtek.com, Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v4 08/13] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver
Date: Mon, 4 Jul 2022 13:07:27 +0200 [thread overview]
Message-ID: <YsLJ7+HiqaBTwCLg@kroah.com> (raw)
In-Reply-To: <CA+hk2fYA3phYAoh+BFr0ddy9MR8Ro1WCoqBpa1UK2StwMtLyfQ@mail.gmail.com>
On Mon, Jul 04, 2022 at 05:31:29PM +0800, szuni chen wrote:
> Greg KH <gregkh@linuxfoundation.org> 於 2022年7月4日 週一 下午3:32寫道：
> >
> > On Mon, Jul 04, 2022 at 01:38:56PM +0800, ChiaEn Wu wrote:
> > > From: ChiYuan Huang <cy_huang@richtek.com>
> > >
> > > Add chip level mt6370 tcpci driver.
> >
> > What does this mean? Please provide more information about the hardware
> > being supported here so we know how to review this.
>
> Dear Greg,
>
> MediaTek MT6370 is a highly-integrated smart power management IC,
> which includes a single cell Li-Ion/Li-Polymer switching battery charger,
> a USB Type-C & Power Delivery (PD) controller, dual flash LED current sources,
> a RGB LED driver, a backlight WLED driver, a display bias driver and a
> general LDO for portable devices.
>
> This driver is used for the Type-C & Power Delivery controller in
> MediaTek MT6370 IC.
>
> If we change the commit message to
>
> "Add MediaTek MT6370 tcpci driver.
> MediaTek MT6370 is a multi-functional IC that includes USB Type-C.
> It works with Type-C Port Controller Manager to provide USB PD and USB
> Type-C functionalities."
>
> does this meet your requirements?
What would you want to see if you were reading a changelog text for an
unfamiliar hardware device? More text is always better!
thanks,
greg k-h
next prev parent reply other threads:[~2022-07-04 11:07 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 5:38 [PATCH v4 00/13] Add Mediatek MT6370 PMIC support ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` [PATCH v4 01/13] dt-bindings: usb: Add Mediatek MT6370 TCPC ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` [PATCH v4 02/13] dt-bindings: power: supply: Add Mediatek MT6370 Charger ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 9:04 ` Krzysztof Kozlowski
2022-07-04 9:04 ` Krzysztof Kozlowski
2022-07-04 9:04 ` Krzysztof Kozlowski
2022-07-04 5:38 ` [PATCH v4 03/13] dt-bindings: leds: mt6370: Add Mediatek mt6370 current sink type LED indicator ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` [PATCH v4 04/13] dt-bindings: leds: Add Mediatek MT6370 flashlight ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` [PATCH v4 05/13] dt-bindings: backlight: Add Mediatek MT6370 backlight ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` [PATCH v4 06/13] dt-bindings: mfd: Add Mediatek MT6370 ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 9:07 ` Krzysztof Kozlowski
2022-07-04 9:07 ` Krzysztof Kozlowski
2022-07-04 9:07 ` Krzysztof Kozlowski
2022-07-04 5:38 ` [PATCH v4 07/13] mfd: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 20:29 ` Andy Shevchenko
2022-07-04 20:29 ` Andy Shevchenko
2022-07-04 20:29 ` Andy Shevchenko
2022-07-04 5:38 ` [PATCH v4 08/13] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 7:32 ` Greg KH
2022-07-04 7:32 ` Greg KH
2022-07-04 7:32 ` Greg KH
2022-07-04 9:31 ` szuni chen
2022-07-04 9:31 ` szuni chen
2022-07-04 9:31 ` szuni chen
2022-07-04 11:07 ` Greg KH [this message]
2022-07-04 11:07 ` Greg KH
2022-07-04 11:07 ` Greg KH
2022-07-04 20:19 ` Andy Shevchenko
2022-07-04 20:19 ` Andy Shevchenko
2022-07-04 20:19 ` Andy Shevchenko
2022-07-04 5:38 ` [PATCH v4 09/13] iio: adc: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 20:35 ` Andy Shevchenko
2022-07-04 20:35 ` Andy Shevchenko
2022-07-04 20:35 ` Andy Shevchenko
2022-07-04 5:38 ` [PATCH v4 10/13] power: supply: mt6370: Add Mediatek MT6370 charger driver ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 20:53 ` Andy Shevchenko
2022-07-04 20:53 ` Andy Shevchenko
2022-07-04 20:53 ` Andy Shevchenko
2022-07-04 5:38 ` [PATCH v4 11/13] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:38 ` ChiaEn Wu
2022-07-04 5:39 ` [PATCH v4 12/13] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support ChiaEn Wu
2022-07-04 5:39 ` ChiaEn Wu
2022-07-04 5:39 ` ChiaEn Wu
2022-07-04 21:05 ` Andy Shevchenko
2022-07-04 21:05 ` Andy Shevchenko
2022-07-04 21:05 ` Andy Shevchenko
2022-07-07 10:49 ` szuni chen
2022-07-07 10:49 ` szuni chen
2022-07-07 10:49 ` szuni chen
2022-07-04 5:39 ` [PATCH v4 13/13] video: backlight: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-07-04 5:39 ` ChiaEn Wu
2022-07-04 5:39 ` ChiaEn Wu
2022-07-04 21:14 ` Andy Shevchenko
2022-07-04 21:14 ` Andy Shevchenko
2022-07-04 21:14 ` Andy Shevchenko
2022-07-13 10:53 ` ChiaEn Wu
2022-07-13 10:53 ` ChiaEn Wu
2022-07-13 10:53 ` ChiaEn Wu
2022-07-13 12:07 ` Andy Shevchenko
2022-07-13 12:07 ` Andy Shevchenko
2022-07-13 12:07 ` Andy Shevchenko
2022-07-13 13:07 ` Lee Jones
2022-07-13 13:07 ` Lee Jones
2022-07-13 13:07 ` Lee Jones
2022-07-14 7:13 ` ChiaEn Wu
2022-07-14 7:13 ` ChiaEn Wu
2022-07-14 7:13 ` ChiaEn Wu
2022-07-14 9:27 ` Andy Shevchenko
2022-07-14 9:27 ` Andy Shevchenko
2022-07-14 9:27 ` Andy Shevchenko
2022-07-14 9:43 ` Andy Shevchenko
2022-07-14 9:43 ` Andy Shevchenko
2022-07-14 9:43 ` Andy Shevchenko
2022-07-14 10:15 ` Andy Shevchenko
2022-07-14 10:15 ` Andy Shevchenko
2022-07-14 10:15 ` Andy Shevchenko
2022-07-14 9:47 ` Daniel Thompson
2022-07-14 9:47 ` Daniel Thompson
2022-07-14 9:47 ` Daniel Thompson
2022-07-14 9:49 ` Andy Shevchenko
2022-07-14 9:49 ` Andy Shevchenko
2022-07-14 9:49 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsLJ7+HiqaBTwCLg@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alice_chen@richtek.com \
--cc=broonie@kernel.org \
--cc=chiaen_wu@richtek.com \
--cc=chunfeng.yun@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jic23@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=peterwu.pub@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=szunichen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.