From: Andy Shevchenko <andy.shevchenko@gmail.com> To: Michal Simek <michal.simek@xilinx.com> Cc: Sai Krishna Potthuri <lakshmis@xilinx.com>, Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, devicetree <devicetree@vger.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, git <git@xilinx.com>, "saikrishna12468@gmail.com" <saikrishna12468@gmail.com> Subject: Re: [PATCH v6 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support Date: Tue, 27 Apr 2021 10:31:08 +0300 [thread overview] Message-ID: <CAHp75Vejqe3r6s5eoOfza0DjXEwN-hK73FWkxx6VNpx0y1ms2w@mail.gmail.com> (raw) In-Reply-To: <d1220d39-4be4-a375-042f-e7bb0264ed35@xilinx.com> On Tue, Apr 27, 2021 at 10:23 AM Michal Simek <michal.simek@xilinx.com> wrote: > > Hi Andy, > > On 4/26/21 4:04 PM, Andy Shevchenko wrote: > > On Mon, Apr 26, 2021 at 4:20 PM Sai Krishna Potthuri > > <lakshmis@xilinx.com> wrote: > >>> From: Andy Shevchenko <andy.shevchenko@gmail.com> > >>> Sent: Friday, April 23, 2021 9:24 PM > >>> On Thu, Apr 22, 2021 at 11:31 AM Sai Krishna Potthuri > >>> <lakshmi.sai.krishna.potthuri@xilinx.com> wrote: > > > > ... > > > >>>> +config PINCTRL_ZYNQMP > >>>> + tristate "Pinctrl driver for Xilinx ZynqMP" > >>>> + depends on ZYNQMP_FIRMWARE > >>>> + select PINMUX > >>>> + select GENERIC_PINCONF > >>>> + default ZYNQMP_FIRMWARE > >>>> + help > >>>> + This selects the pinctrl driver for Xilinx ZynqMP platform. > >>>> + This driver will query the pin information from the firmware > >>>> + and allow configuring the pins. > >>>> + Configuration can include the mux function to select on those > >>>> + pin(s)/group(s), and various pin configuration parameters > >>>> + such as pull-up, slew rate, etc. > >>> > >>> Missed module name. > >> Is this (module name) a configuration option in Kconfig? > > > > It's a text in a free form that sheds light on how the module will be > > named in case the user will choose "m". > > Is this described somewhere in documentation that module name should be > the part of symbol description? I was looking at pinctrl Kconfig and I > can't see any description like this there that's why I want to double > check. I dunno if it is described, the group of maintainers require that for some time. I personally found this as a good practice. > Also if this is a rule checkpatch should be extended to checking this. There was a discussion at some point to add a check that help description shouldn't be less than 3 lines. Not sure what the outcome of it. -- With Best Regards, Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com> To: Michal Simek <michal.simek@xilinx.com> Cc: Sai Krishna Potthuri <lakshmis@xilinx.com>, Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, devicetree <devicetree@vger.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, git <git@xilinx.com>, "saikrishna12468@gmail.com" <saikrishna12468@gmail.com> Subject: Re: [PATCH v6 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support Date: Tue, 27 Apr 2021 10:31:08 +0300 [thread overview] Message-ID: <CAHp75Vejqe3r6s5eoOfza0DjXEwN-hK73FWkxx6VNpx0y1ms2w@mail.gmail.com> (raw) In-Reply-To: <d1220d39-4be4-a375-042f-e7bb0264ed35@xilinx.com> On Tue, Apr 27, 2021 at 10:23 AM Michal Simek <michal.simek@xilinx.com> wrote: > > Hi Andy, > > On 4/26/21 4:04 PM, Andy Shevchenko wrote: > > On Mon, Apr 26, 2021 at 4:20 PM Sai Krishna Potthuri > > <lakshmis@xilinx.com> wrote: > >>> From: Andy Shevchenko <andy.shevchenko@gmail.com> > >>> Sent: Friday, April 23, 2021 9:24 PM > >>> On Thu, Apr 22, 2021 at 11:31 AM Sai Krishna Potthuri > >>> <lakshmi.sai.krishna.potthuri@xilinx.com> wrote: > > > > ... > > > >>>> +config PINCTRL_ZYNQMP > >>>> + tristate "Pinctrl driver for Xilinx ZynqMP" > >>>> + depends on ZYNQMP_FIRMWARE > >>>> + select PINMUX > >>>> + select GENERIC_PINCONF > >>>> + default ZYNQMP_FIRMWARE > >>>> + help > >>>> + This selects the pinctrl driver for Xilinx ZynqMP platform. > >>>> + This driver will query the pin information from the firmware > >>>> + and allow configuring the pins. > >>>> + Configuration can include the mux function to select on those > >>>> + pin(s)/group(s), and various pin configuration parameters > >>>> + such as pull-up, slew rate, etc. > >>> > >>> Missed module name. > >> Is this (module name) a configuration option in Kconfig? > > > > It's a text in a free form that sheds light on how the module will be > > named in case the user will choose "m". > > Is this described somewhere in documentation that module name should be > the part of symbol description? I was looking at pinctrl Kconfig and I > can't see any description like this there that's why I want to double > check. I dunno if it is described, the group of maintainers require that for some time. I personally found this as a good practice. > Also if this is a rule checkpatch should be extended to checking this. There was a discussion at some point to add a check that help description shouldn't be less than 3 lines. Not sure what the outcome of it. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-27 7:31 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-22 8:29 [PATCH v6 0/3] Add ZynqMP pinctrl driver Sai Krishna Potthuri 2021-04-22 8:29 ` Sai Krishna Potthuri 2021-04-22 8:30 ` [PATCH v6 1/3] firmware: xilinx: Add pinctrl support Sai Krishna Potthuri 2021-04-22 8:30 ` Sai Krishna Potthuri 2021-04-22 8:30 ` [PATCH v6 2/3] dt-bindings: pinctrl: Add binding for ZynqMP pinctrl driver Sai Krishna Potthuri 2021-04-22 8:30 ` Sai Krishna Potthuri 2021-04-22 8:30 ` [PATCH v6 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support Sai Krishna Potthuri 2021-04-22 8:30 ` Sai Krishna Potthuri 2021-04-22 16:39 ` kernel test robot 2021-04-23 15:53 ` Andy Shevchenko 2021-04-23 15:53 ` Andy Shevchenko 2021-04-26 13:20 ` Sai Krishna Potthuri 2021-04-26 13:20 ` Sai Krishna Potthuri 2021-04-26 14:04 ` Andy Shevchenko 2021-04-26 14:04 ` Andy Shevchenko 2021-04-27 7:23 ` Michal Simek 2021-04-27 7:23 ` Michal Simek 2021-04-27 7:31 ` Andy Shevchenko [this message] 2021-04-27 7:31 ` Andy Shevchenko 2021-04-27 7:38 ` Michal Simek 2021-04-27 7:38 ` Michal Simek 2021-04-27 8:39 ` Andy Shevchenko 2021-04-27 8:39 ` Andy Shevchenko 2021-04-27 9:59 ` Michal Simek 2021-04-27 9:59 ` Michal Simek 2021-04-27 14:04 ` Andy Shevchenko 2021-04-27 14:04 ` Andy Shevchenko 2021-04-28 5:33 ` Sai Krishna Potthuri 2021-04-28 5:33 ` Sai Krishna Potthuri 2021-05-11 12:38 ` Sai Krishna Potthuri 2021-05-11 12:38 ` Sai Krishna Potthuri 2021-06-17 6:37 ` Sai Krishna Potthuri 2021-06-17 6:37 ` Sai Krishna Potthuri 2021-06-17 7:18 ` Andy Shevchenko 2021-06-17 7:18 ` Andy Shevchenko 2021-06-17 7:31 ` Greg Kroah-Hartman 2021-06-17 7:31 ` Greg Kroah-Hartman 2021-04-22 9:13 ` [PATCH v6 0/3] Add ZynqMP pinctrl driver Linus Walleij 2021-04-22 9:13 ` Linus Walleij 2021-04-23 15:54 ` Andy Shevchenko 2021-04-23 15:54 ` Andy Shevchenko 2021-04-29 14:21 ` Linus Walleij 2021-04-29 14:21 ` Linus Walleij 2021-04-29 14:32 ` Sai Krishna Potthuri 2021-04-29 14:32 ` Sai Krishna Potthuri
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAHp75Vejqe3r6s5eoOfza0DjXEwN-hK73FWkxx6VNpx0y1ms2w@mail.gmail.com \ --to=andy.shevchenko@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=git@xilinx.com \ --cc=gregkh@linuxfoundation.org \ --cc=lakshmis@xilinx.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=michal.simek@xilinx.com \ --cc=robh+dt@kernel.org \ --cc=saikrishna12468@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.