From: Andy Shevchenko <andy.shevchenko@gmail.com> To: Bartosz Golaszewski <brgl@bgdev.pl> Cc: Jonathan Cameron <jic23@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, Michal Simek <michal.simek@xilinx.com>, linux-iio <linux-iio@vger.kernel.org>, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com> Subject: Re: [PATCH 2/5] iio: adc: xilinx: use devm_krealloc() instead of kfree() + kcalloc() Date: Tue, 27 Oct 2020 12:30:41 +0200 [thread overview] Message-ID: <CAHp75Vf-z8yba-QX4G51PRkMV9VKAczd_79sma96zHRf+bMD2w@mail.gmail.com> (raw) In-Reply-To: <CAMRc=Mf33JMNMT1vcrHx33QK7wj_gPY-CPaPUsqtON8X8S-JtQ@mail.gmail.com> On Tue, Oct 27, 2020 at 12:04 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > On Tue, Oct 27, 2020 at 10:33 AM Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: > > > > On Mon, Oct 26, 2020 at 4:03 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > > > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > > > We now have devm_krealloc() in the kernel Use it indstead of calling > > > kfree() and kcalloc() separately. > > > > Which is completely lawful when size > previous_size (I mean, the > > additional patch you sent previously seems not related to this). > > > > Sure but devm_krealloc() is cleaner and adds the benefit of resource management. I meant devm_krealloc(). It should work in this case without your additional "fix" patch. > > > - kfree(xadc->data); > > > - xadc->data = kcalloc(n, sizeof(*xadc->data), GFP_KERNEL); > > > + xadc->data = devm_krealloc(indio_dev->dev.parent, xadc->data, > > > + n * sizeof(*xadc->data), > > > > I think you need to use something from overflow.h instead of explicit > > multiplication here. > > > > Or maybe add devm_krealloc_array() which would perform the checks > behind the scenes? Maybe. But what to do in the cases when you have struct with flexible arrays, like struct foo { ... type bar[]; }; ? And you do kzalloc(sizeof(foo)) followed by krealloc(). The above name (krealloc_array) may be a bit ambiguous. > > > + GFP_KERNEL | __GFP_ZERO); -- With Best Regards, Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com> To: Bartosz Golaszewski <brgl@bgdev.pl> Cc: Lars-Peter Clausen <lars@metafoo.de>, linux-iio <linux-iio@vger.kernel.org>, Michal Simek <michal.simek@xilinx.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Jonathan Cameron <jic23@kernel.org>, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 2/5] iio: adc: xilinx: use devm_krealloc() instead of kfree() + kcalloc() Date: Tue, 27 Oct 2020 12:30:41 +0200 [thread overview] Message-ID: <CAHp75Vf-z8yba-QX4G51PRkMV9VKAczd_79sma96zHRf+bMD2w@mail.gmail.com> (raw) In-Reply-To: <CAMRc=Mf33JMNMT1vcrHx33QK7wj_gPY-CPaPUsqtON8X8S-JtQ@mail.gmail.com> On Tue, Oct 27, 2020 at 12:04 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > On Tue, Oct 27, 2020 at 10:33 AM Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: > > > > On Mon, Oct 26, 2020 at 4:03 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > > > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > > > We now have devm_krealloc() in the kernel Use it indstead of calling > > > kfree() and kcalloc() separately. > > > > Which is completely lawful when size > previous_size (I mean, the > > additional patch you sent previously seems not related to this). > > > > Sure but devm_krealloc() is cleaner and adds the benefit of resource management. I meant devm_krealloc(). It should work in this case without your additional "fix" patch. > > > - kfree(xadc->data); > > > - xadc->data = kcalloc(n, sizeof(*xadc->data), GFP_KERNEL); > > > + xadc->data = devm_krealloc(indio_dev->dev.parent, xadc->data, > > > + n * sizeof(*xadc->data), > > > > I think you need to use something from overflow.h instead of explicit > > multiplication here. > > > > Or maybe add devm_krealloc_array() which would perform the checks > behind the scenes? Maybe. But what to do in the cases when you have struct with flexible arrays, like struct foo { ... type bar[]; }; ? And you do kzalloc(sizeof(foo)) followed by krealloc(). The above name (krealloc_array) may be a bit ambiguous. > > > + GFP_KERNEL | __GFP_ZERO); -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-27 10:30 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-26 13:36 [PATCH 0/5] iio: adc: xilinx: use even more devres Bartosz Golaszewski 2020-10-26 13:36 ` Bartosz Golaszewski 2020-10-26 13:36 ` [PATCH 1/5] iio: adc: xilinx: use helper variable for &pdev->dev Bartosz Golaszewski 2020-10-26 13:36 ` Bartosz Golaszewski 2020-10-26 13:36 ` [PATCH 2/5] iio: adc: xilinx: use devm_krealloc() instead of kfree() + kcalloc() Bartosz Golaszewski 2020-10-26 13:36 ` Bartosz Golaszewski 2020-10-27 9:33 ` Andy Shevchenko 2020-10-27 9:33 ` Andy Shevchenko 2020-10-27 10:04 ` Bartosz Golaszewski 2020-10-27 10:04 ` Bartosz Golaszewski 2020-10-27 10:30 ` Andy Shevchenko [this message] 2020-10-27 10:30 ` Andy Shevchenko 2020-10-27 10:40 ` Bartosz Golaszewski 2020-10-27 10:40 ` Bartosz Golaszewski 2020-10-27 11:18 ` Andy Shevchenko 2020-10-27 11:18 ` Andy Shevchenko 2020-10-26 13:36 ` [PATCH 3/5] iio: adc: xilinx: use a devres action to disable and unprepare the clock Bartosz Golaszewski 2020-10-26 13:36 ` Bartosz Golaszewski 2020-10-29 15:38 ` Jonathan Cameron 2020-10-29 15:38 ` Jonathan Cameron 2020-10-26 13:36 ` [PATCH 4/5] iio: adc: xilinx: use devres for irq handling Bartosz Golaszewski 2020-10-26 13:36 ` Bartosz Golaszewski 2020-10-29 15:41 ` Jonathan Cameron 2020-10-29 15:41 ` Jonathan Cameron 2020-10-30 10:52 ` Bartosz Golaszewski 2020-10-30 10:52 ` Bartosz Golaszewski 2020-10-31 11:10 ` Jonathan Cameron 2020-10-31 11:10 ` Jonathan Cameron 2020-11-02 8:39 ` Bartosz Golaszewski 2020-11-02 8:39 ` Bartosz Golaszewski 2020-10-26 13:36 ` [PATCH 5/5] iio: adc: xilinx: use iio devres helpers Bartosz Golaszewski 2020-10-26 13:36 ` Bartosz Golaszewski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAHp75Vf-z8yba-QX4G51PRkMV9VKAczd_79sma96zHRf+bMD2w@mail.gmail.com \ --to=andy.shevchenko@gmail.com \ --cc=bgolaszewski@baylibre.com \ --cc=brgl@bgdev.pl \ --cc=jic23@kernel.org \ --cc=lars@metafoo.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=michal.simek@xilinx.com \ --cc=pmeerw@pmeerw.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.