From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Michal Simek <michal.simek@xilinx.com>,
linux-iio <linux-iio@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] iio: adc: xilinx: use devres for irq handling
Date: Mon, 2 Nov 2020 09:39:44 +0100 [thread overview]
Message-ID: <CAMpxmJWoEGFaX5czVSFd4D2Mhkp_jF7ZQg9TtDGs_tRiYWmupA@mail.gmail.com> (raw)
In-Reply-To: <20201031111003.75a4f6d0@archlinux>
On Sat, Oct 31, 2020 at 12:10 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
[snip]
> >
> > Hi Jonathan,
> >
> > My two priorities for the ordering of this series were: correct
> > end-result and not breaking anything on the way. The latter
> > unfortunately gets in the way of cleaner looking intermediate patches.
> >
> > I tried to not alter the ordering in which the resources are freed at
> > any step. As devres release callbacks are called *after* remove() and
> > in a reverse order to how they were registered, I needed to start from
> > the bottom of the remove() callback and convert the last operation,
> > then go upwards from there.
> >
> > If I tried to do it from the top - I probably could remove labels
> > earlier and in a cleaner manner but it wouldn't guarantee
> > bisectability.
> >
>
> Maybe best plan is to squash last 3 patches into one?
>
> I suspect that's going to be easier to review.
>
> Jonathan
>
Sure I can do this.
Bartosz
WARNING: multiple messages have this Message-ID (diff)
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
linux-iio <linux-iio@vger.kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Michal Simek <michal.simek@xilinx.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/5] iio: adc: xilinx: use devres for irq handling
Date: Mon, 2 Nov 2020 09:39:44 +0100 [thread overview]
Message-ID: <CAMpxmJWoEGFaX5czVSFd4D2Mhkp_jF7ZQg9TtDGs_tRiYWmupA@mail.gmail.com> (raw)
In-Reply-To: <20201031111003.75a4f6d0@archlinux>
On Sat, Oct 31, 2020 at 12:10 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
[snip]
> >
> > Hi Jonathan,
> >
> > My two priorities for the ordering of this series were: correct
> > end-result and not breaking anything on the way. The latter
> > unfortunately gets in the way of cleaner looking intermediate patches.
> >
> > I tried to not alter the ordering in which the resources are freed at
> > any step. As devres release callbacks are called *after* remove() and
> > in a reverse order to how they were registered, I needed to start from
> > the bottom of the remove() callback and convert the last operation,
> > then go upwards from there.
> >
> > If I tried to do it from the top - I probably could remove labels
> > earlier and in a cleaner manner but it wouldn't guarantee
> > bisectability.
> >
>
> Maybe best plan is to squash last 3 patches into one?
>
> I suspect that's going to be easier to review.
>
> Jonathan
>
Sure I can do this.
Bartosz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-02 8:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 13:36 [PATCH 0/5] iio: adc: xilinx: use even more devres Bartosz Golaszewski
2020-10-26 13:36 ` Bartosz Golaszewski
2020-10-26 13:36 ` [PATCH 1/5] iio: adc: xilinx: use helper variable for &pdev->dev Bartosz Golaszewski
2020-10-26 13:36 ` Bartosz Golaszewski
2020-10-26 13:36 ` [PATCH 2/5] iio: adc: xilinx: use devm_krealloc() instead of kfree() + kcalloc() Bartosz Golaszewski
2020-10-26 13:36 ` Bartosz Golaszewski
2020-10-27 9:33 ` Andy Shevchenko
2020-10-27 9:33 ` Andy Shevchenko
2020-10-27 10:04 ` Bartosz Golaszewski
2020-10-27 10:04 ` Bartosz Golaszewski
2020-10-27 10:30 ` Andy Shevchenko
2020-10-27 10:30 ` Andy Shevchenko
2020-10-27 10:40 ` Bartosz Golaszewski
2020-10-27 10:40 ` Bartosz Golaszewski
2020-10-27 11:18 ` Andy Shevchenko
2020-10-27 11:18 ` Andy Shevchenko
2020-10-26 13:36 ` [PATCH 3/5] iio: adc: xilinx: use a devres action to disable and unprepare the clock Bartosz Golaszewski
2020-10-26 13:36 ` Bartosz Golaszewski
2020-10-29 15:38 ` Jonathan Cameron
2020-10-29 15:38 ` Jonathan Cameron
2020-10-26 13:36 ` [PATCH 4/5] iio: adc: xilinx: use devres for irq handling Bartosz Golaszewski
2020-10-26 13:36 ` Bartosz Golaszewski
2020-10-29 15:41 ` Jonathan Cameron
2020-10-29 15:41 ` Jonathan Cameron
2020-10-30 10:52 ` Bartosz Golaszewski
2020-10-30 10:52 ` Bartosz Golaszewski
2020-10-31 11:10 ` Jonathan Cameron
2020-10-31 11:10 ` Jonathan Cameron
2020-11-02 8:39 ` Bartosz Golaszewski [this message]
2020-11-02 8:39 ` Bartosz Golaszewski
2020-10-26 13:36 ` [PATCH 5/5] iio: adc: xilinx: use iio devres helpers Bartosz Golaszewski
2020-10-26 13:36 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMpxmJWoEGFaX5czVSFd4D2Mhkp_jF7ZQg9TtDGs_tRiYWmupA@mail.gmail.com \
--to=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.