From: Guo Ren <guoren@kernel.org>
To: Eugene Syromiatnikov <esyr@redhat.com>
Cc: "Christoph Hellwig" <hch@lst.de>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Naresh Kamboju" <naresh.kamboju@linaro.org>,
linux-arch <linux-arch@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
linux-s390 <linux-s390@vger.kernel.org>,
sparclinux <sparclinux@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"Parisc List" <linux-parisc@vger.kernel.org>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"the arch/x86 maintainers" <x86@kernel.org>,
"Heiko Stübner" <heiko@sntech.de>,
ldv@strace.io
Subject: Re: [PATCH V12 02/20] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h
Date: Mon, 13 Jun 2022 09:15:48 +0800 [thread overview]
Message-ID: <CAJF2gTQhFbN3mK0jco=NAKZr4qCgvX4zkw3h6jdffr66Rz7REQ@mail.gmail.com> (raw)
In-Reply-To: <20220608094108.GA18122@asgard.redhat.com>
On Wed, Jun 8, 2022 at 5:41 PM Eugene Syromiatnikov <esyr@redhat.com> wrote:
>
> On Tue, Apr 05, 2022 at 03:12:56PM +0800, guoren@kernel.org wrote:
> > From: Christoph Hellwig <hch@lst.de>
> >
> > Note that before this change they were never visible to userspace due
> > to the fact that CONFIG_64BIT is only set for kernel builds.
>
> > -#ifndef CONFIG_64BIT
> > +#if __BITS_PER_LONG == 32 || defined(__KERNEL__)
>
> Actually, it's quite the opposite: "ifndef" usage made it vailable at all times
> to the userspace, and this change has actually broken building strace
> with the latest kernel headers[1][2]. There could be some debate
> whether having these F_*64 definitions exposed to the user space 64-bit
> applications, but it seems that were no harm (as they were exposed already
> for quite some time), and they are useful at least for strace for compat
> application tracing purposes.
>
> [1] https://github.com/strace/strace/runs/6779763146?check_suite_focus=true#step:4:3222
> [2] https://pipelines.actions.githubusercontent.com/serviceHosts/e5309ebd-8a2f-43f4-a212-b52080275b5d/_apis/pipelines/1/runs/1473/signedlogcontent/12?urlExpires=2022-06-08T09%3A37%3A13.9248496Z&urlSigningMethod=HMACV1&urlSignature=fIT7vd0O4NNRwzwKWLXY4UVZBIIF3XiVI9skAsGvV0I%3D
>
Yes, there is no CONFIG_64BIT in userspace, we shouldn't limit it with
(__BITS_PER_LONG == 32 || defined(__KERNEL__)) to break the
compatibility. Just export F_*64 definitions permanently.
--
Best Regards
Guo Ren
ML: https://lore.kernel.org/linux-csky/
WARNING: multiple messages have this Message-ID (diff)
From: Guo Ren <guoren@kernel.org>
To: Eugene Syromiatnikov <esyr@redhat.com>
Cc: "Christoph Hellwig" <hch@lst.de>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Naresh Kamboju" <naresh.kamboju@linaro.org>,
linux-arch <linux-arch@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
linux-s390 <linux-s390@vger.kernel.org>,
sparclinux <sparclinux@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"Parisc List" <linux-parisc@vger.kernel.org>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"the arch/x86 maintainers" <x86@kernel.org>,
"Heiko Stübner" <heiko@sntech.de>,
ldv@strace.io
Subject: Re: [PATCH V12 02/20] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h
Date: Mon, 13 Jun 2022 09:15:48 +0800 [thread overview]
Message-ID: <CAJF2gTQhFbN3mK0jco=NAKZr4qCgvX4zkw3h6jdffr66Rz7REQ@mail.gmail.com> (raw)
In-Reply-To: <20220608094108.GA18122@asgard.redhat.com>
On Wed, Jun 8, 2022 at 5:41 PM Eugene Syromiatnikov <esyr@redhat.com> wrote:
>
> On Tue, Apr 05, 2022 at 03:12:56PM +0800, guoren@kernel.org wrote:
> > From: Christoph Hellwig <hch@lst.de>
> >
> > Note that before this change they were never visible to userspace due
> > to the fact that CONFIG_64BIT is only set for kernel builds.
>
> > -#ifndef CONFIG_64BIT
> > +#if __BITS_PER_LONG == 32 || defined(__KERNEL__)
>
> Actually, it's quite the opposite: "ifndef" usage made it vailable at all times
> to the userspace, and this change has actually broken building strace
> with the latest kernel headers[1][2]. There could be some debate
> whether having these F_*64 definitions exposed to the user space 64-bit
> applications, but it seems that were no harm (as they were exposed already
> for quite some time), and they are useful at least for strace for compat
> application tracing purposes.
>
> [1] https://github.com/strace/strace/runs/6779763146?check_suite_focus=true#step:4:3222
> [2] https://pipelines.actions.githubusercontent.com/serviceHosts/e5309ebd-8a2f-43f4-a212-b52080275b5d/_apis/pipelines/1/runs/1473/signedlogcontent/12?urlExpires=2022-06-08T09%3A37%3A13.9248496Z&urlSigningMethod=HMACV1&urlSignature=fIT7vd0O4NNRwzwKWLXY4UVZBIIF3XiVI9skAsGvV0I%3D
>
Yes, there is no CONFIG_64BIT in userspace, we shouldn't limit it with
(__BITS_PER_LONG == 32 || defined(__KERNEL__)) to break the
compatibility. Just export F_*64 definitions permanently.
--
Best Regards
Guo Ren
ML: https://lore.kernel.org/linux-csky/
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Guo Ren <guoren@kernel.org>
To: Eugene Syromiatnikov <esyr@redhat.com>
Cc: linux-arch <linux-arch@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
"Parisc List" <linux-parisc@vger.kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Naresh Kamboju" <naresh.kamboju@linaro.org>,
"the arch/x86 maintainers" <x86@kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
sparclinux <sparclinux@vger.kernel.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
ldv@strace.io, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"Christoph Hellwig" <hch@lst.de>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"Heiko Stübner" <heiko@sntech.de>
Subject: Re: [PATCH V12 02/20] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h
Date: Mon, 13 Jun 2022 09:15:48 +0800 [thread overview]
Message-ID: <CAJF2gTQhFbN3mK0jco=NAKZr4qCgvX4zkw3h6jdffr66Rz7REQ@mail.gmail.com> (raw)
In-Reply-To: <20220608094108.GA18122@asgard.redhat.com>
On Wed, Jun 8, 2022 at 5:41 PM Eugene Syromiatnikov <esyr@redhat.com> wrote:
>
> On Tue, Apr 05, 2022 at 03:12:56PM +0800, guoren@kernel.org wrote:
> > From: Christoph Hellwig <hch@lst.de>
> >
> > Note that before this change they were never visible to userspace due
> > to the fact that CONFIG_64BIT is only set for kernel builds.
>
> > -#ifndef CONFIG_64BIT
> > +#if __BITS_PER_LONG == 32 || defined(__KERNEL__)
>
> Actually, it's quite the opposite: "ifndef" usage made it vailable at all times
> to the userspace, and this change has actually broken building strace
> with the latest kernel headers[1][2]. There could be some debate
> whether having these F_*64 definitions exposed to the user space 64-bit
> applications, but it seems that were no harm (as they were exposed already
> for quite some time), and they are useful at least for strace for compat
> application tracing purposes.
>
> [1] https://github.com/strace/strace/runs/6779763146?check_suite_focus=true#step:4:3222
> [2] https://pipelines.actions.githubusercontent.com/serviceHosts/e5309ebd-8a2f-43f4-a212-b52080275b5d/_apis/pipelines/1/runs/1473/signedlogcontent/12?urlExpires=2022-06-08T09%3A37%3A13.9248496Z&urlSigningMethod=HMACV1&urlSignature=fIT7vd0O4NNRwzwKWLXY4UVZBIIF3XiVI9skAsGvV0I%3D
>
Yes, there is no CONFIG_64BIT in userspace, we shouldn't limit it with
(__BITS_PER_LONG == 32 || defined(__KERNEL__)) to break the
compatibility. Just export F_*64 definitions permanently.
--
Best Regards
Guo Ren
ML: https://lore.kernel.org/linux-csky/
WARNING: multiple messages have this Message-ID (diff)
From: Guo Ren <guoren@kernel.org>
To: Eugene Syromiatnikov <esyr@redhat.com>
Cc: "Christoph Hellwig" <hch@lst.de>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Naresh Kamboju" <naresh.kamboju@linaro.org>,
linux-arch <linux-arch@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
linux-s390 <linux-s390@vger.kernel.org>,
sparclinux <sparclinux@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"Parisc List" <linux-parisc@vger.kernel.org>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"the arch/x86 maintainers" <x86@kernel.org>,
"Heiko Stübner" <heiko@sntech.de>,
ldv@strace.io
Subject: Re: [PATCH V12 02/20] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h
Date: Mon, 13 Jun 2022 09:15:48 +0800 [thread overview]
Message-ID: <CAJF2gTQhFbN3mK0jco=NAKZr4qCgvX4zkw3h6jdffr66Rz7REQ@mail.gmail.com> (raw)
In-Reply-To: <20220608094108.GA18122@asgard.redhat.com>
On Wed, Jun 8, 2022 at 5:41 PM Eugene Syromiatnikov <esyr@redhat.com> wrote:
>
> On Tue, Apr 05, 2022 at 03:12:56PM +0800, guoren@kernel.org wrote:
> > From: Christoph Hellwig <hch@lst.de>
> >
> > Note that before this change they were never visible to userspace due
> > to the fact that CONFIG_64BIT is only set for kernel builds.
>
> > -#ifndef CONFIG_64BIT
> > +#if __BITS_PER_LONG == 32 || defined(__KERNEL__)
>
> Actually, it's quite the opposite: "ifndef" usage made it vailable at all times
> to the userspace, and this change has actually broken building strace
> with the latest kernel headers[1][2]. There could be some debate
> whether having these F_*64 definitions exposed to the user space 64-bit
> applications, but it seems that were no harm (as they were exposed already
> for quite some time), and they are useful at least for strace for compat
> application tracing purposes.
>
> [1] https://github.com/strace/strace/runs/6779763146?check_suite_focus=true#step:4:3222
> [2] https://pipelines.actions.githubusercontent.com/serviceHosts/e5309ebd-8a2f-43f4-a212-b52080275b5d/_apis/pipelines/1/runs/1473/signedlogcontent/12?urlExpires=2022-06-08T09%3A37%3A13.9248496Z&urlSigningMethod=HMACV1&urlSignature=fIT7vd0O4NNRwzwKWLXY4UVZBIIF3XiVI9skAsGvV0I%3D
>
Yes, there is no CONFIG_64BIT in userspace, we shouldn't limit it with
(__BITS_PER_LONG == 32 || defined(__KERNEL__)) to break the
compatibility. Just export F_*64 definitions permanently.
--
Best Regards
Guo Ren
ML: https://lore.kernel.org/linux-csky/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-13 1:16 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 7:12 [PATCH V12 00/20] riscv: Add COMPAT mode support for 64BIT guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` [PATCH V12 01/20] uapi: simplify __ARCH_FLOCK{,64}_PAD a little guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-07-15 3:13 ` Florian Fainelli
2022-07-15 3:13 ` Florian Fainelli
2022-07-15 3:13 ` Florian Fainelli
2022-07-15 3:13 ` Florian Fainelli
2022-04-05 7:12 ` [PATCH V12 02/20] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-06-08 9:41 ` Eugene Syromiatnikov
2022-06-08 9:41 ` Eugene Syromiatnikov
2022-06-08 9:41 ` Eugene Syromiatnikov
2022-06-08 9:41 ` Eugene Syromiatnikov
2022-06-13 1:15 ` Guo Ren [this message]
2022-06-13 1:15 ` Guo Ren
2022-06-13 1:15 ` Guo Ren
2022-06-13 1:15 ` Guo Ren
2022-04-05 7:12 ` [PATCH V12 03/20] compat: consolidate the compat_flock{, 64} definition guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` [PATCH V12 03/20] compat: consolidate the compat_flock{,64} definition guoren
2022-04-05 7:12 ` [PATCH V12 04/20] arch: Add SYSVIPC_COMPAT for all architectures guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` [PATCH V12 05/20] fs: stat: compat: Add __ARCH_WANT_COMPAT_STAT guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:13 ` [PATCH V12 06/20] asm-generic: compat: Cleanup duplicate definitions guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 07/20] syscalls: compat: Fix the missing part for __SYSCALL_COMPAT guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 08/20] riscv: Fixup difference with defconfig guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 09/20] riscv: compat: Add basic compat data type implementation guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 10/20] riscv: compat: Support TASK_SIZE for compat mode guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 11/20] riscv: compat: syscall: Add compat_sys_call_table implementation guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 12/20] riscv: compat: syscall: Add entry.S implementation guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 13/20] riscv: compat: process: Add UXL_32 support in start_thread guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 14/20] riscv: compat: Add elf.h implementation guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 15/20] riscv: compat: Add hw capability check for elf guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 16/20] riscv: compat: vdso: Add COMPAT_VDSO base code implementation guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 17/20] riscv: compat: vdso: Add setup additional pages implementation guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 18/20] riscv: compat: signal: Add rt_frame implementation guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 19/20] riscv: compat: ptrace: Add compat_arch_ptrace implement guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 20/20] riscv: compat: Add COMPAT Kbuild skeletal support guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-28 12:25 ` [PATCH V12 00/20] riscv: Add COMPAT mode support for 64BIT Guo Ren
2022-04-28 12:25 ` Guo Ren
2022-04-28 12:25 ` Guo Ren
2022-04-28 12:25 ` Guo Ren
2022-04-28 18:22 ` Palmer Dabbelt
2022-04-28 18:22 ` Palmer Dabbelt
2022-04-28 18:22 ` Palmer Dabbelt
2022-04-28 18:22 ` Palmer Dabbelt
2022-04-30 5:43 ` Guo Ren
2022-04-30 5:43 ` Guo Ren
2022-04-30 5:43 ` Guo Ren
2022-04-30 5:43 ` Guo Ren
2022-05-19 17:50 ` Palmer Dabbelt
2022-05-19 17:50 ` Palmer Dabbelt
2022-05-19 17:50 ` Palmer Dabbelt
2022-05-19 17:50 ` Palmer Dabbelt
2022-05-20 18:18 ` Guo Ren
2022-05-20 18:18 ` Guo Ren
2022-05-20 18:18 ` Guo Ren
2022-05-20 18:18 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJF2gTQhFbN3mK0jco=NAKZr4qCgvX4zkw3h6jdffr66Rz7REQ@mail.gmail.com' \
--to=guoren@kernel.org \
--cc=arnd@arndb.de \
--cc=esyr@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=heiko@sntech.de \
--cc=ldv@strace.io \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naresh.kamboju@linaro.org \
--cc=nathan@kernel.org \
--cc=palmer@dabbelt.com \
--cc=sparclinux@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.