From: Florian Fainelli <f.fainelli@gmail.com>
To: guoren@kernel.org, palmer@dabbelt.com, arnd@arndb.de,
gregkh@linuxfoundation.org, hch@lst.de, nathan@kernel.org,
naresh.kamboju@linaro.org
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-parisc@vger.kernel.org, linux-mips@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, x86@kernel.org,
heiko@sntech.de
Subject: Re: [PATCH V12 01/20] uapi: simplify __ARCH_FLOCK{,64}_PAD a little
Date: Thu, 14 Jul 2022 20:13:12 -0700 [thread overview]
Message-ID: <d95d1afe-655c-3526-0c7e-949dfad8c6ba@gmail.com> (raw)
In-Reply-To: <20220405071314.3225832-2-guoren@kernel.org>
On 4/5/2022 12:12 AM, guoren@kernel.org wrote:
> From: Christoph Hellwig <hch@lst.de>
>
> Don't bother to define the symbols empty, just don't use them.
> That makes the intent a little more clear.
>
> Remove the unused HAVE_ARCH_STRUCT_FLOCK64 define and merge the
> 32-bit mips struct flock into the generic one.
>
> Add a new __ARCH_FLOCK_EXTRA_SYSID macro following the style of
> __ARCH_FLOCK_PAD to avoid having a separate definition just for
> one architecture.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Guo Ren <guoren@kernel.org>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
Being late to this, but this breaks the perf build for me using a MIPS
toolchain with the following:
CC
/home/fainelli/work/buildroot/output/bmips/build/linux-custom/tools/perf/trace/beauty/fcntl.o
In file included from
../../../../host/mipsel-buildroot-linux-gnu/sysroot/usr/include/asm/fcntl.h:77,
from ../include/uapi/linux/fcntl.h:5,
from trace/beauty/fcntl.c:10:
../include/uapi/asm-generic/fcntl.h:188:8: error: redefinition of
'struct flock'
struct flock {
^~~~~
In file included from ../include/uapi/linux/fcntl.h:5,
from trace/beauty/fcntl.c:10:
../../../../host/mipsel-buildroot-linux-gnu/sysroot/usr/include/asm/fcntl.h:63:8:
note: originally defined here
struct flock {
^~~~~
make[6]: ***
[/home/fainelli/work/buildroot/output/bmips/build/linux-custom/tools/build/Makefile.build:97:
/home/fainelli/work/buildroot/output/bmips/build/linux-custom/tools/perf/trace/beauty/fcntl.o]
Error 1
the kernel headers are set to 4.1.31 which is arguably old but
toolchains using newer kernel headers do not fare much better either
unfortunately as I tried a toolchain with kernel headers 4.9.x.
I will start doing more regular MIPS builds of the perf tools since that
seems to escape our testing.
Thanks!
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: guoren@kernel.org, palmer@dabbelt.com, arnd@arndb.de,
gregkh@linuxfoundation.org, hch@lst.de, nathan@kernel.org,
naresh.kamboju@linaro.org
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-parisc@vger.kernel.org, linux-mips@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, x86@kernel.org,
heiko@sntech.de
Subject: Re: [PATCH V12 01/20] uapi: simplify __ARCH_FLOCK{,64}_PAD a little
Date: Thu, 14 Jul 2022 20:13:12 -0700 [thread overview]
Message-ID: <d95d1afe-655c-3526-0c7e-949dfad8c6ba@gmail.com> (raw)
In-Reply-To: <20220405071314.3225832-2-guoren@kernel.org>
On 4/5/2022 12:12 AM, guoren@kernel.org wrote:
> From: Christoph Hellwig <hch@lst.de>
>
> Don't bother to define the symbols empty, just don't use them.
> That makes the intent a little more clear.
>
> Remove the unused HAVE_ARCH_STRUCT_FLOCK64 define and merge the
> 32-bit mips struct flock into the generic one.
>
> Add a new __ARCH_FLOCK_EXTRA_SYSID macro following the style of
> __ARCH_FLOCK_PAD to avoid having a separate definition just for
> one architecture.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Guo Ren <guoren@kernel.org>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
Being late to this, but this breaks the perf build for me using a MIPS
toolchain with the following:
CC
/home/fainelli/work/buildroot/output/bmips/build/linux-custom/tools/perf/trace/beauty/fcntl.o
In file included from
../../../../host/mipsel-buildroot-linux-gnu/sysroot/usr/include/asm/fcntl.h:77,
from ../include/uapi/linux/fcntl.h:5,
from trace/beauty/fcntl.c:10:
../include/uapi/asm-generic/fcntl.h:188:8: error: redefinition of
'struct flock'
struct flock {
^~~~~
In file included from ../include/uapi/linux/fcntl.h:5,
from trace/beauty/fcntl.c:10:
../../../../host/mipsel-buildroot-linux-gnu/sysroot/usr/include/asm/fcntl.h:63:8:
note: originally defined here
struct flock {
^~~~~
make[6]: ***
[/home/fainelli/work/buildroot/output/bmips/build/linux-custom/tools/build/Makefile.build:97:
/home/fainelli/work/buildroot/output/bmips/build/linux-custom/tools/perf/trace/beauty/fcntl.o]
Error 1
the kernel headers are set to 4.1.31 which is arguably old but
toolchains using newer kernel headers do not fare much better either
unfortunately as I tried a toolchain with kernel headers 4.9.x.
I will start doing more regular MIPS builds of the perf tools since that
seems to escape our testing.
Thanks!
--
Florian
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: guoren@kernel.org, palmer@dabbelt.com, arnd@arndb.de,
gregkh@linuxfoundation.org, hch@lst.de, nathan@kernel.org,
naresh.kamboju@linaro.org
Cc: linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
heiko@sntech.de, linux-parisc@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V12 01/20] uapi: simplify __ARCH_FLOCK{,64}_PAD a little
Date: Thu, 14 Jul 2022 20:13:12 -0700 [thread overview]
Message-ID: <d95d1afe-655c-3526-0c7e-949dfad8c6ba@gmail.com> (raw)
In-Reply-To: <20220405071314.3225832-2-guoren@kernel.org>
On 4/5/2022 12:12 AM, guoren@kernel.org wrote:
> From: Christoph Hellwig <hch@lst.de>
>
> Don't bother to define the symbols empty, just don't use them.
> That makes the intent a little more clear.
>
> Remove the unused HAVE_ARCH_STRUCT_FLOCK64 define and merge the
> 32-bit mips struct flock into the generic one.
>
> Add a new __ARCH_FLOCK_EXTRA_SYSID macro following the style of
> __ARCH_FLOCK_PAD to avoid having a separate definition just for
> one architecture.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Guo Ren <guoren@kernel.org>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
Being late to this, but this breaks the perf build for me using a MIPS
toolchain with the following:
CC
/home/fainelli/work/buildroot/output/bmips/build/linux-custom/tools/perf/trace/beauty/fcntl.o
In file included from
../../../../host/mipsel-buildroot-linux-gnu/sysroot/usr/include/asm/fcntl.h:77,
from ../include/uapi/linux/fcntl.h:5,
from trace/beauty/fcntl.c:10:
../include/uapi/asm-generic/fcntl.h:188:8: error: redefinition of
'struct flock'
struct flock {
^~~~~
In file included from ../include/uapi/linux/fcntl.h:5,
from trace/beauty/fcntl.c:10:
../../../../host/mipsel-buildroot-linux-gnu/sysroot/usr/include/asm/fcntl.h:63:8:
note: originally defined here
struct flock {
^~~~~
make[6]: ***
[/home/fainelli/work/buildroot/output/bmips/build/linux-custom/tools/build/Makefile.build:97:
/home/fainelli/work/buildroot/output/bmips/build/linux-custom/tools/perf/trace/beauty/fcntl.o]
Error 1
the kernel headers are set to 4.1.31 which is arguably old but
toolchains using newer kernel headers do not fare much better either
unfortunately as I tried a toolchain with kernel headers 4.9.x.
I will start doing more regular MIPS builds of the perf tools since that
seems to escape our testing.
Thanks!
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: guoren@kernel.org, palmer@dabbelt.com, arnd@arndb.de,
gregkh@linuxfoundation.org, hch@lst.de, nathan@kernel.org,
naresh.kamboju@linaro.org
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-parisc@vger.kernel.org, linux-mips@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, x86@kernel.org,
heiko@sntech.de
Subject: Re: [PATCH V12 01/20] uapi: simplify __ARCH_FLOCK{,64}_PAD a little
Date: Thu, 14 Jul 2022 20:13:12 -0700 [thread overview]
Message-ID: <d95d1afe-655c-3526-0c7e-949dfad8c6ba@gmail.com> (raw)
In-Reply-To: <20220405071314.3225832-2-guoren@kernel.org>
On 4/5/2022 12:12 AM, guoren@kernel.org wrote:
> From: Christoph Hellwig <hch@lst.de>
>
> Don't bother to define the symbols empty, just don't use them.
> That makes the intent a little more clear.
>
> Remove the unused HAVE_ARCH_STRUCT_FLOCK64 define and merge the
> 32-bit mips struct flock into the generic one.
>
> Add a new __ARCH_FLOCK_EXTRA_SYSID macro following the style of
> __ARCH_FLOCK_PAD to avoid having a separate definition just for
> one architecture.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Guo Ren <guoren@kernel.org>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
Being late to this, but this breaks the perf build for me using a MIPS
toolchain with the following:
CC
/home/fainelli/work/buildroot/output/bmips/build/linux-custom/tools/perf/trace/beauty/fcntl.o
In file included from
../../../../host/mipsel-buildroot-linux-gnu/sysroot/usr/include/asm/fcntl.h:77,
from ../include/uapi/linux/fcntl.h:5,
from trace/beauty/fcntl.c:10:
../include/uapi/asm-generic/fcntl.h:188:8: error: redefinition of
'struct flock'
struct flock {
^~~~~
In file included from ../include/uapi/linux/fcntl.h:5,
from trace/beauty/fcntl.c:10:
../../../../host/mipsel-buildroot-linux-gnu/sysroot/usr/include/asm/fcntl.h:63:8:
note: originally defined here
struct flock {
^~~~~
make[6]: ***
[/home/fainelli/work/buildroot/output/bmips/build/linux-custom/tools/build/Makefile.build:97:
/home/fainelli/work/buildroot/output/bmips/build/linux-custom/tools/perf/trace/beauty/fcntl.o]
Error 1
the kernel headers are set to 4.1.31 which is arguably old but
toolchains using newer kernel headers do not fare much better either
unfortunately as I tried a toolchain with kernel headers 4.9.x.
I will start doing more regular MIPS builds of the perf tools since that
seems to escape our testing.
Thanks!
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-15 3:13 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 7:12 [PATCH V12 00/20] riscv: Add COMPAT mode support for 64BIT guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` [PATCH V12 01/20] uapi: simplify __ARCH_FLOCK{,64}_PAD a little guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-07-15 3:13 ` Florian Fainelli [this message]
2022-07-15 3:13 ` Florian Fainelli
2022-07-15 3:13 ` Florian Fainelli
2022-07-15 3:13 ` Florian Fainelli
2022-04-05 7:12 ` [PATCH V12 02/20] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-06-08 9:41 ` Eugene Syromiatnikov
2022-06-08 9:41 ` Eugene Syromiatnikov
2022-06-08 9:41 ` Eugene Syromiatnikov
2022-06-08 9:41 ` Eugene Syromiatnikov
2022-06-13 1:15 ` Guo Ren
2022-06-13 1:15 ` Guo Ren
2022-06-13 1:15 ` Guo Ren
2022-06-13 1:15 ` Guo Ren
2022-04-05 7:12 ` [PATCH V12 03/20] compat: consolidate the compat_flock{, 64} definition guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` [PATCH V12 03/20] compat: consolidate the compat_flock{,64} definition guoren
2022-04-05 7:12 ` [PATCH V12 04/20] arch: Add SYSVIPC_COMPAT for all architectures guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` [PATCH V12 05/20] fs: stat: compat: Add __ARCH_WANT_COMPAT_STAT guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:12 ` guoren
2022-04-05 7:13 ` [PATCH V12 06/20] asm-generic: compat: Cleanup duplicate definitions guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 07/20] syscalls: compat: Fix the missing part for __SYSCALL_COMPAT guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 08/20] riscv: Fixup difference with defconfig guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 09/20] riscv: compat: Add basic compat data type implementation guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 10/20] riscv: compat: Support TASK_SIZE for compat mode guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 11/20] riscv: compat: syscall: Add compat_sys_call_table implementation guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 12/20] riscv: compat: syscall: Add entry.S implementation guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 13/20] riscv: compat: process: Add UXL_32 support in start_thread guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 14/20] riscv: compat: Add elf.h implementation guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 15/20] riscv: compat: Add hw capability check for elf guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 16/20] riscv: compat: vdso: Add COMPAT_VDSO base code implementation guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 17/20] riscv: compat: vdso: Add setup additional pages implementation guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 18/20] riscv: compat: signal: Add rt_frame implementation guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 19/20] riscv: compat: ptrace: Add compat_arch_ptrace implement guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` [PATCH V12 20/20] riscv: compat: Add COMPAT Kbuild skeletal support guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-05 7:13 ` guoren
2022-04-28 12:25 ` [PATCH V12 00/20] riscv: Add COMPAT mode support for 64BIT Guo Ren
2022-04-28 12:25 ` Guo Ren
2022-04-28 12:25 ` Guo Ren
2022-04-28 12:25 ` Guo Ren
2022-04-28 18:22 ` Palmer Dabbelt
2022-04-28 18:22 ` Palmer Dabbelt
2022-04-28 18:22 ` Palmer Dabbelt
2022-04-28 18:22 ` Palmer Dabbelt
2022-04-30 5:43 ` Guo Ren
2022-04-30 5:43 ` Guo Ren
2022-04-30 5:43 ` Guo Ren
2022-04-30 5:43 ` Guo Ren
2022-05-19 17:50 ` Palmer Dabbelt
2022-05-19 17:50 ` Palmer Dabbelt
2022-05-19 17:50 ` Palmer Dabbelt
2022-05-19 17:50 ` Palmer Dabbelt
2022-05-20 18:18 ` Guo Ren
2022-05-20 18:18 ` Guo Ren
2022-05-20 18:18 ` Guo Ren
2022-05-20 18:18 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d95d1afe-655c-3526-0c7e-949dfad8c6ba@gmail.com \
--to=f.fainelli@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=guoren@kernel.org \
--cc=hch@lst.de \
--cc=heiko@sntech.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naresh.kamboju@linaro.org \
--cc=nathan@kernel.org \
--cc=palmer@dabbelt.com \
--cc=sparclinux@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.