From: Guo Ren <guoren@kernel.org> To: "Jernej Škrabec" <jernej.skrabec@gmail.com> Cc: "Arnd Bergmann" <arnd@arndb.de>, "Anup Patel" <anup.patel@wdc.com>, "Palmer Dabbelt" <palmerdabbelt@google.com>, "Chen-Yu Tsai" <wens@csie.org>, "Maxime Ripard" <maxime@cerno.tech>, "Drew Fustini" <drew@beagleboard.org>, liush@allwinnertech.com, "Wei Wu (吴伟)" <lazyparser@gmail.com>, wefu@redhat.com, linux-riscv <linux-riscv@lists.infradead.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, linux-arch <linux-arch@vger.kernel.org>, linux-sunxi@lists.linux.dev, "Maxime Ripard" <mripard@kernel.org>, "Corentin Labbe" <clabbe@baylibre.com>, "Samuel Holland" <samuel@sholland.org>, "Icenowy Zheng" <icenowy@aosc.io>, "LABBE Corentin" <clabbe.montjoie@gmail.com>, "Michael Walle" <michael@walle.cc>, "Guo Ren" <guoren@linux.alibaba.com> Subject: Re: [RFC PATCH v2 11/11] riscv: soc: Allwinner D1 GMAC driver only for temp use Date: Mon, 7 Jun 2021 00:53:17 +0800 [thread overview] Message-ID: <CAJF2gTTChtcDaznZSRvU6TvknkCH=St8Fv9Eux1tJDy+s1AagQ@mail.gmail.com> (raw) In-Reply-To: <811499816.OAcyhOWOk8@jernej-laptop> On Mon, Jun 7, 2021 at 12:32 AM Jernej Škrabec <jernej.skrabec@gmail.com> wrote: > > Dne nedelja, 06. junij 2021 ob 18:16:44 CEST je Arnd Bergmann napisal(a): > > On Sun, Jun 6, 2021 at 11:04 AM <guoren@kernel.org> wrote: > > > diff --git a/arch/riscv/boot/dts/allwinner/allwinner-d1-nezha-kit.dts > > > b/arch/riscv/boot/dts/allwinner/allwinner-d1-nezha-kit.dts index > > > cd9f7c9..31b681d 100644 > > > --- a/arch/riscv/boot/dts/allwinner/allwinner-d1-nezha-kit.dts > > > +++ b/arch/riscv/boot/dts/allwinner/allwinner-d1-nezha-kit.dts > > > @@ -11,7 +11,7 @@ > > > > > > compatible = "allwinner,d1-nezha-kit"; > > > > > > chosen { > > > > > > - bootargs = "console=ttyS0,115200"; > > > + bootargs = "console=ttyS0,115200 rootwait init=/sbin/init > > > root=/dev/nfs rw nfsroot=192.168.101.200:/tmp/rootfs_nfs,v3,tcp,nolock > > > ip=192.168.101.23"; > > These are not board specific options, they should be set by the bootloader > > according to the network environment. It clearly doens't belong > > into this patch . > > > > > stdout-path = &serial0; > > > > > > }; > > > > > > diff --git a/arch/riscv/boot/dts/allwinner/allwinner-d1.dtsi > > > b/arch/riscv/boot/dts/allwinner/allwinner-d1.dtsi index 11cd938..d317e19 > > > 100644 > > > --- a/arch/riscv/boot/dts/allwinner/allwinner-d1.dtsi > > > +++ b/arch/riscv/boot/dts/allwinner/allwinner-d1.dtsi > > > @@ -80,5 +80,21 @@ > > > > > > clocks = <&dummy_apb>; > > > status = "disabled"; > > > > > > }; > > > > > > + > > > + eth@4500000 { > > > + compatible = "allwinner,sunxi-gmac"; > > > + reg = <0x00 0x4500000 0x00 0x10000 0x00 0x3000030 > > > 0x00 0x04>; + interrupts-extended = <&plic 0x3e > > > 0x04>; > > > + interrupt-names = "gmacirq"; > > > + device_type = "gmac0"; > > > + phy-mode = "rgmii"; > > > + use_ephy25m = <0x01>; > > > + tx-delay = <0x03>; > > > + rx-delay = <0x03>; > > > + gmac-power0; > > > + gmac-power1; > > > + gmac-power2; > > > + status = "okay"; > > > + }; > > > > Before you add this in the dts file, the properties need to be documented in > > the binding file. The "allwinner,sunxi-gmac" identifier does not appear to > > be specific enough here, and the properties don't match what dwmac uses, > > which would make it unnecessarily hard to change to the other driver later > > on without breaking compatibility to old dtb files. > > > > > +++ b/drivers/net/ethernet/allwinnertmp/sunxi-gmac-ops.c > > > @@ -0,0 +1,690 @@ > > > +/* > > > + * linux/drivers/net/ethernet/allwinner/sunxi_gmac_ops.c > > > + * > > > + * Copyright © 2016-2018, fuzhaoke > > > + * Author: fuzhaoke <fuzhaoke@allwinnertech.com> > > > + * > > > + * This file is provided under a dual BSD/GPL license. When using or > > > + * redistributing this file, you may do so under either license. > > > > Are you sure this is the correct copyright information and "fuzhaoke" is > > the copyright holder for this file? If this is derived from either the > > designware > > code or the Linux stmmac driver, the authors should be mentioned, > > and the license be compatible with the original license terms. > > > > Andre already commented on the driver quality and code duplication, those > > are also show-stoppers, but the unclear license terms and dt binding > > compatibility are even stronger reasons to not get anywhere close to this > > driver. > > I got impression that this patch is not meant to be merged and it's forward > ported from vendor kernel as a stop gap measure for developers until proper > mainline ethernet driver is developed. Yes > > Best regards, > Jernej > > > > -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/
WARNING: multiple messages have this Message-ID (diff)
From: Guo Ren <guoren@kernel.org> To: "Jernej Škrabec" <jernej.skrabec@gmail.com> Cc: "Arnd Bergmann" <arnd@arndb.de>, "Anup Patel" <anup.patel@wdc.com>, "Palmer Dabbelt" <palmerdabbelt@google.com>, "Chen-Yu Tsai" <wens@csie.org>, "Maxime Ripard" <maxime@cerno.tech>, "Drew Fustini" <drew@beagleboard.org>, liush@allwinnertech.com, "Wei Wu (吴伟)" <lazyparser@gmail.com>, wefu@redhat.com, linux-riscv <linux-riscv@lists.infradead.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, linux-arch <linux-arch@vger.kernel.org>, linux-sunxi@lists.linux.dev, "Maxime Ripard" <mripard@kernel.org>, "Corentin Labbe" <clabbe@baylibre.com>, "Samuel Holland" <samuel@sholland.org>, "Icenowy Zheng" <icenowy@aosc.io>, "LABBE Corentin" <clabbe.montjoie@gmail.com>, "Michael Walle" <michael@walle.cc>, "Guo Ren" <guoren@linux.alibaba.com> Subject: Re: [RFC PATCH v2 11/11] riscv: soc: Allwinner D1 GMAC driver only for temp use Date: Mon, 7 Jun 2021 00:53:17 +0800 [thread overview] Message-ID: <CAJF2gTTChtcDaznZSRvU6TvknkCH=St8Fv9Eux1tJDy+s1AagQ@mail.gmail.com> (raw) In-Reply-To: <811499816.OAcyhOWOk8@jernej-laptop> On Mon, Jun 7, 2021 at 12:32 AM Jernej Škrabec <jernej.skrabec@gmail.com> wrote: > > Dne nedelja, 06. junij 2021 ob 18:16:44 CEST je Arnd Bergmann napisal(a): > > On Sun, Jun 6, 2021 at 11:04 AM <guoren@kernel.org> wrote: > > > diff --git a/arch/riscv/boot/dts/allwinner/allwinner-d1-nezha-kit.dts > > > b/arch/riscv/boot/dts/allwinner/allwinner-d1-nezha-kit.dts index > > > cd9f7c9..31b681d 100644 > > > --- a/arch/riscv/boot/dts/allwinner/allwinner-d1-nezha-kit.dts > > > +++ b/arch/riscv/boot/dts/allwinner/allwinner-d1-nezha-kit.dts > > > @@ -11,7 +11,7 @@ > > > > > > compatible = "allwinner,d1-nezha-kit"; > > > > > > chosen { > > > > > > - bootargs = "console=ttyS0,115200"; > > > + bootargs = "console=ttyS0,115200 rootwait init=/sbin/init > > > root=/dev/nfs rw nfsroot=192.168.101.200:/tmp/rootfs_nfs,v3,tcp,nolock > > > ip=192.168.101.23"; > > These are not board specific options, they should be set by the bootloader > > according to the network environment. It clearly doens't belong > > into this patch . > > > > > stdout-path = &serial0; > > > > > > }; > > > > > > diff --git a/arch/riscv/boot/dts/allwinner/allwinner-d1.dtsi > > > b/arch/riscv/boot/dts/allwinner/allwinner-d1.dtsi index 11cd938..d317e19 > > > 100644 > > > --- a/arch/riscv/boot/dts/allwinner/allwinner-d1.dtsi > > > +++ b/arch/riscv/boot/dts/allwinner/allwinner-d1.dtsi > > > @@ -80,5 +80,21 @@ > > > > > > clocks = <&dummy_apb>; > > > status = "disabled"; > > > > > > }; > > > > > > + > > > + eth@4500000 { > > > + compatible = "allwinner,sunxi-gmac"; > > > + reg = <0x00 0x4500000 0x00 0x10000 0x00 0x3000030 > > > 0x00 0x04>; + interrupts-extended = <&plic 0x3e > > > 0x04>; > > > + interrupt-names = "gmacirq"; > > > + device_type = "gmac0"; > > > + phy-mode = "rgmii"; > > > + use_ephy25m = <0x01>; > > > + tx-delay = <0x03>; > > > + rx-delay = <0x03>; > > > + gmac-power0; > > > + gmac-power1; > > > + gmac-power2; > > > + status = "okay"; > > > + }; > > > > Before you add this in the dts file, the properties need to be documented in > > the binding file. The "allwinner,sunxi-gmac" identifier does not appear to > > be specific enough here, and the properties don't match what dwmac uses, > > which would make it unnecessarily hard to change to the other driver later > > on without breaking compatibility to old dtb files. > > > > > +++ b/drivers/net/ethernet/allwinnertmp/sunxi-gmac-ops.c > > > @@ -0,0 +1,690 @@ > > > +/* > > > + * linux/drivers/net/ethernet/allwinner/sunxi_gmac_ops.c > > > + * > > > + * Copyright © 2016-2018, fuzhaoke > > > + * Author: fuzhaoke <fuzhaoke@allwinnertech.com> > > > + * > > > + * This file is provided under a dual BSD/GPL license. When using or > > > + * redistributing this file, you may do so under either license. > > > > Are you sure this is the correct copyright information and "fuzhaoke" is > > the copyright holder for this file? If this is derived from either the > > designware > > code or the Linux stmmac driver, the authors should be mentioned, > > and the license be compatible with the original license terms. > > > > Andre already commented on the driver quality and code duplication, those > > are also show-stoppers, but the unclear license terms and dt binding > > compatibility are even stronger reasons to not get anywhere close to this > > driver. > > I got impression that this patch is not meant to be merged and it's forward > ported from vendor kernel as a stop gap measure for developers until proper > mainline ethernet driver is developed. Yes > > Best regards, > Jernej > > > > -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/ _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-06-06 16:53 UTC|newest] Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-06 9:03 [RFC PATCH v2 00/11] riscv: Add DMA_COHERENT support for Allwinner D1 guoren 2021-06-06 9:03 ` guoren 2021-06-06 9:03 ` [RFC PATCH v2 01/11] riscv: asid: Use global mappings for kernel pages guoren 2021-06-06 9:03 ` guoren 2021-06-06 9:03 ` [PATCH V5 1/3] riscv: " guoren 2021-06-06 9:03 ` guoren 2021-06-06 9:03 ` [PATCH V5 2/3] riscv: Add ASID-based tlbflushing methods guoren 2021-06-06 9:03 ` guoren 2021-06-06 14:38 ` Christoph Hellwig 2021-06-06 14:38 ` Christoph Hellwig 2021-06-06 9:03 ` [RFC PATCH v2 02/11] riscv: asid: " guoren 2021-06-06 9:03 ` guoren 2021-06-06 9:04 ` [RFC PATCH v2 03/11] riscv: asid: Optimize tlbflush coding convention guoren 2021-06-06 9:04 ` guoren 2021-06-06 9:04 ` [PATCH V5 3/3] riscv: tlbflush: Optimize " guoren 2021-06-06 9:04 ` guoren 2021-06-06 9:04 ` [RFC PATCH v2 04/11] riscv: pgtable: Fixup _PAGE_CHG_MASK usage guoren 2021-06-06 9:04 ` guoren 2021-06-06 9:04 ` [RFC PATCH v2 05/11] riscv: pgtable: Add custom protection_map init guoren 2021-06-06 9:04 ` guoren 2021-06-06 9:04 ` [RFC PATCH v2 06/11] riscv: pgtable: Add DMA_COHERENT with custom PTE attributes guoren 2021-06-06 9:04 ` guoren 2021-06-06 14:39 ` Christoph Hellwig 2021-06-06 14:39 ` Christoph Hellwig 2021-06-06 15:08 ` Guo Ren 2021-06-06 15:08 ` Guo Ren 2021-06-06 17:22 ` Nick Kossifidis 2021-06-06 17:22 ` Nick Kossifidis 2021-06-07 6:19 ` Christoph Hellwig 2021-06-07 6:19 ` Christoph Hellwig 2021-06-06 9:04 ` [RFC PATCH v2 07/11] riscv: cmo: Add dma-noncoherency support guoren 2021-06-06 9:04 ` guoren 2021-10-17 9:28 ` twd2 2021-10-17 9:28 ` twd2 2021-10-20 8:11 ` Guo Ren 2021-10-20 8:11 ` Guo Ren 2021-06-06 9:04 ` [RFC PATCH v2 08/11] riscv: cmo: Add vendor custom icache sync guoren 2021-06-06 9:04 ` guoren 2021-06-06 9:04 ` [RFC PATCH v2 09/11] riscv: soc: Initial DTS for Allwinner D1 NeZha board guoren 2021-06-06 9:04 ` guoren 2021-06-06 16:26 ` Jernej Škrabec 2021-06-06 16:26 ` Jernej Škrabec 2021-06-06 17:05 ` Guo Ren 2021-06-06 17:05 ` Guo Ren 2021-06-07 3:44 ` Guo Ren 2021-06-07 3:44 ` Guo Ren 2021-06-07 7:27 ` Maxime Ripard 2021-06-07 7:27 ` Maxime Ripard 2021-06-07 7:53 ` Guo Ren 2021-06-07 7:53 ` Guo Ren 2021-06-07 7:24 ` Maxime Ripard 2021-06-07 7:24 ` Maxime Ripard 2021-06-07 8:07 ` Guo Ren 2021-06-07 8:07 ` Guo Ren 2021-06-14 15:33 ` Maxime Ripard 2021-06-14 15:33 ` Maxime Ripard 2021-06-14 16:28 ` Guo Ren 2021-06-14 16:28 ` Guo Ren 2021-06-14 16:31 ` Jernej Škrabec 2021-06-14 16:31 ` Jernej Škrabec 2021-06-06 9:04 ` [RFC PATCH v2 10/11] riscv: soc: Add Allwinner SoC kconfig option guoren 2021-06-06 9:04 ` guoren 2021-06-07 7:19 ` Maxime Ripard 2021-06-07 7:19 ` Maxime Ripard 2021-06-07 7:27 ` Arnd Bergmann 2021-06-07 7:27 ` Arnd Bergmann 2021-06-07 7:27 ` Arnd Bergmann 2021-06-07 7:45 ` Guo Ren 2021-06-07 7:45 ` Guo Ren 2021-06-07 7:43 ` Guo Ren 2021-06-07 7:43 ` Guo Ren 2021-06-07 12:12 ` Maxime Ripard 2021-06-07 12:12 ` Maxime Ripard 2021-06-07 12:39 ` Guo Ren 2021-06-07 12:39 ` Guo Ren 2021-06-06 9:04 ` [RFC PATCH v2 11/11] riscv: soc: Allwinner D1 GMAC driver only for temp use guoren 2021-06-06 9:04 ` guoren 2021-06-06 10:50 ` Andre Przywara 2021-06-06 10:50 ` Andre Przywara 2021-06-06 15:32 ` Guo Ren 2021-06-06 15:32 ` Guo Ren 2021-06-06 15:39 ` Jernej Škrabec 2021-06-06 15:39 ` Jernej Škrabec 2021-06-06 15:41 ` Guo Ren 2021-06-06 15:41 ` Guo Ren 2021-06-06 16:16 ` Arnd Bergmann 2021-06-06 16:16 ` Arnd Bergmann 2021-06-06 16:16 ` Arnd Bergmann 2021-06-06 16:32 ` Jernej Škrabec 2021-06-06 16:32 ` Jernej Škrabec 2021-06-06 16:53 ` Guo Ren [this message] 2021-06-06 16:53 ` Guo Ren 2021-06-06 16:53 ` Guo Ren 2021-06-06 16:53 ` Guo Ren 2021-06-06 16:29 ` [RFC PATCH v2 00/11] riscv: Add DMA_COHERENT support for Allwinner D1 Jernej Škrabec 2021-06-06 16:29 ` Jernej Škrabec 2021-06-06 16:54 ` Guo Ren 2021-06-06 16:54 ` Guo Ren 2021-06-06 17:14 ` Jernej Škrabec 2021-06-06 17:14 ` Jernej Škrabec 2021-06-06 23:42 ` Guo Ren 2021-06-06 23:42 ` Guo Ren 2021-06-07 3:44 ` Anup Patel 2021-06-07 3:44 ` Anup Patel 2021-06-07 4:36 ` Guo Ren 2021-06-07 4:36 ` Guo Ren 2021-06-07 4:36 ` Guo Ren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJF2gTTChtcDaznZSRvU6TvknkCH=St8Fv9Eux1tJDy+s1AagQ@mail.gmail.com' \ --to=guoren@kernel.org \ --cc=anup.patel@wdc.com \ --cc=arnd@arndb.de \ --cc=clabbe.montjoie@gmail.com \ --cc=clabbe@baylibre.com \ --cc=drew@beagleboard.org \ --cc=guoren@linux.alibaba.com \ --cc=icenowy@aosc.io \ --cc=jernej.skrabec@gmail.com \ --cc=lazyparser@gmail.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=liush@allwinnertech.com \ --cc=maxime@cerno.tech \ --cc=michael@walle.cc \ --cc=mripard@kernel.org \ --cc=palmerdabbelt@google.com \ --cc=samuel@sholland.org \ --cc=wefu@redhat.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.