From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Christoph Hellwig <hch@lst.de>
Cc: mporter@kernel.crashing.org, alex.bou9@gmail.com,
Dominik Brodowski <linux@dominikbrodowski.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
linux-pci@vger.kernel.org,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 2/8] powerpc: simplify CONFIG_PCI_QSPAN Kconfig magic
Date: Mon, 15 Oct 2018 15:35:41 +0900 [thread overview]
Message-ID: <CAK7LNAQxZcBNadLJhfrmxJGj-XJFVaya3Z1eexZp20vRPwrN7A@mail.gmail.com> (raw)
In-Reply-To: <20181013151016.31674-3-hch@lst.de>
On Sun, Oct 14, 2018 at 12:11 AM Christoph Hellwig <hch@lst.de> wrote:
>
> The way how CONFIG_PCI_QSPAN selects the CONFIG_PCI default is highly
> unusual and gets in the way of moving CONFIG_PCI into
> drivers/pci/Kconfig. Simplify it by just having it depend on
> CONFIG_PCI.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/powerpc/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index a80669209155..6fa6f92edb7f 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -955,7 +955,6 @@ config PCI
> bool "PCI support" if PPC_PCI_CHOICE
> default y if !40x && !CPM2 && !PPC_8xx && !PPC_83xx \
> && !PPC_85xx && !PPC_86xx && !GAMECUBE_COMMON
> - default PCI_QSPAN if PPC_8xx
> select GENERIC_PCI_IOMAP
> help
> Find out whether your system includes a PCI bus. PCI is the name of
> @@ -971,7 +970,7 @@ config PCI_SYSCALL
>
> config PCI_QSPAN
> bool "QSpan PCI"
> - depends on PPC_8xx
> + depends on PPC_8xx && PCI
> select PPC_I8259
> help
> Say Y here if you have a system based on a Motorola 8xx-series
> --
> 2.19.1
>
'git grep' did not get any other hit.
masahiro@pug:~/ref/linux$ git grep PCI_QSPAN
arch/powerpc/Kconfig: default PCI_QSPAN if PPC_8xx
arch/powerpc/Kconfig:config PCI_QSPAN
With your patch, PCI_QSPAN will become
a dead config option.
How about removing it entirely?
--
Best Regards
Masahiro Yamada
WARNING: multiple messages have this Message-ID (diff)
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-arch <linux-arch@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
linux-pci@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dominik Brodowski <linux@dominikbrodowski.net>,
alex.bou9@gmail.com, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 2/8] powerpc: simplify CONFIG_PCI_QSPAN Kconfig magic
Date: Mon, 15 Oct 2018 15:35:41 +0900 [thread overview]
Message-ID: <CAK7LNAQxZcBNadLJhfrmxJGj-XJFVaya3Z1eexZp20vRPwrN7A@mail.gmail.com> (raw)
In-Reply-To: <20181013151016.31674-3-hch@lst.de>
On Sun, Oct 14, 2018 at 12:11 AM Christoph Hellwig <hch@lst.de> wrote:
>
> The way how CONFIG_PCI_QSPAN selects the CONFIG_PCI default is highly
> unusual and gets in the way of moving CONFIG_PCI into
> drivers/pci/Kconfig. Simplify it by just having it depend on
> CONFIG_PCI.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/powerpc/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index a80669209155..6fa6f92edb7f 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -955,7 +955,6 @@ config PCI
> bool "PCI support" if PPC_PCI_CHOICE
> default y if !40x && !CPM2 && !PPC_8xx && !PPC_83xx \
> && !PPC_85xx && !PPC_86xx && !GAMECUBE_COMMON
> - default PCI_QSPAN if PPC_8xx
> select GENERIC_PCI_IOMAP
> help
> Find out whether your system includes a PCI bus. PCI is the name of
> @@ -971,7 +970,7 @@ config PCI_SYSCALL
>
> config PCI_QSPAN
> bool "QSpan PCI"
> - depends on PPC_8xx
> + depends on PPC_8xx && PCI
> select PPC_I8259
> help
> Say Y here if you have a system based on a Motorola 8xx-series
> --
> 2.19.1
>
'git grep' did not get any other hit.
masahiro@pug:~/ref/linux$ git grep PCI_QSPAN
arch/powerpc/Kconfig: default PCI_QSPAN if PPC_8xx
arch/powerpc/Kconfig:config PCI_QSPAN
With your patch, PCI_QSPAN will become
a dead config option.
How about removing it entirely?
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2018-10-15 6:36 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 15:10 move bus (PCI, PCMCIA, EISA, rapdio) config to drivers/ Christoph Hellwig
2018-10-13 15:10 ` Christoph Hellwig
2018-10-13 15:10 ` [PATCH 1/8] aha152x: rename the PCMCIA define Christoph Hellwig
2018-10-13 15:10 ` Christoph Hellwig
2018-10-15 20:57 ` Bjorn Helgaas
2018-10-15 20:57 ` Bjorn Helgaas
2018-10-13 15:10 ` [PATCH 2/8] powerpc: simplify CONFIG_PCI_QSPAN Kconfig magic Christoph Hellwig
2018-10-13 15:10 ` Christoph Hellwig
2018-10-15 6:35 ` Masahiro Yamada [this message]
2018-10-15 6:35 ` Masahiro Yamada
2018-10-15 8:47 ` Christoph Hellwig
2018-10-15 8:47 ` Christoph Hellwig
2018-10-13 15:10 ` [PATCH 3/8] powerpc: PCI_MSI needs PCI Christoph Hellwig
2018-10-13 15:10 ` Christoph Hellwig
2018-10-13 15:10 ` [PATCH 4/8] pci: consolidate PCI config entry in drivers/pci Christoph Hellwig
2018-10-13 15:10 ` Christoph Hellwig
2018-10-15 6:37 ` Masahiro Yamada
2018-10-15 6:37 ` Masahiro Yamada
2018-10-15 8:57 ` Christoph Hellwig
2018-10-15 8:57 ` Christoph Hellwig
2018-10-15 9:17 ` Masahiro Yamada
2018-10-15 9:17 ` Masahiro Yamada
2018-10-15 20:58 ` Bjorn Helgaas
2018-10-15 20:58 ` Bjorn Helgaas
2018-10-13 15:10 ` [PATCH 5/8] pcmcia: allow PCMCIA support independent of the architecture Christoph Hellwig
2018-10-13 15:10 ` Christoph Hellwig
2018-10-14 5:42 ` Dominik Brodowski
2018-10-14 5:42 ` Dominik Brodowski
2018-10-14 7:40 ` Christoph Hellwig
2018-10-14 7:40 ` Christoph Hellwig
2018-10-13 15:10 ` [PATCH 6/8] rapidio: consolidate RAPIDIO config entry in drivers/rapidio Christoph Hellwig
2018-10-13 15:10 ` Christoph Hellwig
2018-10-13 15:10 ` [PATCH 7/8] eisa: consolidate EISA Kconfig entry in drivers/eisa Christoph Hellwig
2018-10-13 15:10 ` Christoph Hellwig
2018-10-15 6:37 ` Masahiro Yamada
2018-10-15 6:37 ` Masahiro Yamada
2018-10-13 15:10 ` [PATCH 8/8] kconfig: remove CONFIG_MCA leftovers Christoph Hellwig
2018-10-13 15:10 ` Christoph Hellwig
2018-10-16 5:20 ` Masahiro Yamada
2018-10-16 5:20 ` Masahiro Yamada
2018-10-17 8:17 ` Christoph Hellwig
2018-10-17 8:17 ` Christoph Hellwig
2018-10-14 6:23 ` move bus (PCI, PCMCIA, EISA, rapdio) config to drivers/ Thomas Gleixner
2018-10-14 6:23 ` Thomas Gleixner
2018-10-15 6:38 ` Masahiro Yamada
2018-10-15 6:38 ` Masahiro Yamada
2018-10-15 9:06 ` Christoph Hellwig
2018-10-15 9:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAQxZcBNadLJhfrmxJGj-XJFVaya3Z1eexZp20vRPwrN7A@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=alex.bou9@gmail.com \
--cc=hch@lst.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.