From: Masahiro Yamada <masahiroy@kernel.org> To: Lee Jones <lee.jones@linaro.org> Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Rob Herring <robh+dt@kernel.org>, DTML <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 4/4] ARM: dts: uniphier: change support card to simple-mfd from simple-bus Date: Thu, 25 Jun 2020 01:29:04 +0900 [thread overview] Message-ID: <CAK7LNAR-dm6Zbtt9MsUunn9+qqwTtRCbq4Wzb=8uKLtfaLK6TQ@mail.gmail.com> (raw) In-Reply-To: <20200623122413.GA954398@dell> On Tue, Jun 23, 2020 at 9:24 PM Lee Jones <lee.jones@linaro.org> wrote: > > On Tue, 23 Jun 2020, Masahiro Yamada wrote: > > > 'make ARCH=arm dtbs_check' emits the following warning: > > > > support-card@1,1f00000: $nodename:0: 'support-card@1,1f00000' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' > > > > Maybe, simple-mfd could be a better fit for this device. > > The two should be equivalent. Yes, I know. That's why I can change "simple-bus" to "simple-mfd" with no risk. The difference is schema-check. The node name for "simple-bus" is checked by 'make dtbs_check'. See this code: https://github.com/robherring/dt-schema/blob/v2020.05/schemas/simple-bus.yaml#L17 Even if I rename the node, it does not accept the unit name '1,1f00000' > > What do you mean by "maybe"? Does this squash the warning? "maybe" means I am not quite sure which compatible is a better fit to describe this device. As mentioned above, simple-bus and simple-mfd are interchangeable from a driver point of view. This add-on board is integrated with various peripherals such as 16550a serial, smsc9115 ether etc. The address-decode is implemented in a CPLD device. It has chip selects and local addresses, which are mapped to the parent. It can be either simple-bus or simple-mfd, I think. dt-schema checks the node name of simple-bus. Currently, there is no check for simple-mfd. So, I think this patch is an easy solution to fix the warning. Rob is in Cc. Please add comments if any. > > Isn't the issue caused by the ','? Right. The node name of simple-bus must meet the regular expression: "^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$" Even if I rename the node "support-card@1,1f00000" to "bus@1,1f00000", the warning is still displayed due to ',' "1,1f00000" means the address 0x01f00000 of chip select 1. Thanks > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > --- > > > > arch/arm/boot/dts/uniphier-support-card.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/uniphier-support-card.dtsi b/arch/arm/boot/dts/uniphier-support-card.dtsi > > index 11e46e7de7c5..eedc10cbc6e6 100644 > > --- a/arch/arm/boot/dts/uniphier-support-card.dtsi > > +++ b/arch/arm/boot/dts/uniphier-support-card.dtsi > > @@ -10,7 +10,7 @@ &system_bus { > > ranges = <1 0x00000000 0x42000000 0x02000000>; > > > > support_card: support-card@1,1f00000 { > > - compatible = "simple-bus"; > > + compatible = "simple-mfd"; > > #address-cells = <1>; > > #size-cells = <1>; > > ranges = <0x00000000 1 0x01f00000 0x00100000>; > > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog -- Best Regards Masahiro Yamada
WARNING: multiple messages have this Message-ID (diff)
From: Masahiro Yamada <masahiroy@kernel.org> To: Lee Jones <lee.jones@linaro.org> Cc: DTML <devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 4/4] ARM: dts: uniphier: change support card to simple-mfd from simple-bus Date: Thu, 25 Jun 2020 01:29:04 +0900 [thread overview] Message-ID: <CAK7LNAR-dm6Zbtt9MsUunn9+qqwTtRCbq4Wzb=8uKLtfaLK6TQ@mail.gmail.com> (raw) In-Reply-To: <20200623122413.GA954398@dell> On Tue, Jun 23, 2020 at 9:24 PM Lee Jones <lee.jones@linaro.org> wrote: > > On Tue, 23 Jun 2020, Masahiro Yamada wrote: > > > 'make ARCH=arm dtbs_check' emits the following warning: > > > > support-card@1,1f00000: $nodename:0: 'support-card@1,1f00000' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' > > > > Maybe, simple-mfd could be a better fit for this device. > > The two should be equivalent. Yes, I know. That's why I can change "simple-bus" to "simple-mfd" with no risk. The difference is schema-check. The node name for "simple-bus" is checked by 'make dtbs_check'. See this code: https://github.com/robherring/dt-schema/blob/v2020.05/schemas/simple-bus.yaml#L17 Even if I rename the node, it does not accept the unit name '1,1f00000' > > What do you mean by "maybe"? Does this squash the warning? "maybe" means I am not quite sure which compatible is a better fit to describe this device. As mentioned above, simple-bus and simple-mfd are interchangeable from a driver point of view. This add-on board is integrated with various peripherals such as 16550a serial, smsc9115 ether etc. The address-decode is implemented in a CPLD device. It has chip selects and local addresses, which are mapped to the parent. It can be either simple-bus or simple-mfd, I think. dt-schema checks the node name of simple-bus. Currently, there is no check for simple-mfd. So, I think this patch is an easy solution to fix the warning. Rob is in Cc. Please add comments if any. > > Isn't the issue caused by the ','? Right. The node name of simple-bus must meet the regular expression: "^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$" Even if I rename the node "support-card@1,1f00000" to "bus@1,1f00000", the warning is still displayed due to ',' "1,1f00000" means the address 0x01f00000 of chip select 1. Thanks > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > --- > > > > arch/arm/boot/dts/uniphier-support-card.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/uniphier-support-card.dtsi b/arch/arm/boot/dts/uniphier-support-card.dtsi > > index 11e46e7de7c5..eedc10cbc6e6 100644 > > --- a/arch/arm/boot/dts/uniphier-support-card.dtsi > > +++ b/arch/arm/boot/dts/uniphier-support-card.dtsi > > @@ -10,7 +10,7 @@ &system_bus { > > ranges = <1 0x00000000 0x42000000 0x02000000>; > > > > support_card: support-card@1,1f00000 { > > - compatible = "simple-bus"; > > + compatible = "simple-mfd"; > > #address-cells = <1>; > > #size-cells = <1>; > > ranges = <0x00000000 1 0x01f00000 0x00100000>; > > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog -- Best Regards Masahiro Yamada _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-24 16:30 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-23 11:46 [PATCH 1/4] ARM: dts: uniphier: add interrupts to support card serial Masahiro Yamada 2020-06-23 11:46 ` [PATCH 2/4] arm64: " Masahiro Yamada 2020-06-23 11:46 ` [PATCH 3/4] ARM: dts: uniphier: rename support card serial node to fix schema warning Masahiro Yamada 2020-06-23 11:46 ` [PATCH 4/4] ARM: dts: uniphier: change support card to simple-mfd from simple-bus Masahiro Yamada 2020-06-23 12:24 ` Lee Jones 2020-06-24 16:29 ` Masahiro Yamada [this message] 2020-06-24 16:29 ` Masahiro Yamada 2020-06-24 18:16 ` Lee Jones 2020-06-24 18:16 ` Lee Jones 2020-06-25 14:37 ` Masahiro Yamada 2020-06-25 14:37 ` Masahiro Yamada 2020-06-25 14:57 ` Lee Jones 2020-06-25 14:57 ` Lee Jones 2020-06-29 1:58 ` Masahiro Yamada 2020-06-29 1:58 ` Masahiro Yamada 2020-06-29 7:36 ` Lee Jones 2020-06-29 7:36 ` Lee Jones 2020-06-29 7:43 ` Lee Jones 2020-06-29 7:43 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAK7LNAR-dm6Zbtt9MsUunn9+qqwTtRCbq4Wzb=8uKLtfaLK6TQ@mail.gmail.com' \ --to=masahiroy@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.