From: Arnd Bergmann <arnd@arndb.de>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: linux-arch <linux-arch@vger.kernel.org>,
Shuah Khan <shuah@kernel.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Catalin Marinas <catalin.marinas@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Will Deacon <will.deacon@arm.com>,
Russell King <linux@armlinux.org.uk>,
Ralf Baechle <ralf@linux-mips.org>,
Mark Salyzyn <salyzyn@android.com>,
Paul Burton <paul.burton@mips.com>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Collingbourne <pcc@google.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 00/23] Unify vDSOs across more architectures
Date: Thu, 28 Feb 2019 14:54:36 +0100 [thread overview]
Message-ID: <CAK8P3a0FtUC2Akr7HdqrkMPv-FHEbX+WNik=WH70aEtC66f0uw@mail.gmail.com> (raw)
In-Reply-To: <d4ffe6da-cd47-31eb-f219-3ee064e411ca@arm.com>
On Thu, Feb 28, 2019 at 1:42 PM Vincenzo Frascino
<vincenzo.frascino@arm.com> wrote:
>
> On 28/02/2019 12:38, Arnd Bergmann wrote:
> > On Thu, Feb 28, 2019 at 1:09 PM Vincenzo Frascino
> > <vincenzo.frascino@arm.com> wrote:
> >>
> >> thank you for testing my code.
> >>
> >> On 28/02/2019 11:40, Arnd Bergmann wrote:
> >>> On Fri, Feb 22, 2019 at 1:25 PM Vincenzo Frascino
> >>> <vincenzo.frascino@arm.com> wrote:
> >>> ^
> >>>
> >>> I think this is all harmless, but we need to limit the set of header files
> >>> that can be included indirectly when compiling the vdso in arm32 mode.
> >>>
> >>
> >> I agree with you on the principle, but I am unable to replicate the warnings.
> >> Did you make any customization to the default defconfig? What is the top
> >> commit-id you have on your tree?
> >
> > I observed this on top of v5.0-rc7 earlier, and have since rebased to
> > today's linux-next, where it still happens with the regular 'make defconfig',
> > on all compiler versions I have (4.8 through 8.1).
> >
>
> Thanks, I will try to rebase my patches on linux-next and see if I can reproduce it.
I just found a related issue: when CONFIG_CPU_BIG_ENDIAN is
set, everything breaks in the compat vdso because of the included
arm64 headers in arm32 code. That should be easier to reproduce.
For the moment, I'm using this patch:
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -103,7 +103,7 @@ config ARM64
select GENERIC_STRNLEN_USER
select GENERIC_TIME_VSYSCALL
select GENERIC_GETTIMEOFDAY
- select GENERIC_COMPAT_VDSO
+ select GENERIC_COMPAT_VDSO if !CPU_BIG_ENDIAN
select HANDLE_DOMAIN_IRQ
select HARDIRQS_SW_RESEND
select HAVE_PCI
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: linux-arch <linux-arch@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Russell King <linux@armlinux.org.uk>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mark Salyzyn <salyzyn@android.com>,
Peter Collingbourne <pcc@google.com>,
Shuah Khan <shuah@kernel.org>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH v5 00/23] Unify vDSOs across more architectures
Date: Thu, 28 Feb 2019 14:54:36 +0100 [thread overview]
Message-ID: <CAK8P3a0FtUC2Akr7HdqrkMPv-FHEbX+WNik=WH70aEtC66f0uw@mail.gmail.com> (raw)
Message-ID: <20190228135436.MmNtFe5X5nwtfJYylqaMoRcZ2_MZWain2mbEsfwk6ZM@z> (raw)
In-Reply-To: <d4ffe6da-cd47-31eb-f219-3ee064e411ca@arm.com>
On Thu, Feb 28, 2019 at 1:42 PM Vincenzo Frascino
<vincenzo.frascino@arm.com> wrote:
>
> On 28/02/2019 12:38, Arnd Bergmann wrote:
> > On Thu, Feb 28, 2019 at 1:09 PM Vincenzo Frascino
> > <vincenzo.frascino@arm.com> wrote:
> >>
> >> thank you for testing my code.
> >>
> >> On 28/02/2019 11:40, Arnd Bergmann wrote:
> >>> On Fri, Feb 22, 2019 at 1:25 PM Vincenzo Frascino
> >>> <vincenzo.frascino@arm.com> wrote:
> >>> ^
> >>>
> >>> I think this is all harmless, but we need to limit the set of header files
> >>> that can be included indirectly when compiling the vdso in arm32 mode.
> >>>
> >>
> >> I agree with you on the principle, but I am unable to replicate the warnings.
> >> Did you make any customization to the default defconfig? What is the top
> >> commit-id you have on your tree?
> >
> > I observed this on top of v5.0-rc7 earlier, and have since rebased to
> > today's linux-next, where it still happens with the regular 'make defconfig',
> > on all compiler versions I have (4.8 through 8.1).
> >
>
> Thanks, I will try to rebase my patches on linux-next and see if I can reproduce it.
I just found a related issue: when CONFIG_CPU_BIG_ENDIAN is
set, everything breaks in the compat vdso because of the included
arm64 headers in arm32 code. That should be easier to reproduce.
For the moment, I'm using this patch:
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -103,7 +103,7 @@ config ARM64
select GENERIC_STRNLEN_USER
select GENERIC_TIME_VSYSCALL
select GENERIC_GETTIMEOFDAY
- select GENERIC_COMPAT_VDSO
+ select GENERIC_COMPAT_VDSO if !CPU_BIG_ENDIAN
select HANDLE_DOMAIN_IRQ
select HARDIRQS_SW_RESEND
select HAVE_PCI
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: linux-arch <linux-arch@vger.kernel.org>,
Shuah Khan <shuah@kernel.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Catalin Marinas <catalin.marinas@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Will Deacon <will.deacon@arm.com>,
Russell King <linux@armlinux.org.uk>,
Ralf Baechle <ralf@linux-mips.org>,
Mark Salyzyn <salyzyn@android.com>,
Paul Burton <paul.burton@mips.com>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Collingbourne <pcc@google.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 00/23] Unify vDSOs across more architectures
Date: Thu, 28 Feb 2019 14:54:36 +0100 [thread overview]
Message-ID: <CAK8P3a0FtUC2Akr7HdqrkMPv-FHEbX+WNik=WH70aEtC66f0uw@mail.gmail.com> (raw)
In-Reply-To: <d4ffe6da-cd47-31eb-f219-3ee064e411ca@arm.com>
On Thu, Feb 28, 2019 at 1:42 PM Vincenzo Frascino
<vincenzo.frascino@arm.com> wrote:
>
> On 28/02/2019 12:38, Arnd Bergmann wrote:
> > On Thu, Feb 28, 2019 at 1:09 PM Vincenzo Frascino
> > <vincenzo.frascino@arm.com> wrote:
> >>
> >> thank you for testing my code.
> >>
> >> On 28/02/2019 11:40, Arnd Bergmann wrote:
> >>> On Fri, Feb 22, 2019 at 1:25 PM Vincenzo Frascino
> >>> <vincenzo.frascino@arm.com> wrote:
> >>> ^
> >>>
> >>> I think this is all harmless, but we need to limit the set of header files
> >>> that can be included indirectly when compiling the vdso in arm32 mode.
> >>>
> >>
> >> I agree with you on the principle, but I am unable to replicate the warnings.
> >> Did you make any customization to the default defconfig? What is the top
> >> commit-id you have on your tree?
> >
> > I observed this on top of v5.0-rc7 earlier, and have since rebased to
> > today's linux-next, where it still happens with the regular 'make defconfig',
> > on all compiler versions I have (4.8 through 8.1).
> >
>
> Thanks, I will try to rebase my patches on linux-next and see if I can reproduce it.
I just found a related issue: when CONFIG_CPU_BIG_ENDIAN is
set, everything breaks in the compat vdso because of the included
arm64 headers in arm32 code. That should be easier to reproduce.
For the moment, I'm using this patch:
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -103,7 +103,7 @@ config ARM64
select GENERIC_STRNLEN_USER
select GENERIC_TIME_VSYSCALL
select GENERIC_GETTIMEOFDAY
- select GENERIC_COMPAT_VDSO
+ select GENERIC_COMPAT_VDSO if !CPU_BIG_ENDIAN
select HANDLE_DOMAIN_IRQ
select HARDIRQS_SW_RESEND
select HAVE_PCI
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-28 13:54 UTC|newest]
Thread overview: 178+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 12:24 [PATCH v5 00/23] Unify vDSOs across more architectures Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 01/23] kernel: Standardize vdso_datapage Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:58 ` Mark Rutland
2019-02-22 12:58 ` Mark Rutland
2019-02-22 12:58 ` Mark Rutland
2019-02-23 16:51 ` Thomas Gleixner
2019-02-23 16:51 ` Thomas Gleixner
2019-02-23 16:51 ` Thomas Gleixner
2019-02-27 14:23 ` Vincenzo Frascino
2019-02-27 14:23 ` Vincenzo Frascino
2019-02-27 14:23 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 02/23] kernel: Define gettimeofday vdso common code Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 13:34 ` Mark Rutland
2019-02-22 13:34 ` Mark Rutland
2019-02-22 13:34 ` Mark Rutland
2019-02-22 13:49 ` Arnd Bergmann
2019-02-22 13:49 ` Arnd Bergmann
2019-02-22 13:49 ` Arnd Bergmann
2019-02-22 14:36 ` Arnd Bergmann
2019-02-22 14:36 ` Arnd Bergmann
2019-02-22 14:36 ` Arnd Bergmann
2019-02-27 14:52 ` Vincenzo Frascino
2019-02-27 14:52 ` Vincenzo Frascino
2019-02-27 14:52 ` Vincenzo Frascino
2019-02-28 9:29 ` Arnd Bergmann
2019-02-28 9:29 ` Arnd Bergmann
2019-02-28 9:29 ` Arnd Bergmann
2019-02-28 11:58 ` [PATCH 1/2] vdso: use fixed-size time types Arnd Bergmann
2019-02-28 11:58 ` Arnd Bergmann
2019-02-28 11:58 ` Arnd Bergmann
2019-02-28 11:58 ` [PATCH 2/2] vdso: add clock_gettime64 Arnd Bergmann
2019-02-28 11:58 ` Arnd Bergmann
2019-02-28 11:58 ` Arnd Bergmann
2019-02-28 13:42 ` [PATCH 1/2] vdso: use fixed-size time types Thomas Gleixner
2019-02-28 13:42 ` Thomas Gleixner
2019-02-28 13:42 ` Thomas Gleixner
2019-02-28 13:45 ` Vincenzo Frascino
2019-02-28 13:45 ` Vincenzo Frascino
2019-02-28 13:45 ` Vincenzo Frascino
2019-02-23 10:34 ` [PATCH v5 02/23] kernel: Define gettimeofday vdso common code Thomas Gleixner
2019-02-23 10:34 ` Thomas Gleixner
2019-02-23 10:34 ` Thomas Gleixner
2019-02-25 14:09 ` Vincenzo Frascino
2019-02-25 14:09 ` Vincenzo Frascino
2019-02-25 14:09 ` Vincenzo Frascino
2019-02-23 17:31 ` Thomas Gleixner
2019-02-23 17:31 ` Thomas Gleixner
2019-02-23 17:31 ` Thomas Gleixner
2019-02-27 13:47 ` Vincenzo Frascino
2019-02-27 13:47 ` Vincenzo Frascino
2019-02-27 13:47 ` Vincenzo Frascino
2019-02-27 15:49 ` Thomas Gleixner
2019-02-27 15:49 ` Thomas Gleixner
2019-02-27 15:49 ` Thomas Gleixner
2019-02-27 16:06 ` Vincenzo Frascino
2019-02-27 16:06 ` Vincenzo Frascino
2019-02-27 16:06 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 03/23] arm64: Build vDSO with -ffixed-x18 Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 04/23] arm64: Substitute gettimeofday with C implementation Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 13:42 ` Mark Rutland
2019-02-22 13:42 ` Mark Rutland
2019-02-22 13:42 ` Mark Rutland
2019-02-22 12:24 ` [PATCH v5 05/23] arm64: compat: Alloc separate pages for vectors and sigpage Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 06/23] arm64: compat: Split kuser32 Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 07/23] arm64: compat: Refactor aarch32_alloc_vdso_pages() Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 08/23] arm64: compat: Add KUSER_HELPERS config option Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 14:04 ` Mark Rutland
2019-02-22 14:04 ` Mark Rutland
2019-02-22 14:04 ` Mark Rutland
2019-02-22 14:09 ` Russell King - ARM Linux admin
2019-02-22 14:09 ` Russell King - ARM Linux admin
2019-02-22 14:09 ` Russell King - ARM Linux admin
2019-02-26 12:10 ` Vincenzo Frascino
2019-02-26 12:10 ` Vincenzo Frascino
2019-02-26 12:10 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 09/23] arm64: compat: Add missing syscall numbers Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 10/23] arm64: compat: Expose signal related structures Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 11/23] arm64: compat: Generate asm offsets for signals Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 14:22 ` Mark Rutland
2019-02-22 14:22 ` Mark Rutland
2019-02-22 14:22 ` Mark Rutland
2019-02-22 12:24 ` [PATCH v5 12/23] lib: vdso: Add compat support Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 13/23] arm64: compat: Add vDSO Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 14:32 ` Mark Rutland
2019-02-22 14:32 ` Mark Rutland
2019-02-22 14:32 ` Mark Rutland
2019-02-22 12:24 ` [PATCH v5 14/23] arm64: Refactor vDSO code Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 14:37 ` Mark Rutland
2019-02-22 14:37 ` Mark Rutland
2019-02-22 14:37 ` Mark Rutland
2019-02-22 12:24 ` [PATCH v5 15/23] arm64: compat: vDSO setup for compat layer Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 16/23] arm64: elf: vDSO code page discovery Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 17/23] arm64: compat: Get sigreturn trampolines from vDSO Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 18/23] arm64: Add vDSO compat support Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 19/23] arm64: Enable compat vDSO support Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 14:39 ` Mark Rutland
2019-02-22 14:39 ` Mark Rutland
2019-02-22 14:39 ` Mark Rutland
2019-02-22 14:41 ` Mark Rutland
2019-02-22 14:41 ` Mark Rutland
2019-02-22 14:41 ` Mark Rutland
2019-02-22 12:24 ` [PATCH v5 20/23] arm: Add support for generic vDSO Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 21/23] mips: " Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 22/23] x86: " Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-23 10:45 ` Thomas Gleixner
2019-02-23 10:45 ` Thomas Gleixner
2019-02-23 10:45 ` Thomas Gleixner
2019-02-27 16:18 ` Vincenzo Frascino
2019-02-27 16:18 ` Vincenzo Frascino
2019-02-27 16:18 ` Vincenzo Frascino
2019-02-22 12:24 ` [PATCH v5 23/23] kselftest: Extend vDSO selftest Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-22 12:24 ` Vincenzo Frascino
2019-02-23 17:39 ` [PATCH v5 00/23] Unify vDSOs across more architectures Thomas Gleixner
2019-02-23 17:39 ` Thomas Gleixner
2019-02-23 17:39 ` Thomas Gleixner
2019-02-28 11:40 ` Arnd Bergmann
2019-02-28 11:40 ` Arnd Bergmann
2019-02-28 12:09 ` Vincenzo Frascino
2019-02-28 12:09 ` Vincenzo Frascino
2019-02-28 12:38 ` Arnd Bergmann
2019-02-28 12:38 ` Arnd Bergmann
2019-02-28 12:38 ` Arnd Bergmann
2019-02-28 12:42 ` Vincenzo Frascino
2019-02-28 12:42 ` Vincenzo Frascino
2019-02-28 12:42 ` Vincenzo Frascino
2019-02-28 13:54 ` Arnd Bergmann [this message]
2019-02-28 13:54 ` Arnd Bergmann
2019-02-28 13:54 ` Arnd Bergmann
2019-02-28 15:51 ` Vincenzo Frascino
2019-02-28 15:51 ` Vincenzo Frascino
2019-02-28 15:51 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a0FtUC2Akr7HdqrkMPv-FHEbX+WNik=WH70aEtC66f0uw@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=0x7f454c46@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rasmusvillemoes.dk \
--cc=paul.burton@mips.com \
--cc=pcc@google.com \
--cc=ralf@linux-mips.org \
--cc=salyzyn@android.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.