From: Arnd Bergmann <arnd@arndb.de>
To: Rob Herring <robh@kernel.org>
Cc: Anders Roxell <anders.roxell@linaro.org>,
SoC Team <soc@kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 1/5] power: vexpress: add suppress_bind_attrs to true
Date: Thu, 28 May 2020 12:25:49 +0200 [thread overview]
Message-ID: <CAK8P3a1P3bFC=cneCR9CURgYis6Ue7oPXKAEAQ8TpxQQYUPwgA@mail.gmail.com> (raw)
In-Reply-To: <CAL_Jsq+vrEE2DBY+c3iVyMLf9oOaGVHVvdiMgdYEGCjJwX7Hcw@mail.gmail.com>
On Wed, May 27, 2020 at 3:27 PM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, May 27, 2020 at 5:26 AM Anders Roxell <anders.roxell@linaro.org> wrote:
> >
> > Make sure that the POWER_RESET_VEXPRESS driver won't have bind/unbind
> > attributes available via the sysfs, so lets be explicit here and use
> > ".suppress_bind_attrs = true" to prevent userspace from doing something
> > silly.
>
> This doesn't really make sense if we're going to make this a module.
> Module unloading and unbind introduce the same requirements of
> cleaning up (undoing whatever probe did).
I still want this change as a separate patch so we can backport it to stable
kernels for correctness.
Also, as long as we don't have a working (and tested) .remove callback,
we can only allow making the driver a loadable module but not also
allowing the module to be removed.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Rob Herring <robh@kernel.org>
Cc: SoC Team <soc@kernel.org>,
Anders Roxell <anders.roxell@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 1/5] power: vexpress: add suppress_bind_attrs to true
Date: Thu, 28 May 2020 12:25:49 +0200 [thread overview]
Message-ID: <CAK8P3a1P3bFC=cneCR9CURgYis6Ue7oPXKAEAQ8TpxQQYUPwgA@mail.gmail.com> (raw)
In-Reply-To: <CAL_Jsq+vrEE2DBY+c3iVyMLf9oOaGVHVvdiMgdYEGCjJwX7Hcw@mail.gmail.com>
On Wed, May 27, 2020 at 3:27 PM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, May 27, 2020 at 5:26 AM Anders Roxell <anders.roxell@linaro.org> wrote:
> >
> > Make sure that the POWER_RESET_VEXPRESS driver won't have bind/unbind
> > attributes available via the sysfs, so lets be explicit here and use
> > ".suppress_bind_attrs = true" to prevent userspace from doing something
> > silly.
>
> This doesn't really make sense if we're going to make this a module.
> Module unloading and unbind introduce the same requirements of
> cleaning up (undoing whatever probe did).
I still want this change as a separate patch so we can backport it to stable
kernels for correctness.
Also, as long as we don't have a working (and tested) .remove callback,
we can only allow making the driver a loadable module but not also
allowing the module to be removed.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-28 10:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 11:26 [PATCH 0/5] vexpress: modularize power reset driver Anders Roxell
2020-05-27 11:26 ` Anders Roxell
2020-05-27 11:26 ` [PATCH 1/5] power: vexpress: add suppress_bind_attrs to true Anders Roxell
2020-05-27 11:26 ` Anders Roxell
2020-05-27 13:26 ` Rob Herring
2020-05-28 10:25 ` Arnd Bergmann [this message]
2020-05-28 10:25 ` Arnd Bergmann
2020-05-27 11:26 ` [PATCH 2/5] power: vexpress: cleanup: use builtin_platform_driver Anders Roxell
2020-05-27 11:26 ` Anders Roxell
2020-05-27 11:26 ` [PATCH 3/5] Revert "ARM: vexpress: Don't select VEXPRESS_CONFIG" Anders Roxell
2020-05-27 11:26 ` Anders Roxell
2020-05-27 11:26 ` [PATCH 4/5] power: reset: vexpress: fix build issue Anders Roxell
2020-05-27 11:26 ` Anders Roxell
2020-05-27 11:26 ` [PATCH 5/5] power: vexpress: make the reset driver a module Anders Roxell
2020-05-27 11:26 ` Anders Roxell
2020-05-27 13:32 ` Rob Herring
2020-05-28 10:28 ` Arnd Bergmann
2020-05-28 10:28 ` Arnd Bergmann
2020-05-27 13:34 ` [PATCH 0/5] vexpress: modularize power reset driver Rob Herring
2020-05-28 10:34 ` Arnd Bergmann
2020-05-28 10:34 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a1P3bFC=cneCR9CURgYis6Ue7oPXKAEAQ8TpxQQYUPwgA@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=anders.roxell@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.