From: Arnd Bergmann <arnd@arndb.de>
To: Rob Herring <robh@kernel.org>
Cc: Anders Roxell <anders.roxell@linaro.org>,
SoC Team <soc@kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 5/5] power: vexpress: make the reset driver a module
Date: Thu, 28 May 2020 12:28:46 +0200 [thread overview]
Message-ID: <CAK8P3a3_5pHCc0WqDNt1Aim2M67cicyq27f0ggqPbJuu97i=Nw@mail.gmail.com> (raw)
In-Reply-To: <CAL_Jsq+bwnwQBpxf_Q5GNhCz8+-psH-ovpW80LMk=MK=zcbYcA@mail.gmail.com>
On Wed, May 27, 2020 at 3:32 PM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, May 27, 2020 at 5:26 AM Anders Roxell <anders.roxell@linaro.org> wrote:
> >
> > Today the vexpress power driver can only be builtin. Rework so it's
> > possible for the vexpress power driver to be a module.
>
> This is the same incomplete patch I did[1]. As a module, it needs to
> clean-up everything probe did like overwriting global variables.
>
> Rob
>
> [1] https://lore.kernel.org/linux-arm-kernel/20200419170810.5738-5-robh@kernel.org/
Your version was actually broken because it allowed unloading the
driver again. The version that Anders sent is a bit better because it
explicitly forbids unloading by having a module_init but not module_exit
function, so as long as the .suppress_bind_attrs flag is set, this will
not crash the kernel.
It would be nice to have a .remove callback, but for the merge window
I'm happy with a patch that fixes the build regression.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Rob Herring <robh@kernel.org>
Cc: SoC Team <soc@kernel.org>,
Anders Roxell <anders.roxell@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 5/5] power: vexpress: make the reset driver a module
Date: Thu, 28 May 2020 12:28:46 +0200 [thread overview]
Message-ID: <CAK8P3a3_5pHCc0WqDNt1Aim2M67cicyq27f0ggqPbJuu97i=Nw@mail.gmail.com> (raw)
In-Reply-To: <CAL_Jsq+bwnwQBpxf_Q5GNhCz8+-psH-ovpW80LMk=MK=zcbYcA@mail.gmail.com>
On Wed, May 27, 2020 at 3:32 PM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, May 27, 2020 at 5:26 AM Anders Roxell <anders.roxell@linaro.org> wrote:
> >
> > Today the vexpress power driver can only be builtin. Rework so it's
> > possible for the vexpress power driver to be a module.
>
> This is the same incomplete patch I did[1]. As a module, it needs to
> clean-up everything probe did like overwriting global variables.
>
> Rob
>
> [1] https://lore.kernel.org/linux-arm-kernel/20200419170810.5738-5-robh@kernel.org/
Your version was actually broken because it allowed unloading the
driver again. The version that Anders sent is a bit better because it
explicitly forbids unloading by having a module_init but not module_exit
function, so as long as the .suppress_bind_attrs flag is set, this will
not crash the kernel.
It would be nice to have a .remove callback, but for the merge window
I'm happy with a patch that fixes the build regression.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-28 10:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 11:26 [PATCH 0/5] vexpress: modularize power reset driver Anders Roxell
2020-05-27 11:26 ` Anders Roxell
2020-05-27 11:26 ` [PATCH 1/5] power: vexpress: add suppress_bind_attrs to true Anders Roxell
2020-05-27 11:26 ` Anders Roxell
2020-05-27 13:26 ` Rob Herring
2020-05-28 10:25 ` Arnd Bergmann
2020-05-28 10:25 ` Arnd Bergmann
2020-05-27 11:26 ` [PATCH 2/5] power: vexpress: cleanup: use builtin_platform_driver Anders Roxell
2020-05-27 11:26 ` Anders Roxell
2020-05-27 11:26 ` [PATCH 3/5] Revert "ARM: vexpress: Don't select VEXPRESS_CONFIG" Anders Roxell
2020-05-27 11:26 ` Anders Roxell
2020-05-27 11:26 ` [PATCH 4/5] power: reset: vexpress: fix build issue Anders Roxell
2020-05-27 11:26 ` Anders Roxell
2020-05-27 11:26 ` [PATCH 5/5] power: vexpress: make the reset driver a module Anders Roxell
2020-05-27 11:26 ` Anders Roxell
2020-05-27 13:32 ` Rob Herring
2020-05-28 10:28 ` Arnd Bergmann [this message]
2020-05-28 10:28 ` Arnd Bergmann
2020-05-27 13:34 ` [PATCH 0/5] vexpress: modularize power reset driver Rob Herring
2020-05-28 10:34 ` Arnd Bergmann
2020-05-28 10:34 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a3_5pHCc0WqDNt1Aim2M67cicyq27f0ggqPbJuu97i=Nw@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=anders.roxell@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.