From: Arnd Bergmann <arnd@arndb.de>
To: kernel test robot <lkp@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@armlinux.org.uk>,
linux-omap <linux-omap@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dove: fix returnvar.cocci warnings
Date: Tue, 3 May 2022 09:21:49 +0200 [thread overview]
Message-ID: <CAK8P3a1xMeLa72YKMufdej6KguDwiSXtZmMqRxOt5B05x_fx3A@mail.gmail.com> (raw)
In-Reply-To: <YnCXTPrbLhvfRVDm@e3a974050dc4>
On Tue, May 3, 2022 at 4:45 AM kernel test robot <lkp@intel.com> wrote:
>
> From: kernel test robot <lkp@intel.com>
>
> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161
>
>
> Remove unneeded variable used to store return value.
>
> Generated by: scripts/coccinelle/misc/returnvar.cocci
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
I checked the patch, and unfortunately it is wrong, the current code
needs to stay.
The problem is the SET_DMA_ERRATA() macro that accesses the
local 'errata' variable.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: kernel test robot <lkp@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@armlinux.org.uk>,
linux-omap <linux-omap@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dove: fix returnvar.cocci warnings
Date: Tue, 3 May 2022 09:21:49 +0200 [thread overview]
Message-ID: <CAK8P3a1xMeLa72YKMufdej6KguDwiSXtZmMqRxOt5B05x_fx3A@mail.gmail.com> (raw)
In-Reply-To: <YnCXTPrbLhvfRVDm@e3a974050dc4>
On Tue, May 3, 2022 at 4:45 AM kernel test robot <lkp@intel.com> wrote:
>
> From: kernel test robot <lkp@intel.com>
>
> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161
>
>
> Remove unneeded variable used to store return value.
>
> Generated by: scripts/coccinelle/misc/returnvar.cocci
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
I checked the patch, and unfortunately it is wrong, the current code
needs to stay.
The problem is the SET_DMA_ERRATA() macro that accesses the
local 'errata' variable.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] ARM: dove: fix returnvar.cocci warnings
Date: Tue, 03 May 2022 09:21:49 +0200 [thread overview]
Message-ID: <CAK8P3a1xMeLa72YKMufdej6KguDwiSXtZmMqRxOt5B05x_fx3A@mail.gmail.com> (raw)
In-Reply-To: <YnCXTPrbLhvfRVDm@e3a974050dc4>
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
On Tue, May 3, 2022 at 4:45 AM kernel test robot <lkp@intel.com> wrote:
>
> From: kernel test robot <lkp@intel.com>
>
> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161
>
>
> Remove unneeded variable used to store return value.
>
> Generated by: scripts/coccinelle/misc/returnvar.cocci
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
I checked the patch, and unfortunately it is wrong, the current code
needs to stay.
The problem is the SET_DMA_ERRATA() macro that accesses the
local 'errata' variable.
Arnd
next prev parent reply other threads:[~2022-05-03 7:22 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 2:47 [linux-next:master 1066/8035] arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 kernel test robot
2022-05-03 2:45 ` [PATCH] ARM: dove: fix returnvar.cocci warnings kernel test robot
2022-05-03 2:45 ` kernel test robot
2022-05-03 7:21 ` Arnd Bergmann [this message]
2022-05-03 7:21 ` Arnd Bergmann
2022-05-03 7:21 ` Arnd Bergmann
2022-05-03 7:30 ` Tony Lindgren
2022-05-03 7:30 ` Tony Lindgren
2022-05-03 7:30 ` Tony Lindgren
2022-05-03 7:53 ` Arnd Bergmann
2022-05-03 7:53 ` Arnd Bergmann
2022-05-03 7:53 ` Arnd Bergmann
2022-05-03 8:23 ` Tony Lindgren
2022-05-03 8:23 ` Tony Lindgren
2022-05-03 8:23 ` Tony Lindgren
2022-05-05 16:31 ` Dave Hansen
2022-05-05 16:31 ` Dave Hansen
2022-05-06 1:09 ` Philip Li
2022-05-06 1:09 ` Philip Li
2022-05-06 7:17 ` Arnd Bergmann
2022-05-06 7:17 ` Arnd Bergmann
2022-05-06 7:17 ` Arnd Bergmann
2022-05-06 7:32 ` Philip Li
2022-05-06 7:32 ` Philip Li
2022-05-06 7:24 ` Ard Biesheuvel
2022-05-06 7:24 ` Ard Biesheuvel
2022-05-06 7:24 ` Ard Biesheuvel
2022-05-06 7:30 ` Philip Li
2022-05-06 7:30 ` Philip Li
2022-05-05 14:08 ` Russell King (Oracle)
2022-05-05 14:08 ` Russell King
2022-05-05 14:08 ` Russell King (Oracle)
2022-05-06 1:09 ` [kbuild-all] " Philip Li
2022-05-06 1:09 ` Philip Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a1xMeLa72YKMufdej6KguDwiSXtZmMqRxOt5B05x_fx3A@mail.gmail.com \
--to=arnd@arndb.de \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkp@intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.