Re: [PATCH] ARM: dove: fix returnvar.cocci warnings

From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: kernel test robot <lkp@intel.com>,
	kbuild-all@lists.01.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	Russell King <linux@armlinux.org.uk>,
	linux-omap <linux-omap@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dove: fix returnvar.cocci warnings
Date: Tue, 3 May 2022 11:23:09 +0300	[thread overview]
Message-ID: <YnDmbUCDf7SVPo0s@atomide.com> (raw)
In-Reply-To: <CAK8P3a2NOfu52tADw30e6Bfik56_+PbUv6_+ADs=PUE-6NSrbQ@mail.gmail.com>

* Arnd Bergmann <arnd@arndb.de> [220503 08:12]:
> On Tue, May 3, 2022 at 9:30 AM Tony Lindgren <tony@atomide.com> wrote:
> > * Arnd Bergmann <arnd@arndb.de> [220503 07:18]:
> > > On Tue, May 3, 2022 at 4:45 AM kernel test robot <lkp@intel.com> wrote:
> > > >
> > > > From: kernel test robot <lkp@intel.com>
> > > >
> > > > arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161
> > > >
> > > >
> > > >  Remove unneeded variable used to store return value.
> > > >
> > > > Generated by: scripts/coccinelle/misc/returnvar.cocci
> > > >
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > Signed-off-by: kernel test robot <lkp@intel.com>
> > >
> > > I checked the patch, and unfortunately it is wrong, the current code
> > > needs to stay.
> > > The problem is the SET_DMA_ERRATA() macro that accesses the
> > > local 'errata' variable.
> >
> > Yeah this one keeps popping up. Maybe we can make SET_DMA_ERRATA
> > into a function or have it at least change it to set the errata
> > value.
> 
> I would just remove the macro and open-code the assignment, which
> I think makes it more readable to both people and tools.

Yeah agree after looking at the macro :)

Regards,

Tony