From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Horia Geanta <horia.geanta@nxp.com>,
Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>,
Milan Broz <gmazyland@gmail.com>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: [dm-devel] xts fuzz testing and lack of ciphertext stealing support
Date: Fri, 9 Aug 2019 09:45:20 +0300 [thread overview]
Message-ID: <CAKv+Gu9hk=PGpsAWWOU61VrA3mVQd10LudA1qg0LbiX7DG9RjA@mail.gmail.com> (raw)
In-Reply-To: <20190809024821.GA7186@gondor.apana.org.au>
On Fri, 9 Aug 2019 at 05:48, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Thu, Aug 08, 2019 at 06:01:49PM +0000, Horia Geanta wrote:
> >
> > -- >8 --
> >
> > Subject: [PATCH] crypto: testmgr - Add additional AES-XTS vectors for covering
> > CTS (part II)
>
> Patchwork doesn't like it when you do this and it'll discard
> your patch. To make it into patchwork you need to put the new
> Subject in the email headers.
>
IMO, pretending that your XTS implementation is compliant by only
providing test vectors with the last 8 bytes of IV cleared is not the
right fix for this issue. If you want to be compliant, you will need
to provide a s/w fallback for these cases.
WARNING: multiple messages have this Message-ID (diff)
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
Milan Broz <gmazyland@gmail.com>,
Horia Geanta <horia.geanta@nxp.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: xts fuzz testing and lack of ciphertext stealing support
Date: Fri, 9 Aug 2019 09:45:20 +0300 [thread overview]
Message-ID: <CAKv+Gu9hk=PGpsAWWOU61VrA3mVQd10LudA1qg0LbiX7DG9RjA@mail.gmail.com> (raw)
In-Reply-To: <20190809024821.GA7186@gondor.apana.org.au>
On Fri, 9 Aug 2019 at 05:48, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Thu, Aug 08, 2019 at 06:01:49PM +0000, Horia Geanta wrote:
> >
> > -- >8 --
> >
> > Subject: [PATCH] crypto: testmgr - Add additional AES-XTS vectors for covering
> > CTS (part II)
>
> Patchwork doesn't like it when you do this and it'll discard
> your patch. To make it into patchwork you need to put the new
> Subject in the email headers.
>
IMO, pretending that your XTS implementation is compliant by only
providing test vectors with the last 8 bytes of IV cleared is not the
right fix for this issue. If you want to be compliant, you will need
to provide a s/w fallback for these cases.
next prev parent reply other threads:[~2019-08-09 6:45 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 17:46 xts fuzz testing and lack of ciphertext stealing support Horia Geanta
2019-07-16 22:16 ` Eric Biggers
2019-07-17 17:09 ` Horia Geanta
2019-07-17 17:09 ` Horia Geanta
2019-07-17 17:28 ` Eric Biggers
2019-07-17 17:28 ` Eric Biggers
2019-07-17 18:08 ` Ard Biesheuvel
2019-07-18 6:52 ` Herbert Xu
2019-07-18 6:52 ` Herbert Xu
2019-07-18 7:15 ` Ard Biesheuvel
2019-07-18 7:15 ` Ard Biesheuvel
2019-07-18 7:21 ` Herbert Xu
2019-07-18 7:21 ` Herbert Xu
2019-07-18 7:28 ` Ard Biesheuvel
2019-07-18 7:28 ` Ard Biesheuvel
2019-07-18 7:50 ` Herbert Xu
2019-07-18 7:50 ` Herbert Xu
2019-07-18 7:40 ` Milan Broz
2019-07-18 7:40 ` Milan Broz
2019-07-18 10:40 ` Pascal Van Leeuwen
2019-07-18 11:19 ` Milan Broz
2019-07-18 11:19 ` Milan Broz
2019-07-18 15:27 ` Herbert Xu
2019-07-18 15:27 ` Herbert Xu
2019-07-20 6:58 ` [dm-devel] " Eric Biggers
2019-07-20 6:58 ` Eric Biggers
2019-07-20 7:35 ` [dm-devel] " Milan Broz
2019-07-20 7:35 ` Milan Broz
2019-07-20 10:13 ` Markus
2019-07-21 9:50 ` [dm-devel] " Ard Biesheuvel
2019-07-21 9:50 ` Ard Biesheuvel
2019-07-22 9:44 ` [dm-devel] " Pascal Van Leeuwen
2019-07-22 16:43 ` Ard Biesheuvel
2019-07-22 16:43 ` Ard Biesheuvel
2019-07-22 22:46 ` [dm-devel] " Pascal Van Leeuwen
2019-07-24 12:23 ` Pascal Van Leeuwen
2019-07-24 12:50 ` Pascal Van Leeuwen
2019-07-24 16:10 ` Pascal Van Leeuwen
2019-07-25 6:22 ` Ard Biesheuvel
2019-07-25 6:22 ` Ard Biesheuvel
2019-07-25 7:49 ` [dm-devel] " Pascal Van Leeuwen
2019-07-25 8:01 ` Ard Biesheuvel
2019-07-25 8:01 ` Ard Biesheuvel
2019-07-26 10:31 ` [dm-devel] " Pascal Van Leeuwen
2019-07-26 19:59 ` Horia Geanta
2019-07-26 19:59 ` Horia Geanta
2019-07-26 21:43 ` [dm-devel] " Pascal Van Leeuwen
2019-07-27 5:39 ` Ard Biesheuvel
2019-07-27 5:39 ` Ard Biesheuvel
2019-07-27 12:56 ` [dm-devel] " Pascal Van Leeuwen
2019-07-27 16:04 ` Milan Broz
2019-07-27 16:04 ` Milan Broz
2019-08-04 8:36 ` [dm-devel] " Ard Biesheuvel
2019-08-04 8:36 ` Ard Biesheuvel
[not found] ` <20f4832e-e3af-e3c2-d946-13bf8c367a60@nxp.com>
2019-08-07 15:51 ` [dm-devel] " Horia Geanta
2019-08-07 15:51 ` Horia Geanta
2019-08-07 20:57 ` [dm-devel] " Pascal Van Leeuwen
2019-08-08 14:50 ` Horia Geanta
2019-08-08 14:50 ` Horia Geanta
2019-08-09 8:35 ` [dm-devel] " Pascal Van Leeuwen
2019-08-08 13:43 ` Pascal Van Leeuwen
2019-08-08 18:01 ` Horia Geanta
2019-08-08 18:01 ` Horia Geanta
2019-08-09 2:48 ` [dm-devel] " Herbert Xu
2019-08-09 2:48 ` Herbert Xu
2019-08-09 6:45 ` Ard Biesheuvel [this message]
2019-08-09 6:45 ` Ard Biesheuvel
2019-08-09 7:44 ` [dm-devel] " Horia Geanta
2019-08-09 7:44 ` Horia Geanta
2019-08-09 17:49 ` [dm-devel] " Ard Biesheuvel
2019-08-09 17:49 ` Ard Biesheuvel
2019-08-09 20:57 ` [dm-devel] " Pascal Van Leeuwen
2019-08-10 4:39 ` Ard Biesheuvel
2019-08-10 4:39 ` Ard Biesheuvel
2019-08-11 11:12 ` [dm-devel] " Milan Broz
2019-08-11 11:12 ` Milan Broz
2019-08-11 20:34 ` [dm-devel] " Eric Biggers
2019-08-11 20:34 ` Eric Biggers
2019-08-11 21:39 ` [dm-devel] " Pascal Van Leeuwen
2019-08-11 21:29 ` Pascal Van Leeuwen
2019-08-12 4:51 ` Herbert Xu
2019-08-12 4:51 ` Herbert Xu
2019-08-11 21:15 ` [dm-devel] " Pascal Van Leeuwen
2019-08-11 22:24 ` Ard Biesheuvel
2019-08-11 22:24 ` Ard Biesheuvel
2019-08-12 1:04 ` [dm-devel] " Pascal Van Leeuwen
2019-07-18 15:29 ` Herbert Xu
2019-07-18 15:29 ` Herbert Xu
2019-07-18 15:43 ` Pascal Van Leeuwen
2019-07-18 15:51 ` Herbert Xu
2019-07-18 15:51 ` Herbert Xu
2019-07-18 16:19 ` Ard Biesheuvel
2019-07-18 16:19 ` Ard Biesheuvel
2019-07-18 16:22 ` Herbert Xu
2019-07-18 16:22 ` Herbert Xu
2019-07-18 17:03 ` Pascal Van Leeuwen
2019-07-19 5:34 ` Ard Biesheuvel
2019-07-19 5:34 ` Ard Biesheuvel
2019-07-19 7:29 ` Pascal Van Leeuwen
2019-07-19 17:14 ` Ard Biesheuvel
2019-07-19 17:14 ` Ard Biesheuvel
2019-07-19 20:07 ` Pascal Van Leeuwen
2019-07-19 7:29 ` Pascal Van Leeuwen
2019-07-18 17:03 ` Pascal Van Leeuwen
2019-07-18 16:35 ` Pascal Van Leeuwen
2019-07-19 1:47 ` Herbert Xu
2019-07-19 1:47 ` Herbert Xu
2019-07-18 16:35 ` Pascal Van Leeuwen
2019-07-18 15:43 ` Pascal Van Leeuwen
2019-07-18 10:40 ` Pascal Van Leeuwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu9hk=PGpsAWWOU61VrA3mVQd10LudA1qg0LbiX7DG9RjA@mail.gmail.com' \
--to=ard.biesheuvel@linaro.org \
--cc=dm-devel@redhat.com \
--cc=gmazyland@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=pvanleeuwen@verimatrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.