All of lore.kernel.org
 help / color / mirror / Atom feed
From: Horia Geanta <horia.geanta@nxp.com>
To: Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Milan Broz <gmazyland@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"dm-devel@redhat.com" <dm-devel@redhat.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: [dm-devel] xts fuzz testing and lack of ciphertext stealing support
Date: Wed, 7 Aug 2019 15:51:49 +0000	[thread overview]
Message-ID: <VI1PR0402MB34856F03FCE57AB62FC2257998D40@VI1PR0402MB3485.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 20f4832e-e3af-e3c2-d946-13bf8c367a60@nxp.com

On 7/26/2019 10:59 PM, Horia Geantă wrote:
> On 7/26/2019 1:31 PM, Pascal Van Leeuwen wrote:
>> Ok, find below a patch file that adds your vectors from the specification
>> plus my set of additional vectors covering all CTS alignments combined
>> with the block sizes you desired. Please note though that these vectors
>> are from our in-house home-grown model so no warranties.
> I've checked the test vectors against caam (HW + driver).
> 
> Test vectors from IEEE 1619-2007 (i.e. up to and including "XTS-AES 18")
> are fine.
> 
> caam complains when /* Additional vectors to increase CTS coverage */
> section starts:
> alg: skcipher: xts-aes-caam encryption test failed (wrong result) on test vector 9, cfg="in-place"
> 
I've nailed this down to a caam hw limitation.
Except for lx2160a and ls1028a SoCs, all the (older) SoCs allow only for
8-byte wide IV (sector index).
Will follow up with 16-byte IV support for the above-mentioned SoCs.

Pascal,

Could you also generate a few test vectors covering CTS with 8-byte IV?

Thanks,
Horia

WARNING: multiple messages have this Message-ID (diff)
From: Horia Geanta <horia.geanta@nxp.com>
To: Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"dm-devel@redhat.com" <dm-devel@redhat.com>,
	Milan Broz <gmazyland@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: xts fuzz testing and lack of ciphertext stealing support
Date: Wed, 7 Aug 2019 15:51:49 +0000	[thread overview]
Message-ID: <VI1PR0402MB34856F03FCE57AB62FC2257998D40@VI1PR0402MB3485.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 20f4832e-e3af-e3c2-d946-13bf8c367a60@nxp.com

On 7/26/2019 10:59 PM, Horia Geantă wrote:
> On 7/26/2019 1:31 PM, Pascal Van Leeuwen wrote:
>> Ok, find below a patch file that adds your vectors from the specification
>> plus my set of additional vectors covering all CTS alignments combined
>> with the block sizes you desired. Please note though that these vectors
>> are from our in-house home-grown model so no warranties.
> I've checked the test vectors against caam (HW + driver).
> 
> Test vectors from IEEE 1619-2007 (i.e. up to and including "XTS-AES 18")
> are fine.
> 
> caam complains when /* Additional vectors to increase CTS coverage */
> section starts:
> alg: skcipher: xts-aes-caam encryption test failed (wrong result) on test vector 9, cfg="in-place"
> 
I've nailed this down to a caam hw limitation.
Except for lx2160a and ls1028a SoCs, all the (older) SoCs allow only for
8-byte wide IV (sector index).
Will follow up with 16-byte IV support for the above-mentioned SoCs.

Pascal,

Could you also generate a few test vectors covering CTS with 8-byte IV?

Thanks,
Horia

  parent reply	other threads:[~2019-08-07 15:51 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-16 17:46 xts fuzz testing and lack of ciphertext stealing support Horia Geanta
2019-07-16 22:16 ` Eric Biggers
2019-07-17 17:09   ` Horia Geanta
2019-07-17 17:09     ` Horia Geanta
2019-07-17 17:28     ` Eric Biggers
2019-07-17 17:28       ` Eric Biggers
2019-07-17 18:08       ` Ard Biesheuvel
2019-07-18  6:52         ` Herbert Xu
2019-07-18  6:52           ` Herbert Xu
2019-07-18  7:15           ` Ard Biesheuvel
2019-07-18  7:15             ` Ard Biesheuvel
2019-07-18  7:21             ` Herbert Xu
2019-07-18  7:21               ` Herbert Xu
2019-07-18  7:28               ` Ard Biesheuvel
2019-07-18  7:28                 ` Ard Biesheuvel
2019-07-18  7:50                 ` Herbert Xu
2019-07-18  7:50                   ` Herbert Xu
2019-07-18  7:40               ` Milan Broz
2019-07-18  7:40                 ` Milan Broz
2019-07-18 10:40                 ` Pascal Van Leeuwen
2019-07-18 11:19                   ` Milan Broz
2019-07-18 11:19                     ` Milan Broz
2019-07-18 15:27                     ` Herbert Xu
2019-07-18 15:27                       ` Herbert Xu
2019-07-20  6:58                     ` [dm-devel] " Eric Biggers
2019-07-20  6:58                       ` Eric Biggers
2019-07-20  7:35                       ` [dm-devel] " Milan Broz
2019-07-20  7:35                         ` Milan Broz
2019-07-20 10:13                         ` Markus
2019-07-21  9:50                         ` [dm-devel] " Ard Biesheuvel
2019-07-21  9:50                           ` Ard Biesheuvel
2019-07-22  9:44                           ` [dm-devel] " Pascal Van Leeuwen
2019-07-22 16:43                             ` Ard Biesheuvel
2019-07-22 16:43                               ` Ard Biesheuvel
2019-07-22 22:46                               ` [dm-devel] " Pascal Van Leeuwen
2019-07-24 12:23                               ` Pascal Van Leeuwen
2019-07-24 12:50                                 ` Pascal Van Leeuwen
2019-07-24 16:10                               ` Pascal Van Leeuwen
2019-07-25  6:22                                 ` Ard Biesheuvel
2019-07-25  6:22                                   ` Ard Biesheuvel
2019-07-25  7:49                                   ` [dm-devel] " Pascal Van Leeuwen
2019-07-25  8:01                                     ` Ard Biesheuvel
2019-07-25  8:01                                       ` Ard Biesheuvel
2019-07-26 10:31                                       ` [dm-devel] " Pascal Van Leeuwen
2019-07-26 19:59                                         ` Horia Geanta
2019-07-26 19:59                                           ` Horia Geanta
2019-07-26 21:43                                           ` [dm-devel] " Pascal Van Leeuwen
2019-07-27  5:39                                             ` Ard Biesheuvel
2019-07-27  5:39                                               ` Ard Biesheuvel
2019-07-27 12:56                                               ` [dm-devel] " Pascal Van Leeuwen
2019-07-27 16:04                                               ` Milan Broz
2019-07-27 16:04                                                 ` Milan Broz
2019-08-04  8:36                                                 ` [dm-devel] " Ard Biesheuvel
2019-08-04  8:36                                                   ` Ard Biesheuvel
     [not found]                                         ` <20f4832e-e3af-e3c2-d946-13bf8c367a60@nxp.com>
2019-08-07 15:51                                           ` Horia Geanta [this message]
2019-08-07 15:51                                             ` Horia Geanta
2019-08-07 20:57                                             ` [dm-devel] " Pascal Van Leeuwen
2019-08-08 14:50                                               ` Horia Geanta
2019-08-08 14:50                                                 ` Horia Geanta
2019-08-09  8:35                                                 ` [dm-devel] " Pascal Van Leeuwen
2019-08-08 13:43                                             ` Pascal Van Leeuwen
2019-08-08 18:01                                               ` Horia Geanta
2019-08-08 18:01                                                 ` Horia Geanta
2019-08-09  2:48                                                 ` [dm-devel] " Herbert Xu
2019-08-09  2:48                                                   ` Herbert Xu
2019-08-09  6:45                                                   ` [dm-devel] " Ard Biesheuvel
2019-08-09  6:45                                                     ` Ard Biesheuvel
2019-08-09  7:44                                                     ` [dm-devel] " Horia Geanta
2019-08-09  7:44                                                       ` Horia Geanta
2019-08-09 17:49                                                       ` [dm-devel] " Ard Biesheuvel
2019-08-09 17:49                                                         ` Ard Biesheuvel
2019-08-09 20:57                                                         ` [dm-devel] " Pascal Van Leeuwen
2019-08-10  4:39                                                           ` Ard Biesheuvel
2019-08-10  4:39                                                             ` Ard Biesheuvel
2019-08-11 11:12                                                             ` [dm-devel] " Milan Broz
2019-08-11 11:12                                                               ` Milan Broz
2019-08-11 20:34                                                               ` [dm-devel] " Eric Biggers
2019-08-11 20:34                                                                 ` Eric Biggers
2019-08-11 21:39                                                                 ` [dm-devel] " Pascal Van Leeuwen
2019-08-11 21:29                                                               ` Pascal Van Leeuwen
2019-08-12  4:51                                                                 ` Herbert Xu
2019-08-12  4:51                                                                   ` Herbert Xu
2019-08-11 21:15                                                             ` [dm-devel] " Pascal Van Leeuwen
2019-08-11 22:24                                                               ` Ard Biesheuvel
2019-08-11 22:24                                                                 ` Ard Biesheuvel
2019-08-12  1:04                                                                 ` [dm-devel] " Pascal Van Leeuwen
2019-07-18 15:29                   ` Herbert Xu
2019-07-18 15:29                     ` Herbert Xu
2019-07-18 15:43                     ` Pascal Van Leeuwen
2019-07-18 15:51                       ` Herbert Xu
2019-07-18 15:51                         ` Herbert Xu
2019-07-18 16:19                         ` Ard Biesheuvel
2019-07-18 16:19                           ` Ard Biesheuvel
2019-07-18 16:22                           ` Herbert Xu
2019-07-18 16:22                             ` Herbert Xu
2019-07-18 17:03                           ` Pascal Van Leeuwen
2019-07-19  5:34                             ` Ard Biesheuvel
2019-07-19  5:34                               ` Ard Biesheuvel
2019-07-19  7:29                               ` Pascal Van Leeuwen
2019-07-19 17:14                                 ` Ard Biesheuvel
2019-07-19 17:14                                   ` Ard Biesheuvel
2019-07-19 20:07                                   ` Pascal Van Leeuwen
2019-07-19  7:29                               ` Pascal Van Leeuwen
2019-07-18 17:03                           ` Pascal Van Leeuwen
2019-07-18 16:35                         ` Pascal Van Leeuwen
2019-07-19  1:47                           ` Herbert Xu
2019-07-19  1:47                             ` Herbert Xu
2019-07-18 16:35                         ` Pascal Van Leeuwen
2019-07-18 15:43                     ` Pascal Van Leeuwen
2019-07-18 10:40                 ` Pascal Van Leeuwen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR0402MB34856F03FCE57AB62FC2257998D40@VI1PR0402MB3485.eurprd04.prod.outlook.com \
    --to=horia.geanta@nxp.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=dm-devel@redhat.com \
    --cc=gmazyland@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=pvanleeuwen@verimatrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.