From: Nick Desaulniers <ndesaulniers@google.com>
To: Joe Perches <joe@perches.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 00/13] nvdimm: Use more common kernel coding style
Date: Thu, 12 Sep 2019 16:00:53 -0700 [thread overview]
Message-ID: <CAKwvOd=S911qkQtN31JkusS==NXZMnEwrUOGN3Gp6B7GTzYe2A@mail.gmail.com> (raw)
In-Reply-To: <4f759f8c4f4d59fd60008e833334e29b0da0869c.camel@perches.com>
On Thu, Sep 12, 2019 at 3:38 PM Joe Perches <joe@perches.com> wrote:
>
> On Thu, 2019-09-12 at 23:58 +0200, Miguel Ojeda wrote:
> > On Thu, Sep 12, 2019 at 11:08 PM Joe Perches <joe@perches.com> wrote:
> > > Please name the major projects and then point to their
> > > .clang-format equivalents.
> > >
> > > Also note the size/scope/complexity of the major projects.
> >
> > Mozilla, WebKit, LLVM and Microsoft. They have their style distributed
> > with the official clang-format, not sure if they enforce it.
>
> At least for LLVM, it appears not.
I acknowledge the irony you present, but that's because there's no
enforcement on the LLVM side. I frequently forget to run:
$ git-clang-format HEAD~
If you have automated systems that help encourage (ie. force) the use
of the formatter, this helps.
Consider the fact that not all kernel developers run checkpatch.pl.
Is that a deficiency in checkpatch.pl, or the lack of enforcement in
kernel developers' workflows?
--
Thanks,
~Nick Desaulniers
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Nick Desaulniers <ndesaulniers@google.com>
To: Joe Perches <joe@perches.com>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Jeff Moyer <jmoyer@redhat.com>,
Dan Williams <dan.j.williams@intel.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 00/13] nvdimm: Use more common kernel coding style
Date: Thu, 12 Sep 2019 16:00:53 -0700 [thread overview]
Message-ID: <CAKwvOd=S911qkQtN31JkusS==NXZMnEwrUOGN3Gp6B7GTzYe2A@mail.gmail.com> (raw)
In-Reply-To: <4f759f8c4f4d59fd60008e833334e29b0da0869c.camel@perches.com>
On Thu, Sep 12, 2019 at 3:38 PM Joe Perches <joe@perches.com> wrote:
>
> On Thu, 2019-09-12 at 23:58 +0200, Miguel Ojeda wrote:
> > On Thu, Sep 12, 2019 at 11:08 PM Joe Perches <joe@perches.com> wrote:
> > > Please name the major projects and then point to their
> > > .clang-format equivalents.
> > >
> > > Also note the size/scope/complexity of the major projects.
> >
> > Mozilla, WebKit, LLVM and Microsoft. They have their style distributed
> > with the official clang-format, not sure if they enforce it.
>
> At least for LLVM, it appears not.
I acknowledge the irony you present, but that's because there's no
enforcement on the LLVM side. I frequently forget to run:
$ git-clang-format HEAD~
If you have automated systems that help encourage (ie. force) the use
of the formatter, this helps.
Consider the fact that not all kernel developers run checkpatch.pl.
Is that a deficiency in checkpatch.pl, or the lack of enforcement in
kernel developers' workflows?
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2019-09-12 23:01 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 2:54 [PATCH 00/13] nvdimm: Use more common kernel coding style Joe Perches
2019-09-12 2:54 ` Joe Perches
2019-09-12 2:54 ` [PATCH 01/13] nvdimm: Use more typical whitespace Joe Perches
2019-09-12 2:54 ` Joe Perches
2019-09-12 12:17 ` Christoph Hellwig
2019-09-12 12:17 ` Christoph Hellwig
2019-09-12 15:01 ` Joe Perches
2019-09-12 15:01 ` Joe Perches
2019-09-16 7:07 ` Christoph Hellwig
2019-09-16 7:07 ` Christoph Hellwig
2019-09-12 2:54 ` [PATCH 02/13] nvdimm: Move logical continuations to previous line Joe Perches
2019-09-12 2:54 ` Joe Perches
2019-09-12 2:54 ` [PATCH 03/13] nvdimm: Use octal permissions Joe Perches
2019-09-12 2:54 ` Joe Perches
2019-09-12 2:54 ` [PATCH 04/13] nvdimm: Use a more common kernel spacing style Joe Perches
2019-09-12 2:54 ` Joe Perches
2019-09-12 2:54 ` [PATCH 05/13] nvdimm: Use "unsigned int" in preference to "unsigned" Joe Perches
2019-09-12 2:54 ` Joe Perches
2019-09-12 2:54 ` [PATCH 06/13] nvdimm: Add and remove blank lines Joe Perches
2019-09-12 2:54 ` Joe Perches
2019-09-12 2:54 ` [PATCH 07/13] nvdimm: Use typical kernel brace styles Joe Perches
2019-09-12 2:54 ` Joe Perches
2019-09-12 2:54 ` [PATCH 08/13] nvdimm: Use typical kernel style indentation Joe Perches
2019-09-12 2:54 ` Joe Perches
2019-09-12 2:54 ` [PATCH 09/13] nvdimm: btt.h: Neaten #defines to improve readability Joe Perches
2019-09-12 2:54 ` Joe Perches
2019-09-12 2:54 ` [PATCH 10/13] nvdimm: namespace_devs: Move assignment operators Joe Perches
2019-09-12 2:54 ` Joe Perches
2019-09-12 2:54 ` [PATCH 11/13] nvdimm: Use more common logic testing styles and bare ; positions Joe Perches
2019-09-12 2:54 ` Joe Perches
2019-09-12 3:52 ` Verma, Vishal L
2019-09-12 3:52 ` Verma, Vishal L
2019-09-12 2:54 ` [PATCH 12/13] nvdimm: namespace_devs: Change progess typo to progress Joe Perches
2019-09-12 2:54 ` Joe Perches
2019-09-12 2:54 ` [PATCH 13/13] nvdimm: Miscellaneous neatening Joe Perches
2019-09-12 2:54 ` Joe Perches
2019-09-12 8:00 ` [PATCH 00/13] nvdimm: Use more common kernel coding style Dan Williams
2019-09-12 8:00 ` Dan Williams
2019-09-12 8:15 ` Joe Perches
2019-09-12 8:15 ` Joe Perches
2019-09-12 8:42 ` Miguel Ojeda
2019-09-12 8:42 ` Miguel Ojeda
2019-09-12 14:00 ` Jeff Moyer
2019-09-12 14:00 ` Jeff Moyer
2019-09-12 14:06 ` Johannes Thumshirn
2019-09-12 14:06 ` Johannes Thumshirn
2019-09-12 14:35 ` Dan Williams
2019-09-12 14:35 ` Dan Williams
2019-09-12 14:21 ` Miguel Ojeda
2019-09-12 14:21 ` Miguel Ojeda
2019-09-12 21:08 ` Joe Perches
2019-09-12 21:08 ` Joe Perches
2019-09-12 21:58 ` Miguel Ojeda
2019-09-12 21:58 ` Miguel Ojeda
2019-09-12 22:15 ` Joe Perches
2019-09-12 22:15 ` Joe Perches
2019-09-12 22:38 ` Joe Perches
2019-09-12 22:38 ` Joe Perches
2019-09-12 23:00 ` Nick Desaulniers [this message]
2019-09-12 23:00 ` Nick Desaulniers
2019-09-12 23:07 ` Joe Perches
2019-09-12 23:07 ` Joe Perches
2019-09-12 22:58 ` Nick Desaulniers
2019-09-12 22:58 ` Nick Desaulniers
2019-09-12 23:26 ` clang-format and 'clang-format on' and 'clang-format off' Joe Perches
2019-09-12 23:26 ` Joe Perches
2019-09-15 18:25 ` Miguel Ojeda
2019-09-15 18:25 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOd=S911qkQtN31JkusS==NXZMnEwrUOGN3Gp6B7GTzYe2A@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=dan.carpenter@oracle.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=miguel.ojeda.sandonis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.