From: Nick Desaulniers <ndesaulniers@google.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Stefan Agner <stefan@agner.ch>,
Russell King <linux@armlinux.org.uk>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Will Deacon <will.deacon@arm.com>,
julien.thierry@arm.com, LKML <linux-kernel@vger.kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Kristof Beyls <Kristof.Beyls@arm.com>,
Peter Smith <Peter.Smith@arm.com>
Subject: Re: [PATCH 1/2] ARM: drop unnecessary WASM
Date: Tue, 5 Mar 2019 16:47:55 -0800 [thread overview]
Message-ID: <CAKwvOdnb58nGXdweWTobGjqry7=9ZmfnMWnjTn8uHKt=Z5iabQ@mail.gmail.com> (raw)
In-Reply-To: <cdf451c0-3947-9be1-3bee-2366577c4c5f@arm.com>
On Tue, Mar 5, 2019 at 3:39 PM Robin Murphy <robin.murphy@arm.com> wrote:
>
> Hi Stefan,
>
> On 2019-03-05 10:18 pm, Stefan Agner wrote:
> > The W macro for generating wide instructions when targeting Thumb-2
> > is not required for the preload data instructions (pld, pldw) since
> > they are only available as wide instructions. The GNU assembler seems
> > to work with or without the .w appended when compiling an Thumb-2
> > kernel. However, Clang's integrated assembler does not consider the
> > .w variants as valid instructions:
> >
> > ./arch/arm/include/asm/processor.h:133:5: error: invalid instruction
> > "pldw.w\t%a0 \n"
> > ^
> > <inline asm>:2:1: note: instantiated into assembly here
> > pldw.w [r0]
> > ^
> > 1 error generated.
>
> Have you filed a bug against Clang for that? Something like "pldwal.w"
Yes; please. For each deficiency you find, please file a bug. We're
working on identifying what's missing from Clang's integrated
assembler support. Given the list of issues, it's easier to estimate
how much effort is needed, which helps us allocate resources towards
fixing those issues better.
It would be good to know if pldw.w is valid under UAL or not.
Hopefully, the ARM kernel team can stress the importance of assembler
support for their ISA to their LLVM team.
--
Thanks,
~Nick Desaulniers
WARNING: multiple messages have this Message-ID (diff)
From: Nick Desaulniers <ndesaulniers@google.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
julien.thierry@arm.com, Will Deacon <will.deacon@arm.com>,
Russell King <linux@armlinux.org.uk>,
Stefan Agner <stefan@agner.ch>,
LKML <linux-kernel@vger.kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Kristof Beyls <Kristof.Beyls@arm.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Peter Smith <Peter.Smith@arm.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] ARM: drop unnecessary WASM
Date: Tue, 5 Mar 2019 16:47:55 -0800 [thread overview]
Message-ID: <CAKwvOdnb58nGXdweWTobGjqry7=9ZmfnMWnjTn8uHKt=Z5iabQ@mail.gmail.com> (raw)
In-Reply-To: <cdf451c0-3947-9be1-3bee-2366577c4c5f@arm.com>
On Tue, Mar 5, 2019 at 3:39 PM Robin Murphy <robin.murphy@arm.com> wrote:
>
> Hi Stefan,
>
> On 2019-03-05 10:18 pm, Stefan Agner wrote:
> > The W macro for generating wide instructions when targeting Thumb-2
> > is not required for the preload data instructions (pld, pldw) since
> > they are only available as wide instructions. The GNU assembler seems
> > to work with or without the .w appended when compiling an Thumb-2
> > kernel. However, Clang's integrated assembler does not consider the
> > .w variants as valid instructions:
> >
> > ./arch/arm/include/asm/processor.h:133:5: error: invalid instruction
> > "pldw.w\t%a0 \n"
> > ^
> > <inline asm>:2:1: note: instantiated into assembly here
> > pldw.w [r0]
> > ^
> > 1 error generated.
>
> Have you filed a bug against Clang for that? Something like "pldwal.w"
Yes; please. For each deficiency you find, please file a bug. We're
working on identifying what's missing from Clang's integrated
assembler support. Given the list of issues, it's easier to estimate
how much effort is needed, which helps us allocate resources towards
fixing those issues better.
It would be good to know if pldw.w is valid under UAL or not.
Hopefully, the ARM kernel team can stress the importance of assembler
support for their ISA to their LLVM team.
--
Thanks,
~Nick Desaulniers
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-06 0:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 22:18 [PATCH 1/2] ARM: drop unnecessary WASM Stefan Agner
2019-03-05 22:18 ` Stefan Agner
2019-03-05 22:18 ` [PATCH 2/2] ARM: drop -mauto-it Stefan Agner
2019-03-05 22:18 ` Stefan Agner
2019-03-05 22:21 ` Nick Desaulniers
2019-03-05 22:21 ` Nick Desaulniers
2019-03-05 22:40 ` Stefan Agner
2019-03-05 22:40 ` Stefan Agner
2019-03-05 23:20 ` Nick Desaulniers
2019-03-05 23:20 ` Nick Desaulniers
2019-03-05 23:39 ` [PATCH 1/2] ARM: drop unnecessary WASM Robin Murphy
2019-03-05 23:39 ` Robin Murphy
2019-03-06 0:47 ` Nick Desaulniers [this message]
2019-03-06 0:47 ` Nick Desaulniers
2019-03-17 15:44 ` Stefan Agner
2019-03-17 15:44 ` Stefan Agner
2019-03-06 7:58 ` Stefan Agner
2019-03-06 7:58 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOdnb58nGXdweWTobGjqry7=9ZmfnMWnjTn8uHKt=Z5iabQ@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=Kristof.Beyls@arm.com \
--cc=Peter.Smith@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=julien.thierry@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=natechancellor@gmail.com \
--cc=nicolas.pitre@linaro.org \
--cc=robin.murphy@arm.com \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.