From: Robin Murphy <robin.murphy@arm.com> To: Stefan Agner <stefan@agner.ch>, linux@armlinux.org.uk Cc: nicolas.pitre@linaro.org, mark.rutland@arm.com, arnd@arndb.de, ard.biesheuvel@linaro.org, will.deacon@arm.com, julien.thierry@arm.com, ndesaulniers@google.com, linux-kernel@vger.kernel.org, thierry.reding@gmail.com, natechancellor@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] ARM: drop unnecessary WASM Date: Tue, 5 Mar 2019 23:39:13 +0000 [thread overview] Message-ID: <cdf451c0-3947-9be1-3bee-2366577c4c5f@arm.com> (raw) In-Reply-To: <13835555f8ef44b21d1b7ddfe1c4203d0981f77e.1551824161.git.stefan@agner.ch> Hi Stefan, On 2019-03-05 10:18 pm, Stefan Agner wrote: > The W macro for generating wide instructions when targeting Thumb-2 > is not required for the preload data instructions (pld, pldw) since > they are only available as wide instructions. The GNU assembler seems > to work with or without the .w appended when compiling an Thumb-2 > kernel. However, Clang's integrated assembler does not consider the > .w variants as valid instructions: > > ./arch/arm/include/asm/processor.h:133:5: error: invalid instruction > "pldw.w\t%a0 \n" > ^ > <inline asm>:2:1: note: instantiated into assembly here > pldw.w [r0] > ^ > 1 error generated. Have you filed a bug against Clang for that? Something like "pldwal.w" may be super-redundant, but it's still perfectly valid syntax. The "Standard assembler syntax fields" section of the Arm ARM even calls out that "...the .W qualifier has no effect" on ARM/A32 instructions since they are inherently 32-bit; that should equally apply for 32-bit only Thumb/T32 instructions. There are certainly a few instructions which don't allow a condition code (even "AL"), but off-hand I don't remember any not having the optional {<q>} field in their syntax. That said, obviously the patch itself is no problem since the syntax *is* redundant here, but it really is just a workaround for an assembler bug. Robin. > Drop the macro to make sure non-wide variants of pld and pldw are > emitted in all cases. > > Signed-off-by: Stefan Agner <stefan@agner.ch> > --- > arch/arm/include/asm/processor.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/include/asm/processor.h b/arch/arm/include/asm/processor.h > index 120f4c9bbfde..042d77cf686d 100644 > --- a/arch/arm/include/asm/processor.h > +++ b/arch/arm/include/asm/processor.h > @@ -131,8 +131,8 @@ static inline void prefetchw(const void *ptr) > __asm__ __volatile__( > ".arch_extension mp\n" > __ALT_SMP_ASM( > - WASM(pldw) "\t%a0", > - WASM(pld) "\t%a0" > + "pldw\t%a0", > + "pld\t%a0" > ) > :: "p" (ptr)); > } >
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com> To: Stefan Agner <stefan@agner.ch>, linux@armlinux.org.uk Cc: nicolas.pitre@linaro.org, mark.rutland@arm.com, arnd@arndb.de, julien.thierry@arm.com, ndesaulniers@google.com, ard.biesheuvel@linaro.org, will.deacon@arm.com, linux-kernel@vger.kernel.org, thierry.reding@gmail.com, natechancellor@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] ARM: drop unnecessary WASM Date: Tue, 5 Mar 2019 23:39:13 +0000 [thread overview] Message-ID: <cdf451c0-3947-9be1-3bee-2366577c4c5f@arm.com> (raw) In-Reply-To: <13835555f8ef44b21d1b7ddfe1c4203d0981f77e.1551824161.git.stefan@agner.ch> Hi Stefan, On 2019-03-05 10:18 pm, Stefan Agner wrote: > The W macro for generating wide instructions when targeting Thumb-2 > is not required for the preload data instructions (pld, pldw) since > they are only available as wide instructions. The GNU assembler seems > to work with or without the .w appended when compiling an Thumb-2 > kernel. However, Clang's integrated assembler does not consider the > .w variants as valid instructions: > > ./arch/arm/include/asm/processor.h:133:5: error: invalid instruction > "pldw.w\t%a0 \n" > ^ > <inline asm>:2:1: note: instantiated into assembly here > pldw.w [r0] > ^ > 1 error generated. Have you filed a bug against Clang for that? Something like "pldwal.w" may be super-redundant, but it's still perfectly valid syntax. The "Standard assembler syntax fields" section of the Arm ARM even calls out that "...the .W qualifier has no effect" on ARM/A32 instructions since they are inherently 32-bit; that should equally apply for 32-bit only Thumb/T32 instructions. There are certainly a few instructions which don't allow a condition code (even "AL"), but off-hand I don't remember any not having the optional {<q>} field in their syntax. That said, obviously the patch itself is no problem since the syntax *is* redundant here, but it really is just a workaround for an assembler bug. Robin. > Drop the macro to make sure non-wide variants of pld and pldw are > emitted in all cases. > > Signed-off-by: Stefan Agner <stefan@agner.ch> > --- > arch/arm/include/asm/processor.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/include/asm/processor.h b/arch/arm/include/asm/processor.h > index 120f4c9bbfde..042d77cf686d 100644 > --- a/arch/arm/include/asm/processor.h > +++ b/arch/arm/include/asm/processor.h > @@ -131,8 +131,8 @@ static inline void prefetchw(const void *ptr) > __asm__ __volatile__( > ".arch_extension mp\n" > __ALT_SMP_ASM( > - WASM(pldw) "\t%a0", > - WASM(pld) "\t%a0" > + "pldw\t%a0", > + "pld\t%a0" > ) > :: "p" (ptr)); > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-05 23:39 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-05 22:18 [PATCH 1/2] ARM: drop unnecessary WASM Stefan Agner 2019-03-05 22:18 ` Stefan Agner 2019-03-05 22:18 ` [PATCH 2/2] ARM: drop -mauto-it Stefan Agner 2019-03-05 22:18 ` Stefan Agner 2019-03-05 22:21 ` Nick Desaulniers 2019-03-05 22:21 ` Nick Desaulniers 2019-03-05 22:40 ` Stefan Agner 2019-03-05 22:40 ` Stefan Agner 2019-03-05 23:20 ` Nick Desaulniers 2019-03-05 23:20 ` Nick Desaulniers 2019-03-05 23:39 ` Robin Murphy [this message] 2019-03-05 23:39 ` [PATCH 1/2] ARM: drop unnecessary WASM Robin Murphy 2019-03-06 0:47 ` Nick Desaulniers 2019-03-06 0:47 ` Nick Desaulniers 2019-03-17 15:44 ` Stefan Agner 2019-03-17 15:44 ` Stefan Agner 2019-03-06 7:58 ` Stefan Agner 2019-03-06 7:58 ` Stefan Agner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cdf451c0-3947-9be1-3bee-2366577c4c5f@arm.com \ --to=robin.murphy@arm.com \ --cc=ard.biesheuvel@linaro.org \ --cc=arnd@arndb.de \ --cc=julien.thierry@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=mark.rutland@arm.com \ --cc=natechancellor@gmail.com \ --cc=ndesaulniers@google.com \ --cc=nicolas.pitre@linaro.org \ --cc=stefan@agner.ch \ --cc=thierry.reding@gmail.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.