From: Geert Uytterhoeven <geert@linux-m68k.org> To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Cc: Magnus Damm <magnus.damm@gmail.com>, Rob Herring <robh+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Thomas Gleixner <tglx@linutronix.de>, Jason Cooper <jason@lakedaemon.net>, Marc Zyngier <maz@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Russell King <linux@armlinux.org.uk>, Lad Prabhakar <prabhakar.csengg@gmail.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, dmaengine <dmaengine@vger.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 07/18] ARM: dts: r8a7742: Initial SoC device tree Date: Thu, 30 Apr 2020 15:49:17 +0200 [thread overview] Message-ID: <CAMuHMdU90pqCVd=jombH-JMomoCDe1tA8Lq=m0urACK67ZNYuw@mail.gmail.com> (raw) In-Reply-To: <1588197415-13747-8-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> Hi Prabhakar, Thanks for your patch! On Wed, Apr 29, 2020 at 11:58 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > Basic support for the RZ/G1H (R8A7742) SoC. Added placeholders > for the peripherals supported by the SoC which will be filled up > by incremental patches. Please remove the placeholders, as there is nothing that depends on their presence. > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > --- /dev/null > +++ b/arch/arm/boot/dts/r8a7742.dtsi > @@ -0,0 +1,715 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Device Tree Source for the r8a7742 SoC > + * > + * Copyright (C) 2020 Renesas Electronics Corp. > + */ > + > +#include <dt-bindings/interrupt-controller/irq.h> > +#include <dt-bindings/interrupt-controller/arm-gic.h> > +#include <dt-bindings/clock/r8a7742-cpg-mssr.h> > +#include <dt-bindings/power/r8a7742-sysc.h> > + > +/ { > + compatible = "renesas,r8a7742"; > + #address-cells = <2>; > + #size-cells = <2>; > + > + /* > + * The external audio clocks are configured as 0 Hz fixed frequency > + * clocks by default. > + * Boards that provide audio clocks should override them. > + */ > + audio_clk_a: audio_clk_a { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <0>; > + }; > + > + audio_clk_b: audio_clk_b { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <0>; > + }; > + > + audio_clk_c: audio_clk_c { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <0>; > + }; > + > + /* External CAN clock */ > + can_clk: can { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + /* This value must be overridden by the board. */ > + clock-frequency = <0>; > + }; Please drop the audio and CAN clocks for now, as they are not used. > + /* External root clock */ > + extal_clk: extal { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + /* This value must be overridden by the board. */ > + clock-frequency = <0>; > + }; > + > + /* External PCIe clock - can be overridden by the board */ > + pcie_bus_clk: pcie_bus { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <0>; > + }; Please drop the PCI clock for now, as it is not used. > + > + /* External SCIF clock */ > + scif_clk: scif { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + /* This value must be overridden by the board. */ > + clock-frequency = <0>; > + }; This should be used (see below). > + > + /* External USB clock - can be overridden by the board */ > + usb_extal_clk: usb_extal { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <48000000>; > + }; > + > + cpus { Please sort nodes by unit-address (if present) per type, or alphabetically. > + soc { > + scifa2: serial@e6c60000 { > + reg = <0 0xe6c60000 0 0x40>; > + /* placeholder */ > + }; I prefer to see a real node for the serial console, so the system can at least be boot tested to a console prompt. Note that this requires adding a minimal board DTS, too. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Jason Cooper <jason@lakedaemon.net>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, Marc Zyngier <maz@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Magnus Damm <magnus.damm@gmail.com>, Russell King <linux@armlinux.org.uk>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>, Lad Prabhakar <prabhakar.csengg@gmail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, dmaengine <dmaengine@vger.kernel.org>, Thomas Gleixner <tglx@linutronix.de>, "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 07/18] ARM: dts: r8a7742: Initial SoC device tree Date: Thu, 30 Apr 2020 15:49:17 +0200 [thread overview] Message-ID: <CAMuHMdU90pqCVd=jombH-JMomoCDe1tA8Lq=m0urACK67ZNYuw@mail.gmail.com> (raw) In-Reply-To: <1588197415-13747-8-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> Hi Prabhakar, Thanks for your patch! On Wed, Apr 29, 2020 at 11:58 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > Basic support for the RZ/G1H (R8A7742) SoC. Added placeholders > for the peripherals supported by the SoC which will be filled up > by incremental patches. Please remove the placeholders, as there is nothing that depends on their presence. > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > --- /dev/null > +++ b/arch/arm/boot/dts/r8a7742.dtsi > @@ -0,0 +1,715 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Device Tree Source for the r8a7742 SoC > + * > + * Copyright (C) 2020 Renesas Electronics Corp. > + */ > + > +#include <dt-bindings/interrupt-controller/irq.h> > +#include <dt-bindings/interrupt-controller/arm-gic.h> > +#include <dt-bindings/clock/r8a7742-cpg-mssr.h> > +#include <dt-bindings/power/r8a7742-sysc.h> > + > +/ { > + compatible = "renesas,r8a7742"; > + #address-cells = <2>; > + #size-cells = <2>; > + > + /* > + * The external audio clocks are configured as 0 Hz fixed frequency > + * clocks by default. > + * Boards that provide audio clocks should override them. > + */ > + audio_clk_a: audio_clk_a { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <0>; > + }; > + > + audio_clk_b: audio_clk_b { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <0>; > + }; > + > + audio_clk_c: audio_clk_c { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <0>; > + }; > + > + /* External CAN clock */ > + can_clk: can { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + /* This value must be overridden by the board. */ > + clock-frequency = <0>; > + }; Please drop the audio and CAN clocks for now, as they are not used. > + /* External root clock */ > + extal_clk: extal { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + /* This value must be overridden by the board. */ > + clock-frequency = <0>; > + }; > + > + /* External PCIe clock - can be overridden by the board */ > + pcie_bus_clk: pcie_bus { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <0>; > + }; Please drop the PCI clock for now, as it is not used. > + > + /* External SCIF clock */ > + scif_clk: scif { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + /* This value must be overridden by the board. */ > + clock-frequency = <0>; > + }; This should be used (see below). > + > + /* External USB clock - can be overridden by the board */ > + usb_extal_clk: usb_extal { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <48000000>; > + }; > + > + cpus { Please sort nodes by unit-address (if present) per type, or alphabetically. > + soc { > + scifa2: serial@e6c60000 { > + reg = <0 0xe6c60000 0 0x40>; > + /* placeholder */ > + }; I prefer to see a real node for the serial console, so the system can at least be boot tested to a console prompt. Note that this requires adding a minimal board DTS, too. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-30 13:49 UTC|newest] Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-29 21:56 [PATCH 00/18] Add R8A7742/RZG1H board support Lad Prabhakar 2020-04-29 21:56 ` Lad Prabhakar 2020-04-29 21:56 ` [PATCH 01/18] soc: renesas: Add Renesas R8A7742 config option Lad Prabhakar 2020-04-29 21:56 ` Lad Prabhakar 2020-04-30 12:57 ` Geert Uytterhoeven 2020-04-30 12:57 ` Geert Uytterhoeven 2020-04-29 21:56 ` [PATCH 02/18] ARM: shmobile: defconfig: Enable r8a7742 SoC Lad Prabhakar 2020-04-29 21:56 ` Lad Prabhakar 2020-04-30 12:58 ` Geert Uytterhoeven 2020-04-30 12:58 ` Geert Uytterhoeven 2020-04-29 21:56 ` [PATCH 03/18] ARM: multi_v7_defconfig: " Lad Prabhakar 2020-04-29 21:56 ` Lad Prabhakar 2020-04-30 12:59 ` Geert Uytterhoeven 2020-04-30 12:59 ` Geert Uytterhoeven 2020-04-29 21:56 ` [PATCH 04/18] ARM: debug-ll: Add support for r8a7742 Lad Prabhakar 2020-04-29 21:56 ` Lad Prabhakar 2020-04-29 21:59 ` Russell King - ARM Linux admin 2020-04-29 21:59 ` Russell King - ARM Linux admin 2020-04-29 22:03 ` Lad, Prabhakar 2020-04-29 22:03 ` Lad, Prabhakar 2020-04-30 13:03 ` Geert Uytterhoeven 2020-04-30 13:03 ` Geert Uytterhoeven 2020-05-01 8:19 ` Lad, Prabhakar 2020-05-01 8:19 ` Lad, Prabhakar 2020-04-29 21:56 ` [PATCH 05/18] dt-bindings: pinctrl: sh-pfc: Document r8a7742 PFC support Lad Prabhakar 2020-04-29 21:56 ` Lad Prabhakar 2020-04-30 13:04 ` Geert Uytterhoeven 2020-04-30 13:04 ` Geert Uytterhoeven 2020-04-29 21:56 ` [PATCH 06/18] pinctrl: sh-pfc: r8a7790: Add " Lad Prabhakar 2020-04-29 21:56 ` Lad Prabhakar 2020-04-30 13:17 ` Geert Uytterhoeven 2020-04-30 13:17 ` Geert Uytterhoeven 2020-05-01 8:08 ` Lad, Prabhakar 2020-05-01 8:08 ` Lad, Prabhakar 2020-04-29 21:56 ` [PATCH 07/18] ARM: dts: r8a7742: Initial SoC device tree Lad Prabhakar 2020-04-29 21:56 ` Lad Prabhakar 2020-04-30 13:49 ` Geert Uytterhoeven [this message] 2020-04-30 13:49 ` Geert Uytterhoeven 2020-05-01 8:15 ` Lad, Prabhakar 2020-05-01 8:15 ` Lad, Prabhakar 2020-04-29 21:56 ` [PATCH 08/18] dt-bindings: irqchip: renesas-irqc: Document r8a7742 bindings Lad Prabhakar 2020-04-29 21:56 ` Lad Prabhakar 2020-04-30 13:52 ` Geert Uytterhoeven 2020-04-30 13:52 ` Geert Uytterhoeven 2020-04-29 21:56 ` [PATCH 09/18] ARM: dts: r8a7742: Add IRQC support Lad Prabhakar 2020-04-29 21:56 ` Lad Prabhakar 2020-04-30 13:54 ` Geert Uytterhoeven 2020-04-30 13:54 ` Geert Uytterhoeven 2020-04-30 14:01 ` Marc Zyngier 2020-04-30 14:01 ` Marc Zyngier 2020-04-30 14:04 ` Geert Uytterhoeven 2020-04-30 14:04 ` Geert Uytterhoeven 2020-04-29 21:56 ` [PATCH 10/18] dt-bindings: rcar-dmac: Document r8a7742 support Lad Prabhakar 2020-04-29 21:56 ` Lad Prabhakar 2020-04-30 13:56 ` Geert Uytterhoeven 2020-04-30 13:56 ` Geert Uytterhoeven 2020-04-29 21:56 ` [PATCH 11/18] ARM: dts: r8a7742: Add SYS-DMAC support Lad Prabhakar 2020-04-29 21:56 ` Lad Prabhakar 2020-04-30 14:00 ` Geert Uytterhoeven 2020-04-30 14:00 ` Geert Uytterhoeven 2020-04-29 21:56 ` [PATCH 12/18] dt-bindings: serial: renesas,scif: Document r8a7742 bindings Lad Prabhakar 2020-04-29 21:56 ` [PATCH 12/18] dt-bindings: serial: renesas, scif: " Lad Prabhakar 2020-04-30 14:01 ` [PATCH 12/18] dt-bindings: serial: renesas,scif: " Geert Uytterhoeven 2020-04-30 14:01 ` [PATCH 12/18] dt-bindings: serial: renesas, scif: " Geert Uytterhoeven 2020-04-29 21:56 ` [PATCH 13/18] dt-bindings: serial: renesas,scifa: " Lad Prabhakar 2020-04-29 21:56 ` [PATCH 13/18] dt-bindings: serial: renesas, scifa: " Lad Prabhakar 2020-04-30 14:02 ` [PATCH 13/18] dt-bindings: serial: renesas,scifa: " Geert Uytterhoeven 2020-04-30 14:02 ` Geert Uytterhoeven 2020-04-29 21:56 ` [PATCH 14/18] dt-bindings: serial: renesas,scifb: " Lad Prabhakar 2020-04-29 21:56 ` [PATCH 14/18] dt-bindings: serial: renesas, scifb: " Lad Prabhakar 2020-04-30 14:03 ` [PATCH 14/18] dt-bindings: serial: renesas,scifb: " Geert Uytterhoeven 2020-04-30 14:03 ` Geert Uytterhoeven 2020-04-29 21:56 ` [PATCH 15/18] dt-bindings: serial: renesas,hscif: " Lad Prabhakar 2020-04-29 21:56 ` [PATCH 15/18] dt-bindings: serial: renesas, hscif: " Lad Prabhakar 2020-04-30 14:03 ` [PATCH 15/18] dt-bindings: serial: renesas,hscif: " Geert Uytterhoeven 2020-04-30 14:03 ` Geert Uytterhoeven 2020-04-29 21:56 ` [PATCH 16/18] ARM: dts: r8a7742: Add [H]SCIF{A|B} support Lad Prabhakar 2020-04-29 21:56 ` Lad Prabhakar 2020-04-30 14:27 ` Geert Uytterhoeven 2020-04-30 14:27 ` Geert Uytterhoeven 2020-04-29 21:56 ` [PATCH 17/18] dt-bindings: gpio: rcar: Add r8a7742 (RZ/G1H) support Lad Prabhakar 2020-04-29 21:56 ` Lad Prabhakar 2020-04-30 14:28 ` Geert Uytterhoeven 2020-04-30 14:28 ` Geert Uytterhoeven 2020-05-12 14:52 ` Rob Herring 2020-05-12 14:52 ` Rob Herring 2020-05-12 14:56 ` Geert Uytterhoeven 2020-05-12 14:56 ` Geert Uytterhoeven 2020-04-29 21:56 ` [PATCH 18/18] ARM: dts: r8a7742: Add GPIO support Lad Prabhakar 2020-04-29 21:56 ` Lad Prabhakar 2020-04-30 14:37 ` Geert Uytterhoeven 2020-04-30 14:37 ` Geert Uytterhoeven 2020-05-01 8:27 ` [PATCH 00/18] Add R8A7742/RZG1H board support Lad, Prabhakar 2020-05-01 8:27 ` Lad, Prabhakar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMuHMdU90pqCVd=jombH-JMomoCDe1tA8Lq=m0urACK67ZNYuw@mail.gmail.com' \ --to=geert@linux-m68k.org \ --cc=bgolaszewski@baylibre.com \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=jason@lakedaemon.net \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=magnus.damm@gmail.com \ --cc=maz@kernel.org \ --cc=prabhakar.csengg@gmail.com \ --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \ --cc=robh+dt@kernel.org \ --cc=tglx@linutronix.de \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.