Re: [PATCH v2 09/15] pmdomain: renesas: r8a779h0-sysc: Add r8a779h0 support

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	 Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Philipp Zabel <p.zabel@pengutronix.de>,
	Magnus Damm <magnus.damm@gmail.com>,
	 Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	 Ulf Hansson <ulf.hansson@linaro.org>,
	Cong Dang <cong.dang.xn@renesas.com>,
	 Duy Nguyen <duy.nguyen.rh@renesas.com>,
	Hai Pham <hai.pham.ud@renesas.com>,
	 Linh Phung <linh.phung.jy@renesas.com>,
	linux-renesas-soc@vger.kernel.org,  linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 09/15] pmdomain: renesas: r8a779h0-sysc: Add r8a779h0 support
Date: Fri, 26 Jan 2024 09:13:05 +0100	[thread overview]
Message-ID: <CAMuHMdUBPdiSqgkZOs2nddvk_xEVe3m7sZ51XC20Optcp+pVLg@mail.gmail.com> (raw)
In-Reply-To: <20240125184650.GO4126432@ragnatech.se>

Hi Niklas,

On Thu, Jan 25, 2024 at 7:46 PM Niklas Söderlund
<niklas.soderlund@ragnatech.se> wrote:
> On 2024-01-25 16:34:37 +0100, Geert Uytterhoeven wrote:
> > From: Duy Nguyen <duy.nguyen.rh@renesas.com>
> >
> > Add support for R-Car V4M (R8A779H0) SoC power areas to the R-Car SYSC
> > driver.
> >
> > Signed-off-by: Duy Nguyen <duy.nguyen.rh@renesas.com>
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > v2:
> >   - Add vendor-prefix to DT binding definition header file.

> > --- /dev/null
> > +++ b/drivers/pmdomain/renesas/r8a779h0-sysc.c
> > @@ -0,0 +1,55 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Renesas R-Car V4M System Controller
> > + *
> > + * Copyright (C) 2016-2017 Glider bvba
>
> Is 2016-2017 correct? With or without that fixed,

That must have been copied from r8a7795-sysc.c...
As the layout of R-Car V4M is completely different from R-Car H3,
I will drop that line (with or without reposting).

> Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel