All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
	Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Subject: Re: [PATCH 1/2] arm64: dts: renesas: r9a07g044: Add gpu cooling device
Date: Wed, 3 May 2023 12:28:26 +0200	[thread overview]
Message-ID: <CAMuHMdUs=F3ePP1P5OTbf9cut1wrbov=YEsyZEnKToBaFK0qNA@mail.gmail.com> (raw)
In-Reply-To: <20230425155237.357592-2-biju.das.jz@bp.renesas.com>

Hi Biju,

On Tue, Apr 25, 2023 at 5:52 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Add gpu cooling device for passive control.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> @@ -970,6 +970,7 @@ gpu: gpu@11840000 {
>                                  <&cpg R9A07G044_GPU_ACE_RESETN>;
>                         reset-names = "rst", "axi_rst", "ace_rst";
>                         operating-points-v2 = <&gpu_opp_table>;
> +                       #cooling-cells = <2>;
>                 };
>
>                 gic: interrupt-controller@11900000 {
> @@ -1245,6 +1246,11 @@ map0 {
>                                         cooling-device = <&cpu0 0 2>;
>                                         contribution = <1024>;
>                                 };
> +
> +                               map1 {
> +                                       trip = <&target>;
> +                                       cooling-device = <&gpu 0 2>;

Perhaps this needs a "contribution" property, as the CPU device in
the same zone has one?

> +                               };
>                         };
>
>                         trips {

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2023-05-03 10:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25 15:52 [PATCH 0/2] Add GPU cooling device support Biju Das
2023-04-25 15:52 ` [PATCH 1/2] arm64: dts: renesas: r9a07g044: Add gpu cooling device Biju Das
2023-05-03 10:28   ` Geert Uytterhoeven [this message]
2023-05-04  7:06     ` Biju Das
2023-04-25 15:52 ` [PATCH 2/2] arm64: dts: renesas: r9a07g054: " Biju Das
2023-11-01 18:37 ` [PATCH 0/2] Add GPU cooling device support Biju Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdUs=F3ePP1P5OTbf9cut1wrbov=YEsyZEnKToBaFK0qNA@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.