All of lore.kernel.org
 help / color / mirror / Atom feed
From: Biju Das <biju.das.jz@bp.renesas.com>
To: Biju Das <biju.das.jz@bp.renesas.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Subject: RE: [PATCH 0/2] Add GPU cooling device support
Date: Wed, 1 Nov 2023 18:37:02 +0000	[thread overview]
Message-ID: <TYCPR01MB11269BF61D52CD6C4C5EC915986A7A@TYCPR01MB11269.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20230425155237.357592-1-biju.das.jz@bp.renesas.com>

Hi All,

> Subject: [PATCH 0/2] Add GPU cooling device support
> 
> Add GPU cooling device support for RZ/{G2L,G2LC,V2L} SMARC EVK.

I would like to drop this patch series as there is no thermal
Sensor unit available in mali gpu and there is no point in
Throttling GPU on high temp for the cases like GPU is on light load, but other loads on the system is very high.

Cheers,
Biju

> 
> This patch series is tested with [1],  [2] and [3]
> 
> Logs:
> root@smarc-rzg2l:~# systemctl stop weston@root root@smarc-rzg2l:~# kmscube
> Using display 0xaaaacf0775e0 with EGL version 1.4
> ===================================
> EGL information:
>   version: "1.4"
>   vendor: "Mesa Project"
>   client extensions: "EGL_EXT_client_extensions EGL_EXT_device_base
> EGL_EXT_device_enumeration EGL_EXT_device_query EGL_EXT_platform_base
> EGL_KHR_client_get_all_proc_addresses EGL_KHR_debug EGL_EXT_platform_device
> EGL_EXT_platform_wayland EGL_KHR_platform_wayland EGL_MESA_platform_gbm
> EGL_KHR_platform_gbm EGL_MESA_platform_surfaceless"
>   display extensions: "EGL_ANDROID_blob_cache EGL_EXT_buffer_age
> EGL_EXT_image_dma_buf_import EGL_EXT_image_dma_buf_import_modifiers
> EGL_KHR_cl_event2 EGL_KHR_config_attribs EGL_KHR_create_context
> EGL_KHR_create_context_no_error EGL_KHR_fence_sync
> EGL_KHR_get_all_proc_addresses EGL_KHR_gl_colorspace
> EGL_KHR_gl_renderbuffer_image EGL_KHR_gl_texture_2D_image
> EGL_KHR_gl_texture_3D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_image
> EGL_KHR_image_base EGL_KHR_image_pixmap EGL_KHR_no_config_context
> EGL_KHR_partial_update EGL_KHR_reusable_sync EGL_KHR_surfaceless_context
> EGL_EXT_pixel_format_float EGL_KHR_wait_sync EGL_MESA_configless_context
> EGL_MESA_drm_image EGL_MESA_image_dma_buf_export EGL_MESA_query_driver
> EGL_WL_bind_wayland_display "
> ===================================
> OpenGL ES 2.x information:
>   version: "OpenGL ES 3.1 Mesa 21.3.0"
>   shading language version: "OpenGL ES GLSL ES 3.10"
>   vendor: "Panfrost"
>   renderer: "Mali-G31 (Panfrost)"
>   extensions: "GL_EXT_blend_minmax GL_EXT_multi_draw_arrays
> GL_EXT_texture_filter_anisotropic GL_EXT_texture_compression_rgtc
> GL_EXT_texture_format_BGRA8888 GL_OES_compressed_ETC1_RGB8_texture
> GL_OES_depth24 GL_OES_element_index_uint GL_OES_fbo_render_mipmap
> GL_OES_mapbuffer GL_OES_rgb8_rgba8 GL_OES_standard_derivatives
> GL_OES_stencil8 GL_OES_texture_3D GL_OES_texture_float
> GL_OES_texture_float_linear GL_OES_texture_half_float
> GL_OES_texture_half_float_linear GL_OES_texture_npot
> GL_OES_vertex_half_float GL_EXT_draw_instanced GL_EXT_texture_sRGB_decode
> GL_OES_EGL_image GL_OES_depth_texture GL_OES_packed_depth_stencil
> GL_EXT_texture_type_2_10_10_10_REV GL_NV_conditional_render
> GL_OES_get_program_binary GL_APPLE_texture_max_level
> GL_EXT_discard_framebuffer GL_EXT_read_format_bgra GL_EXT_frag_depth
> GL_NV_fbo_color_attachments GL_OES_EGL_image_external GL_OES_EGL_sync
> GL_OES_vertex_array_object GL_ANGLE_pack_reverse_row_order
> GL_EXT_occlusion_query_boolean GL_EXT_texture_rg GL_EXT_unpack_subimage
> GL_NV_draw_buffers GL_NV_read_buffer GL_NV_read_depth
> GL_NV_read_depth_stencil GL_NV_read_stencil GL_EXT_draw_buffers
> GL_EXT_map_buffer_range GL_KHR_debug GL_KHR_texture_compression_astc_ldr
> GL_NV_pixel_buffer_object GL_OES_depth_texture_cube_map
> GL_OES_required_internalformat GL_OES_surfaceless_context
> GL_EXT_color_buffer_float GL_EXT_sRGB_write_control
> GL_EXT_separate_shader_objects GL_EXT_shader_framebuffer_fetch
> GL_EXT_shader_implicit_conversions GL_EXT_shader_integer_mix
> GL_EXT_base_instance GL_EXT_compressed_ETC1_RGB8_sub_texture
> GL_EXT_draw_buffers_indexed GL_EXT_draw_elements_base_vertex
> GL_EXT_gpu_shader5 GL_EXT_primitive_bounding_box GL_EXT_shader_io_blocks
> GL_EXT_texture_border_clamp GL_EXT_texture_buffer GL_EXT_texture_view
> GL_KHR_blend_equation_advanced GL_KHR_blend_equation_advanced_coherent
> GL_KHR_context_flush_control GL_NV_image_formats
> GL_OES_draw_buffers_indexed GL_OES_draw_elements_base_vertex
> GL_OES_gpu_shader5 GL_OES_primitive_bounding_box GL_OES_sample_shading
> GL_OES_sample_variables GL_OES_shader_io_blocks
> GL_OES_shader_multisample_interpolation GL_OES_texture_border_clamp
> GL_OES_texture_buffer GL_OES_texture_stencil8
> GL_OES_texture_storage_multisample_2d_array GL_OES_texture_view
> GL_EXT_blend_func_extended GL_EXT_float_blend GL_EXT_texture_sRGB_R8
> GL_EXT_texture_sRGB_RG8 GL_KHR_no_error
> GL_KHR_texture_compression_astc_sliced_3d GL_OES_EGL_image_external_essl3
> GL_OES_shader_image_atomic GL_EXT_multisampled_render_to_texture
> GL_EXT_multisampled_render_to_texture2 GL_MESA_shader_integer_functions
> GL_EXT_color_buffer_half_float GL_EXT_texture_mirror_clamp_to_edge
> GL_KHR_parallel_shader_compile GL_EXT_EGL_image_storage
> GL_EXT_shader_framebuffer_fetch_non_coherent GL_INTEL_blackhole_render
> GL_MESA_framebuffer_flip_y GL_EXT_depth_clamp GL_MESA_bgra "
> ===================================
> ^C
> root@smarc-rzg2l:~# cat /proc/interrupts | grep panfrost
>  82:         15          0     GICv3 185 Level     panfrost-gpu
>  83:          2          0     GICv3 187 Level     panfrost-mmu
>  84:      12667          0     GICv3 186 Level     panfrost-job
> root@smarc-rzg2l:~# cat /sys/class/devfreq/11840000.gpu/trans_stat
>      From  :   To
>            :  50000000  62500000 100000000 125000000 200000000 250000000
> 400000000 500000000   time(ms)
> *  50000000:         0         0         0         0         0         0
> 0         2       292
>    62500000:         0         0         0         0         0         0
> 0         0         0
>   100000000:         0         0         0         0         0         0
> 0         0         0
>   125000000:         0         0         0         0         0         0
> 0         1        56
>   200000000:         0         0         0         0         0         0
> 0       630     35624
>   250000000:         0         0         0         1       540         0
> 0         0     34484
>   400000000:         0         0         0         0         0         0
> 0         2       112
>   500000000:         3         0         0         0        90       541
> 2         0     36524
> Total transition : 1812
> root@smarc-rzg2l:~#
> 
> [1]
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork
> .kernel.org%2Fproject%2Flinux-renesas-
> soc%2Flist%2F%3Fseries%3D742810&data=05%7C01%7Cbiju.das.jz%40bp.renesas.com
> %7C96654dd2de224f1721f408db45a51b15%7C53d82571da1947e49cb4625a166a4a2a%7C0%
> 7C0%7C638180347643845748%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj
> oiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MK9BBWareYh%
> 2BnLpSAV%2Fjfmt7Gz8p%2FQ1yqVoHFMyqHsk%3D&reserved=0
> 
> [2]
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork
> .kernel.org%2Fproject%2Flinux-renesas-
> soc%2Flist%2F%3Fseries%3D742798&data=05%7C01%7Cbiju.das.jz%40bp.renesas.com
> %7C96654dd2de224f1721f408db45a51b15%7C53d82571da1947e49cb4625a166a4a2a%7C0%
> 7C0%7C638180347643845748%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj
> oiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=nkFiesy1lTKM
> bUn7x6CzDvPXOmXQAm9jEGk304cgOB8%3D&reserved=0
> 
> [3]
> It is tested with below MESA patch, planning to mainline this after the
> RZ/G2L DU driver[1] is mainlined.
> 
>  src/gallium/targets/dri/meson.build | 1 +
>  src/gallium/targets/dri/target.c    | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/src/gallium/targets/dri/meson.build
> b/src/gallium/targets/dri/meson.build
> index f4d61f7b254..fbc85ca2fdd 100644
> --- a/src/gallium/targets/dri/meson.build
> +++ b/src/gallium/targets/dri/meson.build
> @@ -84,6 +84,7 @@ foreach d : [[with_gallium_kmsro, [
>                 'mxsfb-drm_dri.so',
>                 'pl111_dri.so',
>                 'rcar-du_dri.so',
> +               'rzg2l-du_dri.so',
>                 'repaper_dri.so',
>                 'rockchip_dri.so',
>                 'st7586_dri.so',
> diff --git a/src/gallium/targets/dri/target.c
> b/src/gallium/targets/dri/target.c
> index fb5798581db..41f45fd4ff4 100644
> --- a/src/gallium/targets/dri/target.c
> +++ b/src/gallium/targets/dri/target.c
> @@ -113,6 +113,7 @@ DEFINE_LOADER_DRM_ENTRYPOINT(mi0283qt)
>  DEFINE_LOADER_DRM_ENTRYPOINT(mxsfb_drm)
>  DEFINE_LOADER_DRM_ENTRYPOINT(pl111)
>  DEFINE_LOADER_DRM_ENTRYPOINT(rcar_du)
> +DEFINE_LOADER_DRM_ENTRYPOINT(rzg2l_du)
>  DEFINE_LOADER_DRM_ENTRYPOINT(repaper)
>  DEFINE_LOADER_DRM_ENTRYPOINT(rockchip)
>  DEFINE_LOADER_DRM_ENTRYPOINT(st7586)
> 
> Biju Das (2):
>   arm64: dts: renesas: r9a07g044: Add gpu cooling device
>   arm64: dts: renesas: r9a07g054: Add gpu cooling device
> 
>  arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 6 ++++++
> arch/arm64/boot/dts/renesas/r9a07g054.dtsi | 6 ++++++
>  2 files changed, 12 insertions(+)
> 
> --
> 2.25.1


      parent reply	other threads:[~2023-11-01 18:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25 15:52 [PATCH 0/2] Add GPU cooling device support Biju Das
2023-04-25 15:52 ` [PATCH 1/2] arm64: dts: renesas: r9a07g044: Add gpu cooling device Biju Das
2023-05-03 10:28   ` Geert Uytterhoeven
2023-05-04  7:06     ` Biju Das
2023-04-25 15:52 ` [PATCH 2/2] arm64: dts: renesas: r9a07g054: " Biju Das
2023-11-01 18:37 ` Biju Das [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYCPR01MB11269BF61D52CD6C4C5EC915986A7A@TYCPR01MB11269.jpnprd01.prod.outlook.com \
    --to=biju.das.jz@bp.renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.