From: Biju Das <biju.das.jz@bp.renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Subject: RE: [PATCH 1/2] arm64: dts: renesas: r9a07g044: Add gpu cooling device
Date: Thu, 4 May 2023 07:06:56 +0000 [thread overview]
Message-ID: <OS0PR01MB5922BE735279BE59FD5A4DF4866D9@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdUs=F3ePP1P5OTbf9cut1wrbov=YEsyZEnKToBaFK0qNA@mail.gmail.com>
Hi Geert,
Thanks for the feedback.
> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: Wednesday, May 3, 2023 11:28 AM
> To: Biju Das <biju.das.jz@bp.renesas.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Geert Uytterhoeven
> <geert+renesas@glider.be>; Magnus Damm <magnus.damm@gmail.com>; linux-
> renesas-soc@vger.kernel.org; devicetree@vger.kernel.org; Fabrizio Castro
> <fabrizio.castro.jz@renesas.com>
> Subject: Re: [PATCH 1/2] arm64: dts: renesas: r9a07g044: Add gpu cooling
> device
>
> Hi Biju,
>
> On Tue, Apr 25, 2023 at 5:52 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > Add gpu cooling device for passive control.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> > @@ -970,6 +970,7 @@ gpu: gpu@11840000 {
> > <&cpg R9A07G044_GPU_ACE_RESETN>;
> > reset-names = "rst", "axi_rst", "ace_rst";
> > operating-points-v2 = <&gpu_opp_table>;
> > + #cooling-cells = <2>;
> > };
> >
> > gic: interrupt-controller@11900000 { @@ -1245,6
> > +1246,11 @@ map0 {
> > cooling-device = <&cpu0 0 2>;
> > contribution = <1024>;
> > };
> > +
> > + map1 {
> > + trip = <&target>;
> > + cooling-device = <&gpu 0 2>;
>
> Perhaps this needs a "contribution" property, as the CPU device in the same
> zone has one?
OK, will check this.
Cheers,
Biju
>
> > + };
> > };
> >
> > trips {
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
next prev parent reply other threads:[~2023-05-04 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 15:52 [PATCH 0/2] Add GPU cooling device support Biju Das
2023-04-25 15:52 ` [PATCH 1/2] arm64: dts: renesas: r9a07g044: Add gpu cooling device Biju Das
2023-05-03 10:28 ` Geert Uytterhoeven
2023-05-04 7:06 ` Biju Das [this message]
2023-04-25 15:52 ` [PATCH 2/2] arm64: dts: renesas: r9a07g054: " Biju Das
2023-11-01 18:37 ` [PATCH 0/2] Add GPU cooling device support Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS0PR01MB5922BE735279BE59FD5A4DF4866D9@OS0PR01MB5922.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.