From: Geert Uytterhoeven <geert@linux-m68k.org> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Magnus Damm <magnus.damm@gmail.com>, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] ARM: dts: r8a7740: Add LCDC nodes Date: Fri, 23 Jun 2023 17:26:09 +0200 [thread overview] Message-ID: <CAMuHMdV2fYzCTA78US=YGGgvhjSbJWvV-suRsknHqq3OhKCWAw@mail.gmail.com> (raw) In-Reply-To: <20230623151236.GM2112@pendragon.ideasonboard.com> Hi Laurent, On Fri, Jun 23, 2023 at 5:12 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > On Fri, Jun 23, 2023 at 05:07:44PM +0200, Geert Uytterhoeven wrote: > > On Fri, Jun 23, 2023 at 3:03 PM Laurent Pinchart wrote: > > > On Thu, Jun 22, 2023 at 11:23:14AM +0200, Geert Uytterhoeven wrote: > > > > Add device nodes for the two LCD Controllers (LCDC) on the R-Mobile A1 > > > > SoC, and for the two optional external LCDL clock inputs. > > > > > > > > Note that the HDMI clock for LCDC1 is not added, as this clock is not > > > > yet supported. > > > > > > > > Based on a patch by Laurent Pinchart adding the first LCDC device node. > > > > > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > --- > > > > Changes compared to Laurent's original: > > > > - Add lcdc0 label, > > > > - Rename node from display to lcdc-controller, > > > > - Rename compatible value from "renesas,lcdc-r8a7740" to > > > > "renesas,r8a7740-lcdc", > > > > - Correct syntax of reg property, > > > > - Use GIC_SPI macro, > > > > - Add more clocks, > > > > - Add power-domains property, > > > > - Add status disabled, > > > > - Remove second port from lcdc0, as only lcdc1 has an HDMI port, > > > > - Add lcdc1 device node. > > > > --- > > > > arch/arm/boot/dts/r8a7740.dtsi | 65 ++++++++++++++++++++++++++++++++++ > > > > 1 file changed, 65 insertions(+) > > > > > > > > diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi > > > > index 1b2cf5fa322b2985..55884ec701f8dab4 100644 > > > > --- a/arch/arm/boot/dts/r8a7740.dtsi > > > > +++ b/arch/arm/boot/dts/r8a7740.dtsi > > > > @@ -474,6 +529,16 @@ fsibck_clk: fsibck { > > > > #clock-cells = <0>; > > > > clock-frequency = <0>; > > > > }; > > > > + lcdlclk0_clk: lcdlclk0 { > > > > + compatible = "fixed-clock"; > > > > + #clock-cells = <0>; > > > > + clock-frequency = <0>; > > > > + }; > > > > + lcdlclk1_clk: lcdlclk1 { > > > > + compatible = "fixed-clock"; > > > > + #clock-cells = <0>; > > > > + clock-frequency = <0>; > > > > + }; > > > > > > The clock frequency seems quite low :-) As far as I understand, there > > > are the clocks fed to the external LCDLCLK pins. They belong to the > > > board DTS, not here. If a board doesn't provide an external clock, the > > > clock should simply be ommitted. The driver must thus treat it as > > > optional. > > > > Usually, we do provide clock nodes with a zero rate in the SoC-specific > > .dtsi for optional clocks. > > Who is "we" ? Is that a kernel-wide practice ? For rcar-du that's not > the case as far as I can tell. "We" do for external CAN, SCIF, Audio, PCI, USB, ... clocks on R-Car. Indeed not for DU... It seems to be common on other platform, too: git grep "clock-frequency = <0>;" Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Magnus Damm <magnus.damm@gmail.com>, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] ARM: dts: r8a7740: Add LCDC nodes Date: Fri, 23 Jun 2023 17:26:09 +0200 [thread overview] Message-ID: <CAMuHMdV2fYzCTA78US=YGGgvhjSbJWvV-suRsknHqq3OhKCWAw@mail.gmail.com> (raw) In-Reply-To: <20230623151236.GM2112@pendragon.ideasonboard.com> Hi Laurent, On Fri, Jun 23, 2023 at 5:12 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > On Fri, Jun 23, 2023 at 05:07:44PM +0200, Geert Uytterhoeven wrote: > > On Fri, Jun 23, 2023 at 3:03 PM Laurent Pinchart wrote: > > > On Thu, Jun 22, 2023 at 11:23:14AM +0200, Geert Uytterhoeven wrote: > > > > Add device nodes for the two LCD Controllers (LCDC) on the R-Mobile A1 > > > > SoC, and for the two optional external LCDL clock inputs. > > > > > > > > Note that the HDMI clock for LCDC1 is not added, as this clock is not > > > > yet supported. > > > > > > > > Based on a patch by Laurent Pinchart adding the first LCDC device node. > > > > > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > --- > > > > Changes compared to Laurent's original: > > > > - Add lcdc0 label, > > > > - Rename node from display to lcdc-controller, > > > > - Rename compatible value from "renesas,lcdc-r8a7740" to > > > > "renesas,r8a7740-lcdc", > > > > - Correct syntax of reg property, > > > > - Use GIC_SPI macro, > > > > - Add more clocks, > > > > - Add power-domains property, > > > > - Add status disabled, > > > > - Remove second port from lcdc0, as only lcdc1 has an HDMI port, > > > > - Add lcdc1 device node. > > > > --- > > > > arch/arm/boot/dts/r8a7740.dtsi | 65 ++++++++++++++++++++++++++++++++++ > > > > 1 file changed, 65 insertions(+) > > > > > > > > diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi > > > > index 1b2cf5fa322b2985..55884ec701f8dab4 100644 > > > > --- a/arch/arm/boot/dts/r8a7740.dtsi > > > > +++ b/arch/arm/boot/dts/r8a7740.dtsi > > > > @@ -474,6 +529,16 @@ fsibck_clk: fsibck { > > > > #clock-cells = <0>; > > > > clock-frequency = <0>; > > > > }; > > > > + lcdlclk0_clk: lcdlclk0 { > > > > + compatible = "fixed-clock"; > > > > + #clock-cells = <0>; > > > > + clock-frequency = <0>; > > > > + }; > > > > + lcdlclk1_clk: lcdlclk1 { > > > > + compatible = "fixed-clock"; > > > > + #clock-cells = <0>; > > > > + clock-frequency = <0>; > > > > + }; > > > > > > The clock frequency seems quite low :-) As far as I understand, there > > > are the clocks fed to the external LCDLCLK pins. They belong to the > > > board DTS, not here. If a board doesn't provide an external clock, the > > > clock should simply be ommitted. The driver must thus treat it as > > > optional. > > > > Usually, we do provide clock nodes with a zero rate in the SoC-specific > > .dtsi for optional clocks. > > Who is "we" ? Is that a kernel-wide practice ? For rcar-du that's not > the case as far as I can tell. "We" do for external CAN, SCIF, Audio, PCI, USB, ... clocks on R-Car. Indeed not for DU... It seems to be common on other platform, too: git grep "clock-frequency = <0>;" Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-23 15:26 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-22 9:23 [PATCH 0/2] ARM: dts: r8a7740/armadillo800eva: Add LCD support Geert Uytterhoeven 2023-06-22 9:23 ` Geert Uytterhoeven 2023-06-22 9:23 ` [PATCH 1/2] ARM: dts: r8a7740: Add LCDC nodes Geert Uytterhoeven 2023-06-22 9:23 ` Geert Uytterhoeven 2023-06-23 13:03 ` Laurent Pinchart 2023-06-23 13:03 ` Laurent Pinchart 2023-06-23 15:07 ` Geert Uytterhoeven 2023-06-23 15:07 ` Geert Uytterhoeven 2023-06-23 15:12 ` Laurent Pinchart 2023-06-23 15:12 ` Laurent Pinchart 2023-06-23 15:26 ` Geert Uytterhoeven [this message] 2023-06-23 15:26 ` Geert Uytterhoeven 2023-06-22 9:23 ` [PATCH 2/2] ARM: dts: armadillo800eva: Add LCD panel Geert Uytterhoeven 2023-06-22 9:23 ` Geert Uytterhoeven 2023-06-23 13:03 ` Laurent Pinchart 2023-06-23 13:03 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMuHMdV2fYzCTA78US=YGGgvhjSbJWvV-suRsknHqq3OhKCWAw@mail.gmail.com' \ --to=geert@linux-m68k.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=magnus.damm@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.