Re: [PATCH 3/3] dt-bindings: gpio: pcf857x: Convert to json-schema

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Jan Tuerk" <jan.tuerk@emtrion.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"open list:TI ETHERNET SWITCH DRIVER (CPSW)"
	<linux-omap@vger.kernel.org>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] dt-bindings: gpio: pcf857x: Convert to json-schema
Date: Thu, 27 May 2021 16:43:41 +0200	[thread overview]
Message-ID: <CAMuHMdWwj7rwxmBX5CC+Qjnmkp1W+imXm1q5PXRZrm7ZB7jtMg@mail.gmail.com> (raw)
In-Reply-To: <YKm1Z4/xULSzuoVV@pendragon.ideasonboard.com>

Hi Laurent,

On Sun, May 23, 2021 at 3:52 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Fri, May 21, 2021 at 09:54:08AM +0200, Geert Uytterhoeven wrote:
> > Convert the PCF857x-compatible I/O expanders Device Tree binding
> > documentation to json-schema.
> >
> > Document missing compatible values, properties, and gpio hogs.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > Perhaps the "ti,pcf8575" construct should be removed, and the few users
> > fixed instead?
>
> Given that the driver doesn't match against it, that could be done, if
> you're confident enough that there's no difference between the TI and
> NXP versions that would need to be taken into account.

I've just checked the datasheets, and they're identical modulo
shuffling.  Probably TI is the mandatory second source for the NXP
(née Philips) part.

> > I have listed Laurent as the maintainer, as he wrote the original
> > bindings.  Laurent: Please scream if this is inappropriate ;-)
>
> I'm sure I'll regret it later, but I don't mind :-)

Thanks!

> > +  lines-initial-states:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description:
> > +      Bitmask that specifies the initial state of each line.
> > +      When a bit is set to zero, the corresponding line will be initialized to
> > +      the input (pulled-up) state.
> > +      When the  bit is set to one, the line will be initialized to the
> > +      low-level output state.
> > +      If the property is not specified all lines will be initialized to the
> > +      input state.
>
> The line wrapping is weird.

Is it? The different cases just start on a new line.  Which makes no
difference, as there's no "|".

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds