From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: DRI Development <dri-devel@lists.freedesktop.org>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH v2 6/9] drm: Decouple EDID parsing from I2C adapter
Date: Fri, 24 Oct 2014 13:58:34 +0000 [thread overview]
Message-ID: <CAMuHMdXF_m2gK2qYvExhAS-J4TXjv8f-5X0bAq--PswAsgjbnA@mail.gmail.com> (raw)
In-Reply-To: <1414155495-3979-7-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Fri, Oct 24, 2014 at 2:58 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> --- a/include/drm/drm_edid.h
> +++ b/include/drm/drm_edid.h
> @@ -279,4 +279,8 @@ int
> drm_hdmi_vendor_infoframe_from_display_mode(struct hdmi_vendor_infoframe *frame,
> const struct drm_display_mode *mode);
>
> +struct edid *drm_do_get_edid(struct drm_connector *connector,
> + int (*get_edid_block)(void *, u8 *buf, unsigned int, size_t),
It doesn't hurt to add parameter names for all parameters, as hints
for implementors.
> + void *data);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: DRI Development <dri-devel@lists.freedesktop.org>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH v2 6/9] drm: Decouple EDID parsing from I2C adapter
Date: Fri, 24 Oct 2014 15:58:34 +0200 [thread overview]
Message-ID: <CAMuHMdXF_m2gK2qYvExhAS-J4TXjv8f-5X0bAq--PswAsgjbnA@mail.gmail.com> (raw)
In-Reply-To: <1414155495-3979-7-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Fri, Oct 24, 2014 at 2:58 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> --- a/include/drm/drm_edid.h
> +++ b/include/drm/drm_edid.h
> @@ -279,4 +279,8 @@ int
> drm_hdmi_vendor_infoframe_from_display_mode(struct hdmi_vendor_infoframe *frame,
> const struct drm_display_mode *mode);
>
> +struct edid *drm_do_get_edid(struct drm_connector *connector,
> + int (*get_edid_block)(void *, u8 *buf, unsigned int, size_t),
It doesn't hurt to add parameter names for all parameters, as hints
for implementors.
> + void *data);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2014-10-24 13:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 12:58 [PATCH v2 0/9] Renesas R-Car DU HDMI support Laurent Pinchart
2014-10-24 12:58 ` Laurent Pinchart
2014-10-24 12:58 ` [PATCH v2 1/9] drm: rcar-du: Remove platform data support Laurent Pinchart
2014-10-24 12:58 ` Laurent Pinchart
2014-10-24 12:58 ` [PATCH v2 2/9] drm: rcar-du: Pass the encoder DT node to rcar_du_encoder_init() Laurent Pinchart
2014-10-24 12:58 ` Laurent Pinchart
2014-10-24 12:58 ` [PATCH v2 3/9] drm: rcar-du: Replace direct DRM encoder access with cast macro Laurent Pinchart
2014-10-24 12:58 ` Laurent Pinchart
2014-10-24 12:58 ` [PATCH v2 4/9] drm: rcar-du: Replace drm_encoder with drm_slave_encoder Laurent Pinchart
2014-10-24 12:58 ` Laurent Pinchart
2014-10-24 12:58 ` [PATCH v2 5/9] drm: rcar-du: Add HDMI encoder and connector support Laurent Pinchart
2014-10-24 12:58 ` Laurent Pinchart
2014-10-24 12:58 ` [PATCH v2 6/9] drm: Decouple EDID parsing from I2C adapter Laurent Pinchart
2014-10-24 12:58 ` Laurent Pinchart
2014-10-24 13:58 ` Geert Uytterhoeven [this message]
2014-10-24 13:58 ` Geert Uytterhoeven
2014-10-26 14:43 ` Laurent Pinchart
2014-10-26 14:43 ` Laurent Pinchart
2014-10-24 12:58 ` [PATCH v2 7/9] video: Add ADV751[13] DT bindings documentation Laurent Pinchart
2014-10-24 12:58 ` Laurent Pinchart
2014-10-24 12:58 ` [PATCH v2 8/9] drm: Add adv7511 encoder driver Laurent Pinchart
2014-10-24 12:58 ` Laurent Pinchart
2014-10-24 12:58 ` [PATCH v2 9/9] ARM: shmobile: koelsch: Add DU HDMI output support Laurent Pinchart
2014-10-24 12:58 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXF_m2gK2qYvExhAS-J4TXjv8f-5X0bAq--PswAsgjbnA@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.