From: Geert Uytterhoeven <geert@linux-m68k.org> To: Biju Das <biju.das.jz@bp.renesas.com> Cc: Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org, Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Michael Walle <michael@walle.cc>, Biju Das <biju.das.au@gmail.com>, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH RFC 1/4] spi: spi-mem: Add set_iofv() callback Date: Thu, 9 Nov 2023 08:56:56 +0100 [thread overview] Message-ID: <CAMuHMdXdzbtR+ruXwfS1a74rnH494kMsFvaT9MTz7cW-LFpB1A@mail.gmail.com> (raw) In-Reply-To: <20231108171149.258656-2-biju.das.jz@bp.renesas.com> Hi Biju, On Wed, Nov 8, 2023 at 6:12 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > As per section 8.14 on the AT25QL128A hardware manual, > IO0..IO3 must be set to Hi-Z state for this flash for fast read quad IO. > Snippet from HW manual section 8.14: > The upper nibble of the Mode(M7-4) controls the length of the next FAST > Read Quad IO instruction through the inclusion or exclusion of the first > byte instruction code. The lower nibble bits of the Mode(M3-0) are don't > care. However, the IO pins must be high-impedance before the falling edge > of the first data out clock. > > Add set_iofv() callback for configuring IO fixed values to control the > pin state. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Thanks for your patch! > --- a/drivers/spi/spi-mem.c > +++ b/drivers/spi/spi-mem.c > @@ -297,6 +297,26 @@ static void spi_mem_access_end(struct spi_mem *mem) > pm_runtime_put(ctlr->dev.parent); > } > > +/** > + * spi_mem_set_iofv() - Set IO fixed values to control the pin state > + * @mem: the SPI memory > + * @val: the IO fixed values Please document the meaning of this value (i.e. what does a set or cleared bit mean?). > + * > + * Set IO fixed values to control the pin state. > + * > + * Return: 0 in case of success, a negative error code otherwise. > + */ > +int spi_mem_set_iofv(struct spi_mem *mem, u32 val) > +{ > + struct spi_controller *ctlr = mem->spi->controller; > + > + if (ctlr->mem_ops && ctlr->mem_ops->set_iofv) > + return ctlr->mem_ops->set_iofv(mem, val); > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(spi_mem_set_iofv); > + > /** > * spi_mem_exec_op() - Execute a memory operation > * @mem: the SPI memory Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Biju Das <biju.das.jz@bp.renesas.com> Cc: Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org, Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Michael Walle <michael@walle.cc>, Biju Das <biju.das.au@gmail.com>, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH RFC 1/4] spi: spi-mem: Add set_iofv() callback Date: Thu, 9 Nov 2023 08:56:56 +0100 [thread overview] Message-ID: <CAMuHMdXdzbtR+ruXwfS1a74rnH494kMsFvaT9MTz7cW-LFpB1A@mail.gmail.com> (raw) In-Reply-To: <20231108171149.258656-2-biju.das.jz@bp.renesas.com> Hi Biju, On Wed, Nov 8, 2023 at 6:12 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > As per section 8.14 on the AT25QL128A hardware manual, > IO0..IO3 must be set to Hi-Z state for this flash for fast read quad IO. > Snippet from HW manual section 8.14: > The upper nibble of the Mode(M7-4) controls the length of the next FAST > Read Quad IO instruction through the inclusion or exclusion of the first > byte instruction code. The lower nibble bits of the Mode(M3-0) are don't > care. However, the IO pins must be high-impedance before the falling edge > of the first data out clock. > > Add set_iofv() callback for configuring IO fixed values to control the > pin state. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Thanks for your patch! > --- a/drivers/spi/spi-mem.c > +++ b/drivers/spi/spi-mem.c > @@ -297,6 +297,26 @@ static void spi_mem_access_end(struct spi_mem *mem) > pm_runtime_put(ctlr->dev.parent); > } > > +/** > + * spi_mem_set_iofv() - Set IO fixed values to control the pin state > + * @mem: the SPI memory > + * @val: the IO fixed values Please document the meaning of this value (i.e. what does a set or cleared bit mean?). > + * > + * Set IO fixed values to control the pin state. > + * > + * Return: 0 in case of success, a negative error code otherwise. > + */ > +int spi_mem_set_iofv(struct spi_mem *mem, u32 val) > +{ > + struct spi_controller *ctlr = mem->spi->controller; > + > + if (ctlr->mem_ops && ctlr->mem_ops->set_iofv) > + return ctlr->mem_ops->set_iofv(mem, val); > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(spi_mem_set_iofv); > + > /** > * spi_mem_exec_op() - Execute a memory operation > * @mem: the SPI memory Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-11-09 7:57 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-08 17:11 [PATCH RFC 0/4] Add set_iofv() callback Biju Das 2023-11-08 17:11 ` Biju Das 2023-11-08 17:11 ` [PATCH RFC 1/4] spi: spi-mem: " Biju Das 2023-11-08 17:11 ` Biju Das 2023-11-09 7:56 ` Geert Uytterhoeven [this message] 2023-11-09 7:56 ` Geert Uytterhoeven 2023-11-09 8:28 ` Biju Das 2023-11-08 17:11 ` [PATCH RFC 2/4] mtd: spi-nor: Add post_sfdp() callback Biju Das 2023-11-08 17:11 ` Biju Das 2023-11-08 17:11 ` [PATCH RFC 3/4] memory: renesas-rpc-if: Add support for overriding IO fixed values Biju Das 2023-11-21 9:08 ` Krzysztof Kozlowski 2023-11-08 17:11 ` [PATCH RFC 4/4] spi: rpc-if: Add set_iofv() callback Biju Das 2023-11-09 9:01 ` [PATCH RFC 0/4] " Michael Walle 2023-11-09 9:01 ` Michael Walle 2023-11-09 10:04 ` Biju Das 2023-11-09 10:48 ` Michael Walle 2023-11-09 10:48 ` Michael Walle 2023-11-09 11:48 ` Biju Das 2023-11-09 12:40 ` Michael Walle 2023-11-09 12:40 ` Michael Walle 2023-11-09 18:02 ` Biju Das 2023-11-10 10:11 ` Michael Walle 2023-11-10 10:11 ` Michael Walle 2023-11-10 11:35 ` Biju Das 2023-11-11 12:26 ` Biju Das 2023-11-11 13:08 ` Biju Das 2023-11-13 14:04 ` Michael Walle 2023-11-13 14:04 ` Michael Walle 2023-11-13 14:27 ` Biju Das 2023-11-13 14:48 ` Michael Walle 2023-11-13 14:48 ` Michael Walle 2023-11-13 14:59 ` Biju Das 2023-11-13 15:10 ` Michael Walle 2023-11-13 15:10 ` Michael Walle 2023-11-13 15:55 ` Biju Das 2023-11-14 10:05 ` Michael Walle 2023-11-14 10:05 ` Michael Walle 2023-11-12 20:24 ` Biju Das 2023-11-13 14:37 ` Michael Walle 2023-11-13 14:37 ` Michael Walle 2023-11-13 14:47 ` Michael Walle 2023-11-13 14:47 ` Michael Walle
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAMuHMdXdzbtR+ruXwfS1a74rnH494kMsFvaT9MTz7cW-LFpB1A@mail.gmail.com \ --to=geert@linux-m68k.org \ --cc=biju.das.au@gmail.com \ --cc=biju.das.jz@bp.renesas.com \ --cc=broonie@kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=michael@walle.cc \ --cc=miquel.raynal@bootlin.com \ --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.