Re: [PATCH v2] selftests/timers/posix_timers: reimplement check_timer_distribution()

From: John Stultz <jstultz@google.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Oleg Nesterov <oleg@redhat.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Marco Elver <elver@google.com>,
	 Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	 "Eric W. Biederman" <ebiederm@xmission.com>,
	linux-kernel@vger.kernel.org,  linux-kselftest@vger.kernel.org,
	kasan-dev@googlegroups.com,  Edward Liaw <edliaw@google.com>,
	Carlos Llamas <cmllamas@google.com>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2] selftests/timers/posix_timers: reimplement check_timer_distribution()
Date: Wed, 10 Apr 2024 15:33:17 -0700	[thread overview]
Message-ID: <CANDhNCpas4AQuAquVMVFgN3NCfCsVgg993Kjad8MjvSZAbsXow@mail.gmail.com> (raw)
In-Reply-To: <871q7c3l47.ffs@tglx>

On Wed, Apr 10, 2024 at 3:31 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> On Wed, Apr 10 2024 at 15:21, John Stultz wrote:
> > On Tue, Apr 9, 2024 at 6:39 AM Oleg Nesterov <oleg@redhat.com> wrote:
> > This is working great here (on both 6.6 and the older 6.1)! Thanks so
> > much for fixing this!
> > One nit below, but otherwise:
> >   Tested-by: John Stultz <jstultz@google.com>
> >
> >> +err:
> >> +       ksft_print_msg(errmsg);
> >
> > This bit is causing the following warning:
> > posix_timers.c:250:2: warning: format not a string literal and no
> > format arguments [-Wformat-security]
> >   250 |  ksft_print_msg(errmsg);
> >       |  ^~~~~~~~~~~~~~
> >
> > A simple fix is just to switch it to:
> >   ksft_print_msg("%s", errmsg);
>
> Can you please send a delta patch against tip timers/urgent?

Will do! Apologies for not getting to test and reply earlier.
-john