From: Nicolas Boichat <drinkcat@chromium.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Steven Price <steven.price@arm.com>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Devicetree List <devicetree@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators
Date: Thu, 13 Feb 2020 16:24:59 +0800 [thread overview]
Message-ID: <CANMq1KCD-Ut3bjEmtpPCgOf+KHyi9cw7QSsxcQrWU4h2juZCUQ@mail.gmail.com> (raw)
In-Reply-To: <CANMq1KCn5rrOrv2GjFh5Aau5Los4VVk=NMWAsvZiNuwoxyMVHA@mail.gmail.com>
On Thu, Feb 13, 2020 at 3:57 PM Nicolas Boichat <drinkcat@chromium.org> wrote:
> > > [snip]
> > > But then there's a slight problem: panfrost_devfreq uses a bunch of
> > > clk_get_rate calls, and the clock PLLs (at least on MTK platform) are
> > > never fully precise, so we get back 299999955 for 300 Mhz and
> > > 799999878 for 800 Mhz. That means that the kernel is unable to keep
> > > devfreq stats as neither of these values are in the table:
> > > [ 4802.470952] devfreq devfreq1: Couldn't update frequency transition
> > > information.
> > > The kbase driver fixes this by remembering the last set frequency, and
> > > reporting that to devfreq. Should we do that as well or is there a
> > > better fix?
This one is my bad, I was missing this patch in my forklift to 4.19:
22bd4df9dadf46f drm/panfrost: devfreq: Round frequencies to OPPs
(should really try to boot that board on linux-next, but that's for
another time)
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Boichat <drinkcat@chromium.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Devicetree List <devicetree@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
David Airlie <airlied@linux.ie>,
lkml <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Steven Price <steven.price@arm.com>,
Stephen Boyd <sboyd@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Mark Brown <broonie@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Daniel Vetter <daniel@ffwll.ch>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators
Date: Thu, 13 Feb 2020 16:24:59 +0800 [thread overview]
Message-ID: <CANMq1KCD-Ut3bjEmtpPCgOf+KHyi9cw7QSsxcQrWU4h2juZCUQ@mail.gmail.com> (raw)
In-Reply-To: <CANMq1KCn5rrOrv2GjFh5Aau5Los4VVk=NMWAsvZiNuwoxyMVHA@mail.gmail.com>
On Thu, Feb 13, 2020 at 3:57 PM Nicolas Boichat <drinkcat@chromium.org> wrote:
> > > [snip]
> > > But then there's a slight problem: panfrost_devfreq uses a bunch of
> > > clk_get_rate calls, and the clock PLLs (at least on MTK platform) are
> > > never fully precise, so we get back 299999955 for 300 Mhz and
> > > 799999878 for 800 Mhz. That means that the kernel is unable to keep
> > > devfreq stats as neither of these values are in the table:
> > > [ 4802.470952] devfreq devfreq1: Couldn't update frequency transition
> > > information.
> > > The kbase driver fixes this by remembering the last set frequency, and
> > > reporting that to devfreq. Should we do that as well or is there a
> > > better fix?
This one is my bad, I was missing this patch in my forklift to 4.19:
22bd4df9dadf46f drm/panfrost: devfreq: Round frequencies to OPPs
(should really try to boot that board on linux-next, but that's for
another time)
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Boichat <drinkcat@chromium.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Devicetree List <devicetree@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
David Airlie <airlied@linux.ie>,
lkml <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Steven Price <steven.price@arm.com>,
Stephen Boyd <sboyd@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Mark Brown <broonie@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Daniel Vetter <daniel@ffwll.ch>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators
Date: Thu, 13 Feb 2020 16:24:59 +0800 [thread overview]
Message-ID: <CANMq1KCD-Ut3bjEmtpPCgOf+KHyi9cw7QSsxcQrWU4h2juZCUQ@mail.gmail.com> (raw)
In-Reply-To: <CANMq1KCn5rrOrv2GjFh5Aau5Los4VVk=NMWAsvZiNuwoxyMVHA@mail.gmail.com>
On Thu, Feb 13, 2020 at 3:57 PM Nicolas Boichat <drinkcat@chromium.org> wrote:
> > > [snip]
> > > But then there's a slight problem: panfrost_devfreq uses a bunch of
> > > clk_get_rate calls, and the clock PLLs (at least on MTK platform) are
> > > never fully precise, so we get back 299999955 for 300 Mhz and
> > > 799999878 for 800 Mhz. That means that the kernel is unable to keep
> > > devfreq stats as neither of these values are in the table:
> > > [ 4802.470952] devfreq devfreq1: Couldn't update frequency transition
> > > information.
> > > The kbase driver fixes this by remembering the last set frequency, and
> > > reporting that to devfreq. Should we do that as well or is there a
> > > better fix?
This one is my bad, I was missing this patch in my forklift to 4.19:
22bd4df9dadf46f drm/panfrost: devfreq: Round frequencies to OPPs
(should really try to boot that board on linux-next, but that's for
another time)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Boichat <drinkcat@chromium.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Devicetree List <devicetree@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
David Airlie <airlied@linux.ie>,
lkml <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Steven Price <steven.price@arm.com>,
Stephen Boyd <sboyd@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Mark Brown <broonie@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators
Date: Thu, 13 Feb 2020 16:24:59 +0800 [thread overview]
Message-ID: <CANMq1KCD-Ut3bjEmtpPCgOf+KHyi9cw7QSsxcQrWU4h2juZCUQ@mail.gmail.com> (raw)
In-Reply-To: <CANMq1KCn5rrOrv2GjFh5Aau5Los4VVk=NMWAsvZiNuwoxyMVHA@mail.gmail.com>
On Thu, Feb 13, 2020 at 3:57 PM Nicolas Boichat <drinkcat@chromium.org> wrote:
> > > [snip]
> > > But then there's a slight problem: panfrost_devfreq uses a bunch of
> > > clk_get_rate calls, and the clock PLLs (at least on MTK platform) are
> > > never fully precise, so we get back 299999955 for 300 Mhz and
> > > 799999878 for 800 Mhz. That means that the kernel is unable to keep
> > > devfreq stats as neither of these values are in the table:
> > > [ 4802.470952] devfreq devfreq1: Couldn't update frequency transition
> > > information.
> > > The kbase driver fixes this by remembering the last set frequency, and
> > > reporting that to devfreq. Should we do that as well or is there a
> > > better fix?
This one is my bad, I was missing this patch in my forklift to 4.19:
22bd4df9dadf46f drm/panfrost: devfreq: Round frequencies to OPPs
(should really try to boot that board on linux-next, but that's for
another time)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-13 8:25 UTC|newest]
Thread overview: 166+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 5:26 [PATCH v4 0/7] Add dts for mt8183 GPU (and misc panfrost patches) Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-07 5:26 ` [PATCH v4 1/7] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-25 17:16 ` Rob Herring
2020-02-25 17:16 ` Rob Herring
2020-02-25 17:16 ` Rob Herring
2020-02-25 17:16 ` Rob Herring
2020-02-26 0:55 ` Nicolas Boichat
2020-02-26 0:55 ` Nicolas Boichat
2020-02-26 0:55 ` Nicolas Boichat
2020-02-26 0:55 ` Nicolas Boichat
2020-03-06 2:34 ` Nick Fan
2020-03-06 2:34 ` Nick Fan
2020-03-06 2:34 ` Nick Fan
2020-03-06 2:34 ` Nick Fan
2020-03-06 2:43 ` Nicolas Boichat
2020-03-06 2:43 ` Nicolas Boichat
2020-03-06 2:43 ` Nicolas Boichat
2020-03-06 2:43 ` Nicolas Boichat
2020-03-06 14:13 ` Rob Herring
2020-03-06 14:13 ` Rob Herring
2020-03-06 14:13 ` Rob Herring
2020-03-06 14:13 ` Rob Herring
2020-03-06 14:43 ` Steven Price
2020-03-06 14:43 ` Steven Price
2020-03-06 14:43 ` Steven Price
2020-03-06 14:43 ` Steven Price
2020-03-09 7:55 ` Nick Fan
2020-03-09 7:55 ` Nick Fan
2020-03-09 7:55 ` Nick Fan
2020-03-09 7:55 ` Nick Fan
2020-02-07 5:26 ` [PATCH v4 2/7] arm64: dts: mt8183: Add node for the Mali GPU Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-07 5:26 ` [PATCH v4 3/7] drm/panfrost: Improve error reporting in panfrost_gpu_power_on Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-12 10:38 ` Matthias Brugger
2020-02-12 10:38 ` Matthias Brugger
2020-02-12 10:38 ` Matthias Brugger
2020-02-12 10:38 ` Matthias Brugger
2020-02-07 5:26 ` [PATCH v4 4/7] drm/panfrost: Add support for multiple regulators Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-10 11:31 ` Steven Price
2020-02-10 11:31 ` Steven Price
2020-02-10 11:31 ` Steven Price
2020-02-10 11:31 ` Steven Price
2020-02-10 14:00 ` Mark Brown
2020-02-10 14:00 ` Mark Brown
2020-02-10 14:00 ` Mark Brown
2020-02-10 14:00 ` Mark Brown
2020-02-07 5:26 ` [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-07 13:52 ` Alyssa Rosenzweig
2020-02-07 13:52 ` Alyssa Rosenzweig
2020-02-07 13:52 ` Alyssa Rosenzweig
2020-02-07 13:52 ` Alyssa Rosenzweig
2020-02-09 12:43 ` Nicolas Boichat
2020-02-09 12:43 ` Nicolas Boichat
2020-02-09 12:43 ` Nicolas Boichat
2020-02-09 12:43 ` Nicolas Boichat
2020-02-07 14:25 ` Ulf Hansson
2020-02-07 14:25 ` Ulf Hansson
2020-02-07 14:25 ` Ulf Hansson
2020-02-07 14:25 ` Ulf Hansson
2020-02-09 12:50 ` Nicolas Boichat
2020-02-09 12:50 ` Nicolas Boichat
2020-02-09 12:50 ` Nicolas Boichat
2020-02-09 12:50 ` Nicolas Boichat
2020-02-10 7:50 ` Ulf Hansson
2020-02-10 7:50 ` Ulf Hansson
2020-02-10 7:50 ` Ulf Hansson
2020-02-10 7:50 ` Ulf Hansson
2020-02-10 11:39 ` Steven Price
2020-02-10 11:39 ` Steven Price
2020-02-10 11:39 ` Steven Price
2020-02-10 11:39 ` Steven Price
2020-02-11 19:43 ` Rob Herring
2020-02-11 19:43 ` Rob Herring
2020-02-11 19:43 ` Rob Herring
2020-02-11 19:43 ` Rob Herring
2020-02-11 20:08 ` Saravana Kannan
2020-02-11 20:08 ` Saravana Kannan
2020-02-11 20:08 ` Saravana Kannan
2020-02-11 20:08 ` Saravana Kannan
2020-02-12 1:58 ` Rob Herring
2020-02-12 1:58 ` Rob Herring
2020-02-12 1:58 ` Rob Herring
2020-02-12 1:58 ` Rob Herring
2020-02-12 2:10 ` Saravana Kannan
2020-02-12 2:10 ` Saravana Kannan
2020-02-12 2:10 ` Saravana Kannan
2020-02-12 2:10 ` Saravana Kannan
2020-02-12 2:08 ` Nicolas Boichat
2020-02-12 2:08 ` Nicolas Boichat
2020-02-12 2:08 ` Nicolas Boichat
2020-02-12 2:08 ` Nicolas Boichat
2020-02-07 5:26 ` [PATCH v4 6/7] RFC: drm/panfrost: Add mt8183-mali compatible string Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-07 5:26 ` [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-07 5:26 ` Nicolas Boichat
2020-02-12 8:49 ` Nicolas Boichat
2020-02-12 8:49 ` Nicolas Boichat
2020-02-12 8:49 ` Nicolas Boichat
2020-02-12 8:49 ` Nicolas Boichat
2020-02-12 9:06 ` Viresh Kumar
2020-02-12 9:06 ` Viresh Kumar
2020-02-12 9:06 ` Viresh Kumar
2020-02-12 9:06 ` Viresh Kumar
2020-02-12 18:14 ` Rob Herring
2020-02-12 18:14 ` Rob Herring
2020-02-12 18:14 ` Rob Herring
2020-02-12 18:14 ` Rob Herring
2020-02-13 7:57 ` Nicolas Boichat
2020-02-13 7:57 ` Nicolas Boichat
2020-02-13 7:57 ` Nicolas Boichat
2020-02-13 7:57 ` Nicolas Boichat
2020-02-13 8:24 ` Nicolas Boichat [this message]
2020-02-13 8:24 ` Nicolas Boichat
2020-02-13 8:24 ` Nicolas Boichat
2020-02-13 8:24 ` Nicolas Boichat
2020-02-14 1:37 ` Nick Fan (范哲維)
2020-02-14 1:37 ` Nick Fan (范哲維)
2020-03-09 1:53 ` Nicolas Boichat
2020-03-09 1:53 ` Nicolas Boichat
2020-03-09 1:53 ` Nicolas Boichat
2020-03-09 1:53 ` Nicolas Boichat
2020-02-07 6:17 ` [PATCH v4 0/7] Add dts for mt8183 GPU (and misc panfrost patches) Tomeu Vizoso
2020-02-07 6:17 ` Tomeu Vizoso
2020-02-07 6:17 ` Tomeu Vizoso
2020-02-07 6:17 ` Tomeu Vizoso
2020-02-07 7:42 ` Nicolas Boichat
2020-02-07 7:42 ` Nicolas Boichat
2020-02-07 7:42 ` Nicolas Boichat
2020-02-07 7:42 ` Nicolas Boichat
2020-02-07 8:13 ` Tomeu Vizoso
2020-02-07 8:13 ` Tomeu Vizoso
2020-02-07 8:13 ` Tomeu Vizoso
2020-02-07 8:13 ` Tomeu Vizoso
2020-02-10 3:39 ` Nicolas Boichat
2020-02-10 3:39 ` Nicolas Boichat
2020-02-10 3:39 ` Nicolas Boichat
2020-02-10 3:39 ` Nicolas Boichat
2020-02-10 8:17 ` Tomeu Vizoso
2020-02-10 8:17 ` Tomeu Vizoso
2020-02-10 8:17 ` Tomeu Vizoso
2020-02-10 8:17 ` Tomeu Vizoso
2020-02-25 20:35 ` Rob Herring
2020-02-25 20:35 ` Rob Herring
2020-02-25 20:35 ` Rob Herring
2020-02-25 20:35 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANMq1KCD-Ut3bjEmtpPCgOf+KHyi9cw7QSsxcQrWU4h2juZCUQ@mail.gmail.com \
--to=drinkcat@chromium.org \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hsinyi@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
--cc=ulf.hansson@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.