From: Jean Pihet <jean.pihet@newoldbits.com> To: Kevin Hilman <khilman@ti.com> Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 13/22] OMAP2+: voltage: keep track of powerdomains in each voltagedomain Date: Wed, 7 Sep 2011 11:23:21 +0200 [thread overview] Message-ID: <CAORVsuU27kNiJAt-YRgfJ5i0=ZpfcDhNfY+kYK+AnKurDHDPfQ@mail.gmail.com> (raw) In-Reply-To: <1314639355-12713-14-git-send-email-khilman@ti.com> Hi Kevin, On Mon, Aug 29, 2011 at 7:35 PM, Kevin Hilman <khilman@ti.com> wrote: > When a powerdomain is registered and it has an associated voltage domain, > add the powerdomain to the voltagedomain using voltdm_add_pwrdm(). > > Also add voltagedomain iterator helper functions to iterate over all > registered voltagedomains and all powerdomains associated with a > voltagedomain. > > Modeled after a similar relationship between clockdomains and powerdomains. > > Signed-off-by: Kevin Hilman <khilman@ti.com> > --- > arch/arm/mach-omap2/powerdomain.c | 2 + > arch/arm/mach-omap2/powerdomain.h | 2 + > arch/arm/mach-omap2/voltage.c | 80 +++++++++++++++++++++++++++++++++++++ > arch/arm/mach-omap2/voltage.h | 10 +++++ > 4 files changed, 94 insertions(+), 0 deletions(-) > ... > diff --git a/arch/arm/mach-omap2/voltage.h b/arch/arm/mach-omap2/voltage.h > index 966aa88..b41d9f1 100644 > --- a/arch/arm/mach-omap2/voltage.h > +++ b/arch/arm/mach-omap2/voltage.h > @@ -19,6 +19,8 @@ > #include "vc.h" > #include "vp.h" > > +struct powerdomain; > + > /* XXX document */ > #define VOLTSCALE_VPFORCEUPDATE 1 > #define VOLTSCALE_VCBYPASS 2 > @@ -55,12 +57,15 @@ struct omap_vfsm_instance_data { > * @name: Name of the voltage domain which can be used as a unique identifier. > * @scalable: Whether or not this voltage domain is scalable > * @node: list_head linking all voltage domains > + * @pwrdm_node: list_head linking all powerdomains in this voltagedomain > * @vdd: to be removed > + * @pwrdms: powerdomains in this voltagedomain > */ > struct voltagedomain { > char *name; > bool scalable; > struct list_head node; > + struct list_head pwrdm_list; > struct omap_vdd_info *vdd; > }; The kerneldoc is not reflecting the code for struct voltagedomain. Regards, Jean
WARNING: multiple messages have this Message-ID (diff)
From: jean.pihet@newoldbits.com (Jean Pihet) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 13/22] OMAP2+: voltage: keep track of powerdomains in each voltagedomain Date: Wed, 7 Sep 2011 11:23:21 +0200 [thread overview] Message-ID: <CAORVsuU27kNiJAt-YRgfJ5i0=ZpfcDhNfY+kYK+AnKurDHDPfQ@mail.gmail.com> (raw) In-Reply-To: <1314639355-12713-14-git-send-email-khilman@ti.com> Hi Kevin, On Mon, Aug 29, 2011 at 7:35 PM, Kevin Hilman <khilman@ti.com> wrote: > When a powerdomain is registered and it has an associated voltage domain, > add the powerdomain to the voltagedomain using voltdm_add_pwrdm(). > > Also add voltagedomain iterator helper functions to iterate over all > registered voltagedomains and all powerdomains associated with a > voltagedomain. > > Modeled after a similar relationship between clockdomains and powerdomains. > > Signed-off-by: Kevin Hilman <khilman@ti.com> > --- > ?arch/arm/mach-omap2/powerdomain.c | ? ?2 + > ?arch/arm/mach-omap2/powerdomain.h | ? ?2 + > ?arch/arm/mach-omap2/voltage.c ? ? | ? 80 +++++++++++++++++++++++++++++++++++++ > ?arch/arm/mach-omap2/voltage.h ? ? | ? 10 +++++ > ?4 files changed, 94 insertions(+), 0 deletions(-) > ... > diff --git a/arch/arm/mach-omap2/voltage.h b/arch/arm/mach-omap2/voltage.h > index 966aa88..b41d9f1 100644 > --- a/arch/arm/mach-omap2/voltage.h > +++ b/arch/arm/mach-omap2/voltage.h > @@ -19,6 +19,8 @@ > ?#include "vc.h" > ?#include "vp.h" > > +struct powerdomain; > + > ?/* XXX document */ > ?#define VOLTSCALE_VPFORCEUPDATE ? ? ? ? ? ? ? ?1 > ?#define VOLTSCALE_VCBYPASS ? ? ? ? ? ? 2 > @@ -55,12 +57,15 @@ struct omap_vfsm_instance_data { > ?* @name: Name of the voltage domain which can be used as a unique identifier. > ?* @scalable: Whether or not this voltage domain is scalable > ?* @node: list_head linking all voltage domains > + * @pwrdm_node: list_head linking all powerdomains in this voltagedomain > ?* @vdd: to be removed > + * @pwrdms: powerdomains in this voltagedomain > ?*/ > ?struct voltagedomain { > ? ? ? ?char *name; > ? ? ? ?bool scalable; > ? ? ? ?struct list_head node; > + ? ? ? struct list_head pwrdm_list; > ? ? ? ?struct omap_vdd_info *vdd; > ?}; The kerneldoc is not reflecting the code for struct voltagedomain. Regards, Jean
next prev parent reply other threads:[~2011-09-07 9:23 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-08-29 17:35 [PATCH 00/22] OMAP: voltage cleanup part A Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 01/22] OMAP2+: hwmod: remove unused voltagedomain pointer Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 02/22] OMAP2+: voltage: move PRCM mod offets into VC/VP structures Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 03/22] OMAP2+: voltage: move prm_irqst_reg from VP into voltage domain Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 04/22] OMAP2+: voltage: start towards a new voltagedomain layer Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 05/22] OMAP3: voltage: rename "mpu" voltagedomain to "mpu_iva" Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 06/22] OMAP3: voltagedomain data: add wakeup domain Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 07/22] OMAP3+: voltage: add scalable flag to voltagedomain Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 08/22] OMAP2+: powerdomain: add voltagedomain to struct powerdomain Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 09/22] OMAP2: add voltage domains and connect to powerdomains Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-09-07 10:39 ` Jean Pihet 2011-09-07 10:39 ` Jean Pihet 2011-09-09 21:41 ` Kevin Hilman 2011-09-09 21:41 ` Kevin Hilman 2011-09-09 21:46 ` Kevin Hilman 2011-09-09 21:46 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 10/22] OMAP3: powerdomain data: add voltage domains Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 11/22] OMAP4: " Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-09-07 9:04 ` Jean Pihet 2011-09-07 9:04 ` Jean Pihet 2011-09-09 21:48 ` Kevin Hilman 2011-09-09 21:48 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 12/22] OMAP2+: powerdomain: add voltage domain lookup during register Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 13/22] OMAP2+: voltage: keep track of powerdomains in each voltagedomain Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-09-07 9:23 ` Jean Pihet [this message] 2011-09-07 9:23 ` Jean Pihet 2011-09-09 21:52 ` Kevin Hilman 2011-09-09 21:52 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 14/22] OMAP2+: voltage: split voltage controller (VC) code into dedicated layer Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-09-07 10:42 ` Jean Pihet 2011-09-07 10:42 ` Jean Pihet 2011-09-09 21:51 ` Kevin Hilman 2011-09-09 21:51 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 15/22] OMAP2+: voltage: move VC into struct voltagedomain, misc. renames Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 16/22] OMAP2+: voltage: enable VC bypass scale method when VC is initialized Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 17/22] OMAP2+: voltage: split out voltage processor (VP) code into new layer Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-09-07 9:52 ` Jean Pihet 2011-09-07 9:52 ` Jean Pihet 2011-08-29 17:35 ` [PATCH 18/22] OMAP2+: VC: support PMICs with separate voltage and command registers Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 19/22] OMAP2+: add PRM VP functions for checking/clearing VP TX done status Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 20/22] OMAP3+ VP: replace transaction done check/clear with VP ops Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 21/22] OMAP2+: PRM: add register access functions for VC/VP Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-08-29 17:35 ` [PATCH 22/22] OMAP3+: voltage: convert to PRM register access functions Kevin Hilman 2011-08-29 17:35 ` Kevin Hilman 2011-09-07 19:12 ` [PATCH 00/22] OMAP: voltage cleanup part A Jean Pihet 2011-09-07 19:12 ` Jean Pihet
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAORVsuU27kNiJAt-YRgfJ5i0=ZpfcDhNfY+kYK+AnKurDHDPfQ@mail.gmail.com' \ --to=jean.pihet@newoldbits.com \ --cc=khilman@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.