From: Olof Johansson <olof@lixom.net>
To: Jolly Shah <jolly.shah@xilinx.com>
Cc: "ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
Ingo Molnar <mingo@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
matt@codeblueprint.co.uk, Sudeep Holla <sudeep.holla@arm.com>,
hkallweit1@gmail.com, Kees Cook <keescook@chromium.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Michal Simek <michal.simek@xilinx.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-clk <linux-clk@vger.kernel.org>,
rajanv@xilinx.com,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>, Jolly Shah <jollys@xilinx.com>
Subject: Re: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control
Date: Sat, 8 Sep 2018 18:18:53 -0700 [thread overview]
Message-ID: <CAOesGMi7Q9L4oZkUubKtV-m8XD67MQ05ZFhPA_0Hwky_qVUxfg@mail.gmail.com> (raw)
In-Reply-To: <1533318808-10781-4-git-send-email-jollys@xilinx.com>
Hi,
On Fri, Aug 3, 2018 at 10:53 AM, Jolly Shah <jolly.shah@xilinx.com> wrote:
> From: Rajan Vaja <rajanv@xilinx.com>
>
> Add ZynqMP firmware IOCTL API to control and configure
> devices like PLLs, SD, Gem, etc.
>
> Signed-off-by: Rajan Vaja <rajanv@xilinx.com>
> Signed-off-by: Jolly Shah <jollys@xilinx.com>
This patch worries me somewhat. It's a transparent pass-through ioctl
driver. Is there a spec available for what the implemented IOCTLs are?
Should some of them be proper drivers instead of an opaque
pass-through like this? Could some of them have stability impact on
the platform such that there are security concerns and the list of
arguments should somehow be sanitized?
What's the intended usecase anyway? Just a debug tool during
development, or something that you expect heavy use of by some
userspace middleware?
-Olof
WARNING: multiple messages have this Message-ID (diff)
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control
Date: Sat, 8 Sep 2018 18:18:53 -0700 [thread overview]
Message-ID: <CAOesGMi7Q9L4oZkUubKtV-m8XD67MQ05ZFhPA_0Hwky_qVUxfg@mail.gmail.com> (raw)
In-Reply-To: <1533318808-10781-4-git-send-email-jollys@xilinx.com>
Hi,
On Fri, Aug 3, 2018 at 10:53 AM, Jolly Shah <jolly.shah@xilinx.com> wrote:
> From: Rajan Vaja <rajanv@xilinx.com>
>
> Add ZynqMP firmware IOCTL API to control and configure
> devices like PLLs, SD, Gem, etc.
>
> Signed-off-by: Rajan Vaja <rajanv@xilinx.com>
> Signed-off-by: Jolly Shah <jollys@xilinx.com>
This patch worries me somewhat. It's a transparent pass-through ioctl
driver. Is there a spec available for what the implemented IOCTLs are?
Should some of them be proper drivers instead of an opaque
pass-through like this? Could some of them have stability impact on
the platform such that there are security concerns and the list of
arguments should somehow be sanitized?
What's the intended usecase anyway? Just a debug tool during
development, or something that you expect heavy use of by some
userspace middleware?
-Olof
next prev parent reply other threads:[~2018-09-09 1:18 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 17:53 [PATCH v11 00/11] drivers: Introduce firmware dnd clock river for ZynqMP core Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` [PATCH v11 01/11] dt-bindings: firmware: Add bindings for ZynqMP firmware Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` [PATCH v11 02/11] firmware: xilinx: Add Zynqmp firmware driver Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-09-09 1:18 ` Olof Johansson [this message]
2018-09-09 1:18 ` Olof Johansson
2018-09-09 19:20 ` Moritz Fischer
2018-09-09 19:20 ` Moritz Fischer
2018-09-10 12:35 ` Michal Simek
2018-09-10 12:35 ` Michal Simek
2018-09-10 12:35 ` Michal Simek
2018-09-10 8:43 ` Sudeep Holla
2018-09-10 8:43 ` Sudeep Holla
2018-09-10 12:34 ` Michal Simek
2018-09-10 12:34 ` Michal Simek
2018-09-10 12:34 ` Michal Simek
2018-09-10 19:17 ` Jolly Shah
2018-09-10 19:17 ` Jolly Shah
2018-09-10 19:17 ` Jolly Shah
2018-09-10 19:17 ` Jolly Shah
2018-09-11 10:02 ` Sudeep Holla
2018-09-11 10:02 ` Sudeep Holla
2018-09-11 10:02 ` Sudeep Holla
2018-09-11 15:03 ` Olof Johansson
2018-09-11 15:03 ` Olof Johansson
2018-09-11 15:03 ` Olof Johansson
2018-09-11 15:03 ` Olof Johansson
2018-09-11 19:20 ` Jolly Shah
2018-09-11 19:20 ` Jolly Shah
2018-09-11 19:20 ` Jolly Shah
2018-09-11 19:20 ` Jolly Shah
2018-09-23 13:10 ` Olof Johansson
2018-09-23 13:10 ` Olof Johansson
2018-09-23 13:10 ` Olof Johansson
2018-09-23 13:10 ` Olof Johansson
2018-09-24 18:26 ` Jolly Shah
2018-09-24 18:26 ` Jolly Shah
2018-09-24 18:26 ` Jolly Shah
2018-09-24 18:26 ` Jolly Shah
2018-08-03 17:53 ` [PATCH v11 04/11] firmware: xilinx: Add query data API Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` [PATCH v11 05/11] firmware: xilinx: Add clock APIs Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` [PATCH v11 06/11] firmware: xilinx: Add debugfs interface Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` [PATCH v11 07/11] firmware: xilinx: Add debugfs for IOCTL API Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` [PATCH v11 08/11] firmware: xilinx: Add debugfs for query data API Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-09-09 1:15 ` Olof Johansson
2018-09-09 1:15 ` Olof Johansson
2018-09-10 19:19 ` Jolly Shah
2018-09-10 19:19 ` Jolly Shah
2018-09-10 19:19 ` Jolly Shah
2018-09-10 19:19 ` Jolly Shah
2018-08-03 17:53 ` [PATCH v11 09/11] dt-bindings: clock: Add bindings for ZynqMP clock driver Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` [PATCH v11 10/11] drivers: clk: Add " Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` [PATCH v11 11/11] firmware: xilinx: Replace init call with probe method Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-03 17:53 ` Jolly Shah
2018-08-24 22:04 ` [PATCH v11 00/11] drivers: Introduce firmware dnd clock river for ZynqMP core Jolly Shah
2018-08-24 22:04 ` Jolly Shah
2018-08-24 22:04 ` Jolly Shah
2018-08-24 22:04 ` Jolly Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOesGMi7Q9L4oZkUubKtV-m8XD67MQ05ZFhPA_0Hwky_qVUxfg@mail.gmail.com \
--to=olof@lixom.net \
--cc=ard.biesheuvel@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=jolly.shah@xilinx.com \
--cc=jollys@xilinx.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matt@codeblueprint.co.uk \
--cc=michal.simek@xilinx.com \
--cc=mingo@kernel.org \
--cc=mturquette@baylibre.com \
--cc=rajanv@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.