Re: [PATCH v2 04/17] pmdomain: apple: Move Kconfig option to the pmdomain subsystem

From: Ulf Hansson <ulf.hansson@linaro.org>
To: Eric Curtin <ecurtin@redhat.com>, Neal Gompa <neal@gompa.dev>
Cc: Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	linux-pm@vger.kernel.org,  linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,  Hector Martin <marcan@marcan.st>,
	Sven Peter <sven@svenpeter.dev>,
	 Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	asahi@lists.linux.dev
Subject: Re: [PATCH v2 04/17] pmdomain: apple: Move Kconfig option to the pmdomain subsystem
Date: Fri, 15 Sep 2023 13:46:44 +0200	[thread overview]
Message-ID: <CAPDyKFpYRwDGbYajVK8MMDjf=0ab-ZpMH2QXKUsVAFy0kh-iYA@mail.gmail.com> (raw)
In-Reply-To: <CAOgh=FzNordx=_YMiQs2Uj6JQ7Ctqqi=XZbbRAY9cS-F8v68RA@mail.gmail.com>

+ Neal

On Fri, 15 Sept 2023 at 11:45, Eric Curtin <ecurtin@redhat.com> wrote:
>
> On Fri, 15 Sept 2023 at 10:29, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> >
> > The Kconfig option belongs closer to the corresponding implementation,
> > hence let's move it from the soc subsystem to the pmdomain subsystem.
> >
> > Cc: Hector Martin <marcan@marcan.st>
> > Cc: Sven Peter <sven@svenpeter.dev>
> > Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io>
> > Cc: <asahi@lists.linux.dev>
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> This patch in the patchset looks the same as yesterday, so...
>
> Reviewed-by: Eric Curtin <ecurtin@redhat.com>

Yes my bad, again. I forgot to add yours and Neal's tags, sorry.

Thanks!

Kind regards
Uffe

>
> Is mise le meas/Regards,
>
> Eric Curtin
>
> > ---
> >  drivers/pmdomain/Kconfig       |  1 +
> >  drivers/pmdomain/apple/Kconfig | 18 ++++++++++++++++++
> >  drivers/soc/apple/Kconfig      | 13 -------------
> >  3 files changed, 19 insertions(+), 13 deletions(-)
> >  create mode 100644 drivers/pmdomain/apple/Kconfig
> >
> > diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig
> > index 03c8991ad0fd..482d9e970e14 100644
> > --- a/drivers/pmdomain/Kconfig
> > +++ b/drivers/pmdomain/Kconfig
> > @@ -3,5 +3,6 @@ menu "PM Domains"
> >
> >  source "drivers/pmdomain/actions/Kconfig"
> >  source "drivers/pmdomain/amlogic/Kconfig"
> > +source "drivers/pmdomain/apple/Kconfig"
> >
> >  endmenu
> > diff --git a/drivers/pmdomain/apple/Kconfig b/drivers/pmdomain/apple/Kconfig
> > new file mode 100644
> > index 000000000000..12237cbcfaa9
> > --- /dev/null
> > +++ b/drivers/pmdomain/apple/Kconfig
> > @@ -0,0 +1,18 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +
> > +if ARCH_APPLE || COMPILE_TEST
> > +
> > +config APPLE_PMGR_PWRSTATE
> > +       bool "Apple SoC PMGR power state control"
> > +       depends on PM
> > +       select REGMAP
> > +       select MFD_SYSCON
> > +       select PM_GENERIC_DOMAINS
> > +       select RESET_CONTROLLER
> > +       default ARCH_APPLE
> > +       help
> > +         The PMGR block in Apple SoCs provides high-level power state
> > +         controls for SoC devices. This driver manages them through the
> > +         generic power domain framework, and also provides reset support.
> > +
> > +endif
> > diff --git a/drivers/soc/apple/Kconfig b/drivers/soc/apple/Kconfig
> > index a1596fefacff..eff486a77337 100644
> > --- a/drivers/soc/apple/Kconfig
> > +++ b/drivers/soc/apple/Kconfig
> > @@ -4,19 +4,6 @@ if ARCH_APPLE || COMPILE_TEST
> >
> >  menu "Apple SoC drivers"
> >
> > -config APPLE_PMGR_PWRSTATE
> > -       bool "Apple SoC PMGR power state control"
> > -       depends on PM
> > -       select REGMAP
> > -       select MFD_SYSCON
> > -       select PM_GENERIC_DOMAINS
> > -       select RESET_CONTROLLER
> > -       default ARCH_APPLE
> > -       help
> > -         The PMGR block in Apple SoCs provides high-level power state
> > -         controls for SoC devices. This driver manages them through the
> > -         generic power domain framework, and also provides reset support.
> > -
> >  config APPLE_RTKIT
> >         tristate "Apple RTKit co-processor IPC protocol"
> >         depends on MAILBOX
> > --
> > 2.34.1
> >
> >
>