From: Dave Stevenson <dave.stevenson@raspberrypi.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
Neil Armstrong <narmstrong@baylibre.com>,
David Airlie <airlied@linux.ie>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
dri-devel@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Jitao Shi <jitao.shi@mediatek.com>, Arnd Bergmann <arnd@arndb.de>,
Jonas Karlman <jonas@kwiboo.se>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Philip Chen <philipchen@chromium.org>,
Robert Foss <robert.foss@linaro.org>,
linux-renesas-soc@vger.kernel.org,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Cai Huoqing <cai.huoqing@linux.dev>
Subject: Re: [PATCH v1 08/12] drm/mediatek: Drop mtk_hdmi_bridge_mode_fixup
Date: Tue, 19 Jul 2022 15:09:38 +0100 [thread overview]
Message-ID: <CAPY8ntBVhdixytMMMxAZcnCYf=zCB14RGucgD+hsTrD5RFP_fw@mail.gmail.com> (raw)
In-Reply-To: <20220717175801.78668-1-sam@ravnborg.org>
On Sun, 17 Jul 2022 at 18:58, Sam Ravnborg <sam@ravnborg.org> wrote:
>
> The implementation of drm_bridge_funcs.mode_fixup is optional
> so there is no need to provide an empty implementation.
> Drop mtk_hdmi_bridge_mode_fixup() so the driver no longer uses the
> deprecated drm_bridge_funcs.mode_fixup() operation.
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: linux-mediatek@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index a63b76055f81..7321aa1ee6f0 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -1293,13 +1293,6 @@ static int mtk_hdmi_bridge_attach(struct drm_bridge *bridge,
> return 0;
> }
>
> -static bool mtk_hdmi_bridge_mode_fixup(struct drm_bridge *bridge,
> - const struct drm_display_mode *mode,
> - struct drm_display_mode *adjusted_mode)
> -{
> - return true;
> -}
> -
> static void mtk_hdmi_bridge_atomic_disable(struct drm_bridge *bridge,
> struct drm_bridge_state *old_bridge_state)
> {
> @@ -1399,7 +1392,6 @@ static const struct drm_bridge_funcs mtk_hdmi_bridge_funcs = {
> .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
> .atomic_reset = drm_atomic_helper_bridge_reset,
> .attach = mtk_hdmi_bridge_attach,
> - .mode_fixup = mtk_hdmi_bridge_mode_fixup,
> .atomic_disable = mtk_hdmi_bridge_atomic_disable,
> .atomic_post_disable = mtk_hdmi_bridge_atomic_post_disable,
> .mode_set = mtk_hdmi_bridge_mode_set,
> --
> 2.34.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Stevenson <dave.stevenson@raspberrypi.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: dri-devel@lists.freedesktop.org,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
David Airlie <airlied@linux.ie>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Jitao Shi <jitao.shi@mediatek.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Arnd Bergmann <arnd@arndb.de>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Philip Chen <philipchen@chromium.org>,
linux-renesas-soc@vger.kernel.org,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Cai Huoqing <cai.huoqing@linux.dev>
Subject: Re: [PATCH v1 08/12] drm/mediatek: Drop mtk_hdmi_bridge_mode_fixup
Date: Tue, 19 Jul 2022 15:09:38 +0100 [thread overview]
Message-ID: <CAPY8ntBVhdixytMMMxAZcnCYf=zCB14RGucgD+hsTrD5RFP_fw@mail.gmail.com> (raw)
In-Reply-To: <20220717175801.78668-1-sam@ravnborg.org>
On Sun, 17 Jul 2022 at 18:58, Sam Ravnborg <sam@ravnborg.org> wrote:
>
> The implementation of drm_bridge_funcs.mode_fixup is optional
> so there is no need to provide an empty implementation.
> Drop mtk_hdmi_bridge_mode_fixup() so the driver no longer uses the
> deprecated drm_bridge_funcs.mode_fixup() operation.
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: linux-mediatek@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index a63b76055f81..7321aa1ee6f0 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -1293,13 +1293,6 @@ static int mtk_hdmi_bridge_attach(struct drm_bridge *bridge,
> return 0;
> }
>
> -static bool mtk_hdmi_bridge_mode_fixup(struct drm_bridge *bridge,
> - const struct drm_display_mode *mode,
> - struct drm_display_mode *adjusted_mode)
> -{
> - return true;
> -}
> -
> static void mtk_hdmi_bridge_atomic_disable(struct drm_bridge *bridge,
> struct drm_bridge_state *old_bridge_state)
> {
> @@ -1399,7 +1392,6 @@ static const struct drm_bridge_funcs mtk_hdmi_bridge_funcs = {
> .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
> .atomic_reset = drm_atomic_helper_bridge_reset,
> .attach = mtk_hdmi_bridge_attach,
> - .mode_fixup = mtk_hdmi_bridge_mode_fixup,
> .atomic_disable = mtk_hdmi_bridge_atomic_disable,
> .atomic_post_disable = mtk_hdmi_bridge_atomic_post_disable,
> .mode_set = mtk_hdmi_bridge_mode_set,
> --
> 2.34.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Stevenson <dave.stevenson@raspberrypi.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: dri-devel@lists.freedesktop.org,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
David Airlie <airlied@linux.ie>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Jitao Shi <jitao.shi@mediatek.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Arnd Bergmann <arnd@arndb.de>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Philip Chen <philipchen@chromium.org>,
linux-renesas-soc@vger.kernel.org,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Cai Huoqing <cai.huoqing@linux.dev>
Subject: Re: [PATCH v1 08/12] drm/mediatek: Drop mtk_hdmi_bridge_mode_fixup
Date: Tue, 19 Jul 2022 15:09:38 +0100 [thread overview]
Message-ID: <CAPY8ntBVhdixytMMMxAZcnCYf=zCB14RGucgD+hsTrD5RFP_fw@mail.gmail.com> (raw)
In-Reply-To: <20220717175801.78668-1-sam@ravnborg.org>
On Sun, 17 Jul 2022 at 18:58, Sam Ravnborg <sam@ravnborg.org> wrote:
>
> The implementation of drm_bridge_funcs.mode_fixup is optional
> so there is no need to provide an empty implementation.
> Drop mtk_hdmi_bridge_mode_fixup() so the driver no longer uses the
> deprecated drm_bridge_funcs.mode_fixup() operation.
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: linux-mediatek@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index a63b76055f81..7321aa1ee6f0 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -1293,13 +1293,6 @@ static int mtk_hdmi_bridge_attach(struct drm_bridge *bridge,
> return 0;
> }
>
> -static bool mtk_hdmi_bridge_mode_fixup(struct drm_bridge *bridge,
> - const struct drm_display_mode *mode,
> - struct drm_display_mode *adjusted_mode)
> -{
> - return true;
> -}
> -
> static void mtk_hdmi_bridge_atomic_disable(struct drm_bridge *bridge,
> struct drm_bridge_state *old_bridge_state)
> {
> @@ -1399,7 +1392,6 @@ static const struct drm_bridge_funcs mtk_hdmi_bridge_funcs = {
> .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
> .atomic_reset = drm_atomic_helper_bridge_reset,
> .attach = mtk_hdmi_bridge_attach,
> - .mode_fixup = mtk_hdmi_bridge_mode_fixup,
> .atomic_disable = mtk_hdmi_bridge_atomic_disable,
> .atomic_post_disable = mtk_hdmi_bridge_atomic_post_disable,
> .mode_set = mtk_hdmi_bridge_mode_set,
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-19 14:09 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-17 17:44 [PATCH v1 0/12] drm bridge updates Sam Ravnborg
2022-07-17 17:44 ` Sam Ravnborg
2022-07-17 17:44 ` Sam Ravnborg
2022-07-17 17:44 ` [PATCH v1 01/12] drm/bridge: ps8640: Use atomic variants of drm_bridge_funcs Sam Ravnborg
2022-07-17 17:44 ` Sam Ravnborg
2022-07-17 17:44 ` Sam Ravnborg
2022-09-19 15:17 ` Laurent Pinchart
2022-09-19 15:17 ` Laurent Pinchart
2022-09-19 15:17 ` Laurent Pinchart
2022-07-17 17:44 ` [PATCH v1 02/12] drm/bridge: Drop unused drm_bridge_chain functions Sam Ravnborg
2022-07-17 17:44 ` Sam Ravnborg
2022-07-17 17:44 ` Sam Ravnborg
2022-07-17 17:44 ` [PATCH v1 03/12] drm/mediatek: Drop chain_mode_fixup call in mode_valid() Sam Ravnborg
2022-07-17 17:44 ` Sam Ravnborg
2022-07-17 17:44 ` Sam Ravnborg
2022-09-18 4:45 ` Chun-Kuang Hu
2022-09-18 4:45 ` Chun-Kuang Hu
2022-09-18 4:45 ` Chun-Kuang Hu
2022-09-19 15:18 ` Laurent Pinchart
2022-09-19 15:18 ` Laurent Pinchart
2022-09-19 15:18 ` Laurent Pinchart
2022-07-17 17:44 ` [PATCH v1 04/12] drm/bridge: Drop drm_bridge_chain_mode_fixup Sam Ravnborg
2022-07-17 17:44 ` Sam Ravnborg
2022-07-17 17:44 ` Sam Ravnborg
2022-09-19 15:19 ` Laurent Pinchart
2022-09-19 15:19 ` Laurent Pinchart
2022-09-19 15:19 ` Laurent Pinchart
2022-07-17 17:44 ` [PATCH v1 05/12] drm/bridge: sii8620: Use drm_bridge_funcs.atomic_check Sam Ravnborg
2022-07-17 17:44 ` Sam Ravnborg
2022-07-17 17:44 ` Sam Ravnborg
2022-07-19 13:59 ` Dave Stevenson
2022-07-19 13:59 ` Dave Stevenson
2022-07-19 13:59 ` Dave Stevenson
2022-09-19 15:27 ` Laurent Pinchart
2022-09-19 15:27 ` Laurent Pinchart
2022-09-19 15:27 ` Laurent Pinchart
2022-07-17 17:44 ` [PATCH v1 06/12] drm/bridge: cros-ec-anx7688: " Sam Ravnborg
2022-07-17 17:44 ` Sam Ravnborg
2022-07-17 17:44 ` Sam Ravnborg
2022-07-19 14:03 ` Dave Stevenson
2022-07-19 14:03 ` Dave Stevenson
2022-07-19 14:03 ` Dave Stevenson
2022-09-19 15:28 ` Laurent Pinchart
2022-09-19 15:28 ` Laurent Pinchart
2022-09-19 15:28 ` Laurent Pinchart
2022-07-17 17:44 ` [PATCH v1 07/12] drm/bridge: tc358767: " Sam Ravnborg
2022-07-17 17:44 ` Sam Ravnborg
2022-07-17 17:44 ` Sam Ravnborg
2022-07-19 14:08 ` Dave Stevenson
2022-07-19 14:08 ` Dave Stevenson
2022-07-19 14:08 ` Dave Stevenson
2022-09-19 15:29 ` Laurent Pinchart
2022-09-19 15:29 ` Laurent Pinchart
2022-09-19 15:29 ` Laurent Pinchart
2022-09-19 15:38 ` Laurent Pinchart
2022-09-19 15:38 ` Laurent Pinchart
2022-09-19 15:38 ` Laurent Pinchart
2022-07-17 17:57 ` [PATCH v1 08/12] drm/mediatek: Drop mtk_hdmi_bridge_mode_fixup Sam Ravnborg
2022-07-17 17:57 ` Sam Ravnborg
2022-07-17 17:57 ` Sam Ravnborg
2022-07-17 17:57 ` [PATCH v1 09/12] drm/rcar-du: lvds: Use drm_bridge_funcs.atomic_check Sam Ravnborg
2022-07-17 17:57 ` Sam Ravnborg
2022-07-17 17:57 ` Sam Ravnborg
2022-07-19 14:11 ` Dave Stevenson
2022-07-19 14:11 ` Dave Stevenson
2022-07-19 14:11 ` Dave Stevenson
2022-09-19 15:31 ` Laurent Pinchart
2022-09-19 15:31 ` Laurent Pinchart
2022-09-19 15:31 ` Laurent Pinchart
2022-07-17 17:57 ` [PATCH v1 10/12] drm/omapdrm: " Sam Ravnborg
2022-07-17 17:57 ` Sam Ravnborg
2022-07-17 17:57 ` Sam Ravnborg
2022-09-19 15:33 ` Laurent Pinchart
2022-09-19 15:33 ` Laurent Pinchart
2022-09-19 15:33 ` Laurent Pinchart
2022-07-17 17:58 ` [PATCH v1 11/12] drm/bridge: Drop drm_bridge_funcs.mode_fixup Sam Ravnborg
2022-07-17 17:58 ` Sam Ravnborg
2022-07-17 17:58 ` Sam Ravnborg
2022-07-19 14:22 ` Dave Stevenson
2022-07-19 14:22 ` Dave Stevenson
2022-07-19 14:22 ` Dave Stevenson
2022-09-19 15:34 ` Laurent Pinchart
2022-09-19 15:34 ` Laurent Pinchart
2022-09-19 15:34 ` Laurent Pinchart
2022-07-17 17:58 ` [PATCH v1 12/12] drm/todo: Add bridge related todo items Sam Ravnborg
2022-07-17 17:58 ` Sam Ravnborg
2022-07-17 17:58 ` Sam Ravnborg
2022-07-18 10:27 ` Dave Stevenson
2022-07-18 10:27 ` Dave Stevenson
2022-07-18 10:27 ` Dave Stevenson
2022-07-18 18:00 ` Sam Ravnborg
2022-07-18 18:00 ` Sam Ravnborg
2022-07-19 10:47 ` Dave Stevenson
2022-07-19 10:47 ` Dave Stevenson
2022-07-19 14:09 ` Dave Stevenson [this message]
2022-07-19 14:09 ` [PATCH v1 08/12] drm/mediatek: Drop mtk_hdmi_bridge_mode_fixup Dave Stevenson
2022-07-19 14:09 ` Dave Stevenson
2022-09-18 4:46 ` Chun-Kuang Hu
2022-09-18 4:46 ` Chun-Kuang Hu
2022-09-18 4:46 ` Chun-Kuang Hu
2022-09-19 15:30 ` Laurent Pinchart
2022-09-19 15:30 ` Laurent Pinchart
2022-09-19 15:30 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPY8ntBVhdixytMMMxAZcnCYf=zCB14RGucgD+hsTrD5RFP_fw@mail.gmail.com' \
--to=dave.stevenson@raspberrypi.com \
--cc=airlied@linux.ie \
--cc=andrzej.hajda@intel.com \
--cc=arnd@arndb.de \
--cc=cai.huoqing@linux.dev \
--cc=chrome-platform@lists.linux.dev \
--cc=chunkuang.hu@kernel.org \
--cc=dafna.hirschfeld@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=jernej.skrabec@gmail.com \
--cc=jitao.shi@mediatek.com \
--cc=jonas@kwiboo.se \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=narmstrong@baylibre.com \
--cc=philipchen@chromium.org \
--cc=robert.foss@linaro.org \
--cc=sam@ravnborg.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.