From: Sam Ravnborg <sam@ravnborg.org> To: Dave Stevenson <dave.stevenson@raspberrypi.com> Cc: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>, Neil Armstrong <narmstrong@baylibre.com>, David Airlie <airlied@linux.ie>, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>, DRI Development <dri-devel@lists.freedesktop.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Andrzej Hajda <andrzej.hajda@intel.com>, Guenter Roeck <groeck@chromium.org>, chrome-platform@lists.linux.dev, Jernej Skrabec <jernej.skrabec@gmail.com>, Chun-Kuang Hu <chunkuang.hu@kernel.org>, Jitao Shi <jitao.shi@mediatek.com>, Arnd Bergmann <arnd@arndb.de>, Jonas Karlman <jonas@kwiboo.se>, linux-mediatek@lists.infradead.org, Matthias Brugger <matthias.bgg@gmail.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Philip Chen <philipchen@chromium.org>, Robert Foss <robert.foss@linaro.org>, linux-renesas-soc@vger.kernel.org, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Thomas Zimmermann <tzimmermann@suse.de>, Enric Balletbo i Serra <enric.balletbo@collabora.com>, Cai Huoqing <cai.huoqing@linux.dev> Subject: Re: [PATCH v1 12/12] drm/todo: Add bridge related todo items Date: Mon, 18 Jul 2022 20:00:20 +0200 [thread overview] Message-ID: <YtWftDRPYcP5p+i1@ravnborg.org> (raw) In-Reply-To: <CAPY8ntB2gXoUbUJhDLWVX3szaEKKKhnOO-qsKRZkMp1jDOt0Qg@mail.gmail.com> Hi Dave, On Mon, Jul 18, 2022 at 11:27:37AM +0100, Dave Stevenson wrote: > Hi Sam > > On Sun, 17 Jul 2022 at 18:58, Sam Ravnborg <sam@ravnborg.org> wrote: > > > > Add todo in the hope someone will help updating the bridge drivers. > > > > v2: > > - Updated descriptions in todo.rst > > > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > > Acked-by: Maxime Ripard <mripard@kernel.org> > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Cc: Maxime Ripard <mripard@kernel.org> > > Cc: Thomas Zimmermann <tzimmermann@suse.de> > > Cc: David Airlie <airlied@linux.ie> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > --- > > Documentation/gpu/todo.rst | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > > index 10bfb50908d1..fbcc232e0bc1 100644 > > --- a/Documentation/gpu/todo.rst > > +++ b/Documentation/gpu/todo.rst > > @@ -480,6 +480,26 @@ Contact: Thomas Zimmermann <tzimmermann@suse.de> > > > > Level: Starter > > > > +Drop use of deprecated operations in bridge drivers > > +-------------------------------------------------- > > + > > +&struct drm_bridge_funcs contains a number of deprecated operations > > +which can be replaced by the atomic variants. > > + > > +The following is more or less 1:1 replacements with the arguments > > +and names adjusted: > > +* pre_enable => atomic_pre_enable > > +* enable => atomic_enable > > +* disable => atomic_disable > > +* post_disable => atomic_post_disable > > + > > +* mode_set is no longer required and the implementation shall be merged > > + with atomic_enable. > > The dw-mipi-dsi and msm DSI host controller bridge drivers are > currently relying on mode_set as a convenient hook to power up the DSI > host prior to pre_enable of the bridge chain. Removing it is therefore > going to break those. > > There is a proposed mechanism to allow for the removal of this hack > [1], but it's still waiting on R-B tags and/or discussion from bridge > maintainers (gentle nudge as you are one of those maintainers). I have over time gained some knowledge of how bridges works and have applied a few patches - but the maintainer role belongs to others. I just try to help a bit. I will review the referenced series - could you then in return review this series? > > And do you mean merge with atomic_enable, or merge with > atomic_pre_enable? atomic_pre_enable would be more applicable for > almost all the bridges I'm aware of as they want to be configured > before video starts. Thanks, yes you are right. I will update the text to refer to pre_enable as this is often the right choice. Looking at how many bridges who implements mode_set, or are not yet atomic, this will take a while before we can drop it. Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org> To: Dave Stevenson <dave.stevenson@raspberrypi.com> Cc: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>, Neil Armstrong <narmstrong@baylibre.com>, David Airlie <airlied@linux.ie>, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>, DRI Development <dri-devel@lists.freedesktop.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Andrzej Hajda <andrzej.hajda@intel.com>, Guenter Roeck <groeck@chromium.org>, chrome-platform@lists.linux.dev, Jernej Skrabec <jernej.skrabec@gmail.com>, Chun-Kuang Hu <chunkuang.hu@kernel.org>, Jitao Shi <jitao.shi@mediatek.com>, Arnd Bergmann <arnd@arndb.de>, Jonas Karlman <jonas@kwiboo.se>, linux-mediatek@lists.infradead.org, Matthias Brugger <matthias.bgg@gmail.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Philip Chen <philipchen@chromium.org>, Robert Foss <robert.foss@linaro.org>, linux-renesas-soc@vger.kernel.org, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Thomas Zimmermann <tzimmermann@suse.de>, Enric Balletbo i Serra <enric.balletbo@collabora.com>, Cai Huoqing <cai.huoqing@linux.dev> Subject: Re: [PATCH v1 12/12] drm/todo: Add bridge related todo items Date: Mon, 18 Jul 2022 20:00:20 +0200 [thread overview] Message-ID: <YtWftDRPYcP5p+i1@ravnborg.org> (raw) In-Reply-To: <CAPY8ntB2gXoUbUJhDLWVX3szaEKKKhnOO-qsKRZkMp1jDOt0Qg@mail.gmail.com> Hi Dave, On Mon, Jul 18, 2022 at 11:27:37AM +0100, Dave Stevenson wrote: > Hi Sam > > On Sun, 17 Jul 2022 at 18:58, Sam Ravnborg <sam@ravnborg.org> wrote: > > > > Add todo in the hope someone will help updating the bridge drivers. > > > > v2: > > - Updated descriptions in todo.rst > > > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > > Acked-by: Maxime Ripard <mripard@kernel.org> > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Cc: Maxime Ripard <mripard@kernel.org> > > Cc: Thomas Zimmermann <tzimmermann@suse.de> > > Cc: David Airlie <airlied@linux.ie> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > --- > > Documentation/gpu/todo.rst | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > > index 10bfb50908d1..fbcc232e0bc1 100644 > > --- a/Documentation/gpu/todo.rst > > +++ b/Documentation/gpu/todo.rst > > @@ -480,6 +480,26 @@ Contact: Thomas Zimmermann <tzimmermann@suse.de> > > > > Level: Starter > > > > +Drop use of deprecated operations in bridge drivers > > +-------------------------------------------------- > > + > > +&struct drm_bridge_funcs contains a number of deprecated operations > > +which can be replaced by the atomic variants. > > + > > +The following is more or less 1:1 replacements with the arguments > > +and names adjusted: > > +* pre_enable => atomic_pre_enable > > +* enable => atomic_enable > > +* disable => atomic_disable > > +* post_disable => atomic_post_disable > > + > > +* mode_set is no longer required and the implementation shall be merged > > + with atomic_enable. > > The dw-mipi-dsi and msm DSI host controller bridge drivers are > currently relying on mode_set as a convenient hook to power up the DSI > host prior to pre_enable of the bridge chain. Removing it is therefore > going to break those. > > There is a proposed mechanism to allow for the removal of this hack > [1], but it's still waiting on R-B tags and/or discussion from bridge > maintainers (gentle nudge as you are one of those maintainers). I have over time gained some knowledge of how bridges works and have applied a few patches - but the maintainer role belongs to others. I just try to help a bit. I will review the referenced series - could you then in return review this series? > > And do you mean merge with atomic_enable, or merge with > atomic_pre_enable? atomic_pre_enable would be more applicable for > almost all the bridges I'm aware of as they want to be configured > before video starts. Thanks, yes you are right. I will update the text to refer to pre_enable as this is often the right choice. Looking at how many bridges who implements mode_set, or are not yet atomic, this will take a while before we can drop it. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-18 18:01 UTC|newest] Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-17 17:44 [PATCH v1 0/12] drm bridge updates Sam Ravnborg 2022-07-17 17:44 ` Sam Ravnborg 2022-07-17 17:44 ` Sam Ravnborg 2022-07-17 17:44 ` [PATCH v1 01/12] drm/bridge: ps8640: Use atomic variants of drm_bridge_funcs Sam Ravnborg 2022-07-17 17:44 ` Sam Ravnborg 2022-07-17 17:44 ` Sam Ravnborg 2022-09-19 15:17 ` Laurent Pinchart 2022-09-19 15:17 ` Laurent Pinchart 2022-09-19 15:17 ` Laurent Pinchart 2022-07-17 17:44 ` [PATCH v1 02/12] drm/bridge: Drop unused drm_bridge_chain functions Sam Ravnborg 2022-07-17 17:44 ` Sam Ravnborg 2022-07-17 17:44 ` Sam Ravnborg 2022-07-17 17:44 ` [PATCH v1 03/12] drm/mediatek: Drop chain_mode_fixup call in mode_valid() Sam Ravnborg 2022-07-17 17:44 ` Sam Ravnborg 2022-07-17 17:44 ` Sam Ravnborg 2022-09-18 4:45 ` Chun-Kuang Hu 2022-09-18 4:45 ` Chun-Kuang Hu 2022-09-18 4:45 ` Chun-Kuang Hu 2022-09-19 15:18 ` Laurent Pinchart 2022-09-19 15:18 ` Laurent Pinchart 2022-09-19 15:18 ` Laurent Pinchart 2022-07-17 17:44 ` [PATCH v1 04/12] drm/bridge: Drop drm_bridge_chain_mode_fixup Sam Ravnborg 2022-07-17 17:44 ` Sam Ravnborg 2022-07-17 17:44 ` Sam Ravnborg 2022-09-19 15:19 ` Laurent Pinchart 2022-09-19 15:19 ` Laurent Pinchart 2022-09-19 15:19 ` Laurent Pinchart 2022-07-17 17:44 ` [PATCH v1 05/12] drm/bridge: sii8620: Use drm_bridge_funcs.atomic_check Sam Ravnborg 2022-07-17 17:44 ` Sam Ravnborg 2022-07-17 17:44 ` Sam Ravnborg 2022-07-19 13:59 ` Dave Stevenson 2022-07-19 13:59 ` Dave Stevenson 2022-07-19 13:59 ` Dave Stevenson 2022-09-19 15:27 ` Laurent Pinchart 2022-09-19 15:27 ` Laurent Pinchart 2022-09-19 15:27 ` Laurent Pinchart 2022-07-17 17:44 ` [PATCH v1 06/12] drm/bridge: cros-ec-anx7688: " Sam Ravnborg 2022-07-17 17:44 ` Sam Ravnborg 2022-07-17 17:44 ` Sam Ravnborg 2022-07-19 14:03 ` Dave Stevenson 2022-07-19 14:03 ` Dave Stevenson 2022-07-19 14:03 ` Dave Stevenson 2022-09-19 15:28 ` Laurent Pinchart 2022-09-19 15:28 ` Laurent Pinchart 2022-09-19 15:28 ` Laurent Pinchart 2022-07-17 17:44 ` [PATCH v1 07/12] drm/bridge: tc358767: " Sam Ravnborg 2022-07-17 17:44 ` Sam Ravnborg 2022-07-17 17:44 ` Sam Ravnborg 2022-07-19 14:08 ` Dave Stevenson 2022-07-19 14:08 ` Dave Stevenson 2022-07-19 14:08 ` Dave Stevenson 2022-09-19 15:29 ` Laurent Pinchart 2022-09-19 15:29 ` Laurent Pinchart 2022-09-19 15:29 ` Laurent Pinchart 2022-09-19 15:38 ` Laurent Pinchart 2022-09-19 15:38 ` Laurent Pinchart 2022-09-19 15:38 ` Laurent Pinchart 2022-07-17 17:57 ` [PATCH v1 08/12] drm/mediatek: Drop mtk_hdmi_bridge_mode_fixup Sam Ravnborg 2022-07-17 17:57 ` Sam Ravnborg 2022-07-17 17:57 ` Sam Ravnborg 2022-07-17 17:57 ` [PATCH v1 09/12] drm/rcar-du: lvds: Use drm_bridge_funcs.atomic_check Sam Ravnborg 2022-07-17 17:57 ` Sam Ravnborg 2022-07-17 17:57 ` Sam Ravnborg 2022-07-19 14:11 ` Dave Stevenson 2022-07-19 14:11 ` Dave Stevenson 2022-07-19 14:11 ` Dave Stevenson 2022-09-19 15:31 ` Laurent Pinchart 2022-09-19 15:31 ` Laurent Pinchart 2022-09-19 15:31 ` Laurent Pinchart 2022-07-17 17:57 ` [PATCH v1 10/12] drm/omapdrm: " Sam Ravnborg 2022-07-17 17:57 ` Sam Ravnborg 2022-07-17 17:57 ` Sam Ravnborg 2022-09-19 15:33 ` Laurent Pinchart 2022-09-19 15:33 ` Laurent Pinchart 2022-09-19 15:33 ` Laurent Pinchart 2022-07-17 17:58 ` [PATCH v1 11/12] drm/bridge: Drop drm_bridge_funcs.mode_fixup Sam Ravnborg 2022-07-17 17:58 ` Sam Ravnborg 2022-07-17 17:58 ` Sam Ravnborg 2022-07-19 14:22 ` Dave Stevenson 2022-07-19 14:22 ` Dave Stevenson 2022-07-19 14:22 ` Dave Stevenson 2022-09-19 15:34 ` Laurent Pinchart 2022-09-19 15:34 ` Laurent Pinchart 2022-09-19 15:34 ` Laurent Pinchart 2022-07-17 17:58 ` [PATCH v1 12/12] drm/todo: Add bridge related todo items Sam Ravnborg 2022-07-17 17:58 ` Sam Ravnborg 2022-07-17 17:58 ` Sam Ravnborg 2022-07-18 10:27 ` Dave Stevenson 2022-07-18 10:27 ` Dave Stevenson 2022-07-18 10:27 ` Dave Stevenson 2022-07-18 18:00 ` Sam Ravnborg [this message] 2022-07-18 18:00 ` Sam Ravnborg 2022-07-19 10:47 ` Dave Stevenson 2022-07-19 10:47 ` Dave Stevenson 2022-07-19 14:09 ` [PATCH v1 08/12] drm/mediatek: Drop mtk_hdmi_bridge_mode_fixup Dave Stevenson 2022-07-19 14:09 ` Dave Stevenson 2022-07-19 14:09 ` Dave Stevenson 2022-09-18 4:46 ` Chun-Kuang Hu 2022-09-18 4:46 ` Chun-Kuang Hu 2022-09-18 4:46 ` Chun-Kuang Hu 2022-09-19 15:30 ` Laurent Pinchart 2022-09-19 15:30 ` Laurent Pinchart 2022-09-19 15:30 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YtWftDRPYcP5p+i1@ravnborg.org \ --to=sam@ravnborg.org \ --cc=airlied@linux.ie \ --cc=andrzej.hajda@intel.com \ --cc=arnd@arndb.de \ --cc=cai.huoqing@linux.dev \ --cc=chrome-platform@lists.linux.dev \ --cc=chunkuang.hu@kernel.org \ --cc=dafna.hirschfeld@collabora.com \ --cc=dave.stevenson@raspberrypi.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=enric.balletbo@collabora.com \ --cc=groeck@chromium.org \ --cc=jernej.skrabec@gmail.com \ --cc=jitao.shi@mediatek.com \ --cc=jonas@kwiboo.se \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=matthias.bgg@gmail.com \ --cc=narmstrong@baylibre.com \ --cc=philipchen@chromium.org \ --cc=robert.foss@linaro.org \ --cc=tomi.valkeinen@ideasonboard.com \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.