From: "Gupta, Nipun" <Nipun.Gupta@amd.com> To: Greg KH <gregkh@linuxfoundation.org> Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>, "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>, "rafael@kernel.org" <rafael@kernel.org>, "eric.auger@redhat.com" <eric.auger@redhat.com>, "alex.williamson@redhat.com" <alex.williamson@redhat.com>, "cohuck@redhat.com" <cohuck@redhat.com>, "song.bao.hua@hisilicon.com" <song.bao.hua@hisilicon.com>, "mchehab+huawei@kernel.org" <mchehab+huawei@kernel.org>, "maz@kernel.org" <maz@kernel.org>, "f.fainelli@gmail.com" <f.fainelli@gmail.com>, "jeffrey.l.hugo@gmail.com" <jeffrey.l.hugo@gmail.com>, "saravanak@google.com" <saravanak@google.com>, "Michael.Srba@seznam.cz" <Michael.Srba@seznam.cz>, "mani@kernel.org" <mani@kernel.org>, "yishaih@nvidia.com" <yishaih@nvidia.com>, "jgg@ziepe.ca" <jgg@ziepe.ca>, "jgg@nvidia.com" <jgg@nvidia.com>, "robin.murphy@arm.com" <robin.murphy@arm.com>, "will@kernel.org" <will@kernel.org>, "joro@8bytes.org" <joro@8bytes.org>, "masahiroy@kernel.org" <masahiroy@kernel.org>, "ndesaulniers@google.com" <ndesaulniers@google.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "okaya@kernel.org" <okaya@kernel.org>, "Anand, Harpreet" <harpreet.anand@amd.com>, "Agarwal, Nikhil" <nikhil.agarwal@amd.com>, "Simek, Michal" <michal.simek@amd.com>, "git (AMD-Xilinx)" <git@amd.com> Subject: RE: [PATCH 05/19] bus/cdx: add cdx controller Date: Wed, 18 Jan 2023 12:36:12 +0000 [thread overview] Message-ID: <DM6PR12MB30827F763B25B96BF1EB1E3EE8C79@DM6PR12MB3082.namprd12.prod.outlook.com> (raw) In-Reply-To: <Y8asSo2daSm5AWfR@kroah.com> [AMD Official Use Only - General] > -----Original Message----- > From: Greg KH <gregkh@linuxfoundation.org> > Sent: Tuesday, January 17, 2023 7:40 PM > To: Gupta, Nipun <Nipun.Gupta@amd.com> > Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; rafael@kernel.org; > eric.auger@redhat.com; alex.williamson@redhat.com; cohuck@redhat.com; > song.bao.hua@hisilicon.com; mchehab+huawei@kernel.org; maz@kernel.org; > f.fainelli@gmail.com; jeffrey.l.hugo@gmail.com; saravanak@google.com; > Michael.Srba@seznam.cz; mani@kernel.org; yishaih@nvidia.com; > jgg@ziepe.ca; jgg@nvidia.com; robin.murphy@arm.com; will@kernel.org; > joro@8bytes.org; masahiroy@kernel.org; ndesaulniers@google.com; linux-arm- > kernel@lists.infradead.org; linux-kbuild@vger.kernel.org; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org; okaya@kernel.org; > Anand, Harpreet <harpreet.anand@amd.com>; Agarwal, Nikhil > <nikhil.agarwal@amd.com>; Simek, Michal <michal.simek@amd.com>; git > (AMD-Xilinx) <git@amd.com> > Subject: Re: [PATCH 05/19] bus/cdx: add cdx controller > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On Tue, Jan 17, 2023 at 07:11:37PM +0530, Nipun Gupta wrote: > > --- /dev/null > > +++ b/drivers/bus/cdx/controller/cdx_controller.c > > @@ -0,0 +1,243 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Platform driver for CDX bus controller. > > Why is this a platform driver? Shouldn't it also be on some type of bus > so that you can find it? This is host controller for CDX bus similar to PCI controller which is also on the platform bus. Since CDX bus controller is based on communication with RPU firmware we need to have references to remoteproc device in CDX controller node to use the RPMsg device. > > > +MODULE_VERSION("1.0"); > > There's never need for any module versions once the code is in the > kernel tree as then they make no sense at all. Please drop them from > this series. Sure. Will remove. > > thanks, > > greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Gupta, Nipun" <Nipun.Gupta@amd.com> To: Greg KH <gregkh@linuxfoundation.org> Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>, "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>, "rafael@kernel.org" <rafael@kernel.org>, "eric.auger@redhat.com" <eric.auger@redhat.com>, "alex.williamson@redhat.com" <alex.williamson@redhat.com>, "cohuck@redhat.com" <cohuck@redhat.com>, "song.bao.hua@hisilicon.com" <song.bao.hua@hisilicon.com>, "mchehab+huawei@kernel.org" <mchehab+huawei@kernel.org>, "maz@kernel.org" <maz@kernel.org>, "f.fainelli@gmail.com" <f.fainelli@gmail.com>, "jeffrey.l.hugo@gmail.com" <jeffrey.l.hugo@gmail.com>, "saravanak@google.com" <saravanak@google.com>, "Michael.Srba@seznam.cz" <Michael.Srba@seznam.cz>, "mani@kernel.org" <mani@kernel.org>, "yishaih@nvidia.com" <yishaih@nvidia.com>, "jgg@ziepe.ca" <jgg@ziepe.ca>, "jgg@nvidia.com" <jgg@nvidia.com>, "robin.murphy@arm.com" <robin.murphy@arm.com>, "will@kernel.org" <will@kernel.org>, "joro@8bytes.org" <joro@8bytes.org>, "masahiroy@kernel.org" <masahiroy@kernel.org>, "ndesaulniers@google.com" <ndesaulniers@google.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "okaya@kernel.org" <okaya@kernel.org>, "Anand, Harpreet" <harpreet.anand@amd.com>, "Agarwal, Nikhil" <nikhil.agarwal@amd.com>, "Simek, Michal" <michal.simek@amd.com>, "git (AMD-Xilinx)" <git@amd.com> Subject: RE: [PATCH 05/19] bus/cdx: add cdx controller Date: Wed, 18 Jan 2023 12:36:12 +0000 [thread overview] Message-ID: <DM6PR12MB30827F763B25B96BF1EB1E3EE8C79@DM6PR12MB3082.namprd12.prod.outlook.com> (raw) In-Reply-To: <Y8asSo2daSm5AWfR@kroah.com> [AMD Official Use Only - General] > -----Original Message----- > From: Greg KH <gregkh@linuxfoundation.org> > Sent: Tuesday, January 17, 2023 7:40 PM > To: Gupta, Nipun <Nipun.Gupta@amd.com> > Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; rafael@kernel.org; > eric.auger@redhat.com; alex.williamson@redhat.com; cohuck@redhat.com; > song.bao.hua@hisilicon.com; mchehab+huawei@kernel.org; maz@kernel.org; > f.fainelli@gmail.com; jeffrey.l.hugo@gmail.com; saravanak@google.com; > Michael.Srba@seznam.cz; mani@kernel.org; yishaih@nvidia.com; > jgg@ziepe.ca; jgg@nvidia.com; robin.murphy@arm.com; will@kernel.org; > joro@8bytes.org; masahiroy@kernel.org; ndesaulniers@google.com; linux-arm- > kernel@lists.infradead.org; linux-kbuild@vger.kernel.org; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org; okaya@kernel.org; > Anand, Harpreet <harpreet.anand@amd.com>; Agarwal, Nikhil > <nikhil.agarwal@amd.com>; Simek, Michal <michal.simek@amd.com>; git > (AMD-Xilinx) <git@amd.com> > Subject: Re: [PATCH 05/19] bus/cdx: add cdx controller > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On Tue, Jan 17, 2023 at 07:11:37PM +0530, Nipun Gupta wrote: > > --- /dev/null > > +++ b/drivers/bus/cdx/controller/cdx_controller.c > > @@ -0,0 +1,243 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Platform driver for CDX bus controller. > > Why is this a platform driver? Shouldn't it also be on some type of bus > so that you can find it? This is host controller for CDX bus similar to PCI controller which is also on the platform bus. Since CDX bus controller is based on communication with RPU firmware we need to have references to remoteproc device in CDX controller node to use the RPMsg device. > > > +MODULE_VERSION("1.0"); > > There's never need for any module versions once the code is in the > kernel tree as then they make no sense at all. Please drop them from > this series. Sure. Will remove. > > thanks, > > greg k-h
next prev parent reply other threads:[~2023-01-18 12:37 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-17 13:41 [PATCH 0/7] add support for CDX bus Nipun Gupta 2023-01-17 13:41 ` Nipun Gupta 2023-01-17 13:41 ` [PATCH 01/19] bus/cdx: add the cdx bus driver Nipun Gupta 2023-01-17 13:41 ` Nipun Gupta 2023-01-17 14:07 ` Greg KH 2023-01-17 14:07 ` Greg KH 2023-01-18 10:56 ` Gupta, Nipun 2023-01-18 10:56 ` Gupta, Nipun 2023-01-17 17:21 ` Randy Dunlap 2023-01-17 17:21 ` Randy Dunlap 2023-01-18 10:59 ` Gupta, Nipun 2023-01-18 10:59 ` Gupta, Nipun 2023-01-17 13:41 ` [PATCH 02/19] iommu/arm-smmu-v3: support ops registration for CDX bus Nipun Gupta 2023-01-17 13:41 ` Nipun Gupta 2023-01-17 13:41 ` [PATCH 03/19] dt-bindings: bus: add CDX bus controller device tree bindings Nipun Gupta 2023-01-17 13:41 ` Nipun Gupta 2023-01-17 17:54 ` Krzysztof Kozlowski 2023-01-17 17:54 ` Krzysztof Kozlowski 2023-01-18 12:39 ` Gupta, Nipun 2023-01-18 12:39 ` Gupta, Nipun 2023-01-18 12:43 ` Krzysztof Kozlowski 2023-01-18 12:43 ` Krzysztof Kozlowski 2023-01-19 7:33 ` Gupta, Nipun 2023-01-19 7:33 ` Gupta, Nipun 2023-01-17 13:41 ` [PATCH 04/19] bus/cdx: add MCDI protocol interface for firmware interaction Nipun Gupta 2023-01-17 13:41 ` Nipun Gupta 2023-01-17 14:08 ` Greg KH 2023-01-17 14:08 ` Greg KH 2023-01-18 10:58 ` Gupta, Nipun 2023-01-18 10:58 ` Gupta, Nipun 2023-01-17 13:41 ` [PATCH 05/19] bus/cdx: add cdx controller Nipun Gupta 2023-01-17 13:41 ` Nipun Gupta 2023-01-17 14:10 ` Greg KH 2023-01-17 14:10 ` Greg KH 2023-01-18 12:36 ` Gupta, Nipun [this message] 2023-01-18 12:36 ` Gupta, Nipun 2023-01-17 13:41 ` [PATCH 06/19] bus/cdx: add rpmsg communication channel for CDX Nipun Gupta 2023-01-17 13:41 ` Nipun Gupta 2023-01-17 13:41 ` [PATCH 07/19] bus/cdx: add device attributes Nipun Gupta 2023-01-17 13:41 ` Nipun Gupta 2023-01-17 14:13 ` Greg KH 2023-01-17 14:13 ` Greg KH 2023-01-18 13:03 ` Gupta, Nipun 2023-01-18 13:03 ` Gupta, Nipun 2023-01-17 17:47 ` [PATCH 0/7] add support for CDX bus Krzysztof Kozlowski 2023-01-17 17:47 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DM6PR12MB30827F763B25B96BF1EB1E3EE8C79@DM6PR12MB3082.namprd12.prod.outlook.com \ --to=nipun.gupta@amd.com \ --cc=Michael.Srba@seznam.cz \ --cc=alex.williamson@redhat.com \ --cc=cohuck@redhat.com \ --cc=devicetree@vger.kernel.org \ --cc=eric.auger@redhat.com \ --cc=f.fainelli@gmail.com \ --cc=git@amd.com \ --cc=gregkh@linuxfoundation.org \ --cc=harpreet.anand@amd.com \ --cc=jeffrey.l.hugo@gmail.com \ --cc=jgg@nvidia.com \ --cc=jgg@ziepe.ca \ --cc=joro@8bytes.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mani@kernel.org \ --cc=masahiroy@kernel.org \ --cc=maz@kernel.org \ --cc=mchehab+huawei@kernel.org \ --cc=michal.simek@amd.com \ --cc=ndesaulniers@google.com \ --cc=nikhil.agarwal@amd.com \ --cc=okaya@kernel.org \ --cc=rafael@kernel.org \ --cc=robh+dt@kernel.org \ --cc=robin.murphy@arm.com \ --cc=saravanak@google.com \ --cc=song.bao.hua@hisilicon.com \ --cc=will@kernel.org \ --cc=yishaih@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.