From: Randy Dunlap <rdunlap@infradead.org> To: Nipun Gupta <nipun.gupta@amd.com>, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, gregkh@linuxfoundation.org, rafael@kernel.org, eric.auger@redhat.com, alex.williamson@redhat.com, cohuck@redhat.com, song.bao.hua@hisilicon.com, mchehab+huawei@kernel.org, maz@kernel.org, f.fainelli@gmail.com, jeffrey.l.hugo@gmail.com, saravanak@google.com, Michael.Srba@seznam.cz, mani@kernel.org, yishaih@nvidia.com, jgg@ziepe.ca, jgg@nvidia.com, robin.murphy@arm.com, will@kernel.org, joro@8bytes.org, masahiroy@kernel.org, ndesaulniers@google.com, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: okaya@kernel.org, harpreet.anand@amd.com, nikhil.agarwal@amd.com, michal.simek@amd.com, git@amd.com Subject: Re: [PATCH 01/19] bus/cdx: add the cdx bus driver Date: Tue, 17 Jan 2023 09:21:48 -0800 [thread overview] Message-ID: <cc20a76f-6de5-b850-2c54-1e2a535feca6@infradead.org> (raw) In-Reply-To: <20230117134139.1298-2-nipun.gupta@amd.com> Hi-- On 1/17/23 05:41, Nipun Gupta wrote: > Introduce AMD CDX bus, which provides a mechanism for scanning > and probing CDX devices. These devices are memory mapped on > system bus for Application Processors(APUs). > > CDX devices can be changed dynamically in the Fabric and CDX > bus interacts with CDX controller to rescan the bus and > rediscover the devices. > > Signed-off-by: Nipun Gupta <nipun.gupta@amd.com> > Signed-off-by: Tarak Reddy <tarak.reddy@amd.com> > --- > Documentation/ABI/testing/sysfs-bus-cdx | 12 + > MAINTAINERS | 7 + > drivers/bus/Kconfig | 1 + > drivers/bus/Makefile | 2 + > drivers/bus/cdx/Kconfig | 14 + > drivers/bus/cdx/Makefile | 8 + > drivers/bus/cdx/cdx.c | 433 ++++++++++++++++++++++++ > drivers/bus/cdx/cdx.h | 62 ++++ > include/linux/cdx/cdx_bus.h | 153 +++++++++ > include/linux/mod_devicetable.h | 15 + > scripts/mod/devicetable-offsets.c | 4 + > scripts/mod/file2alias.c | 12 + > 12 files changed, 723 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-bus-cdx > create mode 100644 drivers/bus/cdx/Kconfig > create mode 100644 drivers/bus/cdx/Makefile > create mode 100644 drivers/bus/cdx/cdx.c > create mode 100644 drivers/bus/cdx/cdx.h > create mode 100644 include/linux/cdx/cdx_bus.h > > diff --git a/drivers/bus/cdx/Kconfig b/drivers/bus/cdx/Kconfig > new file mode 100644 > index 000000000000..54e0623ebcff > --- /dev/null > +++ b/drivers/bus/cdx/Kconfig > @@ -0,0 +1,14 @@ > +# SPDX-License-Identifier: GPL-2.0 > +# > +# CDX bus configuration > +# > +# Copyright (C) 2022-2023, Advanced Micro Devices, Inc. > +# > + > +config CDX_BUS > + bool "CDX Bus driver" > + help > + Driver to enable CDX Bus. CDX bus provides a mechanism for > + scanning and probing of CDX devices. CDX devices are memory > + mapped on system bus for embedded CPUs. CDX bus uses CDX > + controller and firmware to scan the CDX devices. Would you mind telling people who use 'make *config' what CDX means, either in the bool prompt string or in the help text? > +/** > + * cdx_unregister_device - Unregister a CDX device > + * @dev: CDX device > + * @data: This is always passed as NULL, and is not used in this API, > + * but is required here as the bus_for_each_dev() API expects > + * the passed function (cdx_unregister_device) to have this > + * as an argument. > + * > + * @return: -errno on failure, 0 on success. The syntax (or spelling) for a function's return value in kernel-doc is just: * Return: -errno on failure, 0 on success. That should be changed in many places throughout. Thanks. -- ~Randy _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org> To: Nipun Gupta <nipun.gupta@amd.com>, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, gregkh@linuxfoundation.org, rafael@kernel.org, eric.auger@redhat.com, alex.williamson@redhat.com, cohuck@redhat.com, song.bao.hua@hisilicon.com, mchehab+huawei@kernel.org, maz@kernel.org, f.fainelli@gmail.com, jeffrey.l.hugo@gmail.com, saravanak@google.com, Michael.Srba@seznam.cz, mani@kernel.org, yishaih@nvidia.com, jgg@ziepe.ca, jgg@nvidia.com, robin.murphy@arm.com, will@kernel.org, joro@8bytes.org, masahiroy@kernel.org, ndesaulniers@google.com, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: okaya@kernel.org, harpreet.anand@amd.com, nikhil.agarwal@amd.com, michal.simek@amd.com, git@amd.com Subject: Re: [PATCH 01/19] bus/cdx: add the cdx bus driver Date: Tue, 17 Jan 2023 09:21:48 -0800 [thread overview] Message-ID: <cc20a76f-6de5-b850-2c54-1e2a535feca6@infradead.org> (raw) In-Reply-To: <20230117134139.1298-2-nipun.gupta@amd.com> Hi-- On 1/17/23 05:41, Nipun Gupta wrote: > Introduce AMD CDX bus, which provides a mechanism for scanning > and probing CDX devices. These devices are memory mapped on > system bus for Application Processors(APUs). > > CDX devices can be changed dynamically in the Fabric and CDX > bus interacts with CDX controller to rescan the bus and > rediscover the devices. > > Signed-off-by: Nipun Gupta <nipun.gupta@amd.com> > Signed-off-by: Tarak Reddy <tarak.reddy@amd.com> > --- > Documentation/ABI/testing/sysfs-bus-cdx | 12 + > MAINTAINERS | 7 + > drivers/bus/Kconfig | 1 + > drivers/bus/Makefile | 2 + > drivers/bus/cdx/Kconfig | 14 + > drivers/bus/cdx/Makefile | 8 + > drivers/bus/cdx/cdx.c | 433 ++++++++++++++++++++++++ > drivers/bus/cdx/cdx.h | 62 ++++ > include/linux/cdx/cdx_bus.h | 153 +++++++++ > include/linux/mod_devicetable.h | 15 + > scripts/mod/devicetable-offsets.c | 4 + > scripts/mod/file2alias.c | 12 + > 12 files changed, 723 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-bus-cdx > create mode 100644 drivers/bus/cdx/Kconfig > create mode 100644 drivers/bus/cdx/Makefile > create mode 100644 drivers/bus/cdx/cdx.c > create mode 100644 drivers/bus/cdx/cdx.h > create mode 100644 include/linux/cdx/cdx_bus.h > > diff --git a/drivers/bus/cdx/Kconfig b/drivers/bus/cdx/Kconfig > new file mode 100644 > index 000000000000..54e0623ebcff > --- /dev/null > +++ b/drivers/bus/cdx/Kconfig > @@ -0,0 +1,14 @@ > +# SPDX-License-Identifier: GPL-2.0 > +# > +# CDX bus configuration > +# > +# Copyright (C) 2022-2023, Advanced Micro Devices, Inc. > +# > + > +config CDX_BUS > + bool "CDX Bus driver" > + help > + Driver to enable CDX Bus. CDX bus provides a mechanism for > + scanning and probing of CDX devices. CDX devices are memory > + mapped on system bus for embedded CPUs. CDX bus uses CDX > + controller and firmware to scan the CDX devices. Would you mind telling people who use 'make *config' what CDX means, either in the bool prompt string or in the help text? > +/** > + * cdx_unregister_device - Unregister a CDX device > + * @dev: CDX device > + * @data: This is always passed as NULL, and is not used in this API, > + * but is required here as the bus_for_each_dev() API expects > + * the passed function (cdx_unregister_device) to have this > + * as an argument. > + * > + * @return: -errno on failure, 0 on success. The syntax (or spelling) for a function's return value in kernel-doc is just: * Return: -errno on failure, 0 on success. That should be changed in many places throughout. Thanks. -- ~Randy
next prev parent reply other threads:[~2023-01-17 17:22 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-17 13:41 [PATCH 0/7] add support for CDX bus Nipun Gupta 2023-01-17 13:41 ` Nipun Gupta 2023-01-17 13:41 ` [PATCH 01/19] bus/cdx: add the cdx bus driver Nipun Gupta 2023-01-17 13:41 ` Nipun Gupta 2023-01-17 14:07 ` Greg KH 2023-01-17 14:07 ` Greg KH 2023-01-18 10:56 ` Gupta, Nipun 2023-01-18 10:56 ` Gupta, Nipun 2023-01-17 17:21 ` Randy Dunlap [this message] 2023-01-17 17:21 ` Randy Dunlap 2023-01-18 10:59 ` Gupta, Nipun 2023-01-18 10:59 ` Gupta, Nipun 2023-01-17 13:41 ` [PATCH 02/19] iommu/arm-smmu-v3: support ops registration for CDX bus Nipun Gupta 2023-01-17 13:41 ` Nipun Gupta 2023-01-17 13:41 ` [PATCH 03/19] dt-bindings: bus: add CDX bus controller device tree bindings Nipun Gupta 2023-01-17 13:41 ` Nipun Gupta 2023-01-17 17:54 ` Krzysztof Kozlowski 2023-01-17 17:54 ` Krzysztof Kozlowski 2023-01-18 12:39 ` Gupta, Nipun 2023-01-18 12:39 ` Gupta, Nipun 2023-01-18 12:43 ` Krzysztof Kozlowski 2023-01-18 12:43 ` Krzysztof Kozlowski 2023-01-19 7:33 ` Gupta, Nipun 2023-01-19 7:33 ` Gupta, Nipun 2023-01-17 13:41 ` [PATCH 04/19] bus/cdx: add MCDI protocol interface for firmware interaction Nipun Gupta 2023-01-17 13:41 ` Nipun Gupta 2023-01-17 14:08 ` Greg KH 2023-01-17 14:08 ` Greg KH 2023-01-18 10:58 ` Gupta, Nipun 2023-01-18 10:58 ` Gupta, Nipun 2023-01-17 13:41 ` [PATCH 05/19] bus/cdx: add cdx controller Nipun Gupta 2023-01-17 13:41 ` Nipun Gupta 2023-01-17 14:10 ` Greg KH 2023-01-17 14:10 ` Greg KH 2023-01-18 12:36 ` Gupta, Nipun 2023-01-18 12:36 ` Gupta, Nipun 2023-01-17 13:41 ` [PATCH 06/19] bus/cdx: add rpmsg communication channel for CDX Nipun Gupta 2023-01-17 13:41 ` Nipun Gupta 2023-01-17 13:41 ` [PATCH 07/19] bus/cdx: add device attributes Nipun Gupta 2023-01-17 13:41 ` Nipun Gupta 2023-01-17 14:13 ` Greg KH 2023-01-17 14:13 ` Greg KH 2023-01-18 13:03 ` Gupta, Nipun 2023-01-18 13:03 ` Gupta, Nipun 2023-01-17 17:47 ` [PATCH 0/7] add support for CDX bus Krzysztof Kozlowski 2023-01-17 17:47 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cc20a76f-6de5-b850-2c54-1e2a535feca6@infradead.org \ --to=rdunlap@infradead.org \ --cc=Michael.Srba@seznam.cz \ --cc=alex.williamson@redhat.com \ --cc=cohuck@redhat.com \ --cc=devicetree@vger.kernel.org \ --cc=eric.auger@redhat.com \ --cc=f.fainelli@gmail.com \ --cc=git@amd.com \ --cc=gregkh@linuxfoundation.org \ --cc=harpreet.anand@amd.com \ --cc=jeffrey.l.hugo@gmail.com \ --cc=jgg@nvidia.com \ --cc=jgg@ziepe.ca \ --cc=joro@8bytes.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mani@kernel.org \ --cc=masahiroy@kernel.org \ --cc=maz@kernel.org \ --cc=mchehab+huawei@kernel.org \ --cc=michal.simek@amd.com \ --cc=ndesaulniers@google.com \ --cc=nikhil.agarwal@amd.com \ --cc=nipun.gupta@amd.com \ --cc=okaya@kernel.org \ --cc=rafael@kernel.org \ --cc=robh+dt@kernel.org \ --cc=robin.murphy@arm.com \ --cc=saravanak@google.com \ --cc=song.bao.hua@hisilicon.com \ --cc=will@kernel.org \ --cc=yishaih@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.