From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: Elliot Berman <quic_eberman@quicinc.com> Cc: Bjorn Andersson <quic_bjorande@quicinc.com>, Murali Nalajala <quic_mnalajal@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>, Carl van Schaik <quic_cvanscha@quicinc.com>, Prakruthi Deepak Heragu <quic_pheragu@quicinc.com>, Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Jonathan Corbet <corbet@lwn.net>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Jassi Brar <jassisinghbrar@gmail.com>, Sudeep Holla <sudeep.holla@arm.com>, Mark Rutland <mark.rutland@arm.com>, Lorenzo Pieralisi <lpieralisi@kernel.org>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v7 10/20] gunyah: rsc_mgr: Add resource manager RPC core Date: Mon, 21 Nov 2022 16:23:35 +0100 [thread overview] Message-ID: <Y3uX9ywOVLubxYkW@kroah.com> (raw) In-Reply-To: <20221121140009.2353512-11-quic_eberman@quicinc.com> On Mon, Nov 21, 2022 at 05:59:59AM -0800, Elliot Berman wrote: > The resource manager is a special virtual machine which is always > running on a Gunyah system. It provides APIs for creating and destroying > VMs, secure memory management, sharing/lending of memory between VMs, > and setup of inter-VM communication. Calls to the resource manager are > made via message queues. > > This patch implements the basic probing and RPC mechanism to make those > API calls. Request/response calls can be made with gh_rm_call. > Drivers can also register to notifications pushed by RM via > gh_rm_register_notifier > > Specific API calls that resource manager supports will be implemented in > subsequent patches. > > Signed-off-by: Elliot Berman <quic_eberman@quicinc.com> > --- > MAINTAINERS | 2 +- > drivers/virt/gunyah/Kconfig | 7 + > drivers/virt/gunyah/Makefile | 2 + > drivers/virt/gunyah/gunyah_rm_rpc.c | 570 +++++++++++++++++++++++++++ > drivers/virt/gunyah/gunyah_rsc_mgr.c | 50 +++ > drivers/virt/gunyah/rsc_mgr.h | 37 ++ > include/linux/gunyah_rsc_mgr.h | 18 + > 7 files changed, 685 insertions(+), 1 deletion(-) > create mode 100644 drivers/virt/gunyah/gunyah_rm_rpc.c > create mode 100644 drivers/virt/gunyah/gunyah_rsc_mgr.c > create mode 100644 drivers/virt/gunyah/rsc_mgr.h > create mode 100644 include/linux/gunyah_rsc_mgr.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index 502798197b80..b65f7ff444e5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -8948,7 +8948,7 @@ F: Documentation/virt/gunyah/ > F: arch/arm64/gunyah/ > F: drivers/mailbox/gunyah-msgq.c > F: drivers/virt/gunyah/ > -F: include/linux/gunyah.h > +F: include/linux/gunyah*.h > > HABANALABS PCI DRIVER > M: Oded Gabbay <ogabbay@kernel.org> > diff --git a/drivers/virt/gunyah/Kconfig b/drivers/virt/gunyah/Kconfig > index 127156a678a6..0bb497372d4e 100644 > --- a/drivers/virt/gunyah/Kconfig > +++ b/drivers/virt/gunyah/Kconfig > @@ -10,3 +10,10 @@ config GUNYAH > > Say Y/M here to enable the drivers needed to interact in a Gunyah > virtual environment. > + > +if GUNYAH > +config GUNYAH_RESOURCE_MANAGER > + tristate > + depends on MAILBOX > + select GUNYAH_MESSAGE_QUEUES > +endif > diff --git a/drivers/virt/gunyah/Makefile b/drivers/virt/gunyah/Makefile > index 2ac4ee64b89d..b62ac4045621 100644 > --- a/drivers/virt/gunyah/Makefile > +++ b/drivers/virt/gunyah/Makefile > @@ -1 +1,3 @@ > obj-$(CONFIG_GUNYAH) += gunyah.o > + > +obj-$(CONFIG_GUNYAH_RESOURCE_MANAGER) += gunyah_rsc_mgr.o gunyah_rm_rpc.o > diff --git a/drivers/virt/gunyah/gunyah_rm_rpc.c b/drivers/virt/gunyah/gunyah_rm_rpc.c > new file mode 100644 > index 000000000000..45b1a8691982 > --- /dev/null > +++ b/drivers/virt/gunyah/gunyah_rm_rpc.c > @@ -0,0 +1,570 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +#include <linux/of.h> > +#include <linux/slab.h> > +#include <linux/mutex.h> > +#include <linux/sched.h> > +#include <linux/gunyah.h> > +#include <linux/module.h> > +#include <linux/of_irq.h> > +#include <linux/kthread.h> > +#include <linux/notifier.h> > +#include <linux/workqueue.h> > +#include <linux/completion.h> > +#include <linux/gunyah_rsc_mgr.h> > +#include <linux/platform_device.h> This should not have anything to do with a platform device, please see below. > +#include <linux/gunyah_rsc_mgr.h> > +#include <linux/platform_device.h> > + > +#include "rsc_mgr.h" > + > +static int gh_rm_drv_probe(struct platform_device *pdev) Why is this tied to a platformm device? I don't understand the relationship here, sorry. > +{ > + struct gh_rm_rpc *rsc_mgr; > + > + rsc_mgr = gh_rm_rpc_init(pdev); Shouldn't this be creating a new one that is just a child passed in? Shouldn't this call just take a 'struct device *'? thanks, greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: Elliot Berman <quic_eberman@quicinc.com> Cc: Bjorn Andersson <quic_bjorande@quicinc.com>, Murali Nalajala <quic_mnalajal@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>, Carl van Schaik <quic_cvanscha@quicinc.com>, Prakruthi Deepak Heragu <quic_pheragu@quicinc.com>, Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Jonathan Corbet <corbet@lwn.net>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Jassi Brar <jassisinghbrar@gmail.com>, Sudeep Holla <sudeep.holla@arm.com>, Mark Rutland <mark.rutland@arm.com>, Lorenzo Pieralisi <lpieralisi@kernel.org>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v7 10/20] gunyah: rsc_mgr: Add resource manager RPC core Date: Mon, 21 Nov 2022 16:23:35 +0100 [thread overview] Message-ID: <Y3uX9ywOVLubxYkW@kroah.com> (raw) In-Reply-To: <20221121140009.2353512-11-quic_eberman@quicinc.com> On Mon, Nov 21, 2022 at 05:59:59AM -0800, Elliot Berman wrote: > The resource manager is a special virtual machine which is always > running on a Gunyah system. It provides APIs for creating and destroying > VMs, secure memory management, sharing/lending of memory between VMs, > and setup of inter-VM communication. Calls to the resource manager are > made via message queues. > > This patch implements the basic probing and RPC mechanism to make those > API calls. Request/response calls can be made with gh_rm_call. > Drivers can also register to notifications pushed by RM via > gh_rm_register_notifier > > Specific API calls that resource manager supports will be implemented in > subsequent patches. > > Signed-off-by: Elliot Berman <quic_eberman@quicinc.com> > --- > MAINTAINERS | 2 +- > drivers/virt/gunyah/Kconfig | 7 + > drivers/virt/gunyah/Makefile | 2 + > drivers/virt/gunyah/gunyah_rm_rpc.c | 570 +++++++++++++++++++++++++++ > drivers/virt/gunyah/gunyah_rsc_mgr.c | 50 +++ > drivers/virt/gunyah/rsc_mgr.h | 37 ++ > include/linux/gunyah_rsc_mgr.h | 18 + > 7 files changed, 685 insertions(+), 1 deletion(-) > create mode 100644 drivers/virt/gunyah/gunyah_rm_rpc.c > create mode 100644 drivers/virt/gunyah/gunyah_rsc_mgr.c > create mode 100644 drivers/virt/gunyah/rsc_mgr.h > create mode 100644 include/linux/gunyah_rsc_mgr.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index 502798197b80..b65f7ff444e5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -8948,7 +8948,7 @@ F: Documentation/virt/gunyah/ > F: arch/arm64/gunyah/ > F: drivers/mailbox/gunyah-msgq.c > F: drivers/virt/gunyah/ > -F: include/linux/gunyah.h > +F: include/linux/gunyah*.h > > HABANALABS PCI DRIVER > M: Oded Gabbay <ogabbay@kernel.org> > diff --git a/drivers/virt/gunyah/Kconfig b/drivers/virt/gunyah/Kconfig > index 127156a678a6..0bb497372d4e 100644 > --- a/drivers/virt/gunyah/Kconfig > +++ b/drivers/virt/gunyah/Kconfig > @@ -10,3 +10,10 @@ config GUNYAH > > Say Y/M here to enable the drivers needed to interact in a Gunyah > virtual environment. > + > +if GUNYAH > +config GUNYAH_RESOURCE_MANAGER > + tristate > + depends on MAILBOX > + select GUNYAH_MESSAGE_QUEUES > +endif > diff --git a/drivers/virt/gunyah/Makefile b/drivers/virt/gunyah/Makefile > index 2ac4ee64b89d..b62ac4045621 100644 > --- a/drivers/virt/gunyah/Makefile > +++ b/drivers/virt/gunyah/Makefile > @@ -1 +1,3 @@ > obj-$(CONFIG_GUNYAH) += gunyah.o > + > +obj-$(CONFIG_GUNYAH_RESOURCE_MANAGER) += gunyah_rsc_mgr.o gunyah_rm_rpc.o > diff --git a/drivers/virt/gunyah/gunyah_rm_rpc.c b/drivers/virt/gunyah/gunyah_rm_rpc.c > new file mode 100644 > index 000000000000..45b1a8691982 > --- /dev/null > +++ b/drivers/virt/gunyah/gunyah_rm_rpc.c > @@ -0,0 +1,570 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +#include <linux/of.h> > +#include <linux/slab.h> > +#include <linux/mutex.h> > +#include <linux/sched.h> > +#include <linux/gunyah.h> > +#include <linux/module.h> > +#include <linux/of_irq.h> > +#include <linux/kthread.h> > +#include <linux/notifier.h> > +#include <linux/workqueue.h> > +#include <linux/completion.h> > +#include <linux/gunyah_rsc_mgr.h> > +#include <linux/platform_device.h> This should not have anything to do with a platform device, please see below. > +#include <linux/gunyah_rsc_mgr.h> > +#include <linux/platform_device.h> > + > +#include "rsc_mgr.h" > + > +static int gh_rm_drv_probe(struct platform_device *pdev) Why is this tied to a platformm device? I don't understand the relationship here, sorry. > +{ > + struct gh_rm_rpc *rsc_mgr; > + > + rsc_mgr = gh_rm_rpc_init(pdev); Shouldn't this be creating a new one that is just a child passed in? Shouldn't this call just take a 'struct device *'? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-21 15:24 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-21 13:59 [PATCH v7 00/20] Drivers for gunyah hypervisor Elliot Berman 2022-11-21 13:59 ` Elliot Berman 2022-11-21 13:59 ` [PATCH v7 01/20] docs: gunyah: Introduce Gunyah Hypervisor Elliot Berman 2022-11-21 13:59 ` Elliot Berman 2022-11-21 13:59 ` [PATCH v7 02/20] dt-bindings: Add binding for gunyah hypervisor Elliot Berman 2022-11-21 13:59 ` Elliot Berman 2022-12-05 19:42 ` Rob Herring 2022-12-05 19:42 ` Rob Herring 2022-11-21 13:59 ` [PATCH v7 03/20] gunyah: Common types and error codes for Gunyah hypercalls Elliot Berman 2022-11-21 13:59 ` Elliot Berman 2022-11-21 13:59 ` [PATCH v7 04/20] arm64: smccc: Include alternative-macros.h Elliot Berman 2022-11-21 13:59 ` Elliot Berman 2022-11-21 13:59 ` [PATCH v7 05/20] virt: gunyah: Add hypercalls to identify Gunyah Elliot Berman 2022-11-21 13:59 ` Elliot Berman 2022-11-21 13:59 ` [PATCH v7 06/20] virt: gunyah: Identify hypervisor version Elliot Berman 2022-11-21 13:59 ` Elliot Berman 2022-11-21 13:59 ` [PATCH v7 07/20] mailbox: Allow direct registration to a channel Elliot Berman 2022-11-21 13:59 ` Elliot Berman 2022-11-22 4:34 ` kernel test robot 2022-11-21 13:59 ` [PATCH v7 08/20] virt: gunyah: msgq: Add hypercalls to send and receive messages Elliot Berman 2022-11-21 13:59 ` Elliot Berman 2022-11-21 13:59 ` [PATCH v7 09/20] mailbox: Add Gunyah message queue mailbox Elliot Berman 2022-11-21 13:59 ` Elliot Berman 2022-11-21 13:59 ` [PATCH v7 10/20] gunyah: rsc_mgr: Add resource manager RPC core Elliot Berman 2022-11-21 13:59 ` Elliot Berman 2022-11-21 15:23 ` Greg Kroah-Hartman [this message] 2022-11-21 15:23 ` Greg Kroah-Hartman 2022-12-12 23:46 ` Elliot Berman 2022-12-12 23:46 ` Elliot Berman 2022-12-13 6:25 ` Greg Kroah-Hartman 2022-12-13 6:25 ` Greg Kroah-Hartman 2022-11-21 15:24 ` Greg Kroah-Hartman 2022-11-21 15:24 ` Greg Kroah-Hartman 2022-12-12 23:46 ` Elliot Berman 2022-12-12 23:46 ` Elliot Berman 2022-12-13 6:26 ` Greg Kroah-Hartman 2022-12-13 6:26 ` Greg Kroah-Hartman 2022-12-16 2:25 ` Elliot Berman 2022-12-16 2:25 ` Elliot Berman 2023-01-26 21:27 ` Elliot Berman 2023-01-26 21:27 ` Elliot Berman 2022-11-21 14:00 ` [PATCH v7 11/20] gunyah: rsc_mgr: Add VM lifecycle RPC Elliot Berman 2022-11-21 14:00 ` Elliot Berman 2022-11-21 14:00 ` [PATCH v7 12/20] gunyah: vm_mgr: Introduce basic VM Manager Elliot Berman 2022-11-21 14:00 ` Elliot Berman 2022-11-21 14:00 ` [PATCH v7 13/20] gunyah: rsc_mgr: Add RPC for sharing memory Elliot Berman 2022-11-21 14:00 ` Elliot Berman 2022-11-21 14:00 ` [PATCH v7 14/20] gunyah: vm_mgr: Add/remove user memory regions Elliot Berman 2022-11-21 14:00 ` Elliot Berman 2022-11-21 14:00 ` [PATCH v7 15/20] gunyah: vm_mgr: Add ioctls to support basic non-proxy VM boot Elliot Berman 2022-11-21 14:00 ` Elliot Berman 2022-11-21 14:00 ` [PATCH v7 16/20] samples: Add sample userspace Gunyah VM Manager Elliot Berman 2022-11-21 14:00 ` Elliot Berman 2022-11-21 14:00 ` [PATCH v7 17/20] gunyah: rsc_mgr: Add platform ops on mem_lend/mem_reclaim Elliot Berman 2022-11-21 14:00 ` Elliot Berman 2022-11-21 14:00 ` [PATCH v7 18/20] firmware: qcom_scm: Use fixed width src vm bitmap Elliot Berman 2022-11-21 14:00 ` Elliot Berman 2022-11-21 14:00 ` Elliot Berman 2022-11-21 15:59 ` Kalle Valo 2022-11-21 15:59 ` Kalle Valo 2022-11-21 15:59 ` Kalle Valo 2022-11-21 14:00 ` [PATCH v7 19/20] firmware: qcom_scm: Register Gunyah platform ops Elliot Berman 2022-11-21 14:00 ` Elliot Berman 2022-12-02 16:55 ` kernel test robot 2022-11-21 14:00 ` [PATCH v7 20/20] docs: gunyah: Document Gunyah VM Manager Elliot Berman 2022-11-21 14:00 ` Elliot Berman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Y3uX9ywOVLubxYkW@kroah.com \ --to=gregkh@linuxfoundation.org \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=corbet@lwn.net \ --cc=devicetree@vger.kernel.org \ --cc=jassisinghbrar@gmail.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lpieralisi@kernel.org \ --cc=mark.rutland@arm.com \ --cc=quic_bjorande@quicinc.com \ --cc=quic_cvanscha@quicinc.com \ --cc=quic_eberman@quicinc.com \ --cc=quic_mnalajal@quicinc.com \ --cc=quic_pheragu@quicinc.com \ --cc=quic_svaddagi@quicinc.com \ --cc=quic_tsoni@quicinc.com \ --cc=robh+dt@kernel.org \ --cc=sudeep.holla@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.