From: Rob Herring <robh@kernel.org> To: Bert Vermeulen <bert@biot.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>, soc@kernel.org, John Crispin <john@phrozen.org>, Felix Fietkau <nbd@nbd.name> Subject: Re: [PATCH 3/5] ARM: dts: Add basic support for EcoNet EN7523 Date: Fri, 6 Aug 2021 14:59:44 -0600 [thread overview] Message-ID: <YQ2iwIcSuDwcw/s5@robh.at.kernel.org> (raw) In-Reply-To: <d0ff051b-280c-4021-f4ee-7bfda5e356d3@biot.com> On Wed, Aug 04, 2021 at 06:41:55PM +0200, Bert Vermeulen wrote: > On 7/30/21 4:46 PM, Mark Rutland wrote: > > On Fri, Jul 30, 2021 at 03:45:50PM +0200, Bert Vermeulen wrote: > > > + timer { > > > + compatible = "arm,armv8-timer"; > > > > This should be "arm,armv7-timer". > > > > > + interrupt-parent = <&gic>; > > > + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > > > + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > > > + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > > > + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>; > > > > GICv3 doesn't have a cpumask in its PPI description, so the > > GIC_CPU_MASK_SIMPLE() bits should be removed. > > Ok, will fix. > > > > + clock-frequency = <25000000>; > > > > Please have your FW configure CNTFRQ on each CPU; the clock-frequency > > property in the DT is a workaround for broken FW, and it's *vastly* > > preferable for FW to configure this correctly (e.g. as it means VMs > > should "just work"). > > I've since got hold of the modified U-Boot that runs on my eval board, and > indeed it doesn't set CNTFRQ. So the kernel does need this, for the moment. Can't you write CNTFRQ in the u-boot shell/script? > I may get a chance to upstream support for this SoC in U-Boot, but I can't > control what people are going to ship with their board. Is it ok to leave > this in? If they want a working upstream Linux, then you can control it. I seem to recall this being rejected in other cases. That may have been on v8 which has taken stricter stances (but arguably any new v7 stuff should too). Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Bert Vermeulen <bert@biot.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>, soc@kernel.org, John Crispin <john@phrozen.org>, Felix Fietkau <nbd@nbd.name> Subject: Re: [PATCH 3/5] ARM: dts: Add basic support for EcoNet EN7523 Date: Fri, 6 Aug 2021 14:59:44 -0600 [thread overview] Message-ID: <YQ2iwIcSuDwcw/s5@robh.at.kernel.org> (raw) Message-ID: <20210806205944.5ldZZBmFjjedlNZR5X2Z1Iin8dnqbEsBThC6alWlZM0@z> (raw) In-Reply-To: <d0ff051b-280c-4021-f4ee-7bfda5e356d3@biot.com> On Wed, Aug 04, 2021 at 06:41:55PM +0200, Bert Vermeulen wrote: > On 7/30/21 4:46 PM, Mark Rutland wrote: > > On Fri, Jul 30, 2021 at 03:45:50PM +0200, Bert Vermeulen wrote: > > > + timer { > > > + compatible = "arm,armv8-timer"; > > > > This should be "arm,armv7-timer". > > > > > + interrupt-parent = <&gic>; > > > + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > > > + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > > > + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > > > + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>; > > > > GICv3 doesn't have a cpumask in its PPI description, so the > > GIC_CPU_MASK_SIMPLE() bits should be removed. > > Ok, will fix. > > > > + clock-frequency = <25000000>; > > > > Please have your FW configure CNTFRQ on each CPU; the clock-frequency > > property in the DT is a workaround for broken FW, and it's *vastly* > > preferable for FW to configure this correctly (e.g. as it means VMs > > should "just work"). > > I've since got hold of the modified U-Boot that runs on my eval board, and > indeed it doesn't set CNTFRQ. So the kernel does need this, for the moment. Can't you write CNTFRQ in the u-boot shell/script? > I may get a chance to upstream support for this SoC in U-Boot, but I can't > control what people are going to ship with their board. Is it ok to leave > this in? If they want a working upstream Linux, then you can control it. I seem to recall this being rejected in other cases. That may have been on v8 which has taken stricter stances (but arguably any new v7 stuff should too). Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-06 20:59 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-30 13:45 [PATCH 0/4] Add support for EcoNet EN7523 SoC Bert Vermeulen 2021-07-30 13:45 ` Bert Vermeulen 2021-07-30 13:45 ` [PATCH 1/5] dt-bindings: Add vendor prefix for EcoNet Bert Vermeulen 2021-07-30 13:45 ` Bert Vermeulen 2021-08-06 21:02 ` Rob Herring 2021-08-06 21:02 ` Rob Herring 2021-07-30 13:45 ` [PATCH 2/5] dt-bindings: arm: econet: Add binding for EN7523 SoC and EVB Bert Vermeulen 2021-07-30 13:45 ` Bert Vermeulen 2021-08-06 21:04 ` Rob Herring 2021-08-06 21:04 ` Rob Herring 2021-07-30 13:45 ` [PATCH 3/5] ARM: dts: Add basic support for EcoNet EN7523 Bert Vermeulen 2021-07-30 13:45 ` Bert Vermeulen 2021-07-30 14:31 ` Linus Walleij 2021-07-30 14:31 ` Linus Walleij 2021-07-30 14:31 ` Linus Walleij 2021-07-30 14:53 ` Marc Zyngier 2021-07-30 14:53 ` Marc Zyngier 2021-08-01 9:07 ` Bert Vermeulen 2021-08-01 9:07 ` Bert Vermeulen 2021-08-01 9:07 ` Bert Vermeulen 2021-08-01 9:40 ` Arnd Bergmann 2021-08-01 9:40 ` Arnd Bergmann 2021-08-01 9:40 ` Arnd Bergmann 2021-08-01 9:50 ` Marc Zyngier 2021-08-01 9:50 ` Marc Zyngier 2021-07-30 14:45 ` Daniel Palmer 2021-07-30 14:45 ` Daniel Palmer 2021-07-30 14:45 ` Daniel Palmer 2021-07-30 14:46 ` Mark Rutland 2021-07-30 14:46 ` Mark Rutland 2021-08-04 16:41 ` Bert Vermeulen 2021-08-04 16:41 ` Bert Vermeulen 2021-08-06 20:59 ` Rob Herring [this message] 2021-08-06 20:59 ` Rob Herring 2021-07-30 14:59 ` Mark Rutland 2021-07-30 14:59 ` Mark Rutland 2021-08-06 20:52 ` Rob Herring 2021-08-06 20:52 ` Rob Herring 2021-07-30 16:47 ` Andre Przywara 2021-07-30 16:47 ` Andre Przywara 2021-07-30 17:23 ` Marc Zyngier 2021-07-30 17:23 ` Marc Zyngier 2021-07-30 13:45 ` [PATCH 4/5] ARM: Add basic support for EcoNet EN7523 SoC Bert Vermeulen 2021-07-30 13:45 ` Bert Vermeulen 2021-07-30 14:48 ` Arnd Bergmann 2021-07-30 14:48 ` Arnd Bergmann 2021-07-30 15:15 ` John Crispin 2021-07-30 15:15 ` John Crispin 2021-07-30 16:55 ` Arnd Bergmann 2021-07-30 16:55 ` Arnd Bergmann 2021-08-01 16:44 ` Ard Biesheuvel 2021-08-01 16:44 ` Ard Biesheuvel 2021-09-03 16:20 ` Felix Fietkau 2021-09-03 16:20 ` Felix Fietkau 2021-09-03 17:47 ` Ard Biesheuvel 2021-09-03 17:47 ` Ard Biesheuvel 2021-08-04 16:43 ` Bert Vermeulen 2021-08-04 16:43 ` Bert Vermeulen 2021-08-09 12:46 ` Geert Uytterhoeven 2021-08-09 12:46 ` Geert Uytterhoeven 2021-08-09 12:49 ` Ard Biesheuvel 2021-08-09 12:49 ` Ard Biesheuvel 2021-08-09 13:00 ` Bert Vermeulen 2021-08-09 13:00 ` Bert Vermeulen 2021-07-30 13:45 ` [PATCH 5/5] ARM: multi_v7_defconfig: Add " Bert Vermeulen 2021-07-30 13:45 ` Bert Vermeulen 2021-07-30 14:26 ` [PATCH 0/4] " Linus Walleij 2021-07-30 14:26 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YQ2iwIcSuDwcw/s5@robh.at.kernel.org \ --to=robh@kernel.org \ --cc=arnd@arndb.de \ --cc=bert@biot.com \ --cc=devicetree@vger.kernel.org \ --cc=john@phrozen.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=nbd@nbd.name \ --cc=olof@lixom.net \ --cc=soc@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.