Re: [PATCH v2 08/15] dt-bindings: arm: cpus: Document qcom,msm8916-smp enable-method

From: Rob Herring <robh@kernel.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	~postmarketos/upstreaming@lists.sr.ht,
	Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH v2 08/15] dt-bindings: arm: cpus: Document qcom,msm8916-smp enable-method
Date: Thu, 14 Oct 2021 11:40:43 -0500	[thread overview]
Message-ID: <YWhdi8gt95W2q+pB@robh.at.kernel.org> (raw)
In-Reply-To: <20211004204955.21077-8-stephan@gerhold.net>

On Mon, 04 Oct 2021 22:49:48 +0200, Stephan Gerhold wrote:
> Since MSM8916 is an ARM v8 64-bit SoC the CPU cores are normally booted
> using "psci" or "spin-table". Unfortunately, some devices come with signed
> 32-bit-only firmware without ARM64 and PSCI support. This setup is easy to
> support since it's very similar to older 32-bit only Qualcomm SoCs
> (e.g. MSM8226) and only requires adding a few new definitions to already
> existing drivers.
> 
> Document the qcom,msm8916-smp enable-method. It is actually just an alias
> of qcom,msm8226-smp since it should be implemented identically.
> The enable-method is only valid on ARM32 and must not be used on ARM64.
> 
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> Changes in v2:
>   - Clarify that this is only supposed to be used on ARM 32-bit
>     (Add comment to commit message and DT schema)
> 
> The "see above for ARM v8 64-bit" comment refers to this a few lines
> above in the DT schema:
> 
>       # On ARM v8 64-bit this property is required
>       - enum:
>           - psci
>           - spin-table
> ---
>  Documentation/devicetree/bindings/arm/cpus.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>