From: Christoph Hellwig <hch@infradead.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Wang Wenhu <wenhu.wang@hotmail.com>,
gregkh@linuxfoundation.org, christophe.leroy@csgroup.eu,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] powerpc:mm: export symbol ioremap_coherent
Date: Tue, 14 Jun 2022 07:49:15 -0700 [thread overview]
Message-ID: <Yqif65sCt9hUEjUf@infradead.org> (raw)
In-Reply-To: <8735g7cym2.fsf@mpe.ellerman.id.au>
On Tue, Jun 14, 2022 at 08:45:25PM +1000, Michael Ellerman wrote:
> Wang Wenhu <wenhu.wang@hotmail.com> writes:
> > The function ioremap_coherent may be called by modules such as
> > fsl_85xx_cache_sram. So export it for access in other modules.
>
> ioremap_coherent() is powerpc specific, and only has one other caller,
> I'd like to remove it.
>
> Does ioremap_cache() work for you?
Chances are that both are the wrong thing and this really wants
memremap, as SRAM tends to have memory and not MMIO semantics.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: gregkh@linuxfoundation.org, linuxppc-dev@lists.ozlabs.org,
Wang Wenhu <wenhu.wang@hotmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] powerpc:mm: export symbol ioremap_coherent
Date: Tue, 14 Jun 2022 07:49:15 -0700 [thread overview]
Message-ID: <Yqif65sCt9hUEjUf@infradead.org> (raw)
In-Reply-To: <8735g7cym2.fsf@mpe.ellerman.id.au>
On Tue, Jun 14, 2022 at 08:45:25PM +1000, Michael Ellerman wrote:
> Wang Wenhu <wenhu.wang@hotmail.com> writes:
> > The function ioremap_coherent may be called by modules such as
> > fsl_85xx_cache_sram. So export it for access in other modules.
>
> ioremap_coherent() is powerpc specific, and only has one other caller,
> I'd like to remove it.
>
> Does ioremap_cache() work for you?
Chances are that both are the wrong thing and this really wants
memremap, as SRAM tends to have memory and not MMIO semantics.
next prev parent reply other threads:[~2022-06-14 14:49 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220609102855.272270-1-wenhu.wang@hotmail.com>
2022-06-09 10:28 ` [PATCH 1/2] powerpc:mm: export symbol ioremap_coherent Wang Wenhu
2022-06-09 10:28 ` Wang Wenhu
2022-06-14 10:45 ` Michael Ellerman
2022-06-14 14:49 ` Christoph Hellwig [this message]
2022-06-14 14:49 ` Christoph Hellwig
2022-06-15 4:37 ` 回复: " Wenhu Wang
2022-06-09 10:28 ` [PATCH 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation Wang Wenhu
2022-06-09 10:28 ` Wang Wenhu
2022-06-09 13:17 ` Greg KH
2022-06-09 13:17 ` Greg KH
2022-06-14 6:09 ` 回复: " Wenhu Wang
2022-06-14 6:09 ` Wenhu Wang
2022-06-14 6:34 ` Greg KH
2022-06-14 6:34 ` Greg KH
2022-06-14 7:12 ` Christophe Leroy
2022-06-14 7:12 ` Christophe Leroy
2022-06-14 7:18 ` Christophe Leroy
2022-06-14 7:18 ` Christophe Leroy
2022-06-14 7:26 ` Christophe Leroy
2022-06-14 7:26 ` Christophe Leroy
2022-06-14 7:53 ` Wenhu Wang
2022-06-14 7:53 ` Wenhu Wang
2022-06-14 8:03 ` Greg KH
2022-06-14 8:03 ` Greg KH
2022-06-14 8:39 ` Wenhu Wang
2022-06-14 8:39 ` Wenhu Wang
2022-06-14 14:40 ` Wenhu Wang
2022-06-14 14:40 ` Wenhu Wang
2022-06-14 14:59 ` Christophe Leroy
2022-06-14 14:59 ` Christophe Leroy
2022-06-15 6:04 ` 回复: " Christophe Leroy
2022-06-15 6:04 ` Christophe Leroy
2022-06-15 5:57 ` [PATCHv2 0/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver Wang Wenhu
2022-06-15 5:57 ` Wang Wenhu
[not found] ` <20220615055735.53585-1-wenhu.wang@hotmail.com>
2022-06-15 5:57 ` [PATCHv2 1/2] mm: eliminate ifdef of HAVE_IOREMAP_PROT in .c files Wang Wenhu
2022-06-15 5:57 ` Wang Wenhu
2022-06-15 6:49 ` Christoph Hellwig
2022-06-15 6:49 ` Christoph Hellwig
2022-06-22 2:22 ` kernel test robot
2022-06-22 2:22 ` kernel test robot
2022-06-22 4:13 ` kernel test robot
2022-06-22 4:13 ` kernel test robot
2022-06-15 5:57 ` [PATCHv2 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation Wang Wenhu
2022-06-15 5:57 ` Wang Wenhu
2022-06-15 6:43 ` Christoph Hellwig
2022-06-15 6:43 ` Christoph Hellwig
2022-06-15 6:48 ` Christophe Leroy
2022-06-15 6:48 ` Christophe Leroy
2022-06-15 6:49 ` Christophe Leroy
2022-06-15 6:49 ` Christophe Leroy
2022-06-14 14:51 ` [PATCH " Christoph Hellwig
2022-06-14 14:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yqif65sCt9hUEjUf@infradead.org \
--to=hch@infradead.org \
--cc=christophe.leroy@csgroup.eu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=wenhu.wang@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.