From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Wenhu Wang <wenhu.wang@hotmail.com>,
Greg KH <gregkh@linuxfoundation.org>
Cc: "mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: 回复: [PATCH 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation
Date: Tue, 14 Jun 2022 07:18:48 +0000 [thread overview]
Message-ID: <efebcb50-0481-622a-894c-7000999aacc6@csgroup.eu> (raw)
In-Reply-To: <SG2PR01MB2951EA9ED70E5F766DD26A069FAA9@SG2PR01MB2951.apcprd01.prod.exchangelabs.com>
Le 14/06/2022 à 08:09, Wenhu Wang a écrit :
>>> +static const struct vm_operations_struct uio_cache_sram_vm_ops = {
>>> +#ifdef CONFIG_HAVE_IOREMAP_PROT
>>
>> Same here.
>>
>
> I tried to eliminate it in mainline
> See: [PATCH v2] mm: eliminate ifdef of HAVE_IOREMAP_PROT in .c files
> https://lkml.org/lkml/2022/6/10/695
>
I looked at that patch.
I don't think you can just drop the #ifdef in function
__access_remote_vm() in mm/memory.c
You have to replace it with something like:
if (!IS_ENABLED(CONFIG_HAVE_IOREMAP_PROT))
break;
Christophe
WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Wenhu Wang <wenhu.wang@hotmail.com>,
Greg KH <gregkh@linuxfoundation.org>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: 回复: [PATCH 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation
Date: Tue, 14 Jun 2022 07:18:48 +0000 [thread overview]
Message-ID: <efebcb50-0481-622a-894c-7000999aacc6@csgroup.eu> (raw)
In-Reply-To: <SG2PR01MB2951EA9ED70E5F766DD26A069FAA9@SG2PR01MB2951.apcprd01.prod.exchangelabs.com>
Le 14/06/2022 à 08:09, Wenhu Wang a écrit :
>>> +static const struct vm_operations_struct uio_cache_sram_vm_ops = {
>>> +#ifdef CONFIG_HAVE_IOREMAP_PROT
>>
>> Same here.
>>
>
> I tried to eliminate it in mainline
> See: [PATCH v2] mm: eliminate ifdef of HAVE_IOREMAP_PROT in .c files
> https://lkml.org/lkml/2022/6/10/695
>
I looked at that patch.
I don't think you can just drop the #ifdef in function
__access_remote_vm() in mm/memory.c
You have to replace it with something like:
if (!IS_ENABLED(CONFIG_HAVE_IOREMAP_PROT))
break;
Christophe
next prev parent reply other threads:[~2022-06-14 7:19 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220609102855.272270-1-wenhu.wang@hotmail.com>
2022-06-09 10:28 ` [PATCH 1/2] powerpc:mm: export symbol ioremap_coherent Wang Wenhu
2022-06-09 10:28 ` Wang Wenhu
2022-06-14 10:45 ` Michael Ellerman
2022-06-14 14:49 ` Christoph Hellwig
2022-06-14 14:49 ` Christoph Hellwig
2022-06-15 4:37 ` 回复: " Wenhu Wang
2022-06-09 10:28 ` [PATCH 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation Wang Wenhu
2022-06-09 10:28 ` Wang Wenhu
2022-06-09 13:17 ` Greg KH
2022-06-09 13:17 ` Greg KH
2022-06-14 6:09 ` 回复: " Wenhu Wang
2022-06-14 6:09 ` Wenhu Wang
2022-06-14 6:34 ` Greg KH
2022-06-14 6:34 ` Greg KH
2022-06-14 7:12 ` Christophe Leroy
2022-06-14 7:12 ` Christophe Leroy
2022-06-14 7:18 ` Christophe Leroy [this message]
2022-06-14 7:18 ` Christophe Leroy
2022-06-14 7:26 ` Christophe Leroy
2022-06-14 7:26 ` Christophe Leroy
2022-06-14 7:53 ` Wenhu Wang
2022-06-14 7:53 ` Wenhu Wang
2022-06-14 8:03 ` Greg KH
2022-06-14 8:03 ` Greg KH
2022-06-14 8:39 ` Wenhu Wang
2022-06-14 8:39 ` Wenhu Wang
2022-06-14 14:40 ` Wenhu Wang
2022-06-14 14:40 ` Wenhu Wang
2022-06-14 14:59 ` Christophe Leroy
2022-06-14 14:59 ` Christophe Leroy
2022-06-15 6:04 ` 回复: " Christophe Leroy
2022-06-15 6:04 ` Christophe Leroy
2022-06-15 5:57 ` [PATCHv2 0/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver Wang Wenhu
2022-06-15 5:57 ` Wang Wenhu
[not found] ` <20220615055735.53585-1-wenhu.wang@hotmail.com>
2022-06-15 5:57 ` [PATCHv2 1/2] mm: eliminate ifdef of HAVE_IOREMAP_PROT in .c files Wang Wenhu
2022-06-15 5:57 ` Wang Wenhu
2022-06-15 6:49 ` Christoph Hellwig
2022-06-15 6:49 ` Christoph Hellwig
2022-06-22 2:22 ` kernel test robot
2022-06-22 2:22 ` kernel test robot
2022-06-22 4:13 ` kernel test robot
2022-06-22 4:13 ` kernel test robot
2022-06-15 5:57 ` [PATCHv2 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation Wang Wenhu
2022-06-15 5:57 ` Wang Wenhu
2022-06-15 6:43 ` Christoph Hellwig
2022-06-15 6:43 ` Christoph Hellwig
2022-06-15 6:48 ` Christophe Leroy
2022-06-15 6:48 ` Christophe Leroy
2022-06-15 6:49 ` Christophe Leroy
2022-06-15 6:49 ` Christophe Leroy
2022-06-14 14:51 ` [PATCH " Christoph Hellwig
2022-06-14 14:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efebcb50-0481-622a-894c-7000999aacc6@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=wenhu.wang@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.