From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Paul Elder <paul.elder@ideasonboard.com> Cc: linux-media@vger.kernel.org, dafna@fastmail.com, heiko@sntech.de, jeanmichel.hautbois@ideasonboard.com, jacopo@jmondi.org, djrscally@gmail.com, helen.koike@collabora.com, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 53/55] media: rkisp1: Shift DMA buffer addresses on i.MX8MP Date: Sun, 26 Jun 2022 14:38:06 +0300 [thread overview] Message-ID: <YrhFHt+PsaWXsTUD@pendragon.ideasonboard.com> (raw) In-Reply-To: <20220614191127.3420492-54-paul.elder@ideasonboard.com> Hi Paul, Thank you for the patch. On Wed, Jun 15, 2022 at 04:11:25AM +0900, Paul Elder wrote: > On the ISP that is integrated in the i.MX8MP, the DMA base addresses are > encoded in 34-bit. Shift them to the left by 2 bits so that they can be I think you meant right, not left. > contained in 32 bits. The important part here is that this is how the address is encoded in the hardware. I suppose it's obvious, otherwise it woudln't work at all, but maybe it could be explained more explicitly ? On the ISP that is integrated in the i.MX8MP, DMA addresses have been extended to 34 bits, with the 32 MSBs stored in the DMA address registers and the 2 LSBs set to 0. Shift the buffer addresses right by 2 on that platform. > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > .../platform/rockchip/rkisp1/rkisp1-capture.c | 19 +++++++++++-------- > .../platform/rockchip/rkisp1/rkisp1-common.h | 1 + > .../platform/rockchip/rkisp1/rkisp1-dev.c | 3 ++- > 3 files changed, 14 insertions(+), 9 deletions(-) > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c > index 35cec263c563..234b1f8488cb 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c > @@ -624,6 +624,9 @@ static void rkisp1_dummy_buf_destroy(struct rkisp1_capture *cap) > > static void rkisp1_set_next_buf(struct rkisp1_capture *cap) > { > + u8 shift = cap->rkisp1->info->features & RKISP1_FEATURE_DMA_34BIT ? > + 2 : 0; > + > cap->buf.curr = cap->buf.next; > cap->buf.next = NULL; > > @@ -636,7 +639,7 @@ static void rkisp1_set_next_buf(struct rkisp1_capture *cap) > buff_addr = cap->buf.next->buff_addr; > > rkisp1_write(cap->rkisp1, cap->config->mi.y_base_ad_init, > - buff_addr[RKISP1_PLANE_Y]); > + buff_addr[RKISP1_PLANE_Y] >> shift); > /* > * In order to support grey format we capture > * YUV422 planar format from the camera and > @@ -645,17 +648,17 @@ static void rkisp1_set_next_buf(struct rkisp1_capture *cap) > if (cap->pix.cfg->fourcc == V4L2_PIX_FMT_GREY) { > rkisp1_write(cap->rkisp1, > cap->config->mi.cb_base_ad_init, > - cap->buf.dummy.dma_addr); > + cap->buf.dummy.dma_addr >> shift); > rkisp1_write(cap->rkisp1, > cap->config->mi.cr_base_ad_init, > - cap->buf.dummy.dma_addr); > + cap->buf.dummy.dma_addr >> shift); > } else { > rkisp1_write(cap->rkisp1, > cap->config->mi.cb_base_ad_init, > - buff_addr[RKISP1_PLANE_CB]); > + buff_addr[RKISP1_PLANE_CB] >> shift); > rkisp1_write(cap->rkisp1, > cap->config->mi.cr_base_ad_init, > - buff_addr[RKISP1_PLANE_CR]); > + buff_addr[RKISP1_PLANE_CR] >> shift); > } > } else { > /* > @@ -663,11 +666,11 @@ static void rkisp1_set_next_buf(struct rkisp1_capture *cap) > * throw data if there is no available buffer. > */ > rkisp1_write(cap->rkisp1, cap->config->mi.y_base_ad_init, > - cap->buf.dummy.dma_addr); > + cap->buf.dummy.dma_addr >> shift); > rkisp1_write(cap->rkisp1, cap->config->mi.cb_base_ad_init, > - cap->buf.dummy.dma_addr); > + cap->buf.dummy.dma_addr >> shift); > rkisp1_write(cap->rkisp1, cap->config->mi.cr_base_ad_init, > - cap->buf.dummy.dma_addr); > + cap->buf.dummy.dma_addr >> shift); > } > > /* Set plane offsets */ > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h > index 96657e55a5b0..0b834579d08c 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h > @@ -113,6 +113,7 @@ enum rkisp1_feature { > RKISP1_FEATURE_DUAL_CROP = BIT(1), > RKISP1_FEATURE_RSZ_CROP = BIT(2), > RKISP1_FEATURE_MAIN_STRIDE = BIT(3), > + RKISP1_FEATURE_DMA_34BIT = BIT(4), > }; > > /* > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > index d68a805e8b6b..4c77aa2bc50a 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > @@ -506,7 +506,8 @@ static const struct rkisp1_info imx8mp_isp_info = { > .isr_size = ARRAY_SIZE(imx8mp_isp_isrs), > .isp_ver = IMX8MP_V10, > .features = RKISP1_FEATURE_RSZ_CROP > - | RKISP1_FEATURE_MAIN_STRIDE, > + | RKISP1_FEATURE_MAIN_STRIDE > + | RKISP1_FEATURE_DMA_34BIT, > }; > > static const struct of_device_id rkisp1_of_match[] = { -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Paul Elder <paul.elder@ideasonboard.com> Cc: linux-media@vger.kernel.org, dafna@fastmail.com, heiko@sntech.de, jeanmichel.hautbois@ideasonboard.com, jacopo@jmondi.org, djrscally@gmail.com, helen.koike@collabora.com, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 53/55] media: rkisp1: Shift DMA buffer addresses on i.MX8MP Date: Sun, 26 Jun 2022 14:38:06 +0300 [thread overview] Message-ID: <YrhFHt+PsaWXsTUD@pendragon.ideasonboard.com> (raw) In-Reply-To: <20220614191127.3420492-54-paul.elder@ideasonboard.com> Hi Paul, Thank you for the patch. On Wed, Jun 15, 2022 at 04:11:25AM +0900, Paul Elder wrote: > On the ISP that is integrated in the i.MX8MP, the DMA base addresses are > encoded in 34-bit. Shift them to the left by 2 bits so that they can be I think you meant right, not left. > contained in 32 bits. The important part here is that this is how the address is encoded in the hardware. I suppose it's obvious, otherwise it woudln't work at all, but maybe it could be explained more explicitly ? On the ISP that is integrated in the i.MX8MP, DMA addresses have been extended to 34 bits, with the 32 MSBs stored in the DMA address registers and the 2 LSBs set to 0. Shift the buffer addresses right by 2 on that platform. > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > .../platform/rockchip/rkisp1/rkisp1-capture.c | 19 +++++++++++-------- > .../platform/rockchip/rkisp1/rkisp1-common.h | 1 + > .../platform/rockchip/rkisp1/rkisp1-dev.c | 3 ++- > 3 files changed, 14 insertions(+), 9 deletions(-) > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c > index 35cec263c563..234b1f8488cb 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c > @@ -624,6 +624,9 @@ static void rkisp1_dummy_buf_destroy(struct rkisp1_capture *cap) > > static void rkisp1_set_next_buf(struct rkisp1_capture *cap) > { > + u8 shift = cap->rkisp1->info->features & RKISP1_FEATURE_DMA_34BIT ? > + 2 : 0; > + > cap->buf.curr = cap->buf.next; > cap->buf.next = NULL; > > @@ -636,7 +639,7 @@ static void rkisp1_set_next_buf(struct rkisp1_capture *cap) > buff_addr = cap->buf.next->buff_addr; > > rkisp1_write(cap->rkisp1, cap->config->mi.y_base_ad_init, > - buff_addr[RKISP1_PLANE_Y]); > + buff_addr[RKISP1_PLANE_Y] >> shift); > /* > * In order to support grey format we capture > * YUV422 planar format from the camera and > @@ -645,17 +648,17 @@ static void rkisp1_set_next_buf(struct rkisp1_capture *cap) > if (cap->pix.cfg->fourcc == V4L2_PIX_FMT_GREY) { > rkisp1_write(cap->rkisp1, > cap->config->mi.cb_base_ad_init, > - cap->buf.dummy.dma_addr); > + cap->buf.dummy.dma_addr >> shift); > rkisp1_write(cap->rkisp1, > cap->config->mi.cr_base_ad_init, > - cap->buf.dummy.dma_addr); > + cap->buf.dummy.dma_addr >> shift); > } else { > rkisp1_write(cap->rkisp1, > cap->config->mi.cb_base_ad_init, > - buff_addr[RKISP1_PLANE_CB]); > + buff_addr[RKISP1_PLANE_CB] >> shift); > rkisp1_write(cap->rkisp1, > cap->config->mi.cr_base_ad_init, > - buff_addr[RKISP1_PLANE_CR]); > + buff_addr[RKISP1_PLANE_CR] >> shift); > } > } else { > /* > @@ -663,11 +666,11 @@ static void rkisp1_set_next_buf(struct rkisp1_capture *cap) > * throw data if there is no available buffer. > */ > rkisp1_write(cap->rkisp1, cap->config->mi.y_base_ad_init, > - cap->buf.dummy.dma_addr); > + cap->buf.dummy.dma_addr >> shift); > rkisp1_write(cap->rkisp1, cap->config->mi.cb_base_ad_init, > - cap->buf.dummy.dma_addr); > + cap->buf.dummy.dma_addr >> shift); > rkisp1_write(cap->rkisp1, cap->config->mi.cr_base_ad_init, > - cap->buf.dummy.dma_addr); > + cap->buf.dummy.dma_addr >> shift); > } > > /* Set plane offsets */ > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h > index 96657e55a5b0..0b834579d08c 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h > @@ -113,6 +113,7 @@ enum rkisp1_feature { > RKISP1_FEATURE_DUAL_CROP = BIT(1), > RKISP1_FEATURE_RSZ_CROP = BIT(2), > RKISP1_FEATURE_MAIN_STRIDE = BIT(3), > + RKISP1_FEATURE_DMA_34BIT = BIT(4), > }; > > /* > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > index d68a805e8b6b..4c77aa2bc50a 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > @@ -506,7 +506,8 @@ static const struct rkisp1_info imx8mp_isp_info = { > .isr_size = ARRAY_SIZE(imx8mp_isp_isrs), > .isp_ver = IMX8MP_V10, > .features = RKISP1_FEATURE_RSZ_CROP > - | RKISP1_FEATURE_MAIN_STRIDE, > + | RKISP1_FEATURE_MAIN_STRIDE > + | RKISP1_FEATURE_DMA_34BIT, > }; > > static const struct of_device_id rkisp1_of_match[] = { -- Regards, Laurent Pinchart _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2022-06-26 11:38 UTC|newest] Thread overview: 298+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-14 19:10 [PATCH 00/55] media: rkisp1: Cleanups and add support for i.MX8MP Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-14 19:10 ` [PATCH 01/55] media: rkisp1: debug: Add dump file in debugfs for MI buffer registers Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-15 22:41 ` Laurent Pinchart 2022-06-15 22:41 ` Laurent Pinchart 2022-06-25 17:59 ` Laurent Pinchart 2022-06-25 17:59 ` Laurent Pinchart 2022-07-04 3:46 ` paul.elder 2022-07-04 3:46 ` paul.elder 2022-06-14 19:10 ` [PATCH 02/55] media: rkisp1: Enable compilation on ARCH_MXC Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-24 14:17 ` Dafna Hirschfeld 2022-06-24 14:17 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 03/55] media: rkisp1: debug: Add debugfs files to monitor MI and ISP interrupts Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-16 0:44 ` Laurent Pinchart 2022-06-16 0:44 ` Laurent Pinchart 2022-07-04 3:47 ` paul.elder 2022-07-04 3:47 ` paul.elder 2022-06-14 19:10 ` [PATCH 04/55] media: rkisp1: Disable runtime PM in probe error path Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-24 14:21 ` Dafna Hirschfeld 2022-06-24 14:21 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 05/55] media: rkisp1: Read the ID register at probe time instead of streamon Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-24 14:26 ` Dafna Hirschfeld 2022-06-24 14:26 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 06/55] media: rkisp1: Rename rkisp1_match_data to rkisp1_info Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-24 14:29 ` Dafna Hirschfeld 2022-06-24 14:29 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 07/55] media: rkisp1: Save info pointer in rkisp1_device Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-24 14:34 ` Dafna Hirschfeld 2022-06-24 14:34 ` Dafna Hirschfeld 2022-06-24 14:47 ` Laurent Pinchart 2022-06-24 14:47 ` Laurent Pinchart 2022-06-30 21:28 ` Dafna Hirschfeld 2022-06-30 21:28 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 08/55] media: rkisp1: Access ISP version from info pointer Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-24 14:35 ` Dafna Hirschfeld 2022-06-24 14:35 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 09/55] media: rkisp1: Make rkisp1_isp_mbus_info common Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-16 0:50 ` Laurent Pinchart 2022-06-16 0:50 ` Laurent Pinchart 2022-06-24 14:54 ` Dafna Hirschfeld 2022-06-24 14:54 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 10/55] media: rkisp1: cap: Print debug message on failed link validation Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-16 7:32 ` (EXT) " Alexander Stein 2022-06-16 7:32 ` Alexander Stein 2022-06-16 7:41 ` Laurent Pinchart 2022-06-16 7:41 ` Laurent Pinchart 2022-06-16 7:59 ` (EXT) " Alexander Stein 2022-06-16 7:59 ` Alexander Stein 2022-06-24 15:00 ` Dafna Hirschfeld 2022-06-24 15:00 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 11/55] media: rkisp1: Move sensor .s_stream() call to ISP Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-24 15:14 ` Dafna Hirschfeld 2022-06-24 15:14 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 12/55] media: rkisp1: Reject sensors without pixel rate control at bound time Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-24 18:20 ` Dafna Hirschfeld 2022-06-24 18:20 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 13/55] media: rkisp1: Create link from sensor to ISP at notifier " Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-24 18:40 ` Dafna Hirschfeld 2022-06-24 18:40 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 14/55] media: rkisp1: Create internal links at probe time Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-24 18:43 ` Dafna Hirschfeld 2022-06-24 18:43 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 15/55] media: rkisp1: Rename rkisp1_subdev_notifier() to rkisp1_subdev_notifier_register() Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-24 18:44 ` Dafna Hirschfeld 2022-06-24 18:44 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 16/55] media: v4l2-async: Add notifier operation to destroy asd instances Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-15 22:36 ` Laurent Pinchart 2022-06-15 22:36 ` Laurent Pinchart 2022-06-20 14:27 ` Hans Verkuil 2022-06-20 14:27 ` Hans Verkuil 2022-06-14 19:10 ` [PATCH 17/55] media: rkisp1: Fix sensor source pad retrieval at bound time Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-07-01 4:36 ` Dafna Hirschfeld 2022-07-01 4:36 ` Dafna Hirschfeld 2022-07-01 11:29 ` Laurent Pinchart 2022-07-01 11:29 ` Laurent Pinchart 2022-06-14 19:10 ` [PATCH 18/55] media: rkisp1: Split CSI handling to separate file Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-25 3:48 ` Dafna Hirschfeld 2022-06-25 3:48 ` Dafna Hirschfeld 2022-06-25 10:18 ` Laurent Pinchart 2022-06-25 10:18 ` Laurent Pinchart 2022-06-14 19:10 ` [PATCH 19/55] media: rkisp1: isp: Start CSI-2 receiver before ISP Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-25 3:51 ` Dafna Hirschfeld 2022-06-25 3:51 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 20/55] media: rkisp1: csi: Handle CSI-2 RX configuration fully in rkisp1-csi.c Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-25 4:00 ` Dafna Hirschfeld 2022-06-25 4:00 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 21/55] media: rkisp1: csi: Rename CSI functions with a common rkisp1_csi prefix Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-25 4:03 ` Dafna Hirschfeld 2022-06-25 4:03 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 22/55] media: rkisp1: csi: Move start delay to rkisp1_csi_start() Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-25 4:05 ` Dafna Hirschfeld 2022-06-25 4:05 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 23/55] media: rkisp1: csi: Pass sensor pointer to rkisp1_csi_config() Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-25 4:28 ` Dafna Hirschfeld 2022-06-25 4:28 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 24/55] media: rkisp1: csi: Constify argument to rkisp1_csi_start() Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-25 4:29 ` Dafna Hirschfeld 2022-06-25 4:29 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 25/55] media: rkisp1: isp: Don't initialize ret to 0 in rkisp1_isp_s_stream() Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-25 4:46 ` Dafna Hirschfeld 2022-06-25 4:46 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 26/55] media: rkisp1: isp: Pass mbus type and flags to rkisp1_config_cif() Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-25 4:32 ` Dafna Hirschfeld 2022-06-25 4:32 ` Dafna Hirschfeld 2022-06-14 19:10 ` [PATCH 27/55] media: rkisp1: isp: Rename rkisp1_device.active_sensor to source Paul Elder 2022-06-14 19:10 ` Paul Elder 2022-06-30 21:57 ` Dafna Hirschfeld 2022-06-30 21:57 ` Dafna Hirschfeld 2022-07-01 4:42 ` Dafna Hirschfeld 2022-07-01 4:42 ` Dafna Hirschfeld 2022-06-14 19:11 ` [PATCH 28/55] media: rkisp1: isp: Add container_of wrapper to cast subdev to rkisp1_isp Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-25 4:48 ` Dafna Hirschfeld 2022-06-25 4:48 ` Dafna Hirschfeld 2022-06-14 19:11 ` [PATCH 29/55] media: rkisp1: isp: Add rkisp1_device backpointer " Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-25 4:50 ` Dafna Hirschfeld 2022-06-25 4:50 ` Dafna Hirschfeld 2022-06-14 19:11 ` [PATCH 30/55] media: rkisp1: isp: Pass rkisp1_isp pointer to internal ISP functions Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-25 4:52 ` Dafna Hirschfeld 2022-06-25 4:52 ` Dafna Hirschfeld 2022-06-14 19:11 ` [PATCH 31/55] media: rkisp1: isp: Move input configuration to rkisp1_config_isp() Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-25 5:00 ` Dafna Hirschfeld 2022-06-25 5:00 ` Dafna Hirschfeld 2022-06-14 19:11 ` [PATCH 32/55] media: rkisp1: isp: Merge ISP_ACQ_PROP configuration in single variable Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-25 5:03 ` Dafna Hirschfeld 2022-06-25 5:03 ` Dafna Hirschfeld 2022-06-14 19:11 ` [PATCH 33/55] media: rkisp1: isp: Initialize some variables at declaration time Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-25 5:04 ` Dafna Hirschfeld 2022-06-25 5:04 ` Dafna Hirschfeld 2022-06-14 19:11 ` [PATCH 34/55] media: rkisp1: isp: Fix whitespace issues Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-25 5:05 ` Dafna Hirschfeld 2022-06-25 5:05 ` Dafna Hirschfeld 2022-06-14 19:11 ` [PATCH 35/55] media: rkisp1: isp: Constify various local variables Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-25 5:07 ` Dafna Hirschfeld 2022-06-25 5:07 ` Dafna Hirschfeld 2022-06-14 19:11 ` [PATCH 36/55] media: rkisp1: isp: Rename rkisp1_get_remote_source() Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-25 5:09 ` Dafna Hirschfeld 2022-06-25 5:09 ` Dafna Hirschfeld 2022-06-14 19:11 ` [PATCH 37/55] media: mc-entity: Add a new helper function to get a remote pad Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-15 22:38 ` Laurent Pinchart 2022-06-15 22:38 ` Laurent Pinchart 2022-06-17 11:38 ` Hans Verkuil 2022-06-17 11:38 ` Hans Verkuil 2022-06-17 11:48 ` Hans Verkuil 2022-06-17 11:48 ` Hans Verkuil 2022-06-25 17:00 ` Laurent Pinchart 2022-06-25 17:00 ` Laurent Pinchart 2022-06-25 17:28 ` Laurent Pinchart 2022-06-25 17:28 ` Laurent Pinchart 2022-07-07 6:52 ` Hans Verkuil 2022-07-07 6:52 ` Hans Verkuil 2022-07-07 11:50 ` Laurent Pinchart 2022-07-07 11:50 ` Laurent Pinchart 2022-06-17 21:34 ` Daniel Scally 2022-06-17 21:34 ` Daniel Scally 2022-06-17 22:33 ` Daniel Scally 2022-06-17 22:33 ` Daniel Scally 2022-06-17 22:40 ` Laurent Pinchart 2022-06-17 22:40 ` Laurent Pinchart 2022-06-18 9:35 ` Daniel Scally 2022-06-18 9:35 ` Daniel Scally 2022-06-25 17:34 ` Laurent Pinchart 2022-06-25 17:34 ` Laurent Pinchart 2022-06-14 19:11 ` [PATCH 38/55] media: mc-entity: Add a new helper function to get a remote pad for a pad Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-15 22:38 ` Laurent Pinchart 2022-06-15 22:38 ` Laurent Pinchart 2022-06-17 11:41 ` Hans Verkuil 2022-06-17 11:41 ` Hans Verkuil 2022-06-17 11:48 ` Laurent Pinchart 2022-06-17 11:48 ` Laurent Pinchart 2022-06-14 19:11 ` [PATCH 39/55] media: rkisp1: isp: Disallow multiple active sources Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-14 19:11 ` [PATCH 40/55] media: rkisp1: csi: Implement a V4L2 subdev for the CSI receiver Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-25 7:00 ` Dafna Hirschfeld 2022-06-25 7:00 ` Dafna Hirschfeld 2022-06-25 11:03 ` Laurent Pinchart 2022-06-25 11:03 ` Laurent Pinchart 2022-07-01 4:48 ` Dafna Hirschfeld 2022-07-01 4:48 ` Dafna Hirschfeld 2022-06-14 19:11 ` [PATCH 41/55] media: rkisp1: csi: Plumb the CSI RX subdev Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-15 23:10 ` Laurent Pinchart 2022-06-15 23:10 ` Laurent Pinchart 2022-06-25 7:45 ` Dafna Hirschfeld 2022-06-25 7:45 ` Dafna Hirschfeld 2022-06-25 16:07 ` Laurent Pinchart 2022-06-25 16:07 ` Laurent Pinchart 2022-06-14 19:11 ` [PATCH 42/55] media: rkisp1: Use fwnode_graph_for_each_endpoint Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-17 22:56 ` Laurent Pinchart 2022-06-17 22:56 ` Laurent Pinchart 2022-06-14 19:11 ` [PATCH 43/55] dt-bindings: media: rkisp1: Add port for parallel interface Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-17 23:13 ` Laurent Pinchart 2022-06-17 23:13 ` Laurent Pinchart 2022-07-01 5:22 ` Dafna Hirschfeld 2022-07-01 5:22 ` Dafna Hirschfeld 2022-07-01 9:19 ` Laurent Pinchart 2022-07-01 9:19 ` Laurent Pinchart 2022-06-14 19:11 ` [PATCH 44/55] media: rkisp1: Support the ISP parallel input Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-14 19:11 ` [PATCH 45/55] media: rkisp1: Add infrastructure to support ISP features Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-14 19:11 ` [PATCH 46/55] media: rkisp1: Make the internal CSI-2 receiver optional Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-14 19:11 ` [PATCH 47/55] dt-bindings: media: rkisp1: Add i.MX8MP ISP to compatible Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-17 23:14 ` Laurent Pinchart 2022-06-17 23:14 ` Laurent Pinchart 2022-06-14 19:11 ` [PATCH 48/55] media: rkisp1: Add match data for i.MX8MP ISP Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-17 23:26 ` Laurent Pinchart 2022-06-17 23:26 ` Laurent Pinchart 2022-06-26 4:05 ` Dafna Hirschfeld 2022-06-26 4:05 ` Dafna Hirschfeld 2022-06-26 11:07 ` Laurent Pinchart 2022-06-26 11:07 ` Laurent Pinchart 2022-07-04 10:36 ` paul.elder 2022-07-04 10:36 ` paul.elder 2022-06-14 19:11 ` [PATCH 49/55] media: rkisp1: Configure gasket on i.MX8MP Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-14 19:11 ` [PATCH 50/55] media: rkisp1: Add and set registers for crop for i.MX8MP Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-26 11:59 ` Laurent Pinchart 2022-06-26 11:59 ` Laurent Pinchart 2022-07-04 10:37 ` paul.elder 2022-07-04 10:37 ` paul.elder 2022-07-01 5:37 ` Dafna Hirschfeld 2022-07-01 5:37 ` Dafna Hirschfeld 2022-06-14 19:11 ` [PATCH 51/55] media: rkisp1: Add and set registers for output size config on i.MX8MP Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-26 11:46 ` Laurent Pinchart 2022-06-26 11:46 ` Laurent Pinchart 2022-07-01 5:40 ` Dafna Hirschfeld 2022-07-01 5:40 ` Dafna Hirschfeld 2022-06-14 19:11 ` [PATCH 52/55] media: rkisp1: Add i.MX8MP-specific registers for MI and resizer Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-07-01 5:45 ` Dafna Hirschfeld 2022-07-01 5:45 ` Dafna Hirschfeld 2022-06-14 19:11 ` [PATCH 53/55] media: rkisp1: Shift DMA buffer addresses on i.MX8MP Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-26 11:38 ` Laurent Pinchart [this message] 2022-06-26 11:38 ` Laurent Pinchart 2022-07-01 5:53 ` Dafna Hirschfeld 2022-07-01 5:53 ` Dafna Hirschfeld 2022-07-01 8:38 ` Laurent Pinchart 2022-07-01 8:38 ` Laurent Pinchart 2022-06-14 19:11 ` [PATCH 54/55] media: rkisp1: Add register definitions for the test pattern generator Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-14 19:11 ` [PATCH 55/55] media: rkisp1: Fix RSZ_CTRL bits for i.MX8MP Paul Elder 2022-06-14 19:11 ` Paul Elder 2022-06-16 8:05 ` (EXT) " Alexander Stein 2022-06-16 8:05 ` Alexander Stein 2022-06-17 23:03 ` Laurent Pinchart 2022-06-17 23:03 ` Laurent Pinchart 2022-06-26 11:40 ` Laurent Pinchart 2022-06-26 11:40 ` Laurent Pinchart 2022-07-04 10:40 ` paul.elder 2022-07-04 10:40 ` paul.elder 2022-06-16 0:19 ` [PATCH 00/55] media: rkisp1: Cleanups and add support " Laurent Pinchart 2022-06-16 0:19 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YrhFHt+PsaWXsTUD@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=dafna@fastmail.com \ --cc=djrscally@gmail.com \ --cc=heiko@sntech.de \ --cc=helen.koike@collabora.com \ --cc=jacopo@jmondi.org \ --cc=jeanmichel.hautbois@ideasonboard.com \ --cc=linux-media@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=paul.elder@ideasonboard.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.