From: Rodrigo Vivi <rodrigo.vivi@intel.com> To: Jani Nikula <jani.nikula@intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>, intel-gfx@lists.freedesktop.org, Lucas De Marchi <lucas.demarchi@intel.com>, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 00/19] drm/i915: prepare for xe driver display integration Date: Thu, 14 Sep 2023 10:53:48 -0400 [thread overview] Message-ID: <ZQMefDTkBf35yRly@intel.com> (raw) In-Reply-To: <cover.1694514689.git.jani.nikula@intel.com> On Tue, Sep 12, 2023 at 02:06:27PM +0300, Jani Nikula wrote: > The upcoming drm/xe driver [1][2] will reuse the drm/i915 display code, > initially by compiling the relevant compilation units separately as part > of the xe driver. This series prepares for that in i915 side. > > The first patch defines I915 during the i915 driver build, to allow > conditional compilation based on the driver the code is being built for. > > The rest of the patches add stubs for functions in files that aren't > used in xe. The idea is that this is the least intrusive way of skipping > that code in xe, and is quite similar to the common kconfig stubs. > > While this is arguably unused code for the time being, or only used in > an out-of-tree driver yet to be upstreamed, the upstreaming has to start > somewhere. I see other benefits on adding this right now through drm-intel-next: 1. Separate the good&ready patches from the other patches that are in drm-xe-next, that would require more work. 2. Minimize the non-xe patches in the xe pull-request. Cleaner and with reduced risk of conflicts. > > > BR, > Jani. > > > [1] https://gitlab.freedesktop.org/drm/xe/kernel/-/tree/drm-xe-next > [2] https://patchwork.freedesktop.org/series/112188/ > > Cc: David Airlie <airlied@gmail.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > Cc: Lucas De Marchi <lucas.demarchi@intel.com> Yeap, let's for sure get input from other maintainers, but meanwhile I'd like to state that I have once more reviewed these patches and that you can put my rv-b tag in all of them when we get the proper acks. > > Jani Nikula (19): > drm/i915: define I915 during i915 driver build > drm/i915/display: add I915 conditional build to intel_lvds.h > drm/i915/display: add I915 conditional build to hsw_ips.h > drm/i915/display: add I915 conditional build to i9xx_plane.h > drm/i915/display: add I915 conditional build to intel_lpe_audio.h > drm/i915/display: add I915 conditional build to intel_pch_refclk.h > drm/i915/display: add I915 conditional build to intel_pch_display.h > drm/i915/display: add I915 conditional build to intel_sprite.h > drm/i915/display: add I915 conditional build to intel_overlay.h > drm/i915/display: add I915 conditional build to g4x_dp.h > drm/i915/display: add I915 conditional build to intel_dpio_phy.h > drm/i915/display: add I915 conditional build to intel_crt.h > drm/i915/display: add I915 conditional build to vlv_dsi.h > drm/i915/display: add I915 conditional build to i9xx_wm.h > drm/i915/display: add I915 conditional build to g4x_hdmi.h > drm/i915/display: add I915 conditional build to intel_dvo.h > drm/i915/display: add I915 conditional build to intel_sdvo.h > drm/i915/display: add I915 conditional build to intel_tv.h > drm/i915/display: add I915 conditional build to vlv_dsi_pll.h > > drivers/gpu/drm/i915/Makefile | 4 + > drivers/gpu/drm/i915/display/g4x_dp.h | 26 +++++ > drivers/gpu/drm/i915/display/g4x_hdmi.h | 12 +++ > drivers/gpu/drm/i915/display/hsw_ips.h | 35 +++++++ > drivers/gpu/drm/i915/display/i9xx_plane.h | 23 +++++ > drivers/gpu/drm/i915/display/i9xx_wm.h | 17 ++++ > drivers/gpu/drm/i915/display/intel_crt.h | 14 +++ > drivers/gpu/drm/i915/display/intel_dpio_phy.h | 96 +++++++++++++++++++ > drivers/gpu/drm/i915/display/intel_dvo.h | 6 ++ > .../gpu/drm/i915/display/intel_lpe_audio.h | 18 ++++ > drivers/gpu/drm/i915/display/intel_lvds.h | 19 ++++ > drivers/gpu/drm/i915/display/intel_overlay.h | 35 +++++++ > .../gpu/drm/i915/display/intel_pch_display.h | 53 ++++++++++ > .../gpu/drm/i915/display/intel_pch_refclk.h | 23 +++++ > drivers/gpu/drm/i915/display/intel_sdvo.h | 13 +++ > drivers/gpu/drm/i915/display/intel_sprite.h | 8 ++ > drivers/gpu/drm/i915/display/intel_tv.h | 6 ++ > drivers/gpu/drm/i915/display/vlv_dsi.h | 13 +++ > drivers/gpu/drm/i915/display/vlv_dsi_pll.h | 9 ++ > 19 files changed, 430 insertions(+) > > -- > 2.39.2 >
WARNING: multiple messages have this Message-ID (diff)
From: Rodrigo Vivi <rodrigo.vivi@intel.com> To: Jani Nikula <jani.nikula@intel.com> Cc: intel-gfx@lists.freedesktop.org, Lucas De Marchi <lucas.demarchi@intel.com>, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 00/19] drm/i915: prepare for xe driver display integration Date: Thu, 14 Sep 2023 10:53:48 -0400 [thread overview] Message-ID: <ZQMefDTkBf35yRly@intel.com> (raw) In-Reply-To: <cover.1694514689.git.jani.nikula@intel.com> On Tue, Sep 12, 2023 at 02:06:27PM +0300, Jani Nikula wrote: > The upcoming drm/xe driver [1][2] will reuse the drm/i915 display code, > initially by compiling the relevant compilation units separately as part > of the xe driver. This series prepares for that in i915 side. > > The first patch defines I915 during the i915 driver build, to allow > conditional compilation based on the driver the code is being built for. > > The rest of the patches add stubs for functions in files that aren't > used in xe. The idea is that this is the least intrusive way of skipping > that code in xe, and is quite similar to the common kconfig stubs. > > While this is arguably unused code for the time being, or only used in > an out-of-tree driver yet to be upstreamed, the upstreaming has to start > somewhere. I see other benefits on adding this right now through drm-intel-next: 1. Separate the good&ready patches from the other patches that are in drm-xe-next, that would require more work. 2. Minimize the non-xe patches in the xe pull-request. Cleaner and with reduced risk of conflicts. > > > BR, > Jani. > > > [1] https://gitlab.freedesktop.org/drm/xe/kernel/-/tree/drm-xe-next > [2] https://patchwork.freedesktop.org/series/112188/ > > Cc: David Airlie <airlied@gmail.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > Cc: Lucas De Marchi <lucas.demarchi@intel.com> Yeap, let's for sure get input from other maintainers, but meanwhile I'd like to state that I have once more reviewed these patches and that you can put my rv-b tag in all of them when we get the proper acks. > > Jani Nikula (19): > drm/i915: define I915 during i915 driver build > drm/i915/display: add I915 conditional build to intel_lvds.h > drm/i915/display: add I915 conditional build to hsw_ips.h > drm/i915/display: add I915 conditional build to i9xx_plane.h > drm/i915/display: add I915 conditional build to intel_lpe_audio.h > drm/i915/display: add I915 conditional build to intel_pch_refclk.h > drm/i915/display: add I915 conditional build to intel_pch_display.h > drm/i915/display: add I915 conditional build to intel_sprite.h > drm/i915/display: add I915 conditional build to intel_overlay.h > drm/i915/display: add I915 conditional build to g4x_dp.h > drm/i915/display: add I915 conditional build to intel_dpio_phy.h > drm/i915/display: add I915 conditional build to intel_crt.h > drm/i915/display: add I915 conditional build to vlv_dsi.h > drm/i915/display: add I915 conditional build to i9xx_wm.h > drm/i915/display: add I915 conditional build to g4x_hdmi.h > drm/i915/display: add I915 conditional build to intel_dvo.h > drm/i915/display: add I915 conditional build to intel_sdvo.h > drm/i915/display: add I915 conditional build to intel_tv.h > drm/i915/display: add I915 conditional build to vlv_dsi_pll.h > > drivers/gpu/drm/i915/Makefile | 4 + > drivers/gpu/drm/i915/display/g4x_dp.h | 26 +++++ > drivers/gpu/drm/i915/display/g4x_hdmi.h | 12 +++ > drivers/gpu/drm/i915/display/hsw_ips.h | 35 +++++++ > drivers/gpu/drm/i915/display/i9xx_plane.h | 23 +++++ > drivers/gpu/drm/i915/display/i9xx_wm.h | 17 ++++ > drivers/gpu/drm/i915/display/intel_crt.h | 14 +++ > drivers/gpu/drm/i915/display/intel_dpio_phy.h | 96 +++++++++++++++++++ > drivers/gpu/drm/i915/display/intel_dvo.h | 6 ++ > .../gpu/drm/i915/display/intel_lpe_audio.h | 18 ++++ > drivers/gpu/drm/i915/display/intel_lvds.h | 19 ++++ > drivers/gpu/drm/i915/display/intel_overlay.h | 35 +++++++ > .../gpu/drm/i915/display/intel_pch_display.h | 53 ++++++++++ > .../gpu/drm/i915/display/intel_pch_refclk.h | 23 +++++ > drivers/gpu/drm/i915/display/intel_sdvo.h | 13 +++ > drivers/gpu/drm/i915/display/intel_sprite.h | 8 ++ > drivers/gpu/drm/i915/display/intel_tv.h | 6 ++ > drivers/gpu/drm/i915/display/vlv_dsi.h | 13 +++ > drivers/gpu/drm/i915/display/vlv_dsi_pll.h | 9 ++ > 19 files changed, 430 insertions(+) > > -- > 2.39.2 >
next prev parent reply other threads:[~2023-09-14 14:54 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-12 11:06 [PATCH 00/19] drm/i915: prepare for xe driver display integration Jani Nikula 2023-09-12 11:06 ` [Intel-gfx] " Jani Nikula 2023-09-12 11:06 ` [PATCH 01/19] drm/i915: define I915 during i915 driver build Jani Nikula 2023-09-12 11:06 ` [Intel-gfx] " Jani Nikula 2023-09-12 11:06 ` [PATCH 02/19] drm/i915/display: add I915 conditional build to intel_lvds.h Jani Nikula 2023-09-12 11:06 ` [Intel-gfx] " Jani Nikula 2023-09-12 11:06 ` [PATCH 03/19] drm/i915/display: add I915 conditional build to hsw_ips.h Jani Nikula 2023-09-12 11:06 ` [Intel-gfx] " Jani Nikula 2023-09-12 11:06 ` [Intel-gfx] [PATCH 04/19] drm/i915/display: add I915 conditional build to i9xx_plane.h Jani Nikula 2023-09-12 11:06 ` Jani Nikula 2023-09-12 11:06 ` [Intel-gfx] [PATCH 05/19] drm/i915/display: add I915 conditional build to intel_lpe_audio.h Jani Nikula 2023-09-12 11:06 ` Jani Nikula 2023-09-12 11:06 ` [PATCH 06/19] drm/i915/display: add I915 conditional build to intel_pch_refclk.h Jani Nikula 2023-09-12 11:06 ` [Intel-gfx] " Jani Nikula 2023-09-12 11:06 ` [PATCH 07/19] drm/i915/display: add I915 conditional build to intel_pch_display.h Jani Nikula 2023-09-12 11:06 ` [Intel-gfx] " Jani Nikula 2023-09-12 11:06 ` [PATCH 08/19] drm/i915/display: add I915 conditional build to intel_sprite.h Jani Nikula 2023-09-12 11:06 ` [Intel-gfx] " Jani Nikula 2023-09-12 11:06 ` [Intel-gfx] [PATCH 09/19] drm/i915/display: add I915 conditional build to intel_overlay.h Jani Nikula 2023-09-12 11:06 ` Jani Nikula 2023-09-12 11:06 ` [PATCH 10/19] drm/i915/display: add I915 conditional build to g4x_dp.h Jani Nikula 2023-09-12 11:06 ` [Intel-gfx] " Jani Nikula 2023-09-12 11:06 ` [PATCH 11/19] drm/i915/display: add I915 conditional build to intel_dpio_phy.h Jani Nikula 2023-09-12 11:06 ` [Intel-gfx] " Jani Nikula 2023-09-12 11:06 ` [PATCH 12/19] drm/i915/display: add I915 conditional build to intel_crt.h Jani Nikula 2023-09-12 11:06 ` [Intel-gfx] " Jani Nikula 2023-09-12 11:06 ` [PATCH 13/19] drm/i915/display: add I915 conditional build to vlv_dsi.h Jani Nikula 2023-09-12 11:06 ` [Intel-gfx] " Jani Nikula 2023-09-12 11:06 ` [PATCH 14/19] drm/i915/display: add I915 conditional build to i9xx_wm.h Jani Nikula 2023-09-12 11:06 ` [Intel-gfx] " Jani Nikula 2023-09-12 11:06 ` [PATCH 15/19] drm/i915/display: add I915 conditional build to g4x_hdmi.h Jani Nikula 2023-09-12 11:06 ` [Intel-gfx] " Jani Nikula 2023-09-12 11:06 ` [PATCH 16/19] drm/i915/display: add I915 conditional build to intel_dvo.h Jani Nikula 2023-09-12 11:06 ` [Intel-gfx] " Jani Nikula 2023-09-12 11:06 ` [PATCH 17/19] drm/i915/display: add I915 conditional build to intel_sdvo.h Jani Nikula 2023-09-12 11:06 ` [Intel-gfx] " Jani Nikula 2023-09-12 11:06 ` [Intel-gfx] [PATCH 18/19] drm/i915/display: add I915 conditional build to intel_tv.h Jani Nikula 2023-09-12 11:06 ` Jani Nikula 2023-09-12 11:06 ` [PATCH 19/19] drm/i915/display: add I915 conditional build to vlv_dsi_pll.h Jani Nikula 2023-09-12 11:06 ` [Intel-gfx] " Jani Nikula 2023-09-12 19:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: prepare for xe driver display integration Patchwork 2023-09-12 19:13 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2023-09-12 19:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork 2023-09-13 20:11 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: prepare for xe driver display integration (rev2) Patchwork 2023-09-13 20:11 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2023-09-13 20:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2023-09-14 0:53 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2023-09-14 14:53 ` Rodrigo Vivi [this message] 2023-09-14 14:53 ` [Intel-gfx] [PATCH 00/19] drm/i915: prepare for xe driver display integration Rodrigo Vivi 2023-09-29 11:03 ` Jani Nikula 2023-09-29 11:03 ` [Intel-gfx] " Jani Nikula
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZQMefDTkBf35yRly@intel.com \ --to=rodrigo.vivi@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@intel.com \ --cc=lucas.demarchi@intel.com \ --cc=tvrtko.ursulin@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.