From: Christoph Hellwig <hch@infradead.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
tanzirh@google.com, Kees Cook <keescook@chromium.org>,
Andy Shevchenko <andy@kernel.org>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
Nick DeSaulniers <nnn@google.com>,
llvm@lists.linux.dev
Subject: Re: [PATCH] lib/string: shrink lib/string.i via IWYU
Date: Wed, 6 Dec 2023 22:25:50 -0800 [thread overview]
Message-ID: <ZXFlbn8oaTAS8PaZ@infradead.org> (raw)
In-Reply-To: <CAKwvOdn=og6h5gVdDCjFDANs3MN-_CD4OZ9oRM=o9YAvoTzkzw@mail.gmail.com>
On Tue, Dec 05, 2023 at 01:39:47PM -0800, Nick Desaulniers wrote:
> Hmm...how does one know that linux/bits.h is the higher-level include
> of asm/bitsperlong.h?
I think this the wrong way of thinking. In general we should always
avoid including asm/ headers unless there is no other way. No other
way is not formalized right now, but I think the answer is roughly if
no linux/ headers includes that asm header. This will probably give
a few wrong results at the moment, but it's probably worth fixing
them up.
next prev parent reply other threads:[~2023-12-07 6:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 20:58 [PATCH] lib/string: shrink lib/string.i via IWYU tanzirh
2023-12-05 21:04 ` Andrew Morton
2023-12-05 21:14 ` Nick Desaulniers
2023-12-05 21:24 ` Andrew Morton
2023-12-05 21:39 ` Nick Desaulniers
2023-12-05 21:43 ` Al Viro
2023-12-05 21:57 ` Nick Desaulniers
2023-12-11 20:47 ` Nick Desaulniers
2023-12-11 20:50 ` Andy Shevchenko
2023-12-05 21:53 ` Andy Shevchenko
2023-12-05 22:05 ` Nick Desaulniers
2023-12-07 6:25 ` Christoph Hellwig [this message]
2023-12-05 21:38 ` Al Viro
2023-12-05 21:51 ` Nick Desaulniers
2023-12-05 21:59 ` Greg KH
2023-12-05 22:14 ` Nick Desaulniers
2023-12-05 23:46 ` Greg KH
2023-12-06 0:55 ` Al Viro
2023-12-06 3:00 ` Al Viro
2023-12-06 3:09 ` Greg KH
2023-12-14 21:04 ` Al Viro
2023-12-15 21:03 ` Al Viro
2023-12-07 12:50 ` Andy Shevchenko
2023-12-05 22:01 ` Andy Shevchenko
2023-12-05 22:10 ` Randy Dunlap
2023-12-05 22:25 ` Nick Desaulniers
2023-12-05 22:15 ` Al Viro
2023-12-05 22:20 ` Nick Desaulniers
2023-12-05 22:32 ` Al Viro
2023-12-07 12:52 ` Andy Shevchenko
2023-12-05 21:57 ` Al Viro
2023-12-05 21:50 ` Andy Shevchenko
2023-12-05 22:05 ` Andy Shevchenko
2023-12-06 7:10 ` kernel test robot
2023-12-07 12:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXFlbn8oaTAS8PaZ@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=ndesaulniers@google.com \
--cc=nnn@google.com \
--cc=tanzirh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.