Re: [PATCH] lib/string: shrink lib/string.i via IWYU

From: Andy Shevchenko <andy@kernel.org>
To: kernel test robot <lkp@intel.com>
Cc: tanzirh@google.com, Kees Cook <keescook@chromium.org>,
	oe-kbuild-all@lists.linux.dev, linux-hardening@vger.kernel.org,
	linux-kernel@vger.kernel.org, Nick DeSaulniers <nnn@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	llvm@lists.linux.dev
Subject: Re: [PATCH] lib/string: shrink lib/string.i via IWYU
Date: Thu, 7 Dec 2023 14:55:00 +0200	[thread overview]
Message-ID: <ZXHApFX1mXZnP5lz@smile.fi.intel.com> (raw)
In-Reply-To: <202312061429.BJ7GrHnt-lkp@intel.com>

On Wed, Dec 06, 2023 at 03:10:46PM +0800, kernel test robot wrote:
> Hi,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on 33cc938e65a98f1d29d0a18403dbbee050dcad9a]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/tanzirh-google-com/lib-string-shrink-lib-string-i-via-IWYU/20231206-050121
> base:   33cc938e65a98f1d29d0a18403dbbee050dcad9a
> patch link:    https://lore.kernel.org/r/20231205-libstringheader-v1-1-7f9c573053a7%40gmail.com
> patch subject: [PATCH] lib/string: shrink lib/string.i via IWYU
> config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20231206/202312061429.BJ7GrHnt-lkp@intel.com/config)
> compiler: sh4-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231206/202312061429.BJ7GrHnt-lkp@intel.com/reproduce)

...

>    lib/string.c:124:49: note: in expansion of macro 'WORD_AT_A_TIME_CONSTANTS'
>      124 |         const struct word_at_a_time constants = WORD_AT_A_TIME_CONSTANTS;

> cba8df4be3bdf1 Paul Mundt 2012-06-04 @15  #define WORD_AT_A_TIME_CONSTANTS { REPEAT_BYTE(0x01), REPEAT_BYTE(0x80) }

REPEAT_BYTE() shouldn't be even in kernel.h to begin with!

-- 
With Best Regards,
Andy Shevchenko